235705 2022-01-27 04:20:27 -0800 [GTK][a11y] Do not set the accessibility root object on svg image page elements with ATSPI 2022-01-27 23:04:24 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 230253 1 cgarcia webkit-unassigned aboxhall andresg_22 aperez apinheiro bugs-noreply cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white oldest_to_newest 1834484 0 cgarcia 2022-01-27 04:20:27 -0800 This was needed only because of isolated tree mode. 1834485 1 450126 cgarcia 2022-01-27 04:22:17 -0800 Created attachment 450126 Patch 1834830 2 cgarcia 2022-01-27 23:04:24 -0800 Committed r288730 (246523@trunk): <https://commits.webkit.org/246523@trunk> 450126 2022-01-27 04:22:17 -0800 2022-01-27 04:57:17 -0800 Patch wcore-atspi-root.diff text/plain 4212 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1YWJiOTRlMTZkY2IuLmYwYTJjMTRlNTA1ZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDIyLTAxLTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVthMTF5XSBEbyBub3Qgc2V0IHRoZSBhY2Nlc3Np YmlsaXR5IHJvb3Qgb2JqZWN0IG9uIHN2ZyBpbWFnZSBwYWdlIGVsZW1lbnRzIHdpdGggQVRTUEkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTcwNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgd2Fz IG5lZWRlZCBvbmx5IGJlY2F1c2Ugb2YgaXNvbGF0ZWQgdHJlZSBtb2RlLgorCisgICAgICAgICog YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKiBh Y2Nlc3NpYmlsaXR5L2F0c3BpL0FYT2JqZWN0Q2FjaGVBdHNwaS5jcHA6CisgICAgICAgICogYWNj ZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkuY3BwOgorICAgICAgICAq IGFjY2Vzc2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpLmg6CisKIDIwMjIt MDEtMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdW2ExMXldIElnbm9yZSBzcGFuIGVsZW1lbnRzIHdpdGggQVRTUEkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3QuY3BwCmluZGV4IDQ5ODg2ZTVkODg4MC4uNDgxY2I1NmNmMjQyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9i amVjdC5jcHAKQEAgLTMyOTYsMTEgKzMyOTYsNiBAQCBBY2Nlc3NpYmlsaXR5U1ZHUm9vdCogQWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6cmVtb3RlU1ZHUm9vdEVsZW1lbnQoQ3JlYXRpb25DaAog ICAgIGlmICghY2FjaGUpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogCi0jaWYgVVNFKEFUU1BJ KQotICAgIGlmIChhdXRvKiBwYWdlID0gZG9jdW1lbnQtPnBhZ2UoKSkKLSAgICAgICAgcGFnZS0+ c2V0QWNjZXNzaWJpbGl0eVJvb3RPYmplY3QoY3JlYXRlSWZOZWNlc3NhcnkgPT0gQ3JlYXRlID8g YXhPYmplY3RDYWNoZSgpLT5kb2N1bWVudCgpLnBhZ2UoKS0+YWNjZXNzaWJpbGl0eVJvb3RPYmpl Y3QoKSA6IG51bGxwdHIpOwotI2VuZGlmCi0KICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiByb290 U1ZHT2JqZWN0ID0gY3JlYXRlSWZOZWNlc3NhcnkgPT0gQ3JlYXRlID8gY2FjaGUtPmdldE9yQ3Jl YXRlKHJlbmRlcmVyUm9vdCkgOiBjYWNoZS0+Z2V0KHJlbmRlcmVyUm9vdCk7CiAKICAgICBBU1NF UlQoIWNyZWF0ZUlmTmVjZXNzYXJ5IHx8IHJvb3RTVkdPYmplY3QpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BWE9iamVjdENhY2hlQXRzcGkuY3BwIGIv U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BWE9iamVjdENhY2hlQXRzcGkuY3Bw CmluZGV4IGNmZjJhNDRhZjI3OC4uMzAwZTg0YWJiNTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2F0c3BpL0FYT2JqZWN0Q2FjaGVBdHNwaS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BWE9iamVjdENhY2hlQXRzcGkuY3BwCkBA IC0zNSw4ICszNSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBBWE9iamVjdENhY2hl OjphdHRhY2hXcmFwcGVyKEFYQ29yZU9iamVjdCogYXhPYmplY3QpCiB7Ci0gICAgYXV0byogYXRz cGlSb290ID0gZG9jdW1lbnQoKS5wYWdlKCktPmFjY2Vzc2liaWxpdHlSb290T2JqZWN0KCk7Ci0g ICAgYXV0byB3cmFwcGVyID0gQWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpOjpjcmVhdGUoYXhPYmpl Y3QsIGF0c3BpUm9vdCk7CisgICAgYXV0byB3cmFwcGVyID0gQWNjZXNzaWJpbGl0eU9iamVjdEF0 c3BpOjpjcmVhdGUoYXhPYmplY3QsIGRvY3VtZW50KCkucGFnZSgpLT5hY2Nlc3NpYmlsaXR5Um9v dE9iamVjdCgpKTsKICAgICBheE9iamVjdC0+c2V0V3JhcHBlcih3cmFwcGVyLnB0cigpKTsKIAog ICAgIG1fZGVmZXJyZWRQYXJlbnRDaGFuZ2VkTGlzdC5hZGQoYXhPYmplY3QpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5T2JqZWN0 QXRzcGkuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmls aXR5T2JqZWN0QXRzcGkuY3BwCmluZGV4IGViZDk1NTMwZmZkYy4uNDNhZmRjYzc0Zjk0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlP YmplY3RBdHNwaS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9B Y2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkuY3BwCkBAIC00NjcsMTUgKzQ2Nyw2IEBAIEdEQnVzSW50 ZXJmYWNlVlRhYmxlIEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaTo6c19hY2Nlc3NpYmxlRnVuY3Rp b25zID0gewogICAgIG51bGxwdHIKIH07CiAKLUFjY2Vzc2liaWxpdHlSb290QXRzcGkqIEFjY2Vz c2liaWxpdHlPYmplY3RBdHNwaTo6cm9vdCgpCi17Ci0gICAgaWYgKCFtX3Jvb3QpIHsKLSAgICAg ICAgaWYgKGF1dG8qIGRvY3VtZW50ID0gbV9jb3JlT2JqZWN0LT5kb2N1bWVudCgpKQotICAgICAg ICAgICAgbV9yb290ID0gZG9jdW1lbnQtPnBhZ2UoKS0+YWNjZXNzaWJpbGl0eVJvb3RPYmplY3Qo KTsKLSAgICB9Ci0gICAgcmV0dXJuIG1fcm9vdDsKLX0KLQogYm9vbCBBY2Nlc3NpYmlsaXR5T2Jq ZWN0QXRzcGk6OnJlZ2lzdGVyT2JqZWN0KCkKIHsKICAgICBpZiAoIW1fcGF0aC5pc051bGwoKSkK QEAgLTU0NSw3ICs1MzYsNyBAQCB2b2lkIEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaTo6c2V0UGFy ZW50KHN0ZDo6b3B0aW9uYWw8QWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpKgogICAgICAgICByZXR1 cm47CiAKICAgICBtX3BhcmVudCA9IGF0c3BpUGFyZW50OwotICAgIGlmICghbV9jb3JlT2JqZWN0 IHx8IG1fY29yZU9iamVjdC0+YWNjZXNzaWJpbGl0eUlzSWdub3JlZCgpIHx8ICFyb290KCkpCisg ICAgaWYgKCFtX2NvcmVPYmplY3QgfHwgbV9jb3JlT2JqZWN0LT5hY2Nlc3NpYmlsaXR5SXNJZ25v cmVkKCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIEFjY2Vzc2liaWxpdHlBdHNwaTo6c2luZ2xl dG9uKCkucGFyZW50Q2hhbmdlZCgqdGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlPYmplY3RBdHNwaS5oIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkuaAppbmRl eCA0MjFlNGY4OWQzNDguLjNhOWM5MTBmMGNjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlPYmplY3RBdHNwaS5o CkBAIC0xNTksOCArMTU5LDYgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBBY2Nlc3NpYmlsaXR5 T2JqZWN0QXRzcGkoQVhDb3JlT2JqZWN0KiwgQWNjZXNzaWJpbGl0eVJvb3RBdHNwaSopOwogCi0g ICAgQWNjZXNzaWJpbGl0eVJvb3RBdHNwaSogcm9vdCgpOwotCiAgICAgVmVjdG9yPFJlZlB0cjxB Y2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGk+PiB3cmFwcGVyVmVjdG9yKGNvbnN0IFZlY3RvcjxSZWZQ dHI8QVhDb3JlT2JqZWN0Pj4mKSBjb25zdDsKICAgICBpbnQgaW5kZXhJblBhcmVudCgpIGNvbnN0 OwogICAgIHZvaWQgY2hpbGRBZGRlZChBY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkmKTsK