23569 2009-01-27 06:52:55 -0800 [Gtk] Non-rectangular buttons have a square background behind them 2010-10-09 08:24:24 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 andrea.cimitan webkit-unassigned bearoso+webkitbugzilla jmalonzo mrobinson xan.lopez oldest_to_newest 107181 0 andrea.cimitan 2009-01-27 06:52:55 -0800 Both buttons and entries have a squared border in webkitgtk. For the entry, there's gtk style property that could be added to the widget in order to tell the theming engine to not draw the background. Here is the mozilla patch, which will land in firefox 3.1: https://bugzilla.mozilla.org/show_bug.cgi?id=405421 I don't know that happenes with the buttons (they were already working correctly in gecko), but they have a squared rectangle below, which of course looks out of place 114015 1 xan.lopez 2009-03-17 06:19:34 -0700 We seem to have this patch in our gtk2drawing.c already. Any idea of what could be going on? 118897 2 jmalonzo 2009-04-26 02:06:37 -0700 (In reply to comment #1) > We seem to have this patch in our gtk2drawing.c already. Any idea of what could > be going on? > honor-transparent-bg-hint is only for GtkEntry based on the moz code and the discussion in the bug. I think we need to do this for GtkButton as well. 159693 3 42286 bearoso+webkitbugzilla 2009-11-01 17:38:51 -0800 Created attachment 42286 Patch to fix buttons This one is far too easy for how long it's gone unfixed. Attached patch fixes the problem by not filling the background on buttons (the theme should be doing it anyhow, if necessary). Patch is against 1.1.15.2, but works on trunk, too. 159695 4 bearoso+webkitbugzilla 2009-11-01 18:01:20 -0800 Additionally, line 871 of gtk2drawing.c in the moz_gtk_init () function totally breaks honors-transparent-bg-hint support for GtkEntry by forcing the setting to FALSE no matter the theme. I'm not sure what particular issues setting this to FALSE fixes, but a theme setting the flag means that it supports the behavior. Any problems with it should be reported to the theme engine authors. 159720 5 bearoso+webkitbugzilla 2009-11-01 19:57:13 -0800 (In reply to comment #4) > Additionally, line 871 of gtk2drawing.c in the moz_gtk_init () function totally > breaks honors-transparent-bg-hint support for GtkEntry by forcing the setting > to FALSE no matter the theme. My mistake. I've checked this and it shouldn't actually be affecting the value. In fact, it looks like "honors-transparent-bg-hint" isn't being picked up. The other widgets with the transparent-bg-hint flag don't actually read the "honors-transparent-bg-hint" flag, but just push the "transparent-bg-hint" bit. Fixing this, however, the GtkEntry still won't go transparent. Some parent of the widget or wrapping code is drawing a box around it. I don't remember what version this regressed in, but this WAS working correctly at one time. 292027 6 70334 mrobinson 2010-10-08 19:42:43 -0700 Created attachment 70334 Patch for this issue 292078 7 70334 xan.lopez 2010-10-09 02:41:40 -0700 Comment on attachment 70334 Patch for this issue View in context: https://bugs.webkit.org/attachment.cgi?id=70334&action=review Great! > WebCore/ChangeLog:15 > + Indeed, I actually remember they do exactly this. 292115 8 70334 mrobinson 2010-10-09 08:24:20 -0700 Comment on attachment 70334 Patch for this issue Clearing flags on attachment: 70334 Committed r69448: <http://trac.webkit.org/changeset/69448> 292116 9 mrobinson 2010-10-09 08:24:24 -0700 All reviewed patches have been landed. Closing bug. 42286 2009-11-01 17:38:51 -0800 2010-10-08 19:42:41 -0700 Patch to fix buttons webkit-gtk-button-no-clear.patch text/plain 498 bearoso+webkitbugzilla LS0tIHdlYmtpdC0xLjEuMTUuMi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9ndGsyZHJhd2luZy5jCTIw MDktMDktMjIgMTA6Mjk6MjEuMDAwMDAwMDAwIC0wNTAwCisrKyB3ZWJraXQtMS4xLjE1LjItbmV3 L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL2d0azJkcmF3aW5nLmMJMjAwOS0xMS0wMSAxOToyODoyNS4x OTM5MzAwNjcgLTA2MDAKQEAgLTgwNCw4ICs4MDQsNiBAQAogCiAgICAgaWYgKFdJTkRPV19JU19N QVBQRUQoZHJhd2FibGUpKSB7CiAgICAgICAgIGdka193aW5kb3dfc2V0X2JhY2tfcGl4bWFwKGRy YXdhYmxlLCBOVUxMLCBUUlVFKTsKLSAgICAgICAgZ2RrX3dpbmRvd19jbGVhcl9hcmVhKGRyYXdh YmxlLCBjbGlwcmVjdC0+eCwgY2xpcHJlY3QtPnksCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjbGlwcmVjdC0+d2lkdGgsIGNsaXByZWN0LT5oZWlnaHQpOwogICAgIH0KIAogICAgIGd0 a193aWRnZXRfc2V0X3N0YXRlKHdpZGdldCwgYnV0dG9uX3N0YXRlKTsK 70334 2010-10-08 19:42:43 -0700 2010-10-09 08:24:20 -0700 Patch for this issue bug-23569-20101008194243.patch text/plain 2386 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTEwNTVmNjc2ODcxZjYxMTVlNmJlNjVlNGI1NTJmODZhYjA4ODhjYi4uOTNjNTQzZDA0MWZhNjFh YjdlYjY1YTA2NzE5YjU4MjRiNzhhMTQyNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMC0xMC0wOCAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0d0a10gTm9uLXJlY3Rhbmd1bGFyIGJ1dHRv bnMgaGF2ZSBhIHNxdWFyZSBiYWNrZ3JvdW5kIGJlaGluZCB0aGVtCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU2OQorCisgICAgICAgIFJlbW92ZSBz b21lIGNvZGUgd2hpY2ggd2FzIGNsZWFyaW5nIHBpZWNlcyBvZiB0aGUgR2RrRHJhd2FibGUgaWYg aXQgd2FzCisgICAgICAgIGN1cnJlbnRseSBtYXBwZWQgdG8gYSB3aW5kb3cuIEluIG91ciBjYXNl IGl0IGlzIHVubmVjZXNzYXJ5LCBiZWNhdXNlIHRoZQorICAgICAgICBwbGF0Zm9ybS1pbmRlcGVu ZGVudCBwYXJ0cyBvZiB0aGUgcmVuZGVyIGhhdmUgYWxyZWFkeSBjbGVhcmVkIHRoaXMgc2VjdGlv bgorICAgICAgICBpZiBpdCBpcyBuZWVkZWQuCisKKyAgICAgICAgTW96aWxsYSBtdXN0IG5vdCB0 cmlwIHRoaXMgY29kZSBwYXRoLCB3aGljaCBtZWFucyB0aGV5IGFyZSBwcm9iYWJseSByZW5kZXJp bmcKKyAgICAgICAgbW9zdCBvZnRlbiB0byBhIG5vbi1tYXBwZWQgR2RrUGl4bWFwLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyBhcyBzb21lIHRoZW1lZCByZW5kZXJpbmcgaXMgY292ZXJlZCBieSBl eGlzdGluZyB0ZXN0cyB0aGF0CisgICAgICAgIHJlbmRlciBidXR0b25zLiBUaGlzIHBhcnRpY3Vs YXIgYnVnIGlzIHZlcnkgaGFyZCB0byB0ZXN0IGFzIGl0IG9ubHkgYXBwZWFycworICAgICAgICB3 aXRoIGNlcnRhaW4gR1RLKyB0aGVtZXMgYW5kIHdlIGN1cnJlbnRseSBoYXZlIG5vIG1lY2hhbmlz bSB0byB0ZXN0IGRpZmZlcmVudAorICAgICAgICB0aGVtZXMgaW4gRFJULgorCisgICAgICAgICog cGxhdGZvcm0vZ3RrL2d0azJkcmF3aW5nLmM6CisgICAgICAgIChtb3pfZ3RrX2J1dHRvbl9wYWlu dCk6IFJlbW92ZSB1bm5lY2Vzc2FyeSBjb2RlLgorCiAyMDEwLTEwLTA4ICBDaHJpcyBSb2dlcnMg IDxjcm9nZXJzQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5z b24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9ndGsyZHJhd2luZy5jIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvZ3RrMmRyYXdpbmcuYwppbmRleCA5NDFiZTU4MGQ5ZjhhYmRiODIx YzIyNDY0MWVkODE0NTg0YmZkYmNjLi5kMmQ4YjIwNzI4YmI4OTA0OTllMzg1YjFkMWIxMmE2NmI0 OGJmY2VlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9ndGsyZHJhd2luZy5jCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL2d0azJkcmF3aW5nLmMKQEAgLTU0LDcgKzU0LDYgQEAK IAogI2RlZmluZSBYVEhJQ0tORVNTKHN0eWxlKSAoc3R5bGUtPnh0aGlja25lc3MpCiAjZGVmaW5l IFlUSElDS05FU1Moc3R5bGUpIChzdHlsZS0+eXRoaWNrbmVzcykKLSNkZWZpbmUgV0lORE9XX0lT X01BUFBFRCh3aW5kb3cpICgod2luZG93KSAmJiBHREtfSVNfV0lORE9XKHdpbmRvdykgJiYgZ2Rr X3dpbmRvd19pc192aXNpYmxlKHdpbmRvdykpCiAKIHN0YXRpYyBHdGtUaGVtZVBhcnRzICpnUGFy dHMgPSBOVUxMOwogc3RhdGljIHN0eWxlX3Byb3BfdCBzdHlsZV9wcm9wX2Z1bmM7CkBAIC0zODMs MTIgKzM4Miw2IEBAIG1vel9ndGtfYnV0dG9uX3BhaW50KEdka0RyYXdhYmxlKiBkcmF3YWJsZSwg R2RrUmVjdGFuZ2xlKiByZWN0LAogCiAgICAgbW96X2d0a193aWRnZXRfZ2V0X2ZvY3VzKHdpZGdl dCwgJmludGVyaW9yX2ZvY3VzLCAmZm9jdXNfd2lkdGgsICZmb2N1c19wYWQpOwogCi0gICAgaWYg KFdJTkRPV19JU19NQVBQRUQoZHJhd2FibGUpKSB7Ci0gICAgICAgIGdka193aW5kb3dfc2V0X2Jh Y2tfcGl4bWFwKGRyYXdhYmxlLCBOVUxMLCBUUlVFKTsKLSAgICAgICAgZ2RrX3dpbmRvd19jbGVh cl9hcmVhKGRyYXdhYmxlLCBjbGlwcmVjdC0+eCwgY2xpcHJlY3QtPnksCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjbGlwcmVjdC0+d2lkdGgsIGNsaXByZWN0LT5oZWlnaHQpOwotICAg IH0KLQogICAgIGd0a193aWRnZXRfc2V0X3N0YXRlKHdpZGdldCwgYnV0dG9uX3N0YXRlKTsKICAg ICBndGtfd2lkZ2V0X3NldF9kaXJlY3Rpb24od2lkZ2V0LCBkaXJlY3Rpb24pOwogCg==