235674 2022-01-26 14:29:21 -0800 Symbols not always properly hidden when using WebKitAdditions to introduce new API 2022-01-28 10:34:42 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ap kkinnunen thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1834297 0 cdumez 2022-01-26 14:29:21 -0800 Symbols not always properly hidden when using WebKitAdditions to introduce new API. 1834298 1 cdumez 2022-01-26 14:29:33 -0800 <rdar://87999257> 1834299 2 450070 cdumez 2022-01-26 14:32:36 -0800 Created attachment 450070 Patch 1834348 3 450070 wenson_hsieh 2022-01-26 16:26:42 -0800 Comment on attachment 450070 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450070&action=review > Source/WebKit/mac/replace-webkit-additions-includes.py:93 > + additions_import_pattern = re.compile(r"\#if ENABLE\(API_WEBKIT_ADDITIONS\)\n#import <WebKitAdditions/(.*)>\n#endif") (Not necessarily in this patch, but) I wonder if it's even worth throwing a #if ENABLE(API_WEBKIT_ADDITIONS) #error "…" #endif …somewhere. Not exactly sure where, though. 1834367 4 ews-feeder 2022-01-26 17:06:10 -0800 Committed r288658 (246466@main): <https://commits.webkit.org/246466@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450070. 1835009 5 450070 ap 2022-01-28 09:27:33 -0800 Comment on attachment 450070 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450070&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h:74 > +#if ENABLE(API_WEBKIT_ADDITIONS) Given that this foes not behave like an ENABLE macro, why make it look like one? Something like this seems like it would convey the purpose better: #if 0 // API_WEBKIT_ADDITIONS_REPLACEMENT 1835016 6 cdumez 2022-01-28 09:36:46 -0800 (In reply to Alexey Proskuryakov from comment #5) > Comment on attachment 450070 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450070&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h:74 > > +#if ENABLE(API_WEBKIT_ADDITIONS) > > Given that this foes not behave like an ENABLE macro, why make it look like > one? Something like this seems like it would convey the purpose better: > > #if 0 // API_WEBKIT_ADDITIONS_REPLACEMENT Sure, this seems reasonable. I'll discuss this with Wenson & Tim and follow-up. 1835020 7 cdumez 2022-01-28 09:46:38 -0800 Reopening to attach new patch. 1835021 8 450244 cdumez 2022-01-28 09:46:40 -0800 Created attachment 450244 Follow-up to address ap's comments. 1835024 9 cdumez 2022-01-28 09:51:04 -0800 (In reply to Chris Dumez from comment #6) > (In reply to Alexey Proskuryakov from comment #5) > > Comment on attachment 450070 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=450070&action=review > > > > > Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h:74 > > > +#if ENABLE(API_WEBKIT_ADDITIONS) > > > > Given that this foes not behave like an ENABLE macro, why make it look like > > one? Something like this seems like it would convey the purpose better: > > > > #if 0 // API_WEBKIT_ADDITIONS_REPLACEMENT > > Sure, this seems reasonable. I'll discuss this with Wenson & Tim and > follow-up. Thanks for the improvement suggestion :) 1835045 10 ews-feeder 2022-01-28 10:34:38 -0800 Committed r288747 (246540@main): <https://commits.webkit.org/246540@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450244. 450070 2022-01-26 14:32:36 -0800 2022-01-28 09:46:51 -0800 Patch bug-235674-20220126143235.patch text/plain 2972 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUxOGY0N2Y2NGJlODAxZDM5 NDBjMzY4MTQ3ZTZlN2Y1MTRlY2NiZWEuLjQ2Mjk0ZDkyOWU0ZjkwZTIyOTY3Mzg1YTQzZTFmMjk3 NzhlMDEzODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjItMDEtMjYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTeW1ib2xzIG5vdCBhbHdheXMgcHJv cGVybHkgaGlkZGVuIHdoZW4gdXNpbmcgV2ViS2l0QWRkaXRpb25zIHRvIGludHJvZHVjZSBuZXcg QVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU2 NzQKKyAgICAgICAgPHJkYXI6Ly84Nzk5OTI1Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTdXJyb3VuZCBBUElzIGZyb20gV2ViS2l0QWRkaXRpb25z IHdpdGggYCNpZiBFTkFCTEUoQVBJX1dFQktJVF9BRERJVElPTlMpYCBpbnN0ZWFkIG9mCisgICAg ICAgIGAjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESylgIGFuZCBsZWF2aW5nIEFQSV9XRUJLSVRf QURESVRJT05TIHRvIGJlIGludGVudGlvbmFsbHkKKyAgICAgICAgdW5kZWZpbmVkLiBUaGlzIGlz IGJlY2F1c2Ugd2UgbmV2ZXIgd2FudCB0byBidWlsZCB0aGUgY29kZSBpbnNpZGUgdGhpcyAjaWYg YmxvY2suCisgICAgICAgIEluc3RlYWQsIHRob3NlIGJsb2NrcyBhcmUgb25seSBtZWFudCB0byBi ZSByZXBsYWNlZCBieSB0aGUKKyAgICAgICAgcmVwbGFjZS13ZWJraXQtYWRkaXRpb25zLWluY2x1 ZGVzLnB5IHdpdGggdGhlIGNvZGUgZnJvbSBXZWJLaXRBZGRpdGlvbnMuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL0NvY29hL1dLV2VicGFnZVByZWZlcmVuY2VzLmg6CisgICAgICAgICogbWFj L3JlcGxhY2Utd2Via2l0LWFkZGl0aW9ucy1pbmNsdWRlcy5weToKKyAgICAgICAgKG1haW4pOgor CiAyMDIyLTAxLTI2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAg ICAgIEJ1aWxkIGZhaWx1cmUgLSB3ZWJraXQgZGFlbW9ucyBkb24ndCBuZWVkIHN5bWxpbmsgd2l0 aCBzeXN0ZW0gY29udGVudCBwYXRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJwYWdlUHJlZmVyZW5jZXMuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYnBhZ2VQcmVmZXJlbmNlcy5oCmluZGV4IDllZTc2OTM5ZDE4YTEx MWY2NTMyNjYwOTlkNjlkMTJhZmFjZWE1NzIuLmUxOWMzMmIwMjFiMTQ4NzFhYTY2OTNmNGNiZWUy NDllNjhiNDA0NzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYnBhZ2VQcmVmZXJlbmNlcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1dlYnBhZ2VQcmVmZXJlbmNlcy5oCkBAIC03MSw3ICs3MSw3IEBAIFdLX0NMQVNT X0FWQUlMQUJMRShtYWNvcygxMC4xNSksIGlvcygxMy4wKSkKICovCiBAcHJvcGVydHkgKG5vbmF0 b21pYykgQk9PTCBhbGxvd3NDb250ZW50SmF2YVNjcmlwdCBXS19BUElfQVZBSUxBQkxFKG1hY29z KDExLjApLCBpb3MoMTQuMCkpOwogCi0jaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKKyNpZiBF TkFCTEUoQVBJX1dFQktJVF9BRERJVElPTlMpCiAjaW1wb3J0IDxXZWJLaXRBZGRpdGlvbnMvV0tX ZWJwYWdlUHJlZmVyZW5jZXNBZGRpdGlvbnMuaD4KICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L21hYy9yZXBsYWNlLXdlYmtpdC1hZGRpdGlvbnMtaW5jbHVkZXMucHkgYi9Tb3Vy Y2UvV2ViS2l0L21hYy9yZXBsYWNlLXdlYmtpdC1hZGRpdGlvbnMtaW5jbHVkZXMucHkKaW5kZXgg MGFlMWJkYTIyYmVhNDFmYzc3NTU1ZTAzZjVmM2M4YmMxZjIxY2FjYS4uODVjMmM0ZTNmZWE0ZTk0 MDUwNTIzYmM3OTczYTdjYWM0NjIwNDA0MSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9tYWMv cmVwbGFjZS13ZWJraXQtYWRkaXRpb25zLWluY2x1ZGVzLnB5CisrKyBiL1NvdXJjZS9XZWJLaXQv bWFjL3JlcGxhY2Utd2Via2l0LWFkZGl0aW9ucy1pbmNsdWRlcy5weQpAQCAtODgsNyArODgsOSBA QCBkZWYgbWFpbihhcmd2PU5vbmUpOgogICAgICMgV2UgY3VycmVudGx5IG9ubHkgc3VwcG9ydCBX ZWJLaXRBZGRpdGlvbnMgaW4gRnJhbWV3b3JrIGhlYWRlcnMgb24gbWFjT1MgMTMrIGFuZCBpT1Mg MTYrLgogICAgIHNob3VsZF9kb19yZXBsYWNlbWVudCA9IGlzX3N1cHBvcnRlZF9vcygpCiAKLSAg ICBhZGRpdGlvbnNfaW1wb3J0X3BhdHRlcm4gPSByZS5jb21waWxlKHIiXCNpZiBVU0VcKEFQUExF X0lOVEVSTkFMX1NES1wpXG4jaW1wb3J0IDxXZWJLaXRBZGRpdGlvbnMvKC4qKT5cbiNlbmRpZiIp CisgICAgIyBBUElfV0VCS0lUX0FERElUSU9OUyBpcyBpbnRlbnRpb25hbGx5IG5vdCBkZWZpbmVk IGFueXdoZXJlIHNvIHRoYXQgd2UgbmV2ZXIgdHJ5IHRvIGJ1aWxkIHRoaXMgY29kZS4gSXQgaXMg b25seQorICAgICMgbWVhbnQgdG8gYmUgdXNlZCBieSB0aGlzIHNjcmlwdCB0byBpZGVudGlmeSB3 aGVyZSB0byBpbnRyb2R1Y2UgcmVwbGFjZW1lbnQgaW4gQVBJIGhlYWRlcnMgZnJvbSBXZWJLaXRB ZGRpdGlvbnMuCisgICAgYWRkaXRpb25zX2ltcG9ydF9wYXR0ZXJuID0gcmUuY29tcGlsZShyIlwj aWYgRU5BQkxFXChBUElfV0VCS0lUX0FERElUSU9OU1wpXG4jaW1wb3J0IDxXZWJLaXRBZGRpdGlv bnMvKC4qKT5cbiNlbmRpZiIpCiAgICAgdHJ5OgogICAgICAgICB3aXRoIG9wZW4oaGVhZGVyX3Bh dGgsICJyIikgYXMgaGVhZGVyOgogICAgICAgICAgICAgaGVhZGVyX2NvbnRlbnRzID0gaGVhZGVy LnJlYWQoKQo= 450244 2022-01-28 09:46:40 -0800 2022-01-28 10:34:40 -0800 Follow-up to address ap's comments. bug-235674-20220128094639.patch text/plain 2679 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk4NGY5ZWEyNmFiZDE4MWZk MTRhM2I1YWU5MTMzMmZmYzU5MmM3YmIuLmU3MTg2ZGM4NWE1YzA4MDhiMDYyYTZhMDgzYmY4MGFl YWNiZThhNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDEtMjggIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTeW1ib2xzIG5vdCBhbHdheXMgcHJv cGVybHkgaGlkZGVuIHdoZW4gdXNpbmcgV2ViS2l0QWRkaXRpb25zIHRvIGludHJvZHVjZSBuZXcg QVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU2 NzQKKyAgICAgICAgPHJkYXI6Ly84Nzk5OTI1Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGb2xsb3ctdXAgdG8gcjI4ODY1OCB0byBhZGRyZXNzIHBv c3QgY29tbWl0IGZlZWRiYWNrIGZyb20gQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJwYWdlUHJlZmVyZW5jZXMuaDoKKyAgICAgICAgKiBt YWMvcmVwbGFjZS13ZWJraXQtYWRkaXRpb25zLWluY2x1ZGVzLnB5OgorICAgICAgICAobWFpbik6 CisKIDIwMjItMDEtMjcgIEFkaXR5YSBLZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgogCiAg ICAgICAgIEludHJvZHVjZSBXZWJGb3VuZFRleHRSYW5nZSBhbmQgV2ViRm91bmRUZXh0UmFuZ2VD b250cm9sbGVyIHRvIHN1cHBvcnQgcmVzdG9yYWJsZSBmaW5kIHJlc3VsdHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYnBhZ2VQcmVmZXJlbmNlcy5o IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2VicGFnZVByZWZlcmVuY2Vz LmgKaW5kZXggZTE5YzMyYjAyMWIxNDg3MWFhNjY5M2Y0Y2JlZTI0OWU2OGI0MDQ3My4uNzQzYWQ1 NTQxNzdhM2UyODEyOWE0MDMwNDUyMmEzMDM2Y2RmYzkzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2VicGFnZVByZWZlcmVuY2VzLmgKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2VicGFnZVByZWZlcmVuY2VzLmgKQEAg LTcxLDcgKzcxLDcgQEAgV0tfQ0xBU1NfQVZBSUxBQkxFKG1hY29zKDEwLjE1KSwgaW9zKDEzLjAp KQogKi8KIEBwcm9wZXJ0eSAobm9uYXRvbWljKSBCT09MIGFsbG93c0NvbnRlbnRKYXZhU2NyaXB0 IFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoMTEuMCksIGlvcygxNC4wKSk7CiAKLSNpZiBFTkFCTEUo QVBJX1dFQktJVF9BRERJVElPTlMpCisjaWYgMCAvLyBBUElfV0VCS0lUX0FERElUSU9OU19SRVBM QUNFTUVOVAogI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zL1dLV2VicGFnZVByZWZlcmVuY2VzQWRk aXRpb25zLmg+CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvcmVwbGFj ZS13ZWJraXQtYWRkaXRpb25zLWluY2x1ZGVzLnB5IGIvU291cmNlL1dlYktpdC9tYWMvcmVwbGFj ZS13ZWJraXQtYWRkaXRpb25zLWluY2x1ZGVzLnB5CmluZGV4IDg1YzJjNGUzZmVhNGU5NDA1MDUy M2JjNzk3M2E3Y2FjNDYyMDQwNDEuLjcwMGFiMzhiNGY0YTRkODRlMmU0OGM4YmM2ZTQ4YmMxMzY2 YTlmOTEgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL3JlcGxhY2Utd2Via2l0LWFkZGl0 aW9ucy1pbmNsdWRlcy5weQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9yZXBsYWNlLXdlYmtpdC1h ZGRpdGlvbnMtaW5jbHVkZXMucHkKQEAgLTg4LDkgKzg4LDcgQEAgZGVmIG1haW4oYXJndj1Ob25l KToKICAgICAjIFdlIGN1cnJlbnRseSBvbmx5IHN1cHBvcnQgV2ViS2l0QWRkaXRpb25zIGluIEZy YW1ld29yayBoZWFkZXJzIG9uIG1hY09TIDEzKyBhbmQgaU9TIDE2Ky4KICAgICBzaG91bGRfZG9f cmVwbGFjZW1lbnQgPSBpc19zdXBwb3J0ZWRfb3MoKQogCi0gICAgIyBBUElfV0VCS0lUX0FERElU SU9OUyBpcyBpbnRlbnRpb25hbGx5IG5vdCBkZWZpbmVkIGFueXdoZXJlIHNvIHRoYXQgd2UgbmV2 ZXIgdHJ5IHRvIGJ1aWxkIHRoaXMgY29kZS4gSXQgaXMgb25seQotICAgICMgbWVhbnQgdG8gYmUg dXNlZCBieSB0aGlzIHNjcmlwdCB0byBpZGVudGlmeSB3aGVyZSB0byBpbnRyb2R1Y2UgcmVwbGFj ZW1lbnQgaW4gQVBJIGhlYWRlcnMgZnJvbSBXZWJLaXRBZGRpdGlvbnMuCi0gICAgYWRkaXRpb25z X2ltcG9ydF9wYXR0ZXJuID0gcmUuY29tcGlsZShyIlwjaWYgRU5BQkxFXChBUElfV0VCS0lUX0FE RElUSU9OU1wpXG4jaW1wb3J0IDxXZWJLaXRBZGRpdGlvbnMvKC4qKT5cbiNlbmRpZiIpCisgICAg YWRkaXRpb25zX2ltcG9ydF9wYXR0ZXJuID0gcmUuY29tcGlsZShyIlwjaWYgMCAvLyBBUElfV0VC S0lUX0FERElUSU9OU19SRVBMQUNFTUVOVFxuI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zLyguKik+ XG4jZW5kaWYiKQogICAgIHRyeToKICAgICAgICAgd2l0aCBvcGVuKGhlYWRlcl9wYXRoLCAiciIp IGFzIGhlYWRlcjoKICAgICAgICAgICAgIGhlYWRlcl9jb250ZW50cyA9IGhlYWRlci5yZWFkKCkK