235672 2022-01-26 13:57:09 -0800 avoid setting and clearing :active state when dispatching synthetic click events when possible 2022-01-27 00:49:33 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam cdumez esprehn+autocc ews-watchlist kangil.han simon.fraser webkit-bug-importer oldest_to_newest 1834279 0 heycam 2022-01-26 13:57:09 -0800 Simulated click events are dispatched with two options: * whether to send associated events mouseover, mouseup, mousedown * whether to repaint the target element with its pressed look We currently always set the element's :active state just after when we'd send the mousedown event, and clear it just after that. When we dispatch a simulated click event with neither of the above options set, there's no way to observe the temporary :active state on the element. We can skip it in that case. Forthcoming is a 0.3-0.4% improvement on Speedometer 2. 1834284 1 450067 heycam 2022-01-26 14:01:40 -0800 Created attachment 450067 Patch 1834294 2 webkit-bug-importer 2022-01-26 14:20:49 -0800 <rdar://problem/88095418> 1834375 3 450091 heycam 2022-01-26 17:33:40 -0800 Created attachment 450091 Patch 1834447 4 ews-feeder 2022-01-27 00:49:29 -0800 Committed r288669 (246475@main): <https://commits.webkit.org/246475@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450091. 450067 2022-01-26 14:01:40 -0800 2022-01-26 17:33:36 -0800 Patch bug-235672-20220127090139.patch text/plain 2451 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdmZDk3MzFiZTZmYjVl ZWJiYWZhNDY5ZDAyNjE1YWU0NGNmZTRkOC4uNGMyYzBlZjNmMWExMmNlMWVlZDhlOTQ1NDk1Yzc2 MzljZDVlMTNlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDIyLTAxLTI2ICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgc2V0dGlu ZyBhbmQgY2xlYXJpbmcgOmFjdGl2ZSBzdGF0ZSB3aGVuIGRpc3BhdGNoaW5nIHN5bnRoZXRpYyBj bGljayBldmVudHMgd2hlbiBwb3NzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NjcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2ltdWxhdGVkIGNsaWNrIGV2ZW50cyBhcmUgZGlzcGF0Y2hlZCB3 aXRoIHR3byBvcHRpb25zOgorCisgICAgICAgIC0gd2hldGhlciB0byBzZW5kIGFzc29jaWF0ZWQg ZXZlbnRzIG1vdXNlb3ZlciwgbW91c2V1cCwgbW91c2Vkb3duCisgICAgICAgIC0gd2hldGhlciB0 byByZXBhaW50IHRoZSB0YXJnZXQgZWxlbWVudCB3aXRoIGl0cyBwcmVzc2VkIGxvb2sKKworICAg ICAgICBXZSBjdXJyZW50bHkgYWx3YXlzIHNldCB0aGUgZWxlbWVudCdzIDphY3RpdmUgc3RhdGUg anVzdCBhZnRlciB3aGVuIHdlJ2QKKyAgICAgICAgc2VuZCB0aGUgbW91c2Vkb3duIGV2ZW50LCBh bmQgY2xlYXIgaXQganVzdCBhZnRlciB0aGF0LgorCisgICAgICAgIFdoZW4gd2UgZGlzcGF0Y2gg YSBzaW11bGF0ZWQgY2xpY2sgZXZlbnQgd2l0aCBuZWl0aGVyIG9mIHRoZSBhYm92ZQorICAgICAg ICBvcHRpb25zIHNldCwgdGhlcmUncyBubyB3YXkgdG8gb2JzZXJ2ZSB0aGUgdGVtcG9yYXJ5IDph Y3RpdmUgc3RhdGUgb24KKyAgICAgICAgdGhlIGVsZW1lbnQuIFdlIGNhbiBza2lwIGl0IGluIHRo YXQgY2FzZS4KKworICAgICAgICBXZSBuZWVkIHRvIGNvbnRpbnVlIGNsZWFyaW5nIGNsZWFyaW5n IHRoZSA6YWN0aXZlIHN0YXRlIHJlZ2FyZGxlc3MsCisgICAgICAgIGJlY2F1c2Ugc29tZSBjYWxs ZXJzIGhhdmUgYWxyZWFkeSBzZXQgOmFjdGl2ZSBhbmQgYXJlIHJlbHlpbmcgb24KKyAgICAgICAg c2ltdWxhdGVDbGljayB0byBjbGVhciBpdC4KKworICAgICAgICBUaGlzIHBhdGNoIGlzIGEgMC4z LTAuNCUgaW1wcm92ZW1lbnQgb24gU3BlZWRvbWV0ZXIgMi4KKworICAgICAgICAqIGRvbS9TaW11 bGF0ZWRDbGljay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzaW11bGF0ZUNsaWNrKToKKwogMjAy Mi0wMS0yMyAgTWF0dCBXb29kcm93ICA8bWF0dHdvb2Ryb3dAYXBwbGUuY29tPgogCiAgICAgICAg IFBvc2l0aW9uOmZpeGVkIGxheWVycyBzaG91bGRuJ3QgYWxsb2NhdGUgYSBiYWNraW5nIGJ1ZmZl ciBpZiBhbGwgY2hpbGRyZW4gYXJlIG9mZnNjcmVlbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2RvbS9TaW11bGF0ZWRDbGljay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2ltdWxhdGVk Q2xpY2suY3BwCmluZGV4IGM5YzM4ZDk2ZWQyNDI0YjA2NThjNGE1ZmUxYWM1NDNlN2RjZjJiODcu LjUyZTYxYTAyYjY1OTEyNzcxN2U2NDg5MTc4MTg2NDAxZjFjZmJkMmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9TaW11bGF0ZWRDbGljay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL1NpbXVsYXRlZENsaWNrLmNwcApAQCAtOTUsNyArOTUsOCBAQCBib29sIHNpbXVsYXRlQ2xp Y2soRWxlbWVudCYgZWxlbWVudCwgRXZlbnQqIHVuZGVybHlpbmdFdmVudCwgU2ltdWxhdGVkQ2xp Y2tNb3VzZQogCiAgICAgaWYgKG1vdXNlRXZlbnRPcHRpb25zICE9IFNlbmROb0V2ZW50cykKICAg ICAgICAgc2ltdWxhdGVNb3VzZUV2ZW50KGV2ZW50TmFtZXMoKS5tb3VzZWRvd25FdmVudCwgZWxl bWVudCwgdW5kZXJseWluZ0V2ZW50LCBjcmVhdGlvbk9wdGlvbnMpOwotICAgIGVsZW1lbnQuc2V0 QWN0aXZlKHRydWUsIHZpc3VhbE9wdGlvbnMgPT0gU2hvd1ByZXNzZWRMb29rKTsKKyAgICBpZiAo bW91c2VFdmVudE9wdGlvbnMgIT0gU2VuZE5vRXZlbnRzIHx8IHZpc3VhbE9wdGlvbnMgPT0gU2hv d1ByZXNzZWRMb29rKQorICAgICAgICBlbGVtZW50LnNldEFjdGl2ZSh0cnVlLCB0cnVlKTsKICAg ICBpZiAobW91c2VFdmVudE9wdGlvbnMgIT0gU2VuZE5vRXZlbnRzKQogICAgICAgICBzaW11bGF0 ZU1vdXNlRXZlbnQoZXZlbnROYW1lcygpLm1vdXNldXBFdmVudCwgZWxlbWVudCwgdW5kZXJseWlu Z0V2ZW50LCBjcmVhdGlvbk9wdGlvbnMpOwogICAgIGVsZW1lbnQuc2V0QWN0aXZlKGZhbHNlKTsK 450091 2022-01-26 17:33:40 -0800 2022-01-27 00:49:31 -0800 Patch bug-235672-20220127123339.patch text/plain 4838 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdmZDk3MzFiZTZmYjVl ZWJiYWZhNDY5ZDAyNjE1YWU0NGNmZTRkOC4uOGE5NmU5NWYzODdlNTE1ZWE1N2VjN2IzNDkzMGUz OWIxZGFiYTUxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDIyLTAxLTI2ICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgc2V0dGlu ZyBhbmQgY2xlYXJpbmcgOmFjdGl2ZSBzdGF0ZSB3aGVuIGRpc3BhdGNoaW5nIHN5bnRoZXRpYyBj bGljayBldmVudHMgd2hlbiBwb3NzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NjcyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84ODA5NTQx OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW11 bGF0ZWQgY2xpY2sgZXZlbnRzIGFyZSBkaXNwYXRjaGVkIHdpdGggdHdvIG9wdGlvbnM6CisKKyAg ICAgICAgLSB3aGV0aGVyIHRvIHNlbmQgYXNzb2NpYXRlZCBldmVudHMgbW91c2VvdmVyLCBtb3Vz ZXVwLCBtb3VzZWRvd24KKyAgICAgICAgLSB3aGV0aGVyIHRvIHJlcGFpbnQgdGhlIHRhcmdldCBl bGVtZW50IHdpdGggaXRzIHByZXNzZWQgbG9vaworCisgICAgICAgIFdlIGN1cnJlbnRseSBhbHdh eXMgc2V0IHRoZSBlbGVtZW50J3MgOmFjdGl2ZSBzdGF0ZSBqdXN0IGFmdGVyIHdoZW4gd2UnZAor ICAgICAgICBzZW5kIHRoZSBtb3VzZWRvd24gZXZlbnQsIGFuZCBjbGVhciBpdCBqdXN0IGFmdGVy IHRoYXQuCisKKyAgICAgICAgV2hlbiB3ZSBkaXNwYXRjaCBhIHNpbXVsYXRlZCBjbGljayBldmVu dCB3aXRoIG5laXRoZXIgb2YgdGhlIGFib3ZlCisgICAgICAgIG9wdGlvbnMgc2V0LCB0aGVyZSdz IG5vIHdheSB0byBvYnNlcnZlIHRoZSB0ZW1wb3JhcnkgOmFjdGl2ZSBzdGF0ZSBvbgorICAgICAg ICB0aGUgZWxlbWVudC4gV2UgY2FuIHNraXAgaXQgaW4gdGhhdCBjYXNlLgorCisgICAgICAgIFdl IG5lZWQgdG8gY29udGludWUgY2xlYXJpbmcgY2xlYXJpbmcgdGhlIDphY3RpdmUgc3RhdGUgcmVn YXJkbGVzcywKKyAgICAgICAgYmVjYXVzZSBzb21lIGNhbGxlcnMgaGF2ZSBhbHJlYWR5IHNldCA6 YWN0aXZlIGFuZCBhcmUgcmVseWluZyBvbgorICAgICAgICBzaW11bGF0ZUNsaWNrIHRvIGNsZWFy IGl0LgorCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgYSAwLjMtMC40JSBpbXByb3ZlbWVudCBvbiBT cGVlZG9tZXRlciAyLgorCisgICAgICAgICogZG9tL1NpbXVsYXRlZENsaWNrLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OnNpbXVsYXRlQ2xpY2spOgorCiAyMDIyLTAxLTIzICBNYXR0IFdvb2Ryb3cg IDxtYXR0d29vZHJvd0BhcHBsZS5jb20+CiAKICAgICAgICAgUG9zaXRpb246Zml4ZWQgbGF5ZXJz IHNob3VsZG4ndCBhbGxvY2F0ZSBhIGJhY2tpbmcgYnVmZmVyIGlmIGFsbCBjaGlsZHJlbiBhcmUg b2Zmc2NyZWVuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1NpbXVsYXRlZENsaWNr LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaW11bGF0ZWRDbGljay5jcHAKaW5kZXggYzljMzhk OTZlZDI0MjRiMDY1OGM0YTVmZTFhYzU0M2U3ZGNmMmI4Ny4uNTJlNjFhMDJiNjU5MTI3NzE3ZTY0 ODkxNzgxODY0MDFmMWNmYmQyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NpbXVs YXRlZENsaWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2ltdWxhdGVkQ2xpY2suY3Bw CkBAIC05NSw3ICs5NSw4IEBAIGJvb2wgc2ltdWxhdGVDbGljayhFbGVtZW50JiBlbGVtZW50LCBF dmVudCogdW5kZXJseWluZ0V2ZW50LCBTaW11bGF0ZWRDbGlja01vdXNlCiAKICAgICBpZiAobW91 c2VFdmVudE9wdGlvbnMgIT0gU2VuZE5vRXZlbnRzKQogICAgICAgICBzaW11bGF0ZU1vdXNlRXZl bnQoZXZlbnROYW1lcygpLm1vdXNlZG93bkV2ZW50LCBlbGVtZW50LCB1bmRlcmx5aW5nRXZlbnQs IGNyZWF0aW9uT3B0aW9ucyk7Ci0gICAgZWxlbWVudC5zZXRBY3RpdmUodHJ1ZSwgdmlzdWFsT3B0 aW9ucyA9PSBTaG93UHJlc3NlZExvb2spOworICAgIGlmIChtb3VzZUV2ZW50T3B0aW9ucyAhPSBT ZW5kTm9FdmVudHMgfHwgdmlzdWFsT3B0aW9ucyA9PSBTaG93UHJlc3NlZExvb2spCisgICAgICAg IGVsZW1lbnQuc2V0QWN0aXZlKHRydWUsIHRydWUpOwogICAgIGlmIChtb3VzZUV2ZW50T3B0aW9u cyAhPSBTZW5kTm9FdmVudHMpCiAgICAgICAgIHNpbXVsYXRlTW91c2VFdmVudChldmVudE5hbWVz KCkubW91c2V1cEV2ZW50LCBlbGVtZW50LCB1bmRlcmx5aW5nRXZlbnQsIGNyZWF0aW9uT3B0aW9u cyk7CiAgICAgZWxlbWVudC5zZXRBY3RpdmUoZmFsc2UpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFiOWY4MjhiNTc1ZGQ4 MTg3NTVhMWRlZDUyY2UwNzY3MjcxNTc4MzEuLmNjODY5MjU0MmZhNzg2OWQ1OTg3NjczODAwYWJm N2QwYjkzZDY2OWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMi0wMS0yNiAgQ2FtZXJvbiBN Y0Nvcm1hY2sgIDxoZXljYW1AYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIHNldHRpbmcgYW5k IGNsZWFyaW5nIDphY3RpdmUgc3RhdGUgd2hlbiBkaXNwYXRjaGluZyBzeW50aGV0aWMgY2xpY2sg ZXZlbnRzIHdoZW4gcG9zc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzNTY3MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODgwOTU0MTg+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ndGsvaW5zcGVjdG9yL3RpbWVsaW5lL2xpbmUtY29sdW1uLWV4cGVjdGVkLnR4dDoKKwogMjAy Mi0wMS0yMyAgTWF0dCBXb29kcm93ICA8bWF0dHdvb2Ryb3dAYXBwbGUuY29tPgogCiAgICAgICAg IFBvc2l0aW9uOmZpeGVkIGxheWVycyBzaG91bGRuJ3QgYWxsb2NhdGUgYSBiYWNraW5nIGJ1ZmZl ciBpZiBhbGwgY2hpbGRyZW4gYXJlIG9mZnNjcmVlbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9pbnNwZWN0b3IvdGltZWxpbmUvbGluZS1jb2x1bW4tZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2luc3BlY3Rvci90aW1lbGluZS9saW5lLWNvbHVt bi1leHBlY3RlZC50eHQKaW5kZXggYjBhMThjZjVkMzVlODZiNWZmZjcyMDg1YWY0YTc1ZmM2Nzg5 Y2FjMS4uMjVmOTMwZTI5MjFmODg5YzE2NDc3ZmJmYTEwMmEyZDFjNzY3NzY4MCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2luc3BlY3Rvci90aW1lbGluZS9saW5lLWNvbHVt bi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2luc3BlY3Rvci90 aW1lbGluZS9saW5lLWNvbHVtbi1leHBlY3RlZC50eHQKQEAgLTYsNDkgKzYsNiBAQCBUZXN0IHRo YXQgc2NyaXB0IFRpbWVsaW5lIHJlY29yZHMgaGF2ZSBjb2x1bW4gbnVtYmVycy4KIC0tIFJ1bm5p bmcgdGVzdCBjYXNlOiBUaW1lbGluZS5MaW5lQ29sdW1uLndpbGxDYWxsRnVuY3Rpb24KIEV2YWx1 YXRpbmcgaW4gcGFnZS4uLgogUEFTUzogQ2FwdHVyaW5nIHN0YXJ0ZWQuCi17Ci0gICJzdGFydFRp bWUiOiAiPGZpbHRlcmVkPiIsCi0gICJzdGFja1RyYWNlIjogWwotICAgIHsKLSAgICAgICJmdW5j dGlvbk5hbWUiOiAiY2xpY2siLAotICAgICAgInVybCI6ICJbbmF0aXZlIGNvZGVdIiwKLSAgICAg ICJzY3JpcHRJZCI6ICI8ZmlsdGVyZWQ+IiwKLSAgICAgICJsaW5lTnVtYmVyIjogMCwKLSAgICAg ICJjb2x1bW5OdW1iZXIiOiAwCi0gICAgfSwKLSAgICB7Ci0gICAgICAiZnVuY3Rpb25OYW1lIjog IndpbGxDYWxsRnVuY3Rpb25UZXN0IiwKLSAgICAgICJ1cmwiOiAidGltZWxpbmUvbGluZS1jb2x1 bW4uaHRtbCIsCi0gICAgICAic2NyaXB0SWQiOiAiPGZpbHRlcmVkPiIsCi0gICAgICAibGluZU51 bWJlciI6IDI2LAotICAgICAgImNvbHVtbk51bWJlciI6IDQ0Ci0gICAgfSwKLSAgICB7Ci0gICAg ICAiZnVuY3Rpb25OYW1lIjogImdsb2JhbCBjb2RlIiwKLSAgICAgICJ1cmwiOiAiIiwKLSAgICAg ICJzY3JpcHRJZCI6ICI8ZmlsdGVyZWQ+IiwKLSAgICAgICJsaW5lTnVtYmVyIjogMSwKLSAgICAg ICJjb2x1bW5OdW1iZXIiOiAyMQotICAgIH0sCi0gICAgewotICAgICAgImZ1bmN0aW9uTmFtZSI6 ICJldmFsdWF0ZVdpdGhTY29wZUV4dGVuc2lvbiIsCi0gICAgICAidXJsIjogIltuYXRpdmUgY29k ZV0iLAotICAgICAgInNjcmlwdElkIjogIjxmaWx0ZXJlZD4iLAotICAgICAgImxpbmVOdW1iZXIi OiAwLAotICAgICAgImNvbHVtbk51bWJlciI6IDAKLSAgICB9LAotICAgIHsKLSAgICAgICJmdW5j dGlvbk5hbWUiOiAiIiwKLSAgICAgICJ1cmwiOiAiIiwKLSAgICAgICJzY3JpcHRJZCI6ICI8Zmls dGVyZWQ+IiwKLSAgICAgICJsaW5lTnVtYmVyIjogMTQyLAotICAgICAgImNvbHVtbk51bWJlciI6 IDk3Ci0gICAgfQotICBdLAotICAiZGF0YSI6IHt9LAotICAiZnJhbWVJZCI6ICI8ZmlsdGVyZWQ+ IiwKLSAgInR5cGUiOiAiU2NoZWR1bGVTdHlsZVJlY2FsY3VsYXRpb24iCi19CiB7CiAgICJzdGFy dFRpbWUiOiAiPGZpbHRlcmVkPiIsCiAgICJmcmFtZUlkIjogIjxmaWx0ZXJlZD4iLAo=