235661 2022-01-26 11:36:20 -0800 [Web Inspector] Update return value name for Animation.requestEffectTarget() 2022-03-01 02:05:54 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff pangle saam tzagallo webkit-bug-importer oldest_to_newest 1834205 0 graouts 2022-01-26 11:36:20 -0800 [Web Inspector] Update return value name for Animation.requestEffectTarget() 1834206 1 450047 graouts 2022-01-26 11:37:50 -0800 Created attachment 450047 Patch 1834207 2 ews-watchlist 2022-01-26 11:40:17 -0800 This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. 1834210 3 450049 graouts 2022-01-26 11:43:19 -0800 Created attachment 450049 Patch 1834280 4 450049 hi 2022-01-26 13:58:25 -0800 Comment on attachment 450049 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450049&action=review r=me thanks for fixing :) > Source/WebInspectorUI/UserInterface/Models/Animation.js:213 > // COMPATIBILITY (iOS 15): effectTarget changed from DOM.NodeId to DOM.Styleable. NIT: Please adjust this comment to also indicate that the name of the parameter changed. This is important because if one does not provide a callback to a protocol command, the response is encoded into an object that's used as the resolved value of a returned promise (e.g. `let {effectTarget} = await target.AnimationAgent.requestEffectTarget(this._animationId);`), so the property name in the protocol could affect that. ``` // COMPATIBILITY (iOS 15): nodeId was renamed to effectTarget and changed from DOM.NodeId to DOM.Styleable. ``` Also, you could/should remove the comment above on :194 since it's a duplicate (and it's also not really accurate, because `WI.Animation.prototype.requestEffectTarget` will always return a `WI.DOMStyleable` regardless of the protocol). It's only the `if (!isNaN(effectTarget))` line that matters for compatibility. 1834422 5 graouts 2022-01-26 23:21:48 -0800 Committed r288668 (246474@trunk): <https://commits.webkit.org/246474@trunk> 1834423 6 webkit-bug-importer 2022-01-26 23:22:18 -0800 <rdar://problem/88116899> 1834745 7 450049 pangle 2022-01-27 15:42:10 -0800 Comment on attachment 450049 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450049&action=review >> Source/WebInspectorUI/UserInterface/Models/Animation.js:213 >> // COMPATIBILITY (iOS 15): effectTarget changed from DOM.NodeId to DOM.Styleable. > > NIT: Please adjust this comment to also indicate that the name of the parameter changed. This is important because if one does not provide a callback to a protocol command, the response is encoded into an object that's used as the resolved value of a returned promise (e.g. `let {effectTarget} = await target.AnimationAgent.requestEffectTarget(this._animationId);`), so the property name in the protocol could affect that. > ``` > // COMPATIBILITY (iOS 15): nodeId was renamed to effectTarget and changed from DOM.NodeId to DOM.Styleable. > ``` > > Also, you could/should remove the comment above on :194 since it's a duplicate (and it's also not really accurate, because `WI.Animation.prototype.requestEffectTarget` will always return a `WI.DOMStyleable` regardless of the protocol). It's only the `if (!isNaN(effectTarget))` line that matters for compatibility. FYI this will actually need to be `// COMPATIBILITY (iOS 15.4)`, the protocol definition for which is in Bug 235741. 450047 2022-01-26 11:37:50 -0800 2022-01-26 11:43:15 -0800 Patch bug-235661-20220126203749.patch text/plain 1616 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZDlkOTRiNmVkZTQwNmE2MThiYTlhN2Q2ZGQ0ZmRlMjE1OGIxZGU5Li45ZGZiYmZjM2NhOGM4YWVj ZTI0MzgyZjcxN2ZmOTA0ZDBkMWNiNjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMi0wMS0yNiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9y Zz4KKworICAgICAgICBbV2ViIEluc3BlY3Rvcl0gVXBkYXRlIHJldHVybiB2YWx1ZSBuYW1lIGZv ciBBbmltYXRpb24ucmVxdWVzdEVmZmVjdFRhcmdldCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU2NjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIHdyb25nbHkgYXNzdW1lZCB0aGUgbmFtZSBvZiB0 aGUgcmV0dXJuIHZhbHVlIHdhcyBpbXBvcnRhbnQgZm9yIGJhY2t3YXJkIGNvbXBhdGliaWxpdHkg d2hlbgorICAgICAgICBmaXhpbmcgYnVnIDIzNTIzNCwgYnV0IGl0J3Mgbm90LCBzbyBsZXQncyB1 c2UgYSBiZXR0ZXIgbmFtZSB3aGljaCBkb2Vzbid0IG1ha2UgYW55IHBhcnRpY3VsYXIKKyAgICAg ICAgYXNzdW1wdGlvbiBvbiB0aGUgdHlwZS4KKworICAgICAgICAqIGluc3BlY3Rvci9wcm90b2Nv bC9BbmltYXRpb24uanNvbjoKKwogMjAyMi0wMS0yNiAgQW50b2luZSBRdWludCAgPGdyYW91dHNA d2Via2l0Lm9yZz4KIAogICAgICAgICBbV2ViIEluc3BlY3Rvcl0gR3JhcGhpY3MgdGFiIHNob3Vs ZCBkaXNwbGF5IHBzZXVkby1lbGVtZW50cyBmb3IgbW9yZSB0aGFuIDo6YmVmb3JlIGFuZCA6OmFm dGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29s L0FuaW1hdGlvbi5qc29uIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2Nv bC9BbmltYXRpb24uanNvbgppbmRleCA3OGIxYzM3NDZmZDJmYjdjODAwYTUxYzZkNTg0MTdmYWUz MmVhNjJjLi4yZTllOGM3M2Y4NDg2YjhkYjhkM2MyNGE3NTdkMzAxOWJkZGI3NWQ2IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0FuaW1hdGlvbi5q c29uCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvQW5pbWF0 aW9uLmpzb24KQEAgLTg4LDcgKzg4LDcgQEAKICAgICAgICAgICAgICAgICB7ICJuYW1lIjogImFu aW1hdGlvbklkIiwgIiRyZWYiOiAiQW5pbWF0aW9uSWQiIH0KICAgICAgICAgICAgIF0sCiAgICAg ICAgICAgICAicmV0dXJucyI6IFsKLSAgICAgICAgICAgICAgICB7ICJuYW1lIjogIm5vZGVJZCIs ICIkcmVmIjogIkRPTS5TdHlsZWFibGUiIH0KKyAgICAgICAgICAgICAgICB7ICJuYW1lIjogImVm ZmVjdFRhcmdldCIsICIkcmVmIjogIkRPTS5TdHlsZWFibGUiIH0KICAgICAgICAgICAgIF0KICAg ICAgICAgfSwKICAgICAgICAgewo= 450049 2022-01-26 11:43:19 -0800 2022-03-01 02:05:54 -0800 Patch bug-235661-20220126204318.patch text/plain 3770 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZDlkOTRiNmVkZTQwNmE2MThiYTlhN2Q2ZGQ0ZmRlMjE1OGIxZGU5Li45ZGZiYmZjM2NhOGM4YWVj ZTI0MzgyZjcxN2ZmOTA0ZDBkMWNiNjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMi0wMS0yNiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9y Zz4KKworICAgICAgICBbV2ViIEluc3BlY3Rvcl0gVXBkYXRlIHJldHVybiB2YWx1ZSBuYW1lIGZv ciBBbmltYXRpb24ucmVxdWVzdEVmZmVjdFRhcmdldCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU2NjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIHdyb25nbHkgYXNzdW1lZCB0aGUgbmFtZSBvZiB0 aGUgcmV0dXJuIHZhbHVlIHdhcyBpbXBvcnRhbnQgZm9yIGJhY2t3YXJkIGNvbXBhdGliaWxpdHkg d2hlbgorICAgICAgICBmaXhpbmcgYnVnIDIzNTIzNCwgYnV0IGl0J3Mgbm90LCBzbyBsZXQncyB1 c2UgYSBiZXR0ZXIgbmFtZSB3aGljaCBkb2Vzbid0IG1ha2UgYW55IHBhcnRpY3VsYXIKKyAgICAg ICAgYXNzdW1wdGlvbiBvbiB0aGUgdHlwZS4KKworICAgICAgICAqIGluc3BlY3Rvci9wcm90b2Nv bC9BbmltYXRpb24uanNvbjoKKwogMjAyMi0wMS0yNiAgQW50b2luZSBRdWludCAgPGdyYW91dHNA d2Via2l0Lm9yZz4KIAogICAgICAgICBbV2ViIEluc3BlY3Rvcl0gR3JhcGhpY3MgdGFiIHNob3Vs ZCBkaXNwbGF5IHBzZXVkby1lbGVtZW50cyBmb3IgbW9yZSB0aGFuIDo6YmVmb3JlIGFuZCA6OmFm dGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4OThlMTE0ZjY2Mzk3ZDYwNGE4NzZlMGVi YjUwNDY3MjRmMWMxYzM4Li5lZTc3YjA4ZTdjZDQwZjg5ZjQwMzkzZjE4M2UyMDJiZTNlZGI5MmJk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMi0wMS0yNiAg QW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KKworICAgICAgICBbV2ViIEluc3Bl Y3Rvcl0gVXBkYXRlIHJldHVybiB2YWx1ZSBuYW1lIGZvciBBbmltYXRpb24ucmVxdWVzdEVmZmVj dFRhcmdldCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzU2NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVcGRhdGUgdGhlIHBhcmFtZXRlciBuYW1lIHRvIG1hdGNoIHRoZSBuYW1lIHVzZWQgaW4gdGhl IHByb3RvY29sLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvQW5pbWF0aW9uLmpz OgorICAgICAgICAoV0kuQW5pbWF0aW9uLnByb3RvdHlwZS5yZXF1ZXN0RWZmZWN0VGFyZ2V0KToK KwogMjAyMi0wMS0yNiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAogICAg ICAgICBbV2ViIEluc3BlY3Rvcl0gR3JhcGhpY3MgdGFiIHNob3VsZCBkaXNwbGF5IHBzZXVkby1l bGVtZW50cyBmb3IgbW9yZSB0aGFuIDo6YmVmb3JlIGFuZCA6OmFmdGVyCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0FuaW1hdGlvbi5qc29uIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9BbmltYXRpb24uanNvbgpp bmRleCA3OGIxYzM3NDZmZDJmYjdjODAwYTUxYzZkNTg0MTdmYWUzMmVhNjJjLi4yZTllOGM3M2Y4 NDg2YjhkYjhkM2MyNGE3NTdkMzAxOWJkZGI3NWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0FuaW1hdGlvbi5qc29uCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvQW5pbWF0aW9uLmpzb24KQEAgLTg4LDcg Kzg4LDcgQEAKICAgICAgICAgICAgICAgICB7ICJuYW1lIjogImFuaW1hdGlvbklkIiwgIiRyZWYi OiAiQW5pbWF0aW9uSWQiIH0KICAgICAgICAgICAgIF0sCiAgICAgICAgICAgICAicmV0dXJucyI6 IFsKLSAgICAgICAgICAgICAgICB7ICJuYW1lIjogIm5vZGVJZCIsICIkcmVmIjogIkRPTS5TdHls ZWFibGUiIH0KKyAgICAgICAgICAgICAgICB7ICJuYW1lIjogImVmZmVjdFRhcmdldCIsICIkcmVm IjogIkRPTS5TdHlsZWFibGUiIH0KICAgICAgICAgICAgIF0KICAgICAgICAgfSwKICAgICAgICAg ewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L0FuaW1hdGlvbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVs cy9BbmltYXRpb24uanMKaW5kZXggN2MxYjRjOTg1MTJjMzVmMjIzOGQ0ZTY3OTdjMWM0NDFkZTYz ODgwZS4uMDhiOTVlNDFkNzc4NjFhNWZkMWY2ZDRlZjY4NmFlMGJlMDdmOWVhMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0FuaW1hdGlvbi5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQW5pbWF0 aW9uLmpzCkBAIC0yMDksMTIgKzIwOSwxMiBAQCBXSS5BbmltYXRpb24gPSBjbGFzcyBBbmltYXRp b24gZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgV0kuZG9tTWFuYWdlci5lbnN1cmVEb2N1bWVu dCgpOwogCiAgICAgICAgIGxldCB0YXJnZXQgPSBXSS5hc3N1bWluZ01haW5UYXJnZXQoKTsKLSAg ICAgICAgdGFyZ2V0LkFuaW1hdGlvbkFnZW50LnJlcXVlc3RFZmZlY3RUYXJnZXQodGhpcy5fYW5p bWF0aW9uSWQsIChlcnJvciwgc3R5bGVhYmxlKSA9PiB7CisgICAgICAgIHRhcmdldC5BbmltYXRp b25BZ2VudC5yZXF1ZXN0RWZmZWN0VGFyZ2V0KHRoaXMuX2FuaW1hdGlvbklkLCAoZXJyb3IsIGVm ZmVjdFRhcmdldCkgPT4gewogICAgICAgICAgICAgLy8gQ09NUEFUSUJJTElUWSAoaU9TIDE1KTog ZWZmZWN0VGFyZ2V0IGNoYW5nZWQgZnJvbSBET00uTm9kZUlkIHRvIERPTS5TdHlsZWFibGUuCi0g ICAgICAgICAgICBpZiAoIWlzTmFOKHN0eWxlYWJsZSkpCi0gICAgICAgICAgICAgICAgc3R5bGVh YmxlID0ge25vZGVJZDogc3R5bGVhYmxlfTsKKyAgICAgICAgICAgIGlmICghaXNOYU4oZWZmZWN0 VGFyZ2V0KSkKKyAgICAgICAgICAgICAgICBlZmZlY3RUYXJnZXQgPSB7bm9kZUlkOiBlZmZlY3RU YXJnZXR9OwogCi0gICAgICAgICAgICB0aGlzLl9lZmZlY3RUYXJnZXQgPSAhZXJyb3IgPyBXSS5E T01TdHlsZWFibGUuZnJvbVBheWxvYWQoc3R5bGVhYmxlKSA6IG51bGw7CisgICAgICAgICAgICB0 aGlzLl9lZmZlY3RUYXJnZXQgPSAhZXJyb3IgPyBXSS5ET01TdHlsZWFibGUuZnJvbVBheWxvYWQo ZWZmZWN0VGFyZ2V0KSA6IG51bGw7CiAKICAgICAgICAgICAgIGZvciAobGV0IHJlcXVlc3RFZmZl Y3RUYXJnZXRDYWxsYmFjayBvZiB0aGlzLl9yZXF1ZXN0RWZmZWN0VGFyZ2V0Q2FsbGJhY2tzKQog ICAgICAgICAgICAgICAgIHJlcXVlc3RFZmZlY3RUYXJnZXRDYWxsYmFjayh0aGlzLl9lZmZlY3RU YXJnZXQpOwo=