<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>235630</bug_id>
          
          <creation_ts>2022-01-26 00:32:31 -0800</creation_ts>
          <short_desc>[WebGPU] Make sure WGSLUnitTests can call into WGSL</short_desc>
          <delta_ts>2022-01-27 01:11:48 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Myles C. Maxfield">mmaxfield</reporter>
          <assigned_to name="Myles C. Maxfield">mmaxfield</assigned_to>
          <cc>darin</cc>
    
    <cc>dino</cc>
    
    <cc>rmorisset</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1834003</commentid>
    <comment_count>0</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2022-01-26 00:32:31 -0800</bug_when>
    <thetext>[WebGPU] Make sure WGSLUnitTests can call into WGSL</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1834004</commentid>
    <comment_count>1</comment_count>
      <attachid>450000</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2022-01-26 00:33:47 -0800</bug_when>
    <thetext>Created attachment 450000
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1834005</commentid>
    <comment_count>2</comment_count>
      <attachid>450001</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2022-01-26 00:34:52 -0800</bug_when>
    <thetext>Created attachment 450001
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1834281</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-01-26 13:59:17 -0800</bug_when>
    <thetext>Committed r288643 (246453@main): &lt;https://commits.webkit.org/246453@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450001.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1834282</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-01-26 14:00:17 -0800</bug_when>
    <thetext>&lt;rdar://problem/88094267&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1834316</commentid>
    <comment_count>5</comment_count>
      <attachid>450001</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2022-01-26 15:21:43 -0800</bug_when>
    <thetext>Comment on attachment 450001
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450001&amp;action=review

&gt; Source/WebGPU/ChangeLog:9
&gt; +        (WGSL::staticCheck): Apparently /usr/local/include/AssertMacros.h #defines &quot;check&quot;

In paste we have worked around such things with &quot;#undef&quot;.

See the &quot;#undef new&quot; and &quot;#undef delete&quot; in config.h. And &quot;#undef try&quot; and &quot;#undef catch&quot; in WebCorePrefix.h.

But renaming our function is also OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1834451</commentid>
    <comment_count>6</comment_count>
      <attachid>450001</attachid>
    <who name="Robin Morisset">rmorisset</who>
    <bug_when>2022-01-27 01:11:48 -0800</bug_when>
    <thetext>Comment on attachment 450001
Patch

r=me</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>450000</attachid>
            <date>2022-01-26 00:33:47 -0800</date>
            <delta_ts>2022-01-26 00:34:50 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-235630-20220126003346.patch</filename>
            <type>text/plain</type>
            <size>2559</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViR1BVL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJHUFUvQ2hhbmdlTG9nCmluZGV4IDM1NzU3MmIxZTMwMWZiNDQx
NzYwZmU0YWNiMTgyZjA0ZjNkMTkzYjAuLmNlNTBjMTVmNmNhMTQyYmY5MzUxMzYzZjZkNDVjZTdl
OTZiMjE0NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJHUFUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJHUFUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDEtMjYgIE15bGVzIEMu
IE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViR1BVXSBNYWtl
IHN1cmUgV0dTTFVuaXRUZXN0cyBjYW4gY2FsbCBpbnRvIFdHU0wKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTYzMAorCisgICAgICAgIFVucmV2aWV3
ZWQuCisKKyAgICAgICAgKiBXR1NML1dHU0wuY3BwOgorICAgICAgICAoV0dTTDo6c3RhdGljQ2hl
Y2spOiBBcHBhcmVudGx5IC91c3IvbG9jYWwvaW5jbHVkZS9Bc3NlcnRNYWNyb3MuaCAjZGVmaW5l
cyAiY2hlY2siCisgICAgICAgIChXR1NMOjpjaGVjayk6IERlbGV0ZWQuCisgICAgICAgICogV0dT
TC9XR1NMLmg6CisgICAgICAgICogV0dTTFVuaXRUZXN0cy9XR1NMVW5pdFRlc3RzLm1tOgorICAg
ICAgICAoLVtXR1NMVW5pdFRlc3RzIHRlc3RFeGFtcGxlXSk6CisKIDIwMjItMDEtMjUgIE15bGVz
IEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViR1BVXSBG
aXggV0dTTFVuaXRUZXN0cyBidWlsZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkdQVS9XR1NML1dH
U0wuY3BwIGIvU291cmNlL1dlYkdQVS9XR1NML1dHU0wuY3BwCmluZGV4IDc3YzhhNjE4MzNhZWJh
N2ZhZmE0NzdhYTZlMTgyZmZiM2U1MDJiNDEuLjI1YTY4NWUxNzE1MGI1MzM2OGQ3MGZkNjEzMmZh
YzczNjk0NDcxNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJHUFUvV0dTTC9XR1NMLmNwcAorKysg
Yi9Tb3VyY2UvV2ViR1BVL1dHU0wvV0dTTC5jcHAKQEAgLTMwLDkgKzMwLDggQEAKIAogbmFtZXNw
YWNlIFdHU0wgewogCi1zdGQ6OnZhcmlhbnQ8U3VjY2Vzc2Z1bENoZWNrLCBGYWlsZWRDaGVjaz4g
Y2hlY2soY29uc3QgU3RyaW5nJiwgY29uc3Qgc3RkOjpvcHRpb25hbDxTb3VyY2VNYXA+JikKK3N0
ZDo6dmFyaWFudDxTdWNjZXNzZnVsQ2hlY2ssIEZhaWxlZENoZWNrPiBzdGF0aWNDaGVjayhjb25z
dCBTdHJpbmcmLCBjb25zdCBzdGQ6Om9wdGlvbmFsPFNvdXJjZU1hcD4mKQogewotICAgIEFTU0VS
VF9OT1RfUkVBQ0hFRCgpOwogICAgIHJldHVybiBGYWlsZWRDaGVjayB7IHsgfSwgeyB9IH07CiB9
CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJHUFUvV0dTTC9XR1NMLmggYi9Tb3VyY2UvV2ViR1BV
L1dHU0wvV0dTTC5oCmluZGV4IGIwNmQxMWI1NmYxYzZmM2E5NmRmMGZlMmUxYWIxOGUxZDA4ZmI4
MmQuLjk5YzlkZTdhMzliM2E2Mzc5MTJjYTM0NmM4YzE5YWYxMTljZGUyOTAgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJHUFUvV0dTTC9XR1NMLmgKKysrIGIvU291cmNlL1dlYkdQVS9XR1NML1dHU0wu
aApAQCAtNzIsNyArNzIsNyBAQCBzdHJ1Y3QgU291cmNlTWFwIHsKICAgICAvLyBodHRwczovL3Nv
dXJjZW1hcHMuaW5mby9zcGVjLmh0bWwKIH07CiAKLXN0ZDo6dmFyaWFudDxTdWNjZXNzZnVsQ2hl
Y2ssIEZhaWxlZENoZWNrPiBjaGVjayhjb25zdCBTdHJpbmcmIHdnc2wsIGNvbnN0IHN0ZDo6b3B0
aW9uYWw8U291cmNlTWFwPiYpOworc3RkOjp2YXJpYW50PFN1Y2Nlc3NmdWxDaGVjaywgRmFpbGVk
Q2hlY2s+IHN0YXRpY0NoZWNrKGNvbnN0IFN0cmluZyYgd2dzbCwgY29uc3Qgc3RkOjpvcHRpb25h
bDxTb3VyY2VNYXA+Jik7CiAKIC8vCiAvLyBTdGVwIDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJH
UFUvV0dTTFVuaXRUZXN0cy9XR1NMVW5pdFRlc3RzLm1tIGIvU291cmNlL1dlYkdQVS9XR1NMVW5p
dFRlc3RzL1dHU0xVbml0VGVzdHMubW0KaW5kZXggZjM3NGJhZDYzMzk0YzczZjg5OWVhZjVkNmRi
ZmIwY2E2YjdkZmM5Yy4uZmYwNTRhY2JlMDY3NDI2ZTJjOTYyNDY2YzJjZWI4Mzc1MmE1NzYzYyAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkdQVS9XR1NMVW5pdFRlc3RzL1dHU0xVbml0VGVzdHMubW0K
KysrIGIvU291cmNlL1dlYkdQVS9XR1NMVW5pdFRlc3RzL1dHU0xVbml0VGVzdHMubW0KQEAgLTIz
LDYgKzIzLDkgQEAKICAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUg
UE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAorI2ltcG9ydCAiY29uZmlnLmgiCisj
aW1wb3J0ICJXR1NMLmgiCisKICNpbXBvcnQgPFhDVGVzdC9YQ1Rlc3QuaD4KICNpbXBvcnQgPHZl
Y3Rvcj4KICNpbXBvcnQgPHd0Zi9EYXRhTG9nLmg+CkBAIC00MSw2ICs0NCw3IEBACiAgICAgeS5h
cHBlbmQoMik7CiAgICAgeS5hcHBlbmQoMyk7CiAgICAgWENUQXNzZXJ0RXF1YWwoeCwgeSk7Cisg
ICAgV0dTTDo6c3RhdGljQ2hlY2soIiIsIHN0ZDo6bnVsbG9wdCk7CiB9CiAKIEBlbmQK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>450001</attachid>
            <date>2022-01-26 00:34:52 -0800</date>
            <delta_ts>2022-01-27 01:11:48 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-235630-20220126003451.patch</filename>
            <type>text/plain</type>
            <size>2575</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViR1BVL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJHUFUvQ2hhbmdlTG9nCmluZGV4IDM1NzU3MmIxZTMwMWZiNDQx
NzYwZmU0YWNiMTgyZjA0ZjNkMTkzYjAuLjkzMDE4ZjMxMDllMjQzZjZhOGMxOWY3MmU4ZGU2ODFj
N2ZkYjAyNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJHUFUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJHUFUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDEtMjYgIE15bGVzIEMu
IE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViR1BVXSBNYWtl
IHN1cmUgV0dTTFVuaXRUZXN0cyBjYW4gY2FsbCBpbnRvIFdHU0wKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTYzMAorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV0dTTC9XR1NMLmNwcDoKKyAgICAgICAg
KFdHU0w6OnN0YXRpY0NoZWNrKTogQXBwYXJlbnRseSAvdXNyL2xvY2FsL2luY2x1ZGUvQXNzZXJ0
TWFjcm9zLmggI2RlZmluZXMgImNoZWNrIgorICAgICAgICAoV0dTTDo6Y2hlY2spOiBEZWxldGVk
LgorICAgICAgICAqIFdHU0wvV0dTTC5oOgorICAgICAgICAqIFdHU0xVbml0VGVzdHMvV0dTTFVu
aXRUZXN0cy5tbToKKyAgICAgICAgKC1bV0dTTFVuaXRUZXN0cyB0ZXN0RXhhbXBsZV0pOgorCiAy
MDIyLTAxLTI1ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAg
ICAgICAgW1dlYkdQVV0gRml4IFdHU0xVbml0VGVzdHMgYnVpbGQKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJHUFUvV0dTTC9XR1NMLmNwcCBiL1NvdXJjZS9XZWJHUFUvV0dTTC9XR1NMLmNwcAppbmRl
eCA3N2M4YTYxODMzYWViYTdmYWZhNDc3YWE2ZTE4MmZmYjNlNTAyYjQxLi4yNWE2ODVlMTcxNTBi
NTMzNjhkNzBmZDYxMzJmYWM3MzY5NDQ3MTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViR1BVL1dH
U0wvV0dTTC5jcHAKKysrIGIvU291cmNlL1dlYkdQVS9XR1NML1dHU0wuY3BwCkBAIC0zMCw5ICsz
MCw4IEBACiAKIG5hbWVzcGFjZSBXR1NMIHsKIAotc3RkOjp2YXJpYW50PFN1Y2Nlc3NmdWxDaGVj
aywgRmFpbGVkQ2hlY2s+IGNoZWNrKGNvbnN0IFN0cmluZyYsIGNvbnN0IHN0ZDo6b3B0aW9uYWw8
U291cmNlTWFwPiYpCitzdGQ6OnZhcmlhbnQ8U3VjY2Vzc2Z1bENoZWNrLCBGYWlsZWRDaGVjaz4g
c3RhdGljQ2hlY2soY29uc3QgU3RyaW5nJiwgY29uc3Qgc3RkOjpvcHRpb25hbDxTb3VyY2VNYXA+
JikKIHsKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICByZXR1cm4gRmFpbGVkQ2hlY2sg
eyB7IH0sIHsgfSB9OwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViR1BVL1dHU0wvV0dTTC5o
IGIvU291cmNlL1dlYkdQVS9XR1NML1dHU0wuaAppbmRleCBiMDZkMTFiNTZmMWM2ZjNhOTZkZjBm
ZTJlMWFiMThlMWQwOGZiODJkLi45OWM5ZGU3YTM5YjNhNjM3OTEyY2EzNDZjOGMxOWFmMTE5Y2Rl
MjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViR1BVL1dHU0wvV0dTTC5oCisrKyBiL1NvdXJjZS9X
ZWJHUFUvV0dTTC9XR1NMLmgKQEAgLTcyLDcgKzcyLDcgQEAgc3RydWN0IFNvdXJjZU1hcCB7CiAg
ICAgLy8gaHR0cHM6Ly9zb3VyY2VtYXBzLmluZm8vc3BlYy5odG1sCiB9OwogCi1zdGQ6OnZhcmlh
bnQ8U3VjY2Vzc2Z1bENoZWNrLCBGYWlsZWRDaGVjaz4gY2hlY2soY29uc3QgU3RyaW5nJiB3Z3Ns
LCBjb25zdCBzdGQ6Om9wdGlvbmFsPFNvdXJjZU1hcD4mKTsKK3N0ZDo6dmFyaWFudDxTdWNjZXNz
ZnVsQ2hlY2ssIEZhaWxlZENoZWNrPiBzdGF0aWNDaGVjayhjb25zdCBTdHJpbmcmIHdnc2wsIGNv
bnN0IHN0ZDo6b3B0aW9uYWw8U291cmNlTWFwPiYpOwogCiAvLwogLy8gU3RlcCAyCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViR1BVL1dHU0xVbml0VGVzdHMvV0dTTFVuaXRUZXN0cy5tbSBiL1NvdXJj
ZS9XZWJHUFUvV0dTTFVuaXRUZXN0cy9XR1NMVW5pdFRlc3RzLm1tCmluZGV4IGYzNzRiYWQ2MzM5
NGM3M2Y4OTllYWY1ZDZkYmZiMGNhNmI3ZGZjOWMuLmZmMDU0YWNiZTA2NzQyNmUyYzk2MjQ2NmMy
Y2ViODM3NTJhNTc2M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJHUFUvV0dTTFVuaXRUZXN0cy9X
R1NMVW5pdFRlc3RzLm1tCisrKyBiL1NvdXJjZS9XZWJHUFUvV0dTTFVuaXRUZXN0cy9XR1NMVW5p
dFRlc3RzLm1tCkBAIC0yMyw2ICsyMyw5IEBACiAgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElG
IEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKKyNpbXBv
cnQgImNvbmZpZy5oIgorI2ltcG9ydCAiV0dTTC5oIgorCiAjaW1wb3J0IDxYQ1Rlc3QvWENUZXN0
Lmg+CiAjaW1wb3J0IDx2ZWN0b3I+CiAjaW1wb3J0IDx3dGYvRGF0YUxvZy5oPgpAQCAtNDEsNiAr
NDQsNyBAQAogICAgIHkuYXBwZW5kKDIpOwogICAgIHkuYXBwZW5kKDMpOwogICAgIFhDVEFzc2Vy
dEVxdWFsKHgsIHkpOworICAgIFdHU0w6OnN0YXRpY0NoZWNrKCIiLCBzdGQ6Om51bGxvcHQpOwog
fQogCiBAZW5kCg==
</data>
<flag name="review"
          id="476409"
          type_id="1"
          status="+"
          setter="rmorisset"
    />
          </attachment>
      

    </bug>

</bugzilla>