235624 2022-01-25 18:40:13 -0800 AX: Do less work under m_changeLogLock in AXIsolatedTree::clear and AXIsolatedTree::setFocusedNodeID 2022-01-26 07:55:37 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1833963 0 tyler_w 2022-01-25 18:40:13 -0800 These functions do work while holding the lock that does not require the lock, which is wasteful. 1833964 1 webkit-bug-importer 2022-01-25 18:40:23 -0800 <rdar://problem/88055957> 1833965 2 449988 tyler_w 2022-01-25 18:43:30 -0800 Created attachment 449988 Patch 1834043 3 andresg_22 2022-01-26 04:57:09 -0800 (In reply to Tyler Wilcock from comment #2) > Created attachment 449988 [details] > Patch Looks good. 1834100 4 ews-feeder 2022-01-26 07:55:33 -0800 Committed r288619 (246438@main): <https://commits.webkit.org/246438@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449988. 449988 2022-01-25 18:43:30 -0800 2022-01-26 07:55:35 -0800 Patch bug-235624-20220125204329.patch text/plain 2410 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGVkNDQ2YjQ0OGI5ZjIz YmExZmNmMDI2MzVkYTcyYmUwMTVjMTlkZi4uMTQ4NWExMzVmNTBlZjQyYWIyMmQ2NmFmMDQ1NTg3 Y2NiM2FiOThjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIyLTAxLTI1ICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IERvIGxlc3Mgd29y ayB1bmRlciBtX2NoYW5nZUxvZ0xvY2sgaW4gQVhJc29sYXRlZFRyZWU6OmNsZWFyIGFuZCBBWElz b2xhdGVkVHJlZTo6c2V0Rm9jdXNlZE5vZGVJRAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NjI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQVhJc29sYXRlZFRyZWU6OmNsZWFyIGFuZCBBWElzb2xhdGVk VHJlZTo6c2V0Rm9jdXNlZE5vZGVJRAorICAgICAgICBkbyB3b3JrIHdoaWxlIGhvbGRpbmcgbV9j aGFuZ2VMb2dMb2NrIHRoYXQgZG9lcyBub3QgcmVxdWlyZSB0aGlzIGxvY2suIFRoaXMKKyAgICAg ICAgcGF0Y2ggbW92ZXMgdGhpcyB3b3JrIGJlZm9yZSB0aGUgbG9jayBhY3F1aXNpdGlvbiBzbyB3 ZSBob2xkIHRoZSBsb2NrIGZvciBhcyBzaG9ydAorICAgICAgICBhIHRpbWUgYXMgcG9zc2libGUu CisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVkVHJlZTo6Y2xlYXIpOgorICAgICAgICAo V2ViQ29yZTo6QVhJc29sYXRlZFRyZWU6OnNldEZvY3VzZWROb2RlSUQpOgorICAgICAgICBNb3Zl IHdvcmsgdGhhdCBkb2Vzbid0IHJlcXVpcmUgbV9jaGFuZ2VMb2dMb2NrIGJlZm9yZSB3ZSBhY3F1 aXJlIHRoZSBsb2NrLgorCiAyMDIyLTAxLTI1ICBBbGV4ZXkgU2h2YXlrYSAgPGFzaHZheWthQGFw cGxlLmNvbT4KIAogICAgICAgICBbV2ViSURMXSBSZW1vdmUgdGhlIG5vdy11bnVzZWQgW0N1c3Rv bUVuYWJsZWRdIGV4dGVuZGVkIGF0dHJpYnV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuY3BwIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuY3BwCmluZGV4 IDY1NDlkYmI5YmU1ZmE4NTAxMjkyZjY1NjgyYzcwMGU3ZGE3MmEwZGIuLjAzYWQzZGZmOGI3MzVk NzYxYjMzZmY1Y2NjYzFlZGEyMmZkMmQzNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRUcmVlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5jcHAKQEAg LTc2LDExICs3NiwxMSBAQCB2b2lkIEFYSXNvbGF0ZWRUcmVlOjpjbGVhcigpCiAgICAgQVhUUkFD RSgiQVhJc29sYXRlZFRyZWU6OmNsZWFyIik7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsK ICAgICBtX2F4T2JqZWN0Q2FjaGUgPSBudWxscHRyOworICAgIG1fbm9kZU1hcC5jbGVhcigpOwog CiAgICAgTG9ja2VyIGxvY2tlciB7IG1fY2hhbmdlTG9nTG9jayB9OwogICAgIG1fcGVuZGluZ1N1 YnRyZWVSZW1vdmFscy5hcHBlbmQobV9yb290Tm9kZS0+b2JqZWN0SUQoKSk7CiAgICAgbV9yb290 Tm9kZSA9IG51bGxwdHI7Ci0gICAgbV9ub2RlTWFwLmNsZWFyKCk7CiB9CiAKIFJlZlB0cjxBWElz b2xhdGVkVHJlZT4gQVhJc29sYXRlZFRyZWU6OnRyZWVGb3JJRChBWElzb2xhdGVkVHJlZUlEIHRy ZWVJRCkKQEAgLTQzMSwxMSArNDMxLDExIEBAIHZvaWQgQVhJc29sYXRlZFRyZWU6OnNldEZvY3Vz ZWROb2RlSUQoQVhJRCBheElEKQogICAgIEFYTE9HKG1ha2VTdHJpbmcoImF4SUQgIiwgYXhJRC5s b2dnaW5nU3RyaW5nKCkpKTsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwogCi0gICAgTG9j a2VyIGxvY2tlciB7IG1fY2hhbmdlTG9nTG9jayB9OwotICAgIG1fcGVuZGluZ0ZvY3VzZWROb2Rl SUQgPSBheElEOwotCiAgICAgQVhQcm9wZXJ0eU1hcCBwcm9wZXJ0eU1hcDsKICAgICBwcm9wZXJ0 eU1hcC5zZXQoQVhQcm9wZXJ0eU5hbWU6OklzRm9jdXNlZCwgdHJ1ZSk7CisKKyAgICBMb2NrZXIg bG9ja2VyIHsgbV9jaGFuZ2VMb2dMb2NrIH07CisgICAgbV9wZW5kaW5nRm9jdXNlZE5vZGVJRCA9 IGF4SUQ7CiAgICAgbV9wZW5kaW5nUHJvcGVydHlDaGFuZ2VzLmFwcGVuZCh7IGF4SUQsIHByb3Bl cnR5TWFwIH0pOwogfQogCg==