235613 2022-01-25 15:17:01 -0800 Fix the lldb Color formatter 2022-01-25 17:07:19 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser darin sam simon.fraser webkit-bug-importer oldest_to_newest 1833880 0 simon.fraser 2022-01-25 15:17:01 -0800 Fix the lldb Color formatter 1833881 1 449972 simon.fraser 2022-01-25 15:17:25 -0800 Created attachment 449972 Patch 1833883 2 449972 darin 2022-01-25 15:21:23 -0800 Comment on attachment 449972 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449972&action=review > Tools/lldb/lldb_webkit.py:537 > + # From ColorSpace.h. Should we add a comment to ColorSpace.h telling anyone who edits that they need to update this too? 1833885 3 simon.fraser 2022-01-25 15:23:56 -0800 Will do. 1833904 4 simon.fraser 2022-01-25 16:00:41 -0800 https://trac.webkit.org/changeset/288587/webkit 1833905 5 webkit-bug-importer 2022-01-25 16:01:17 -0800 <rdar://problem/88049212> 1833920 6 449972 sam 2022-01-25 16:21:08 -0800 Comment on attachment 449972 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449972&action=review >> Tools/lldb/lldb_webkit.py:537 >> + # From ColorSpace.h. > > Should we add a comment to ColorSpace.h telling anyone who edits that they need to update this too? "anyone" == "that idiot Sam who has broken this like 10 times now :(" And yes please. 1833942 7 darin 2022-01-25 17:07:19 -0800 The fact that we don’t generate one or both of these from a single source is just "because we are cowards". 449972 2022-01-25 15:17:25 -0800 2022-01-25 15:21:23 -0800 Patch bug-235613-20220125151725.patch text/plain 2617 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmI3NDQ1YjIzZTI0MjcyM2M1ZjUwNjJhNjgxZWVkNTgz YTQ3MDUyOS4uZDZkYWVjZmVjZjFlZjUwMGQxNWEzNjY2N2UxNTU2MzA2OTIwNjZiZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIyLTAxLTI1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCB0aGUgbGxkYiBDb2xvciBmb3JtYXR0ZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTYxMworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQ29weSB0aGUgbGlzdCBvZiBj b2xvciBzcGFjZXMgZnJvbSBDb2xvclNwYWNlLmgKKworICAgICAgICAqIGxsZGIvbGxkYl93ZWJr aXQucHk6CisgICAgICAgIChXZWJDb3JlQ29sb3JQcm92aWRlci5fdG9fc3RyaW5nX291dF9vZl9s aW5lKToKKwogMjAyMi0wMS0yNCAgSm9uYXRoYW4gQmVkYXJkICA8Sm9uV0JlZGFyZEBnbWFpbC5j b20+CiAKICAgICAgICAgW0VXU10gVXNlIGdpdGh1Yi5oZWFkLnNoYSBpbnN0ZWFkIG9mIHJldmlz aW9uCmRpZmYgLS1naXQgYS9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5IGIvVG9vbHMvbGxkYi9s bGRiX3dlYmtpdC5weQppbmRleCA5ODRhZjdjMTZmY2E5YzU0YjMyMWI1ODRmZDYyYWEwZjA0Zjgz NzllLi5iNzUxMmY1MWYxMWM4OGIxMDQ5ZGYwYzkyY2ZhMDkwMzAxZGVlYTcxIDEwMDY0NAotLS0g YS9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5CisrKyBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQu cHkKQEAgLTUzNCwyOCArNTM0LDMxIEBAIGNsYXNzIFdlYkNvcmVDb2xvclByb3ZpZGVyOgogCiAg ICAgICAgIGNvbG9yX3NwYWNlID0gc2VsZi5fY29sb3Jfc3BhY2UocmdiYV9hbmRfZmxhZ3MpCiAK LSAgICAgICAgaWYgY29sb3Jfc3BhY2UgPT0gMDoKLSAgICAgICAgICAgIHByb2ZpbGUgPSAnYTk4 LXJnYicKLSAgICAgICAgZWxpZiBjb2xvcl9zcGFjZSA9PSAxOgotICAgICAgICAgICAgcHJvZmls ZSA9ICdkaXNwbGF5LXAzJwotICAgICAgICBlbGlmIGNvbG9yX3NwYWNlID09IDI6Ci0gICAgICAg ICAgICBwcm9maWxlID0gJ2xjaCcKLSAgICAgICAgZWxpZiBjb2xvcl9zcGFjZSA9PSAzOgotICAg ICAgICAgICAgcHJvZmlsZSA9ICdsYWInCi0gICAgICAgIGVsaWYgY29sb3Jfc3BhY2UgPT0gNDoK LSAgICAgICAgICAgIHByb2ZpbGUgPSAnbGluZWFyLXNyZ2InCi0gICAgICAgIGVsaWYgY29sb3Jf c3BhY2UgPT0gNToKLSAgICAgICAgICAgIHByb2ZpbGUgPSAnbGluZWFyLXNyZ2InCi0gICAgICAg IGVsaWYgY29sb3Jfc3BhY2UgPT0gNjoKLSAgICAgICAgICAgIHByb2ZpbGUgPSAncHJvcGhvdG8t cmdiJwotICAgICAgICBlbGlmIGNvbG9yX3NwYWNlID09IDc6Ci0gICAgICAgICAgICBwcm9maWxl ID0gJ3JlYzIwMjAnCi0gICAgICAgIGVsaWYgY29sb3Jfc3BhY2UgPT0gODoKLSAgICAgICAgICAg IHByb2ZpbGUgPSAnc3JnYicKLSAgICAgICAgZWxpZiBjb2xvcl9zcGFjZSA9PSA5OgotICAgICAg ICAgICAgcHJvZmlsZSA9ICd4eXotZDUwJwotICAgICAgICBlbHNlOgotICAgICAgICAgICAgcHJv ZmlsZSA9ICd1bmtub3duJworICAgICAgICAjIEZyb20gQ29sb3JTcGFjZS5oLgorICAgICAgICBj b2xvcl9zcGFjZXMgPSBbCisgICAgICAgICAgICAnQTk4UkdCJywKKyAgICAgICAgICAgICdEaXNw bGF5UDMnLAorICAgICAgICAgICAgJ0V4dGVuZGVkQTk4UkdCJywKKyAgICAgICAgICAgICdFeHRl bmRlZERpc3BsYXlQMycsCisgICAgICAgICAgICAnRXh0ZW5kZWRMaW5lYXJTUkdCJywKKyAgICAg ICAgICAgICdFeHRlbmRlZFByb1Bob3RvUkdCJywKKyAgICAgICAgICAgICdFeHRlbmRlZFJlYzIw MjAnLAorICAgICAgICAgICAgJ0V4dGVuZGVkU1JHQicsCisgICAgICAgICAgICAnSFNMJywKKyAg ICAgICAgICAgICdIV0InLAorICAgICAgICAgICAgJ0xDSCcsCisgICAgICAgICAgICAnTGFiJywK KyAgICAgICAgICAgICdMaW5lYXJTUkdCJywKKyAgICAgICAgICAgICdPS0xDSCcsCisgICAgICAg ICAgICAnT0tMYWInLAorICAgICAgICAgICAgJ1Byb1Bob3RvUkdCJywKKyAgICAgICAgICAgICdS ZWMyMDIwJywKKyAgICAgICAgICAgICdTUkdCJywKKyAgICAgICAgICAgICdYWVpfRDUwJywKKyAg ICAgICAgICAgICdYWVpfRDY1JywKKyAgICAgICAgXQorCisgICAgICAgIHByb2ZpbGUgPSBjb2xv cl9zcGFjZXNbY29sb3Jfc3BhY2VdIGlmIGNvbG9yX3NwYWNlIDwgbGVuKGNvbG9yX3NwYWNlcykg ZWxzZSAndW5rbm93bicKIAogICAgICAgICBjb2xvcl9jb21wb25lbnRzID0gb3V0X29mX2xpbmVf Y29tcG9uZW50cy5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdtX2NvbXBvbmVudHMnKQogICAgICAg ICBzdGRfYXJyYXlfZWxlbXMgPSBjb2xvcl9jb21wb25lbnRzLkdldENoaWxkTWVtYmVyV2l0aE5h bWUoJ2NvbXBvbmVudHMnKS5HZXRDaGlsZE1lbWJlcldpdGhOYW1lKCdfX2VsZW1zXycpCg==