23561 2009-01-26 17:18:56 -0800 Chromium does not generate a file name when dragging images to the desktop 2009-01-27 09:31:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 paul webkit-unassigned abarth eric oldest_to_newest 107120 0 paul 2009-01-26 17:18:56 -0800 When dragging an image from a web page to the desktop where the image has no ALT text, the file name is empty or contains only an extension (eg ".jpg"). WebCore/platform/ChromiumClipboard.cpp needs to send more information to Chromium in order to properly name the dragged image file. 107121 1 27056 paul 2009-01-26 17:23:58 -0800 Created attachment 27056 Patch for bug 23561 107125 2 27056 eric 2009-01-26 17:37:39 -0800 Comment on attachment 27056 Patch for bug 23561 Patch looks fine. I assume you meant to mark it for review. There seem to be tabs in the changelog which will need to be fixed when landing. 107202 3 dglazkov 2009-01-27 09:31:22 -0800 Committed in http://trac.webkit.org/changeset/40294. 27056 2009-01-26 17:23:58 -0800 2009-01-26 17:37:39 -0800 Patch for bug 23561 saveas.txt text/plain 3112 paul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDI3OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDEtMjYgIFBhdWwgR29kYXZhcmkgIDxwYXVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCUZpeCBmb3Ig aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTYxCisKKwlFeHBsaWNp dGx5IHNlbmQgdGhlIE1JTUUgdHlwZSBmcm9tIGFuIGltYWdlIGRyYWdnZWQgZnJvbSBhIHdlYgor CXBhZ2UgdG8gdGhlIGRlc2t0b3AsIHRvIENocm9taXVtIHNvIHRoYXQgaXQgY2FuIHByb3Blcmx5 IGdlbmVyYXRlCisJYSBmaWxlIG5hbWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9D aHJvbWl1bURhdGFPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21pdW1EYXRhT2Jq ZWN0OjpjbGVhcik6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bURhdGFPYmplY3Q6Omhhc0Rh dGEpOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVjdC5oOgor ICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL0NsaXBib2FyZENocm9taXVtLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OndyaXRlSW1hZ2VUb0RhdGFPYmplY3QpOgorCiAyMDA5LTAxLTI2ICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5z dGVpbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hy b21pdW0uY3BwCShyZXZpc2lvbiA0MDI3MykKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v Q2xpcGJvYXJkQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjgsMTUgKzI2OCwxNCBA QAogICAgIC8vIHVzZSB0aGUgYWx0IHRhZyBpZiBvbmUgZXhpc3RzLCBvdGhlcndpc2Ugd2UgZmFs bCBiYWNrIG9uIHRoZSBzdWdnZXN0ZWQKICAgICAvLyBmaWxlbmFtZSBpbiB0aGUgaHR0cCBoZWFk ZXIsIGFuZCBmaW5hbGx5IHdlIHJlc29ydCB0byB1c2luZyB0aGUgZmlsZW5hbWUKICAgICAvLyBp biB0aGUgVVJMLgotICAgIFN0cmluZyBleHRlbnNpb24oIi4iKTsKLSAgICBleHRlbnNpb24gKz0g TUlNRVR5cGVSZWdpc3RyeTo6Z2V0UHJlZmVycmVkRXh0ZW5zaW9uRm9yTUlNRVR5cGUoCisgICAg ZGF0YU9iamVjdC0+ZmlsZUV4dGVuc2lvbiA9ICIuIjsKKyAgICBkYXRhT2JqZWN0LT5maWxlRXh0 ZW5zaW9uICs9IE1JTUVUeXBlUmVnaXN0cnk6OmdldFByZWZlcnJlZEV4dGVuc2lvbkZvck1JTUVU eXBlKAogICAgICAgICBjYWNoZWRJbWFnZS0+cmVzcG9uc2UoKS5taW1lVHlwZSgpKTsKICAgICBT dHJpbmcgdGl0bGUgPSBlbGVtZW50LT5nZXRBdHRyaWJ1dGUoYWx0QXR0cik7CiAgICAgaWYgKHRp dGxlLmlzRW1wdHkoKSkgewogICAgICAgICB0aXRsZSA9IGNhY2hlZEltYWdlLT5yZXNwb25zZSgp LnN1Z2dlc3RlZEZpbGVuYW1lKCk7Ci0gICAgICAgIC8vIEZJWE1FOiBJZiB0aXRsZSBpcyBlbXB0 eSwgZ2V0IHRoZSBmaWxlbmFtZSBmcm9tIHRoZSBVUkwuCiAgICAgfQotICAgIGRhdGFPYmplY3Qt PmZpbGVDb250ZW50RmlsZW5hbWUgPSB0aXRsZSArIGV4dGVuc2lvbjsKKyAgICBkYXRhT2JqZWN0 LT5maWxlQ29udGVudEZpbGVuYW1lID0gdGl0bGUgKyBkYXRhT2JqZWN0LT5maWxlRXh0ZW5zaW9u OwogfQogCiB2b2lkIENsaXBib2FyZENocm9taXVtOjpkZWNsYXJlQW5kV3JpdGVEcmFnSW1hZ2Uo RWxlbWVudCogZWxlbWVudCwgY29uc3QgS1VSTCYgdXJsLCBjb25zdCBTdHJpbmcmIHRpdGxlLCBG cmFtZSogZnJhbWUpCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0 YU9iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21p dW1EYXRhT2JqZWN0LmgJKHJldmlzaW9uIDQwMjczKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9DaHJvbWl1bURhdGFPYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAtNTQsNiArNTQsNyBA QAogICAgICAgICBLVVJMIHVybDsKICAgICAgICAgU3RyaW5nIHVybFRpdGxlOwogCisgICAgICAg IFN0cmluZyBmaWxlRXh0ZW5zaW9uOwogICAgICAgICBWZWN0b3I8U3RyaW5nPiBmaWxlbmFtZXM7 CiAKICAgICAgICAgU3RyaW5nIHBsYWluVGV4dDsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVjdC5jcHAJKHJldmlzaW9uIDQwMjczKQorKysg V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DaHJvbWl1bURhdGFPYmplY3QuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0zNyw2ICszNyw3IEBACiB7CiAgICAgdXJsID0gS1VSTCgpOwogICAgIHVybFRp dGxlID0gIiI7CisgICAgZmlsZUV4dGVuc2lvbiA9ICIiOwogICAgIGZpbGVuYW1lcy5jbGVhcigp OwogICAgIHBsYWluVGV4dCA9ICIiOwogICAgIHRleHRIdG1sID0gIiI7CkBAIC00OSw2ICs1MCw3 IEBACiBib29sIENocm9taXVtRGF0YU9iamVjdDo6aGFzRGF0YSgpCiB7CiAgICAgcmV0dXJuICF1 cmwuaXNFbXB0eSgpCisgICAgICAgIHx8ICFmaWxlRXh0ZW5zaW9uLmlzRW1wdHkoKQogICAgICAg ICB8fCAhZmlsZW5hbWVzLmlzRW1wdHkoKQogICAgICAgICB8fCAhcGxhaW5UZXh0LmlzRW1wdHko KQogICAgICAgICB8fCAhdGV4dEh0bWwuaXNFbXB0eSgpCg==