235595 2022-01-25 10:02:36 -0800 UIWKDocumentRequestSpatialAndCurrentSelection should limit context to the editable root of the current selection 2022-01-25 12:33:52 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi enrica megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1833755 0 wenson_hsieh 2022-01-25 10:02:36 -0800 rdar://87835602 1833767 1 449939 wenson_hsieh 2022-01-25 10:33:48 -0800 Created attachment 449939 Patch 1833805 2 449939 wenson_hsieh 2022-01-25 12:06:18 -0800 Comment on attachment 449939 Patch Thanks for the review! 1833813 3 ews-feeder 2022-01-25 12:33:49 -0800 Committed r288575 (246398@main): <https://commits.webkit.org/246398@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449939. 449939 2022-01-25 10:33:48 -0800 2022-01-25 12:33:50 -0800 Patch bug-235595-20220125103347.patch text/plain 6488 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY4NDE2MDM1MTFmMmM1NjY5 MGVhYzAwMDE1OGY3NGZmMjIwY2ZmMWEuLjVjYjYzNzI1MzhiMTE2MzJkOGJiMmVjODc2OWViM2Yy NWUwOWJlM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMjItMDEtMjUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgVUlXS0RvY3VtZW50UmVx dWVzdFNwYXRpYWxBbmRDdXJyZW50U2VsZWN0aW9uIHNob3VsZCBsaW1pdCBjb250ZXh0IHRvIHRo ZSBlZGl0YWJsZSByb290IG9mIHRoZSBjdXJyZW50IHNlbGVjdGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NTk1CisgICAgICAgIHJkYXI6Ly84 NzgzNTYwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkanVzdCB0aGUgYmVoYXZpb3Igb2YgZG9jdW1lbnQgZWRpdGluZyBjb250ZXh0IHJlcXVlc3Rz IGluIHRoZSBjYXNlIHdoZXJlIHRoZSBgU3BhdGlhbEFuZEN1cnJlbnRTZWxlY3Rpb25gIGZsYWcK KyAgICAgICAgaXMgc3BlY2lmaWVkLCBidXQgbm8gZXhwbGljaXQgYHRleHRJbnB1dENvbnRleHRg IGhhcyBiZWVuIGdpdmVuLiBJbnN0ZWFkIG9mIHVzaW5nIHRoZSBoaXQtdGVzdGVkIGNvcm5lcnMg b2YgdGhlCisgICAgICAgIHNwYXRpYWwgcmVxdWVzdCBhcy1pcywgY2xhbXAgdG8gdGhlIHZpc2li bGUgc3RhcnQgYW5kIGVuZCBwb3NpdGlvbnMgb2YgdGhlIGN1cnJlbnQgZWRpdGFibGUgcm9vdCAo b25seSBpZiBpdAorICAgICAgICBleGlzdHMpLgorCisgICAgICAgIFRoaXMgYWRqdXN0bWVudCBt YWtlcyB0aGlzIHBhcnRpY3VsYXIgcmVxdWVzdCBjb25maWd1cmF0aW9uIHVzZWZ1bCBmb3IgdGV4 dCBpbnB1dCBjbGllbnRzIHRoYXQganVzdCB3YW50IHRvCisgICAgICAgIHJlcXVlc3QgdGV4dCBp bnB1dCBjb250ZXh0IGluZm9ybWF0aW9uIGZvciB0aGUgY3VycmVudCBlZGl0YWJsZSBlbGVtZW50 IGluIGEgZ2l2ZW4gcmVjdCwgYnV0IGRvbid0IGFscmVhZHkgaGF2ZQorICAgICAgICBhIHRleHQg aW5wdXQgZWxlbWVudCBpZGVudGlmaWVyLgorCisgICAgICAgIFRlc3Q6IERvY3VtZW50RWRpdGlu Z0NvbnRleHQuU3BhdGlhbEFuZEN1cnJlbnRTZWxlY3Rpb25SZXF1ZXN0X0xpbWl0Q29udGV4dFRv RWRpdGFibGVSb290CisKKyAgICAgICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmg6CisK KyAgICAgICAgRHJpdmUtYnkgZml4OiBhbHNvIGNsZWFuIHVwIGEgY291cGxlIG9mIG9sZCBzdGFn aW5nIGRlY2xhcmF0aW9ucy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi UGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6cmVxdWVzdERvY3VtZW50RWRp dGluZ0NvbnRleHQpOgorCiAyMDIyLTAxLTIxICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUu Y29tPgogCiAgICAgICAgIERpc2FibGUgQ0ZVUkxDYWNoZSBpbiBXZWJLaXQyCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaCBiL1NvdXJjZS9XZWJL aXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCmluZGV4IGJmN2ZmMjAwODI3ODU5NDc0Nzgx OTVmMTkwNTdjOWRkMGFhMzY2YjIuLjg1MjJkOWNhZjc2MWZlYjU0MDNlYTQ0Y2VjNzgyMjliYjk5 YzBiZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQ SS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCkBAIC0x MjU5LDYgKzEyNTksOCBAQCB0eXBlZGVmIE5TX09QVElPTlMoTlNJbnRlZ2VyLCBVSVdLRG9jdW1l bnRSZXF1ZXN0RmxhZ3MpIHsKICAgICBVSVdLRG9jdW1lbnRSZXF1ZXN0UmVjdHMgPSAxIDw8IDIs CiAgICAgVUlXS0RvY3VtZW50UmVxdWVzdFNwYXRpYWwgPSAxIDw8IDMsCiAgICAgVUlXS0RvY3Vt ZW50UmVxdWVzdEFubm90YXRpb24gPSAxIDw8IDQsCisgICAgVUlXS0RvY3VtZW50UmVxdWVzdE1h cmtlZFRleHRSZWN0cyA9ICAxIDw8IDUsCisgICAgVUlXS0RvY3VtZW50UmVxdWVzdFNwYXRpYWxB bmRDdXJyZW50U2VsZWN0aW9uID0gIDEgPDwgNiwKIH07CiAKIEBpbnRlcmZhY2UgVUlXS0RvY3Vt ZW50UmVxdWVzdCA6IE5TT2JqZWN0CkBAIC0xMzQxLDkgKzEzNDMsNiBAQCB0eXBlZGVmIE5TX0VO VU0oTlNVSW50ZWdlciwgX1VJQ29udGV4dE1lbnVMYXlvdXQpIHsKIAogI2VuZGlmIC8vIFVTRShB UFBMRV9JTlRFUk5BTF9TREspCiAKLSNkZWZpbmUgVUlXS0RvY3VtZW50UmVxdWVzdE1hcmtlZFRl eHRSZWN0cyAoMSA8PCA1KQotI2RlZmluZSBVSVdLRG9jdW1lbnRSZXF1ZXN0U3BhdGlhbEFuZEN1 cnJlbnRTZWxlY3Rpb24gKDEgPDwgNikKLQogI2lmIEhBVkUoUEFTVEVCT0FSRF9EQVRBX09XTkVS KQogCiBAaW50ZXJmYWNlIFVJUmVzcG9uZGVyIChTdGFnaW5nXzczODUyMzM1KQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gYi9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCA2 MWY1MWIzNmE3NTkxZjNkNGE2YmEzNDM1MjUzYTNiMTQ4ZjU4MGJmLi40MjJmOWRlYTYyY2FlN2Vi ZDgxNTViNmQ0ZjI5NmIyMmFhNTkyMDk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQpAQCAtNDQ5MCw2ICs0NDkwLDE2IEBAIHZv aWQgV2ViUGFnZTo6cmVxdWVzdERvY3VtZW50RWRpdGluZ0NvbnRleHQoRG9jdW1lbnRFZGl0aW5n Q29udGV4dFJlcXVlc3QgcmVxdWVzCiAgICAgICAgIC8vIEZJWE1FOiBXZSBtaWdodCBuZWVkIHRv IGJlIGEgYml0IG1vcmUgY2FyZWZ1bCB0aGF0IHdlIGdldCBzb21ldGhpbmcgdXNlZnVsICh0ZXN0 IHRoZSBvdGhlciBjb3JuZXJzPykuCiAgICAgICAgIHJhbmdlT2ZJbnRlcmVzdC5zdGFydCA9IHZp c2libGVQb3NpdGlvbkZvclBvaW50SW5Sb290Vmlld0Nvb3JkaW5hdGVzKGZyYW1lLmdldCgpLCBy ZXF1ZXN0LnJlY3QubWluWE1pbllDb3JuZXIoKSk7CiAgICAgICAgIHJhbmdlT2ZJbnRlcmVzdC5l bmQgPSB2aXNpYmxlUG9zaXRpb25Gb3JQb2ludEluUm9vdFZpZXdDb29yZGluYXRlcyhmcmFtZS5n ZXQoKSwgcmVxdWVzdC5yZWN0Lm1heFhNYXhZQ29ybmVyKCkpOworICAgICAgICBpZiAocmVxdWVz dC5vcHRpb25zLmNvbnRhaW5zKERvY3VtZW50RWRpdGluZ0NvbnRleHRSZXF1ZXN0OjpPcHRpb25z OjpTcGF0aWFsQW5kQ3VycmVudFNlbGVjdGlvbikpIHsKKyAgICAgICAgICAgIGlmIChSZWZQdHIg cm9vdEVkaXRhYmxlRWxlbWVudCA9IHNlbGVjdGlvbi5yb290RWRpdGFibGVFbGVtZW50KCkpIHsK KyAgICAgICAgICAgICAgICBWaXNpYmxlUG9zaXRpb24gc3RhcnRPZkVkaXRhYmxlUm9vdCB7IGZp cnN0UG9zaXRpb25Jbk9yQmVmb3JlTm9kZShyb290RWRpdGFibGVFbGVtZW50LmdldCgpKSB9Owor ICAgICAgICAgICAgICAgIFZpc2libGVQb3NpdGlvbiBlbmRPZkVkaXRhYmxlUm9vdCB7IGxhc3RQ b3NpdGlvbkluT3JBZnRlck5vZGUocm9vdEVkaXRhYmxlRWxlbWVudC5nZXQoKSkgfTsKKyAgICAg ICAgICAgICAgICBpZiAocmFuZ2VPZkludGVyZXN0LnN0YXJ0IDwgc3RhcnRPZkVkaXRhYmxlUm9v dCkKKyAgICAgICAgICAgICAgICAgICAgcmFuZ2VPZkludGVyZXN0LnN0YXJ0ID0gV1RGTW92ZShz dGFydE9mRWRpdGFibGVSb290KTsKKyAgICAgICAgICAgICAgICBpZiAocmFuZ2VPZkludGVyZXN0 LmVuZCA+IGVuZE9mRWRpdGFibGVSb290KQorICAgICAgICAgICAgICAgICAgICByYW5nZU9mSW50 ZXJlc3QuZW5kID0gV1RGTW92ZShlbmRPZkVkaXRhYmxlUm9vdCk7CisgICAgICAgICAgICB9Cisg ICAgICAgIH0KICAgICB9IGVsc2UgaWYgKCFzZWxlY3Rpb24uaXNOb25lKCkpCiAgICAgICAgIHJh bmdlT2ZJbnRlcmVzdCA9IHNlbGVjdGlvblJhbmdlOwogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmVlOWJiYTRlY2ZiMmZlZmM1N2Y5MDIxN2Iy NWUxMTk1OTAzNTNlMS4uNTMzMDYzMmY0ZWI0OTU1M2IwNDNjYWVlNGJjY2EzZDA3YWI1YzBiYSAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDIyLTAxLTI1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu Y29tPgorCisgICAgICAgIFVJV0tEb2N1bWVudFJlcXVlc3RTcGF0aWFsQW5kQ3VycmVudFNlbGVj dGlvbiBzaG91bGQgbGltaXQgY29udGV4dCB0byB0aGUgZWRpdGFibGUgcm9vdCBvZiB0aGUgY3Vy cmVudCBzZWxlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzNTU5NQorICAgICAgICByZGFyOi8vODc4MzU2MDIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBuZXcgQVBJIHRlc3QgdG8gZXhl cmNpc2UgdGhlIGNoYW5nZS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Q29jb2EvRG9jdW1lbnRFZGl0aW5nQ29udGV4dC5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIy LTAxLTIyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXVthMTF5XSBTdG9wIHJlZ2lzdGVyaW5nIHRoZSB0cmVlIHdoZW4gY2xpZW50cyBh cmUgY29ubmVjdGVkIHdpdGggQVRTUEkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvRG9jdW1lbnRFZGl0aW5nQ29udGV4dC5tbSBiL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvRG9jdW1lbnRFZGl0aW5nQ29udGV4dC5tbQppbmRl eCBhZDRlNzEwZmViNDE0ZGQ4NTNhZjhkYmViNGU5ZjdiODg4N2E2MTUyLi42MjM1NDA4OWE5Zjgy ZTEzMmQ4OTA2ZTA5ZmYzZmIyNjk3YjkzNmU2IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdENvY29hL0RvY3VtZW50RWRpdGluZ0NvbnRleHQubW0KKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Eb2N1bWVudEVkaXRpbmdDb250ZXh0 Lm1tCkBAIC03ODQsNiArNzg0LDE5IEBAIFRFU1QoRG9jdW1lbnRFZGl0aW5nQ29udGV4dCwgU3Bh dGlhbEFuZEN1cnJlbnRTZWxlY3Rpb25SZXF1ZXN0X1JlY3RBZnRlcklucHV0V2l0CiAgICAgRVhQ RUNUX05TU1RSSU5HX0VRKCIgdGhlIGxhenkgZG9nLiIsIGNvbnRleHQuY29udGV4dEFmdGVyKTsK IH0KIAorVEVTVChEb2N1bWVudEVkaXRpbmdDb250ZXh0LCBTcGF0aWFsQW5kQ3VycmVudFNlbGVj dGlvblJlcXVlc3RfTGltaXRDb250ZXh0VG9FZGl0YWJsZVJvb3QpCit7CisgICAgYXV0byB3ZWJW aWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0 TWFrZSgwLCAwLCA5ODAsIDYwMCldKTsKKworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2Fk SFRNTFN0cmluZzphcHBseUFoZW1TdHlsZShAImhlbGxvIHdvcmxkIDx0ZXh0YXJlYT5mb28gYmFy IGJhejwvdGV4dGFyZWE+IHRoaXMgaXMgYSB0ZXN0IildOworICAgIFt3ZWJWaWV3IHN0cmluZ0J5 RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCd0ZXh0YXJlYScp LnNlbGVjdCgpIl07CisKKyAgICBVSVdLRG9jdW1lbnRDb250ZXh0ICpjb250ZXh0ID0gW3dlYlZp ZXcgc3luY2hyb25vdXNseVJlcXVlc3REb2N1bWVudENvbnRleHQ6bWFrZVJlcXVlc3QoVUlXS0Rv Y3VtZW50UmVxdWVzdFRleHQgfCBVSVdLRG9jdW1lbnRSZXF1ZXN0U3BhdGlhbEFuZEN1cnJlbnRT ZWxlY3Rpb24sIFVJVGV4dEdyYW51bGFyaXR5V29yZCwgMjAwLCBDR1JlY3RNYWtlKDAsIDAsIDk4 MCwgNjAwKSldOworICAgIEVYUEVDVF9OVUxMKGNvbnRleHQuY29udGV4dEJlZm9yZSk7CisgICAg RVhQRUNUX05TU1RSSU5HX0VRKCJmb28gYmFyIGJheiIsIGNvbnRleHQuc2VsZWN0ZWRUZXh0KTsK KyAgICBFWFBFQ1RfTlVMTChjb250ZXh0LmNvbnRleHRBZnRlcik7Cit9CisKIFRFU1QoRG9jdW1l bnRFZGl0aW5nQ29udGV4dCwgUmVxdWVzdFJlY3RzSW5UZXh0QXJlYUFjcm9zc1dvcmRXcmFwcGVk TGluZSkKIHsKICAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxv Y10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKV0pOwo=