23559 2009-01-26 16:49:09 -0800 (10 != null), not even on 64-bit. 2009-01-26 17:17:55 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 107111 0 barraclough 2009-01-26 16:49:09 -0800 Specifically, this is a 64-bit JIT bug, and is breaking v8-crypto. 107112 1 27054 barraclough 2009-01-26 16:57:17 -0800 Created attachment 27054 The patch 107114 2 27054 darin 2009-01-26 17:01:16 -0800 Comment on attachment 27054 The patch r=me Is this already covered by a regression test? 107119 3 barraclough 2009-01-26 17:17:55 -0800 (In reply to comment #2) > (From update of attachment 27054 [review]) > Is this already covered by a regression test? Darin, No, it's not covered, I was thinking about that. I could add a regression test to test specifically whether (10 == null), but in a way that feels a little restrictive, and implementation dependent. (this bug occurs since the encoding we happen to use for null happens to be 10, and that we were incorrectly cropping out the high 32-bits). This test would become redundant as soon as we changed the encoding we use for null. At minimum I think I should add a test the checks that null != N, where -255 <= N <= 255, (except, I'm guessing, for zero). But I'd like to try to think of something that feels a little more generic. We should probably also have similar tests for the boolean values, and possibly also for cases where the low 32bits of a double precision number will match an integer value. I'll think a bit more & submit something. cheers, G. Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/jit/JIT.cpp Transmitting file data .. Committed revision 40279. 27054 2009-01-26 16:57:17 -0800 2009-01-26 17:01:16 -0800 The patch patch.cryptofix.txt text/plain 2456 barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQwMjc4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDEt MjYgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIGZvciBlcSBudWxs ICYgbmVxIG51bGwsIG9uIDY0LWJpdCBKSVQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU1OQorCisgICAgICAgIFRoaXMgcGF0Y2ggZGVncmFkZXMg NjQtYml0IEpJVCBwZXJmb3JtYW5jZSBvbiBzb21lIGJlbmNobWFya3MsCisgICAgICAgIGR1ZSB0 byB0aGUgd2hvbGUgbm90LWJlaW5nLWluY29ycmVjdCB0aGluZy4KKworICAgICAgICAqIGppdC9K SVQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OnByaXZhdGVDb21waWxlTWFpblBhc3MpOgorCiAy MDA5LTAxLTI2ICBDYW1lcm9uIFp3YXJpY2ggIDxjd3p3YXJpY2hAdXdhdGVybG9vLmNhPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpJbmRleDogaml0L0pJVC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gaml0L0pJVC5jcHAJKHJldmlzaW9uIDQwMjY4KQorKysgaml0L0pJVC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTc5MSw3ICs3OTEsNyBAQCB2b2lkIEpJVDo6cHJpdmF0ZUNv bXBpbGVNYWluUGFzcygpCiAKICAgICAgICAgICAgIC8vIE5vdyBoYW5kbGUgdGhlIGltbWVkaWF0 ZSBjYXNlcyAtIHVuZGVmaW5lZCAmIG51bGwKICAgICAgICAgICAgIGlzSW1tZWRpYXRlLmxpbmso dGhpcyk7Ci0gICAgICAgICAgICBhbmQzMihJbW0zMih+SlNJbW1lZGlhdGU6OkV4dGVuZGVkVGFn Qml0VW5kZWZpbmVkKSwgWDg2OjplYXgpOworICAgICAgICAgICAgYW5kUHRyKEltbTMyKH5KU0lt bWVkaWF0ZTo6RXh0ZW5kZWRUYWdCaXRVbmRlZmluZWQpLCBYODY6OmVheCk7CiAgICAgICAgICAg ICBhZGRKdW1wKGplUHRyKFg4Njo6ZWF4LCBJbW1QdHIoSlNWYWx1ZVB0cjo6ZW5jb2RlKGpzTnVs bCgpKSkpLCB0YXJnZXQgKyAyKTsgICAgICAgICAgICAKIAogICAgICAgICAgICAgd2FzTm90SW1t ZWRpYXRlLmxpbmsodGhpcyk7CkBAIC04MTEsNyArODExLDcgQEAgdm9pZCBKSVQ6OnByaXZhdGVD b21waWxlTWFpblBhc3MoKQogCiAgICAgICAgICAgICAvLyBOb3cgaGFuZGxlIHRoZSBpbW1lZGlh dGUgY2FzZXMgLSB1bmRlZmluZWQgJiBudWxsCiAgICAgICAgICAgICBpc0ltbWVkaWF0ZS5saW5r KHRoaXMpOwotICAgICAgICAgICAgYW5kMzIoSW1tMzIofkpTSW1tZWRpYXRlOjpFeHRlbmRlZFRh Z0JpdFVuZGVmaW5lZCksIFg4Njo6ZWF4KTsKKyAgICAgICAgICAgIGFuZFB0cihJbW0zMih+SlNJ bW1lZGlhdGU6OkV4dGVuZGVkVGFnQml0VW5kZWZpbmVkKSwgWDg2OjplYXgpOwogICAgICAgICAg ICAgYWRkSnVtcChqbmVQdHIoWDg2OjplYXgsIEltbVB0cihKU1ZhbHVlUHRyOjplbmNvZGUoanNO dWxsKCkpKSksIHRhcmdldCArIDIpOyAgICAgICAgICAgIAogCiAgICAgICAgICAgICB3YXNOb3RJ bW1lZGlhdGUubGluayh0aGlzKTsKQEAgLTExNDgsNyArMTE0OCw3IEBAIHZvaWQgSklUOjpwcml2 YXRlQ29tcGlsZU1haW5QYXNzKCkKIAogICAgICAgICAgICAgaXNJbW1lZGlhdGUubGluayh0aGlz KTsKIAotICAgICAgICAgICAgYW5kMzIoSW1tMzIofkpTSW1tZWRpYXRlOjpFeHRlbmRlZFRhZ0Jp dFVuZGVmaW5lZCksIFg4Njo6ZWF4KTsKKyAgICAgICAgICAgIGFuZFB0cihJbW0zMih+SlNJbW1l ZGlhdGU6OkV4dGVuZGVkVGFnQml0VW5kZWZpbmVkKSwgWDg2OjplYXgpOwogICAgICAgICAgICAg c2V0ZTMyKEltbTMyKEpTSW1tZWRpYXRlOjpGdWxsVGFnVHlwZU51bGwpLCBYODY6OmVheCk7CiAK ICAgICAgICAgICAgIHdhc05vdEltbWVkaWF0ZS5saW5rKHRoaXMpOwpAQCAtMTE3Miw3ICsxMTcy LDcgQEAgdm9pZCBKSVQ6OnByaXZhdGVDb21waWxlTWFpblBhc3MoKQogCiAgICAgICAgICAgICBp c0ltbWVkaWF0ZS5saW5rKHRoaXMpOwogCi0gICAgICAgICAgICBhbmQzMihJbW0zMih+SlNJbW1l ZGlhdGU6OkV4dGVuZGVkVGFnQml0VW5kZWZpbmVkKSwgWDg2OjplYXgpOworICAgICAgICAgICAg YW5kUHRyKEltbTMyKH5KU0ltbWVkaWF0ZTo6RXh0ZW5kZWRUYWdCaXRVbmRlZmluZWQpLCBYODY6 OmVheCk7CiAgICAgICAgICAgICBzZXRuZTMyKEltbTMyKEpTSW1tZWRpYXRlOjpGdWxsVGFnVHlw ZU51bGwpLCBYODY6OmVheCk7CiAKICAgICAgICAgICAgIHdhc05vdEltbWVkaWF0ZS5saW5rKHRo aXMpOwo=