235573 2022-01-25 04:23:27 -0800 [WTF] Make CRASH_WITH_INFO more useful when using GCC 2022-01-25 13:11:19 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 233949 1 aperez aperez aperez benjamin cdumez cmarcelo ews-watchlist fujii mcatanzaro mmaxfield webkit-bug-importer ysuzuki oldest_to_newest 1833661 0 aperez 2022-01-25 04:23:27 -0800 As per the comment in wtf/Assertions.h: // GCC does not allow ##__VA_ARGS__ unless GNU extensions are enabled (--std=gnu++NN instead of // --std=c++NN) and I think we don't want that, so we'll have a fallback path for GCC. Obviously // this will not actually succeed at getting the desired info into registers before crashing, but // it's just a fallback anyway. // // FIXME: When we enable C++20, we should replace ##__VA_ARGS__ with format __VA_OPT__(,) __VA_ARGS__ // so that we can remove this fallback. Nowadays we are passing -std=c++20 to the compiler, so we can use __VA_OPT__ and remove the FIXME. 1833667 1 449917 aperez 2022-01-25 04:29:04 -0800 Created attachment 449917 Patch 1833695 2 449917 mcatanzaro 2022-01-25 07:26:59 -0800 Comment on attachment 449917 Patch WinCairo and Windows EWS are red. Maybe we need to wait for Visual Studio 2022? 1833703 3 aperez 2022-01-25 07:48:03 -0800 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 449917 [details] > Patch > > WinCairo and Windows EWS are red. Maybe we need to wait for Visual Studio > 2022? Probably, but we can keep using ##__VA_ARGS__ with MSVC, and go with __VA_OPT__(,) __VA_ARGS__ for GCC/Clang. I'm going to update the patch to try that. 1833707 4 449930 aperez 2022-01-25 07:57:13 -0800 Created attachment 449930 Patch v2 1833826 5 ews-feeder 2022-01-25 13:10:50 -0800 Committed r288577 (246400@main): <https://commits.webkit.org/246400@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449930. 1833827 6 webkit-bug-importer 2022-01-25 13:11:19 -0800 <rdar://problem/88040547> 449917 2022-01-25 04:29:04 -0800 2022-01-25 08:27:36 -0800 Patch bug-235573-20220125142903.patch text/plain 2729 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJhNzhhYzEwZjU5NWE5NmIyMzczZDMw MTliYzZmMGM4NjYxYWJjODUuLjcwNDA4MWY1OGQ2ZmNkY2FmOWIzMDU5ZTQ1MWQzYzczZmVhYWI3 OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjItMDEtMjUgIEFkcmlhbiBQZXJleiBkZSBDYXN0 cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1RGXSBNYWtlIENSQVNIX1dJVEhf SU5GTyBtb3JlIHVzZWZ1bCB3aGVuIHVzaW5nIEdDQworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NTczCisKKyAgICAgICAgTWFrZSBDUkFTSF9XSVRI X0lORk8oKSBwcmludCBvdXQgdGhlIGFkZGl0aW9uYWwgaW5mb3JtYXRpb24gaW5zdGVhZCBvZiBz aWxlbnRseSBjcmFzaAorICAgICAgICB3aGVuIFdlYktpdCBpcyBjb21waWxlZCB3aXRoIEdDQy4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9B c3NlcnRpb25zLmg6IFVzZSBhIHNpbmdsZSBDUkFTSF9XSVRIX0lORk8oKSBkZWZpbml0aW9uIHdo aWNoIHVzZXMgX19WQV9PUFRfXygpCisgICAgICAgIHRvIG1ha2UgdGhlIHNhbWUgbWFjcm8gd29y ayBhbHNvIHdpdGggR0NDLgorICAgICAgICAoQ1JBU0hfV0lUSF9JTkZPKTogRGVsZXRlZCBHQ0Mg c3BlY2lmaWMgZGVmaW5pdGlvbi4KKyAgICAgICAgKENSQVNIX1dJVEhfU0VDVVJJVFlfSU1QTElD QVRJT05fQU5EX0lORk8pOiBEaXR0by4KKwogMjAyMi0wMS0yNCAgTWFyayBMYW0gIDxtYXJrLmxh bUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIFZlY3RvciBhbmQgRml4ZWRWZWN0b3I6OmZp bmRNYXRjaGluZyB0byBmaW5kSWYgdG8gbWF0Y2ggc3RsIG5hbWluZy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaApp bmRleCA1N2FlNjA2YmY3YWEyYzYxYzVkODRiMjhmMTdmZjFhNTAzYTYzNWY1Li5hZjQ1N2M1NTIx MzY4NTQ5Yjc1MzhiNDY4NTg3MGE4OWUxZGRhYjM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9Bc3NlcnRpb25zLmgKKysrIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCkBAIC03NjAs MzIgKzc2MCwxMSBAQCBpbmxpbmUgdm9pZCBjb21waWxlckZlbmNlRm9yQ3Jhc2goKQogI2lmbmRl ZiBDUkFTSF9XSVRIX0lORk8KIC8vIFRoaXMgaXMgdXNlZnVsIGlmIHlvdSBhcmUgZ29pbmcgdG8g c3R1ZmYgZGF0YSBpbnRvIHJlZ2lzdGVycyBiZWZvcmUgY3Jhc2hpbmcsIGxpa2UgdGhlCiAvLyBj cmFzaFdpdGhJbmZvIGZ1bmN0aW9ucyBiZWxvdy4KLSNpZiBDT01QSUxFUihDTEFORykgfHwgQ09N UElMRVIoTVNWQykKICNkZWZpbmUgQ1JBU0hfV0lUSF9JTkZPKC4uLikgZG8geyBcCiAgICAgICAg IFdURjo6aXNJbnRlZ3JhbE9yUG9pbnRlclR5cGUoX19WQV9BUkdTX18pOyBcCiAgICAgICAgIGNv bXBpbGVyRmVuY2VGb3JDcmFzaCgpOyBcCi0gICAgICAgIFdURkNyYXNoV2l0aEluZm8oX19MSU5F X18sIF9fRklMRV9fLCBXVEZfUFJFVFRZX0ZVTkNUSU9OLCBfX0NPVU5URVJfXywgIyNfX1ZBX0FS R1NfXyk7IFwKKyAgICAgICAgV1RGQ3Jhc2hXaXRoSW5mbyhfX0xJTkVfXywgX19GSUxFX18sIFdU Rl9QUkVUVFlfRlVOQ1RJT04sIF9fQ09VTlRFUl9fIF9fVkFfT1BUX18oLCkgX19WQV9BUkdTX18p OyBcCiAgICAgfSB3aGlsZSAoZmFsc2UpCi0jZWxzZQotLy8gR0NDIGRvZXMgbm90IGFsbG93ICMj X19WQV9BUkdTX18gdW5sZXNzIEdOVSBleHRlbnNpb25zIGFyZSBlbmFibGVkICgtLXN0ZD1nbnUr K05OIGluc3RlYWQgb2YKLS8vIC0tc3RkPWMrK05OKSBhbmQgSSB0aGluayB3ZSBkb24ndCB3YW50 IHRoYXQsIHNvIHdlJ2xsIGhhdmUgYSBmYWxsYmFjayBwYXRoIGZvciBHQ0MuIE9idmlvdXNseQot Ly8gdGhpcyB3aWxsIG5vdCBhY3R1YWxseSBzdWNjZWVkIGF0IGdldHRpbmcgdGhlIGRlc2lyZWQg aW5mbyBpbnRvIHJlZ2lzdGVycyBiZWZvcmUgY3Jhc2hpbmcsIGJ1dAotLy8gaXQncyBqdXN0IGEg ZmFsbGJhY2sgYW55d2F5LgotLy8KLS8vIEZJWE1FOiBXaGVuIHdlIGVuYWJsZSBDKysyMCwgd2Ug c2hvdWxkIHJlcGxhY2UgIyNfX1ZBX0FSR1NfXyB3aXRoIGZvcm1hdCBfX1ZBX09QVF9fKCwpIF9f VkFfQVJHU19fCi0vLyBzbyB0aGF0IHdlIGNhbiByZW1vdmUgdGhpcyBmYWxsYmFjay4KLWlubGlu ZSBOT19SRVRVUk5fRFVFX1RPX0NSQVNIIHZvaWQgQ1JBU0hfV0lUSF9JTkZPKC4uLikKLXsKLSAg ICBDUkFTSCgpOwotfQotCi0vLyBXZSBtdXN0IGRlZmluZSB0aGlzIGhlcmUgYmVjYXVzZSBDUkFT SF9XSVRIX0lORk8oKSBpcyBub3QgZGVmaW5lZCBhcyBhIG1hY3JvLgotLy8gRklYTUU6IFJlbW92 ZSB0aGlzIHdoZW4gdXBncmFkaW5nIHRvIEMrKzIwLgotaW5saW5lIE5PX1JFVFVSTl9EVUVfVE9f Q1JBU0ggdm9pZCBDUkFTSF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OX0FORF9JTkZPKC4uLikK LXsKLSAgICBDUkFTSCgpOwotfQotI2VuZGlmCiAjZW5kaWYgLy8gQ1JBU0hfV0lUSF9JTkZPCiAK ICNpZm5kZWYgQ1JBU0hfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTl9BTkRfSU5GTwo= 449930 2022-01-25 07:57:13 -0800 2022-01-25 13:10:52 -0800 Patch v2 bug-235573-20220125175712.patch text/plain 3085 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJhNzhhYzEwZjU5NWE5NmIyMzczZDMw MTliYzZmMGM4NjYxYWJjODUuLjdmZjM2NjFjNjZiYjE3NzM4MTZiZWZlZDE5NmJjNjI1NjViMWU0 M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjItMDEtMjUgIEFkcmlhbiBQZXJleiBkZSBDYXN0 cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1RGXSBNYWtlIENSQVNIX1dJVEhf SU5GTyBtb3JlIHVzZWZ1bCB3aGVuIHVzaW5nIEdDQworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NTczCisKKyAgICAgICAgTWFrZSBDUkFTSF9XSVRI X0lORk8oKSBwcmludCBvdXQgdGhlIGFkZGl0aW9uYWwgaW5mb3JtYXRpb24gaW5zdGVhZCBvZiBz aWxlbnRseSBjcmFzaAorICAgICAgICB3aGVuIFdlYktpdCBpcyBjb21waWxlZCB3aXRoIEdDQy4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9B c3NlcnRpb25zLmg6IEFkZCBhIHZhcmlhbnQgb2YgQ1JBU0hfV0lUSF9JTkZPKCkgd2hpY2ggdXNl cyBfX1ZBX09QVF9fIGZvcgorICAgICAgICBHQ0MgYW5kIENsYW5nOyBNU1ZDIGlzIGxlZnQgd2l0 aCB0aGUgZXhpc3RpbmcgdmVyc2lvbiBhcyB0aGUgdmVyc2lvbiBjdXJyZW50bHkgaW4KKyAgICAg ICAgdXNlIGlzIG5vdCBoYXBweSBhYm91dCBfX1ZBX09QVF9fLgorICAgICAgICAoQ1JBU0hfV0lU SF9JTkZPKTogRGVsZXRlZCBpbmxpbmUgZnVuY3Rpb24gZm9yIEdDQy4KKyAgICAgICAgKENSQVNI X1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT05fQU5EX0lORk8pOiBEaXR0by4KKwogMjAyMi0wMS0y NCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIFZlY3Rv ciBhbmQgRml4ZWRWZWN0b3I6OmZpbmRNYXRjaGluZyB0byBmaW5kSWYgdG8gbWF0Y2ggc3RsIG5h bWluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1NvdXJjZS9X VEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCA1N2FlNjA2YmY3YWEyYzYxYzVkODRiMjhmMTdmZjFh NTAzYTYzNWY1Li45N2ViN2ZhNGRlMzU2MThiZDZkN2FiMTc1MGIxNDIwMDg3MThjZjE5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKKysrIGIvU291cmNlL1dURi93dGYv QXNzZXJ0aW9ucy5oCkBAIC03NjAsMzEgKzc2MCwyMCBAQCBpbmxpbmUgdm9pZCBjb21waWxlckZl bmNlRm9yQ3Jhc2goKQogI2lmbmRlZiBDUkFTSF9XSVRIX0lORk8KIC8vIFRoaXMgaXMgdXNlZnVs IGlmIHlvdSBhcmUgZ29pbmcgdG8gc3R1ZmYgZGF0YSBpbnRvIHJlZ2lzdGVycyBiZWZvcmUgY3Jh c2hpbmcsIGxpa2UgdGhlCiAvLyBjcmFzaFdpdGhJbmZvIGZ1bmN0aW9ucyBiZWxvdy4KLSNpZiBD T01QSUxFUihDTEFORykgfHwgQ09NUElMRVIoTVNWQykKKyNpZiBDT01QSUxFUihNU1ZDKQorLy8g RklYTUU6IFJlLWNoZWNrIHdoZXRoZXIgTVNWQyAyMDIwIHN1cHBvcnRzIF9fVkFfT1BUX18gYW5k IHJlbW92ZSB0aGUgc3BlY2lhbAorLy8gICAgICAgIGNhc2luZyBvbmNlIG9sZGVyIHZlcnNpb25z IG9mIHRoZSBjb21waWxlciBhcmUgbm8gbG9uZ2VyIHN1cHBvcnRlZC4KICNkZWZpbmUgQ1JBU0hf V0lUSF9JTkZPKC4uLikgZG8geyBcCiAgICAgICAgIFdURjo6aXNJbnRlZ3JhbE9yUG9pbnRlclR5 cGUoX19WQV9BUkdTX18pOyBcCiAgICAgICAgIGNvbXBpbGVyRmVuY2VGb3JDcmFzaCgpOyBcCiAg ICAgICAgIFdURkNyYXNoV2l0aEluZm8oX19MSU5FX18sIF9fRklMRV9fLCBXVEZfUFJFVFRZX0ZV TkNUSU9OLCBfX0NPVU5URVJfXywgIyNfX1ZBX0FSR1NfXyk7IFwKICAgICB9IHdoaWxlIChmYWxz ZSkKICNlbHNlCi0vLyBHQ0MgZG9lcyBub3QgYWxsb3cgIyNfX1ZBX0FSR1NfXyB1bmxlc3MgR05V IGV4dGVuc2lvbnMgYXJlIGVuYWJsZWQgKC0tc3RkPWdudSsrTk4gaW5zdGVhZCBvZgotLy8gLS1z dGQ9YysrTk4pIGFuZCBJIHRoaW5rIHdlIGRvbid0IHdhbnQgdGhhdCwgc28gd2UnbGwgaGF2ZSBh IGZhbGxiYWNrIHBhdGggZm9yIEdDQy4gT2J2aW91c2x5Ci0vLyB0aGlzIHdpbGwgbm90IGFjdHVh bGx5IHN1Y2NlZWQgYXQgZ2V0dGluZyB0aGUgZGVzaXJlZCBpbmZvIGludG8gcmVnaXN0ZXJzIGJl Zm9yZSBjcmFzaGluZywgYnV0Ci0vLyBpdCdzIGp1c3QgYSBmYWxsYmFjayBhbnl3YXkuCi0vLwot Ly8gRklYTUU6IFdoZW4gd2UgZW5hYmxlIEMrKzIwLCB3ZSBzaG91bGQgcmVwbGFjZSAjI19fVkFf QVJHU19fIHdpdGggZm9ybWF0IF9fVkFfT1BUX18oLCkgX19WQV9BUkdTX18KLS8vIHNvIHRoYXQg d2UgY2FuIHJlbW92ZSB0aGlzIGZhbGxiYWNrLgotaW5saW5lIE5PX1JFVFVSTl9EVUVfVE9fQ1JB U0ggdm9pZCBDUkFTSF9XSVRIX0lORk8oLi4uKQotewotICAgIENSQVNIKCk7Ci19Ci0KLS8vIFdl IG11c3QgZGVmaW5lIHRoaXMgaGVyZSBiZWNhdXNlIENSQVNIX1dJVEhfSU5GTygpIGlzIG5vdCBk ZWZpbmVkIGFzIGEgbWFjcm8uCi0vLyBGSVhNRTogUmVtb3ZlIHRoaXMgd2hlbiB1cGdyYWRpbmcg dG8gQysrMjAuCi1pbmxpbmUgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIENSQVNIX1dJVEhf U0VDVVJJVFlfSU1QTElDQVRJT05fQU5EX0lORk8oLi4uKQotewotICAgIENSQVNIKCk7Ci19Cisj ZGVmaW5lIENSQVNIX1dJVEhfSU5GTyguLi4pIGRvIHsgXAorICAgICAgICBXVEY6OmlzSW50ZWdy YWxPclBvaW50ZXJUeXBlKF9fVkFfQVJHU19fKTsgXAorICAgICAgICBjb21waWxlckZlbmNlRm9y Q3Jhc2goKTsgXAorICAgICAgICBXVEZDcmFzaFdpdGhJbmZvKF9fTElORV9fLCBfX0ZJTEVfXywg V1RGX1BSRVRUWV9GVU5DVElPTiwgX19DT1VOVEVSX18gX19WQV9PUFRfXygsKSBfX1ZBX0FSR1Nf Xyk7IFwKKyAgICB9IHdoaWxlIChmYWxzZSkKICNlbmRpZgogI2VuZGlmIC8vIENSQVNIX1dJVEhf SU5GTwogCg==