235562 2022-01-25 02:06:11 -0800 Constructing untaken LOG(Category, ...) arguments slow debug binaries down 2023-08-29 16:15:15 -0700 1 1 1 Unclassified WebKit Web Template Framework Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229664 https://bugs.webkit.org/show_bug.cgi?id=260884 InRadar P2 Normal --- 1 kkinnunen kkinnunen benjamin cdumez cmarcelo ews-watchlist simon.fraser webkit-bug-importer oldest_to_newest 1833639 0 kkinnunen 2022-01-25 02:06:11 -0800 Constructing untaken LOG(Category, ...) arguments slow debug binaries down Leads to case-by-case hacking around the problem, which leads to bugs (Why is this LOG(IPCMessages,..) not printed? Should be consistent with RELEASE_LOG(Category, ...) 1833640 1 449905 kkinnunen 2022-01-25 02:18:10 -0800 Created attachment 449905 Patch 1835870 2 webkit-bug-importer 2022-02-01 02:07:15 -0800 <rdar://problem/88318352> 1842145 3 ews-feeder 2022-02-15 22:54:37 -0800 Committed r289879 (247317@main): <https://commits.webkit.org/247317@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449905. 449905 2022-01-25 02:18:10 -0800 2022-02-15 22:54:39 -0800 Patch bug-235562-20220125121809.patch text/plain 3337 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRlZWVkOGYxMWQ3MTk3NjJmZTg3OTM2 YzNkOTFhYTQyZmUyMDIxMWYuLjM2YjNlMTRhOTQ3OWYyNDZlYzZkNjk1YjE5YzZjODQ0N2FjNDI1 NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjItMDEtMjUgIEtpbW1vIEtpbm51bmVuICA8a2tp bm51bmVuQGFwcGxlLmNvbT4KKworICAgICAgICBDb25zdHJ1Y3RpbmcgdW50YWtlbiBMT0coQ2hh bm5lbCwgLi4uKSBhcmd1bWVudHMgc2xvdyBkZWJ1ZyBiaW5hcmllcyBkb3duCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU1NjIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVlZCB1cCBkZWJ1ZyBidWls ZCBiaW5hcnkgTE9HKENoYW5uZWwsIC4uLikgYnkgY2hlY2tpbmcgdGhlCisgICAgICAgIGNoYW5u ZWwgKGFuZCBsZXZlbCkgYmVmb3JlIGNvbnN0cnVjdGluZyB0aGUgbG9nIGFyZ3VtZW50cy4KKyAg ICAgICAgVGhpcyBpcyBjb25zaXN0ZW50IHdpdGggaG93IFJFTEVBU0VfTE9HKCkgd29ya3MuCisK KyAgICAgICAgSWYgdGhlIGFyZ3VtZW50cyBhcmUgc2xvdyB0byBjcmVhdGUsIGNhbGwgc2l0ZXMg ZW5kIHVwIGltcGxlbWVudGluZworICAgICAgICB0aGlzIGF0IHRoZSBjYWxsIHNpdGUgYW5kIHJp c2sgc3VidGxlIGJ1Z3Mgd2hpY2ggbWFrZSBleGlzdGluZyBsb2dnaW5nIHVucmVsaWFibGUuCisK KyAgICAgICAgRml4ZXMgYSBidWcgd2l0aCBMT0dfV0lUSF9TVFJFQU0gd2hlcmUgQ2hhbm5lbFN0 YXRlOjpPbldpdGhBY2N1bXVsYXRpb24gY2hhbm5lbHMgd291bGQgbm90IGxvZy4KKworICAgICAg ICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisKIDIwMjItMDEtMjEgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBSZWxheCBEYXRlLnBhcnNlIHJlcXVpcmVt ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmggYi9Tb3VyY2UvV1RG L3d0Zi9Bc3NlcnRpb25zLmgKaW5kZXggYmYxMWZjMTcwODM1ODhhOTE4YWJkZmVlNGRkODA5MGZk ZjI0YjdiMi4uNWI3NjJlNzUzYzJhNzNiOTZjMWU2MmVhYjhjYTJmMTMxZjY4MDI0NSAxMDA2NDQK LS0tIGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Fz c2VydGlvbnMuaApAQCAtNDk0LDcgKzQ5NCwxMCBAQCBjb25zdGV4cHIgYm9vbCBhc3NlcnRpb25G YWlsdXJlRHVlVG9VbnJlYWNoYWJsZUNvZGUgPSBmYWxzZTsKICNpZiBMT0dfRElTQUJMRUQKICNk ZWZpbmUgTE9HKGNoYW5uZWwsIC4uLikgKCh2b2lkKTApCiAjZWxzZQotI2RlZmluZSBMT0coY2hh bm5lbCwgLi4uKSBXVEZMb2coJkxPR19DSEFOTkVMKGNoYW5uZWwpLCBfX1ZBX0FSR1NfXykKKyNk ZWZpbmUgTE9HKGNoYW5uZWwsIC4uLikgZG8geyBcCisgICAgICAgIGlmIChMT0dfQ0hBTk5FTChj aGFubmVsKS5zdGF0ZSAhPSBsb2dDaGFubmVsU3RhdGVPZmYpIFwKKyAgICAgICAgICAgIFdURkxv ZygmTE9HX0NIQU5ORUwoY2hhbm5lbCksIF9fVkFfQVJHU19fKTsgXAorICAgIH0gd2hpbGUgKDAp CiAjZW5kaWYKIAogLyogTE9HX1ZFUkJPU0UgKi8KQEAgLTUwMiw3ICs1MDUsMTAgQEAgY29uc3Rl eHByIGJvb2wgYXNzZXJ0aW9uRmFpbHVyZUR1ZVRvVW5yZWFjaGFibGVDb2RlID0gZmFsc2U7CiAj aWYgTE9HX0RJU0FCTEVECiAjZGVmaW5lIExPR19WRVJCT1NFKGNoYW5uZWwsIC4uLikgKCh2b2lk KTApCiAjZWxzZQotI2RlZmluZSBMT0dfVkVSQk9TRShjaGFubmVsLCAuLi4pIFdURkxvZ1ZlcmJv c2UoX19GSUxFX18sIF9fTElORV9fLCBXVEZfUFJFVFRZX0ZVTkNUSU9OLCAmTE9HX0NIQU5ORUwo Y2hhbm5lbCksIF9fVkFfQVJHU19fKQorI2RlZmluZSBMT0dfVkVSQk9TRShjaGFubmVsLCAuLi4p IGRvIHsgXAorICAgICAgICBpZiAoTE9HX0NIQU5ORUwoY2hhbm5lbCkuc3RhdGUgIT0gbG9nQ2hh bm5lbFN0YXRlT2ZmKSBcCisgICAgICAgICAgICBXVEZMb2dWZXJib3NlKF9fRklMRV9fLCBfX0xJ TkVfXywgV1RGX1BSRVRUWV9GVU5DVElPTiwgJkxPR19DSEFOTkVMKGNoYW5uZWwpLCBfX1ZBX0FS R1NfXyk7IFwKKyAgICB9IHdoaWxlICgwKQogI2VuZGlmCiAKIC8qIExPR19XSVRIX0xFVkVMICov CkBAIC01MTAsNyArNTE2LDEwIEBAIGNvbnN0ZXhwciBib29sIGFzc2VydGlvbkZhaWx1cmVEdWVU b1VucmVhY2hhYmxlQ29kZSA9IGZhbHNlOwogI2lmIExPR19ESVNBQkxFRAogI2RlZmluZSBMT0df V0lUSF9MRVZFTChjaGFubmVsLCBsZXZlbCwgLi4uKSAoKHZvaWQpMCkKICNlbHNlCi0jZGVmaW5l IExPR19XSVRIX0xFVkVMKGNoYW5uZWwsIGxldmVsLCAuLi4pIFdURkxvZ1dpdGhMZXZlbCgmTE9H X0NIQU5ORUwoY2hhbm5lbCksIGxldmVsLCBfX1ZBX0FSR1NfXykKKyNkZWZpbmUgTE9HX1dJVEhf TEVWRUwoY2hhbm5lbCwgbGV2ZWwsIC4uLikgZG8geyBcCisgICAgICAgIGlmICAoTE9HX0NIQU5O RUwoY2hhbm5lbCkuc3RhdGUgIT0gbG9nQ2hhbm5lbFN0YXRlT2ZmICYmIGNoYW5uZWwtPmxldmVs ID49IChsZXZlbCkpIFwKKyAgICAgICAgICAgIFdURkxvZ1dpdGhMZXZlbCgmTE9HX0NIQU5ORUwo Y2hhbm5lbCksIGxldmVsLCBfX1ZBX0FSR1NfXyk7IFwKKyAgICB9IHdoaWxlICgwKQogI2VuZGlm CiAKIC8qIExPR19XSVRIX1NUUkVBTSAqLwpAQCAtNTE5LDcgKzUyOCw3IEBAIGNvbnN0ZXhwciBi b29sIGFzc2VydGlvbkZhaWx1cmVEdWVUb1VucmVhY2hhYmxlQ29kZSA9IGZhbHNlOwogI2RlZmlu ZSBMT0dfV0lUSF9TVFJFQU0oY2hhbm5lbCwgY29tbWFuZHMpICgodm9pZCkwKQogI2Vsc2UKICNk ZWZpbmUgTE9HX1dJVEhfU1RSRUFNKGNoYW5uZWwsIGNvbW1hbmRzKSBkbyB7IFwKLSAgICAgICAg aWYgKExPR19DSEFOTkVMKGNoYW5uZWwpLnN0YXRlID09IFdURkxvZ0NoYW5uZWxTdGF0ZTo6T24p IHsgXAorICAgICAgICBpZiAoTE9HX0NIQU5ORUwoY2hhbm5lbCkuc3RhdGUgIT0gbG9nQ2hhbm5l bFN0YXRlT2ZmKSB7IFwKICAgICAgICAgICAgIFdURjo6VGV4dFN0cmVhbSBzdHJlYW0oV1RGOjpU ZXh0U3RyZWFtOjpMaW5lTW9kZTo6U2luZ2xlTGluZSk7IFwKICAgICAgICAgICAgIGNvbW1hbmRz OyBcCiAgICAgICAgICAgICBXVEZMb2coJkxPR19DSEFOTkVMKGNoYW5uZWwpLCAiJXMiLCBzdHJl YW0ucmVsZWFzZSgpLnV0ZjgoKS5kYXRhKCkpOyBcCg==