235536 2022-01-24 13:40:15 -0800 Remove VM::stringCache 2022-01-24 21:15:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam darin ews-watchlist keith_miller mark.lam msaboff saam sam tzagallo webkit-bug-importer oldest_to_newest 1833453 0 heycam 2022-01-24 13:40:15 -0800 We consult VM::stringCache when creating a JSString, but since bug 142115 we never insert anything into it. Removing this results in almost-significant improvements in the VueJS, Vanilla-ES2015, and jQuery sub-tests of Speedometer 2 (of 0.5-2%, 0.03 <= p <= 0.05), and an almost significant 0.2% improvement in the overall score (p = 0.06). 1833455 1 449849 heycam 2022-01-24 13:42:16 -0800 Created attachment 449849 Patch 1833558 2 449849 darin 2022-01-24 16:59:02 -0800 Comment on attachment 449849 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449849&action=review > Source/JavaScriptCore/ChangeLog:9 > + We consult VM::stringCache when creating a JSString, but since > + bug 142115 we never insert anything into it. 6 years, wow I wonder if the patch making it work again would make things even faster. I suppose it comes with the risk of memory use regression. 1833598 3 ews-feeder 2022-01-24 21:14:26 -0800 Committed r288537 (246369@main): <https://commits.webkit.org/246369@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449849. 1833599 4 webkit-bug-importer 2022-01-24 21:15:16 -0800 <rdar://problem/88006205> 449849 2022-01-24 13:42:16 -0800 2022-01-24 21:14:28 -0800 Patch bug-235536-20220125084215.patch text/plain 3033 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi YTE4YTgzYTYwMzg1Zjk5YjNkOTNmODdlNzJiZDYzYjYxOTNjZTYyLi4yOTQwN2RmN2ZjMmQyZTFi OTQ3N2M1M2FlYWNhYzY0MTc5ZmFkM2NmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAyMi0wMS0yNCAgQ2FtZXJvbiBNY0Nvcm1hY2sgIDxoZXljYW1AYXBwbGUu Y29tPgorCisgICAgICAgIFJlbW92ZSBWTTo6c3RyaW5nQ2FjaGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTUzNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGNvbnN1bHQgVk06OnN0cmluZ0NhY2hl IHdoZW4gY3JlYXRpbmcgYSBKU1N0cmluZywgYnV0IHNpbmNlCisgICAgICAgIGJ1ZyAxNDIxMTUg d2UgbmV2ZXIgaW5zZXJ0IGFueXRoaW5nIGludG8gaXQuCisKKyAgICAgICAgUmVtb3ZpbmcgdGhp cyByZXN1bHRzIGluIGFsbW9zdC1zaWduaWZpY2FudCBpbXByb3ZlbWVudHMgaW4gdGhlIFZ1ZUpT LAorICAgICAgICBWYW5pbGxhLUVTMjAxNSwgYW5kIGpRdWVyeSBzdWItdGVzdHMgb2YgU3BlZWRv bWV0ZXIgMiAob2YgMC41LTIlLAorICAgICAgICAwLjAzIDw9IHAgPD0gMC4wNSksIGFuZCBhbiBh bG1vc3Qgc2lnbmlmaWNhbnQgMC4yJSBpbXByb3ZlbWVudCBpbiB0aGUKKyAgICAgICAgb3ZlcmFs bCBzY29yZSAocCA9IDAuMDYpLgorCisgICAgICAgICogcnVudGltZS9KU1N0cmluZy5jcHA6Cisg ICAgICAgIChKU0M6OmpzU3RyaW5nV2l0aENhY2hlU2xvd0Nhc2UpOgorICAgICAgICAqIHJ1bnRp bWUvVk0uY3BwOgorICAgICAgICAoSlNDOjpWTTo6Vk0pOgorICAgICAgICAqIHJ1bnRpbWUvVk0u aDoKKwogMjAyMi0wMS0yMSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyODg0MDAuCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5jcHAKaW5kZXggMTJhMjE1ZjdhMjhmNzAxNThlYzg5 NDNmMzU5MDI2YmQwMDNkMWQ4Yy4uZGM1ZTY5ZTY3N2Y5NjBlMzg5M2Y1M2E1ZGQzZTc1YmQyODM0 MjAzOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmNwcApAQCAt NDM2LDkgKzQzNiw2IEBAIGJvb2wgSlNTdHJpbmc6OmdldFN0cmluZ1Byb3BlcnR5RGVzY3JpcHRv cihKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBQcm9wZXJ0CiAKIEpTU3RyaW5nKiBqc1N0 cmluZ1dpdGhDYWNoZVNsb3dDYXNlKFZNJiB2bSwgU3RyaW5nSW1wbCYgc3RyaW5nSW1wbCkKIHsK LSAgICBpZiAoSlNTdHJpbmcqIHN0cmluZyA9IHZtLnN0cmluZ0NhY2hlLmdldCgmc3RyaW5nSW1w bCkpCi0gICAgICAgIHJldHVybiBzdHJpbmc7Ci0KICAgICBKU1N0cmluZyogc3RyaW5nID0ganNT dHJpbmcodm0sIFN0cmluZyhzdHJpbmdJbXBsKSk7CiAgICAgdm0ubGFzdENhY2hlZFN0cmluZy5z ZXQodm0sIHN0cmluZyk7CiAgICAgcmV0dXJuIHN0cmluZzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1ZNLmNwcAppbmRleCBmZjFhYWY3M2E0OWQzZjcxMWY1NDJkNjVmMGQxZGYzNzYxY2MyMGIx Li5lZWY1MTVkOTAzYmRmNjkyYmFiYjcyNmMyY2Y2MGJiNWJjNmUxOGRjIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvVk0uY3BwCkBAIC0yMTgsNyArMjE4LDYgQEAgVk06OlZNKFZNVHlwZSB2 bVR5cGUsIEhlYXBUeXBlIGhlYXBUeXBlLCBXVEY6OlJ1bkxvb3AqIHJ1bkxvb3AsIGJvb2wqIHN1 Y2Nlc3MpCiAgICAgLCBwcm9wZXJ0eU5hbWVzKG51bGxwdHIpCiAgICAgLCBlbXB0eUxpc3QobmV3 IEFyZ0xpc3QpCiAgICAgLCBtYWNoaW5lQ29kZUJ5dGVzUGVyQnl0ZWNvZGVXb3JkRm9yQmFzZWxp bmVKSVQobWFrZVVuaXF1ZTxTaW1wbGVTdGF0cz4oKSkKLSAgICAsIHN0cmluZ0NhY2hlKCp0aGlz KQogICAgICwgc3ltYm9sSW1wbFRvU3ltYm9sTWFwKCp0aGlzKQogICAgICwgc3RydWN0dXJlQ2Fj aGUoKnRoaXMpCiAgICAgLCBpbnRlcnByZXRlcihudWxscHRyKQpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1ZNLmgKaW5kZXggYTFiMGIzODUzOGJmMjA4MzIwNzlkZmM5NDc0ZmVhOTU1M2YzMGYwYS4u NGJiYmM0ZDc3YWJlNzcwNzY1YjMzYWIwMTg3YmViNmQ5NDM1MTJhMiAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9WTS5oCkBAIC01ODUsNyArNTg1LDYgQEAgcHVibGljOgogICAgIFNtYWxsU3Ry aW5ncyBzbWFsbFN0cmluZ3M7CiAgICAgTnVtZXJpY1N0cmluZ3MgbnVtZXJpY1N0cmluZ3M7CiAg ICAgc3RkOjp1bmlxdWVfcHRyPFNpbXBsZVN0YXRzPiBtYWNoaW5lQ29kZUJ5dGVzUGVyQnl0ZWNv ZGVXb3JkRm9yQmFzZWxpbmVKSVQ7Ci0gICAgV2Vha0dDTWFwPFN0cmluZ0ltcGwqLCBKU1N0cmlu ZywgUHRySGFzaDxTdHJpbmdJbXBsKj4+IHN0cmluZ0NhY2hlOwogICAgIFN0cm9uZzxKU1N0cmlu Zz4gbGFzdENhY2hlZFN0cmluZzsKICAgICBKU09OQXRvbVN0cmluZ0NhY2hlIGpzb25BdG9tU3Ry aW5nQ2FjaGU7CiAK