235535 2022-01-24 12:39:39 -0800 Network Cache: do not use disk cache for Fetch media loads 2024-02-12 02:03:22 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=144259 https://bugs.webkit.org/show_bug.cgi?id=157405 https://bugs.webkit.org/show_bug.cgi?id=170676 https://bugs.webkit.org/show_bug.cgi?id=187544 https://bugs.webkit.org/show_bug.cgi?id=229813 InRadar P2 Normal --- 1 olivier.blin webkit-unassigned achristensen cdumez cgarcia darin eocanha ews-watchlist jer.noble koivisto loic.yhuel mcatanzaro pnormand webkit-bug-importer youennf zdobersek oldest_to_newest 1833441 0 olivier.blin 2022-01-24 12:39:39 -0800 In r183467, checks have been added to avoid putting media resources from XHR requests in the disk cache, since they are likely specific to MSE streaming. But this does not check for Fetch requests, which can also be used for MSE streaming. This has been found by using Shaka Player on a low-end device. Playing high quality MSE content was pushing to the disk cache faster than the device could handle. Media data was accumulating in the the background IOQueue thread, and the NetworkProcess memory was constantly increasing. Recently, similar checks have been added for the MSE IPC overhead in r282003. Loïc found a few differences: - it supports ResourceLoadInfo::Type::XMLHTTPRequest and ResourceLoadInfo::Type::Fetch, but not ResourceLoadInfo::Type::Media - it has a different definition of isMediaMIMEType, which adds application/octet-stream to the audio/* and video/* we have in makeStoreDecision() Should we attempt to factorize these checks? 1833442 1 449846 olivier.blin 2022-01-24 12:43:28 -0800 Created attachment 449846 Patch 1833619 2 449846 darin 2022-01-24 23:00:28 -0800 Comment on attachment 449846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449846&action=review Looks good > Source/WebKit/ChangeLog:23 > + No new tests (OOPS!). Can’t land a patch that still has this in it. Need to remove this line, and replace it with an explanation of why we are landing this patch without any tests. Might want to look back at the original XHR change to see how they wrote the test. 1833620 3 darin 2022-01-24 23:00:46 -0800 (In reply to Olivier Blin from comment #0) > Should we attempt to factorize these checks? Yes. 1835639 4 webkit-bug-importer 2022-01-31 12:40:18 -0800 <rdar://problem/88288422> 2012658 5 olivier.blin 2024-02-12 02:03:22 -0800 Pull request: https://github.com/WebKit/WebKit/pull/24243 449846 2022-01-24 12:43:28 -0800 2022-01-24 23:00:28 -0800 Patch bug-235535-20220124214326.patch text/plain 2556 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY4NDE2MDM1MTFmMmM1NjY5 MGVhYzAwMDE1OGY3NGZmMjIwY2ZmMWEuLjA2YWFiMjM5MmExNjQ2MDI5Njk5ZTVjNDkzOTE0NjMx Y2I1MzQ1OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMjItMDEtMjQgIE9saXZpZXIg QmxpbiAgPG9saXZpZXIuYmxpbkBzb2Z0YXRob21lLmNvbT4KKworICAgICAgICBOZXR3b3JrIENh Y2hlOiBkbyBub3QgdXNlIGRpc2sgY2FjaGUgZm9yIEZldGNoIG1lZGlhIGxvYWRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU1MzUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMTgzNDY3LCBjaGVj a3MgaGF2ZSBiZWVuIGFkZGVkIHRvIGF2b2lkIHB1dHRpbmcgbWVkaWEKKyAgICAgICAgcmVzb3Vy Y2VzIGZyb20gWEhSIHJlcXVlc3RzIGluIHRoZSBkaXNrIGNhY2hlLCBzaW5jZSB0aGV5IGFyZQor ICAgICAgICBsaWtlbHkgc3BlY2lmaWMgdG8gTVNFIHN0cmVhbWluZy4KKworICAgICAgICBCdXQg dGhpcyBkaWQgbm90IGNoZWNrIGZvciBGZXRjaCByZXF1ZXN0cywgd2hpY2ggY2FuIGFsc28gYmUg dXNlZAorICAgICAgICBmb3IgTVNFIHN0cmVhbWluZy4KKworICAgICAgICBUaGlzIGhhcyBiZWVu IGZvdW5kIGJ5IHVzaW5nIFNoYWthIFBsYXllciBvbiBhIGxvdy1lbmQgZGV2aWNlLgorICAgICAg ICBQbGF5aW5nIGhpZ2ggcXVhbGl0eSBNU0UgY29udGVudCB3YXMgcHVzaGluZyB0byB0aGUgZGlz ayBjYWNoZQorICAgICAgICBmYXN0ZXIgdGhhbiB0aGUgZGV2aWNlIGNvdWxkIGhhbmRsZS4KKyAg ICAgICAgTWVkaWEgZGF0YSB3YXMgYWNjdW11bGF0aW5nIGluIHRoZSB0aGUgYmFja2dyb3VuZCBJ T1F1ZXVlIHRocmVhZCwKKyAgICAgICAgYW5kIHRoZSBOZXR3b3JrUHJvY2VzcyBtZW1vcnkgd2Fz IGNvbnN0YW50bHkgaW5jcmVhc2luZy4KKworICAgICAgICBTaW1pbGFyIGNoZWNrcyBoYXZlIGJl ZW4gYWRkZWQgZm9yIHRoZSBNU0UgSVBDIG92ZXJoZWFkIGluIHIyODIwMDMuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9O ZXR3b3JrQ2FjaGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6Om1ha2VTdG9y ZURlY2lzaW9uKToKKwogMjAyMi0wMS0yMSAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNv bT4KIAogICAgICAgICBEaXNhYmxlIENGVVJMQ2FjaGUgaW4gV2ViS2l0MgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwIGIvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCmluZGV4IGRk MzA1YWYyOTc2NjFlNDc2YzQ5Njc3ZGY1NzIxZWZkMWVjOTMyZjQuLmQyNDg4MmY1NGY3MzU3NmRh MmE1YjNmZGNiZmJlYjViMjJkNjcwYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHAKQEAgLTMwNiw3ICszMDYsNyBAQCBzdGF0 aWMgU3RvcmVEZWNpc2lvbiBtYWtlU3RvcmVEZWNpc2lvbihjb25zdCBXZWJDb3JlOjpSZXNvdXJj ZVJlcXVlc3QmIG9yaWdpbmFsUgogICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgYWxzbyBtYWtlIHN1 cmUgbWFrZSB0aGUgTVNFIHBhdGhzIGFyZSBjb3B5LWZyZWUgc28gd2UgY2FuIHVzZSBtYXBwZWQg YnVmZmVycyBmcm9tIGRpc2sgZWZmZWN0aXZlbHkuCiAgICAgYXV0byByZXF1ZXN0ZXIgPSBvcmln aW5hbFJlcXVlc3QucmVxdWVzdGVyKCk7CiAgICAgYm9vbCBpc0RlZmluaXRlbHlTdHJlYW1pbmdN ZWRpYSA9IHJlcXVlc3RlciA9PSBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q6OlJlcXVlc3Rlcjo6 TWVkaWE7Ci0gICAgYm9vbCBpc0xpa2VseVN0cmVhbWluZ01lZGlhID0gcmVxdWVzdGVyID09IFdl YkNvcmU6OlJlc291cmNlUmVxdWVzdDo6UmVxdWVzdGVyOjpYSFIgJiYgaXNNZWRpYU1JTUVUeXBl KHJlc3BvbnNlLm1pbWVUeXBlKCkpOworICAgIGJvb2wgaXNMaWtlbHlTdHJlYW1pbmdNZWRpYSA9 IChyZXF1ZXN0ZXIgPT0gV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpSZXF1ZXN0ZXI6OlhIUiB8 fCByZXF1ZXN0ZXIgPT0gV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpSZXF1ZXN0ZXI6OkZldGNo KSAmJiBpc01lZGlhTUlNRVR5cGUocmVzcG9uc2UubWltZVR5cGUoKSk7CiAgICAgaWYgKGlzTGlr ZWx5U3RyZWFtaW5nTWVkaWEgfHwgaXNEZWZpbml0ZWx5U3RyZWFtaW5nTWVkaWEpCiAgICAgICAg IHJldHVybiBTdG9yZURlY2lzaW9uOjpOb0R1ZVRvU3RyZWFtaW5nTWVkaWE7CiAK