235527 2022-01-24 10:35:14 -0800 Missing EnabledBySetting=WebXREnabled where Conditional=WEBXR exists 2022-01-25 08:49:11 -0800 1 1 1 Unclassified WebKit WebXR WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235531 InRadar P2 Normal --- 1 gsnedders gsnedders cdumez changseok darin dino esprehn+autocc ews-watchlist gyuyoung.kim hi kondapallykalyan pangle webkit-bug-importer oldest_to_newest 1833381 0 gsnedders 2022-01-24 10:35:14 -0800 There's a few places we're missing this, patch forthcoming. <rdar://87976757> 1833386 1 449829 gsnedders 2022-01-24 10:45:27 -0800 Created attachment 449829 Patch 1833393 2 449829 darin 2022-01-24 11:07:26 -0800 Comment on attachment 449829 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449829&action=review > Source/WebCore/Modules/webxr/XRFrameRequestCallback.idl:31 > + EnabledBySetting=WebXREnabled, > Conditional=WEBXR Normally we like to keep these alphabetical. 1833404 3 449832 gsnedders 2022-01-24 11:20:34 -0800 Created attachment 449832 Patch 1833726 4 ews-feeder 2022-01-25 08:49:06 -0800 Committed r288553 (246385@main): <https://commits.webkit.org/246385@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449832. 449829 2022-01-24 10:45:27 -0800 2022-01-24 11:20:30 -0800 Patch bug-235527-20220124184525.patch text/plain 2909 gsnedders U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ0Mjk4OGQzNjMwZWIx YmUyYzYyOWM3M2Y0YWIxOWIwZGVmYmE5NC4uODc0NDAwZTBkZjY1NDNiNTUzMjg3NzQ0NmU4OWJh YzZiYTk1Yzg2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAxLTI0ICBTYW0g U25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAgICAgICAgTWlzc2luZyBFbmFibGVk QnlTZXR0aW5nPVdlYlhSRW5hYmxlZCB3aGVyZSBDb25kaXRpb25hbD1XRUJYUiBleGlzdHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTUyNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hbnVhbGx5IHRl c3RlZC4KKworICAgICAgICAqIE1vZHVsZXMvd2VieHIvWFJGcmFtZVJlcXVlc3RDYWxsYmFjay5p ZGw6CisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xDb250ZXh0QXR0cmlidXRlcy5pZGw6Cisg ICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5pZGw6CisKIDIw MjItMDEtMjQgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAog ICAgICAgICBGaXggbm9uLXVuaWZpZWQgYnVpbGQgYWZ0ZXIgcjI4ODQzMgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9YUkZyYW1lUmVxdWVzdENhbGxiYWNrLmlkbCBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VieHIvWFJGcmFtZVJlcXVlc3RDYWxsYmFjay5pZGwK aW5kZXggNmEyNmRjNGZkN2QwMGZjZmU4MTU1ZjA1MjZhMGJkMjJlNzc0NzAxNC4uMTA2YTVkNTdj YWVlMTk1OWFjYTgwMjM3MzE4YjI3NDY0YmRkNWFiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJ4ci9YUkZyYW1lUmVxdWVzdENhbGxiYWNrLmlkbAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1hSRnJhbWVSZXF1ZXN0Q2FsbGJhY2suaWRsCkBAIC0yNyw1 ICsyNyw2IEBAIHR5cGVkZWYgZG91YmxlIERPTUhpZ2hSZXNUaW1lU3RhbXA7CiAKIC8vIGh0dHBz Oi8vaW1tZXJzaXZlLXdlYi5naXRodWIuaW8vd2VieHIvI2NhbGxiYWNrZGVmLXhyZnJhbWVyZXF1 ZXN0Y2FsbGJhY2sKIFsKKyAgICBFbmFibGVkQnlTZXR0aW5nPVdlYlhSRW5hYmxlZCwKICAgICBD b25kaXRpb25hbD1XRUJYUgogXSBjYWxsYmFjayBYUkZyYW1lUmVxdWVzdENhbGxiYWNrID0gdW5k ZWZpbmVkIChET01IaWdoUmVzVGltZVN0YW1wIHRpbWUsIFdlYlhSRnJhbWUgZnJhbWUpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xDb250ZXh0QXR0cmlidXRl cy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTENvbnRleHRBdHRyaWJ1dGVz LmlkbAppbmRleCAzOTAyYmFlYmZkZjNmOGRiMmMxZWU3ODY1MDY3NTE0NGZiOWY5MGViLi5jNTIx ODFjY2EzNjNhNjIzODg2NGViNWIzM2UwMDAwYTc3N2JkNDUzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTENvbnRleHRBdHRyaWJ1dGVzLmlkbAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTENvbnRleHRBdHRyaWJ1dGVzLmlkbApAQCAtNDUs NSArNDUsNSBAQCBlbnVtIFdlYkdMUG93ZXJQcmVmZXJlbmNlIHsKICAgICBHTGJvb2xlYW4gcHJl c2VydmVEcmF3aW5nQnVmZmVyID0gZmFsc2U7CiAgICAgV2ViR0xQb3dlclByZWZlcmVuY2UgcG93 ZXJQcmVmZXJlbmNlID0gImRlZmF1bHQiOwogICAgIEdMYm9vbGVhbiBmYWlsSWZNYWpvclBlcmZv cm1hbmNlQ2F2ZWF0ID0gZmFsc2U7Ci0gICAgW0NvbmRpdGlvbmFsPVdFQlhSXSBib29sZWFuIHhy Q29tcGF0aWJsZSA9IGZhbHNlOworICAgIFtDb25kaXRpb25hbD1XRUJYUiwgRW5hYmxlZEJ5U2V0 dGluZz1XZWJYUkVuYWJsZWRdIGJvb2xlYW4geHJDb21wYXRpYmxlID0gZmFsc2U7CiB9OwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0 QmFzZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRl eHRCYXNlLmlkbAppbmRleCBiZmU0ZjQyMmM1Y2M4MjJhYjU3ZmU4N2I3ZDIyMzUyYjNmY2RiMmFj Li5kZmU4M2FhYjhjOGFmMWMxMTRhNjE4MzBhYTliYTAxMGNhMTlhMTE3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNl LmlkbApAQCAtNjA0LDcgKzYwNCw3IEBAIHR5cGVkZWYgKEhUTUxDYW52YXNFbGVtZW50KSBXZWJH TENhbnZhczsKICAgICB1bmRlZmluZWQgbGluZVdpZHRoKEdMZmxvYXQgd2lkdGgpOwogICAgIHVu ZGVmaW5lZCBsaW5rUHJvZ3JhbShXZWJHTFByb2dyYW0gcHJvZ3JhbSk7CiAKLSAgICBbTmV3T2Jq ZWN0LCBDb25kaXRpb25hbD1XRUJYUl0gUHJvbWlzZTx1bmRlZmluZWQ+IG1ha2VYUkNvbXBhdGli bGUoKTsKKyAgICBbTmV3T2JqZWN0LCBDb25kaXRpb25hbD1XRUJYUiwgRW5hYmxlZEJ5U2V0dGlu Zz1XZWJYUkVuYWJsZWRdIFByb21pc2U8dW5kZWZpbmVkPiBtYWtlWFJDb21wYXRpYmxlKCk7CiAK ICAgICB1bmRlZmluZWQgcGl4ZWxTdG9yZWkoR0xlbnVtIHBuYW1lLCBHTGludCBwYXJhbSk7CiAg ICAgdW5kZWZpbmVkIHBvbHlnb25PZmZzZXQoR0xmbG9hdCBmYWN0b3IsIEdMZmxvYXQgdW5pdHMp Owo= 449832 2022-01-24 11:20:34 -0800 2022-01-25 08:49:09 -0800 Patch bug-235527-20220124192033.patch text/plain 2932 gsnedders U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ0Mjk4OGQzNjMwZWIx YmUyYzYyOWM3M2Y0YWIxOWIwZGVmYmE5NC4uODc0NDAwZTBkZjY1NDNiNTUzMjg3NzQ0NmU4OWJh YzZiYTk1Yzg2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAxLTI0ICBTYW0g U25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAgICAgICAgTWlzc2luZyBFbmFibGVk QnlTZXR0aW5nPVdlYlhSRW5hYmxlZCB3aGVyZSBDb25kaXRpb25hbD1XRUJYUiBleGlzdHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTUyNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hbnVhbGx5IHRl c3RlZC4KKworICAgICAgICAqIE1vZHVsZXMvd2VieHIvWFJGcmFtZVJlcXVlc3RDYWxsYmFjay5p ZGw6CisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xDb250ZXh0QXR0cmlidXRlcy5pZGw6Cisg ICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5pZGw6CisKIDIw MjItMDEtMjQgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAog ICAgICAgICBGaXggbm9uLXVuaWZpZWQgYnVpbGQgYWZ0ZXIgcjI4ODQzMgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9YUkZyYW1lUmVxdWVzdENhbGxiYWNrLmlkbCBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VieHIvWFJGcmFtZVJlcXVlc3RDYWxsYmFjay5pZGwK aW5kZXggNmEyNmRjNGZkN2QwMGZjZmU4MTU1ZjA1MjZhMGJkMjJlNzc0NzAxNC4uNDUyZTkwZjVj NjYzZmY1YTljY2M4ZjJlYzE5MWNlOWRkNGU2MzMyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJ4ci9YUkZyYW1lUmVxdWVzdENhbGxiYWNrLmlkbAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1hSRnJhbWVSZXF1ZXN0Q2FsbGJhY2suaWRsCkBAIC0yNyw1 ICsyNyw2IEBAIHR5cGVkZWYgZG91YmxlIERPTUhpZ2hSZXNUaW1lU3RhbXA7CiAKIC8vIGh0dHBz Oi8vaW1tZXJzaXZlLXdlYi5naXRodWIuaW8vd2VieHIvI2NhbGxiYWNrZGVmLXhyZnJhbWVyZXF1 ZXN0Y2FsbGJhY2sKIFsKLSAgICBDb25kaXRpb25hbD1XRUJYUgorICAgIENvbmRpdGlvbmFsPVdF QlhSLAorICAgIEVuYWJsZWRCeVNldHRpbmc9V2ViWFJFbmFibGVkCiBdIGNhbGxiYWNrIFhSRnJh bWVSZXF1ZXN0Q2FsbGJhY2sgPSB1bmRlZmluZWQgKERPTUhpZ2hSZXNUaW1lU3RhbXAgdGltZSwg V2ViWFJGcmFtZSBmcmFtZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTENvbnRleHRBdHRyaWJ1dGVzLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFz L1dlYkdMQ29udGV4dEF0dHJpYnV0ZXMuaWRsCmluZGV4IDM5MDJiYWViZmRmM2Y4ZGIyYzFlZTc4 NjUwNjc1MTQ0ZmI5ZjkwZWIuLmM1MjE4MWNjYTM2M2E2MjM4ODY0ZWI1YjMzZTAwMDBhNzc3YmQ0 NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMQ29udGV4dEF0 dHJpYnV0ZXMuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMQ29udGV4 dEF0dHJpYnV0ZXMuaWRsCkBAIC00NSw1ICs0NSw1IEBAIGVudW0gV2ViR0xQb3dlclByZWZlcmVu Y2UgewogICAgIEdMYm9vbGVhbiBwcmVzZXJ2ZURyYXdpbmdCdWZmZXIgPSBmYWxzZTsKICAgICBX ZWJHTFBvd2VyUHJlZmVyZW5jZSBwb3dlclByZWZlcmVuY2UgPSAiZGVmYXVsdCI7CiAgICAgR0xi b29sZWFuIGZhaWxJZk1ham9yUGVyZm9ybWFuY2VDYXZlYXQgPSBmYWxzZTsKLSAgICBbQ29uZGl0 aW9uYWw9V0VCWFJdIGJvb2xlYW4geHJDb21wYXRpYmxlID0gZmFsc2U7CisgICAgW0NvbmRpdGlv bmFsPVdFQlhSLCBFbmFibGVkQnlTZXR0aW5nPVdlYlhSRW5hYmxlZF0gYm9vbGVhbiB4ckNvbXBh dGlibGUgPSBmYWxzZTsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuaWRsCmluZGV4IGJmZTRmNDIyYzVjYzgyMmFi NTdmZTg3YjdkMjIzNTJiM2ZjZGIyYWMuLmRmZTgzYWFiOGM4YWYxYzExNGE2MTgzMGFhOWJhMDEw Y2ExOWExMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVu ZGVyaW5nQ29udGV4dEJhc2UuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dl YkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuaWRsCkBAIC02MDQsNyArNjA0LDcgQEAgdHlwZWRlZiAo SFRNTENhbnZhc0VsZW1lbnQpIFdlYkdMQ2FudmFzOwogICAgIHVuZGVmaW5lZCBsaW5lV2lkdGgo R0xmbG9hdCB3aWR0aCk7CiAgICAgdW5kZWZpbmVkIGxpbmtQcm9ncmFtKFdlYkdMUHJvZ3JhbSBw cm9ncmFtKTsKIAotICAgIFtOZXdPYmplY3QsIENvbmRpdGlvbmFsPVdFQlhSXSBQcm9taXNlPHVu ZGVmaW5lZD4gbWFrZVhSQ29tcGF0aWJsZSgpOworICAgIFtOZXdPYmplY3QsIENvbmRpdGlvbmFs PVdFQlhSLCBFbmFibGVkQnlTZXR0aW5nPVdlYlhSRW5hYmxlZF0gUHJvbWlzZTx1bmRlZmluZWQ+ IG1ha2VYUkNvbXBhdGlibGUoKTsKIAogICAgIHVuZGVmaW5lZCBwaXhlbFN0b3JlaShHTGVudW0g cG5hbWUsIEdMaW50IHBhcmFtKTsKICAgICB1bmRlZmluZWQgcG9seWdvbk9mZnNldChHTGZsb2F0 IGZhY3RvciwgR0xmbG9hdCB1bml0cyk7Cg==