235524 2022-01-24 09:10:46 -0800 [git-webkit] Improve handling of Ctrl-C during git-webkit commands while waiting for user input 2022-02-02 11:00:15 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235655 InRadar P2 Normal --- 1 aakash_jain jbedard aakash_jain webkit-bug-importer oldest_to_newest 1833357 0 aakash_jain 2022-01-24 09:10:46 -0800 Improve handling of Ctrl-C during git-webkit commands. Currently it prints a stack-trace which might not be very readable. e.g.: [WebKit]$git-webkit pr Branch name: ^CTraceback (most recent call last): File "/Volumes/Apple/code/WebKit/Tools/Scripts/git-webkit", line 69, in <module> sys.exit(program.main( File "/Volumes/Apple/code/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 134, in main return parsed.main( File "/Volumes/Apple/code/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 111, in main if Branch.main(args, repository, **kwargs): File "/Volumes/Apple/code/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py", line 79, in main args.issue = Terminal.input('Branch name: ') File "/Volumes/Apple/code/WebKit/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py", line 39, in input return (input if sys.version_info > (3, 0) else raw_input)(*args, **kwargs) KeyboardInterrupt 1833363 1 jbedard 2022-01-24 09:19:53 -0800 In most cases, I think the stack-trace is the right option. However, a Ctrl-C during input seems like a special case (as the example stack-trace is), and one we could pretty easily handle differently 1833365 2 aakash_jain 2022-01-24 09:22:15 -0800 (In reply to Jonathan Bedard from comment #1) > In most cases, I think the stack-trace is the right option. However, a Ctrl-C during input seems like a special case (as the example stack-trace is), and one we could pretty easily handle differently Yeah, the specific use-case I had in mind was pressing Ctrl-C when user was asked for an input. Re-titled the bug appropriately. 1835561 3 webkit-bug-importer 2022-01-31 09:41:36 -0800 <rdar://problem/88276494> 1835636 4 jbedard 2022-01-31 12:28:35 -0800 At the moment, one of the series of commits in https://github.com/WebKit/WebKit/pull/99 has this fix. 1836533 5 jbedard 2022-02-02 10:55:28 -0800 Fixed in 246695@main (r288966) 1836535 6 aakash_jain 2022-02-02 11:00:15 -0800 Thanks! Seems to be working fine. e.g.: [/Volumes/Apple/code/WebKit/Tools/CISupport/ews-build]$git-webkit pr 'main' is not a pull request branch, enter name of new branch: ^C User interrupted program