<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>235516</bug_id>
          
          <creation_ts>2022-01-24 07:41:11 -0800</creation_ts>
          <short_desc>EWS results (GitHub checks) are not displayed while logged out from GitHub</short_desc>
          <delta_ts>2023-08-11 14:02:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=235512</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=235306</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=235554</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>jbedard</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1833307</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-01-24 07:41:11 -0800</bug_when>
    <thetext>Currently, EWS results (default GitHub checks UI) are not displayed while logged out from GitHub. For e.g.: https://github.com/WebKit/WebKit/pull/89 (currently un-merged) shows the checks information while logged into GitHub, but doesn&apos;t show the information while logged out.

Not sure if this is critical, since reviewers would need to login to review the PR or leave any comments anyways. But it would probably be nice if the EWS results are displayed without logging in as well, e.g.: someone checking the PR on mobile to have a quick look if the PR is good, or bot-watchers looking at failing builds.

If someone have strong opinion on this, it would be good to know that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1833362</commentid>
    <comment_count>1</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-01-24 09:16:12 -0800</bug_when>
    <thetext>Feels like the solution to this is what we&apos;re pursing: have EWS have a comment which it updates.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1835532</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-01-31 07:42:18 -0800</bug_when>
    <thetext>&lt;rdar://problem/88269684&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1970783</commentid>
    <comment_count>3</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2023-08-11 14:02:15 -0700</bug_when>
    <thetext>We now have EWS status-bubbles which don&apos;t have this problem.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>