235513 2022-01-24 06:40:31 -0800 Incorrect pull-request url printed by git-webkit 2022-03-26 07:28:47 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235358 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain jbedard webkit-bug-importer oldest_to_newest 1833288 0 aakash_jain 2022-01-24 06:40:31 -0800 After the fix in https://github.com/WebKit/WebKit/pull/80, git-webkit pr now prints the pr url, which is great. However, the url has a typo making it incorrect. e.g.: https://github.com/WebKit/WebKit/pulls/89 instead of https://github.com/WebKit/WebKit/pull/89 (pulls instead of pull). We should fix this. 1833416 1 449838 aakash_jain 2022-01-24 11:47:44 -0800 Created attachment 449838 Proposed patch 1833422 2 aakash_jain 2022-01-24 12:10:53 -0800 Pull Request: https://github.com/WebKit/WebKit/pull/91 1833679 3 aakash_jain 2022-01-25 05:44:43 -0800 Landed https://commits.webkit.org/246353@main (d6f2ef7)! 1833680 4 webkit-bug-importer 2022-01-25 05:45:23 -0800 <rdar://problem/88019800> 449838 2022-01-24 11:47:44 -0800 2022-03-26 07:28:47 -0700 Proposed patch fix_typo_in_pr_url.patch text/plain 2603 aakash_jain ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNj bXB5L3JlbW90ZS9naXRfaHViLnB5IGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2Nt cHkvd2Via2l0c2NtcHkvcmVtb3RlL2dpdF9odWIucHkKaW5kZXggN2RiNjc1Nzg3YmI3Li5jOGJl YTY3YWJmOTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L3JlbW90ZS9naXRfaHViLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvbGlicmFy aWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3JlbW90ZS9naXRfaHViLnB5CkBAIC01Nyw3ICs1 Nyw3IEBAIGNsYXNzIEdpdEh1YihTY20pOgogICAgICAgICAgICAgICAgIGdlbmVyYXRvcj1zZWxm LAogICAgICAgICAgICAgICAgIG1ldGFkYXRhPWRpY3QoCiAgICAgICAgICAgICAgICAgICAgIGlz c3VlPWRhdGEuZ2V0KCdfbGlua3MnLCB7fSkuZ2V0KCdpc3N1ZScsIHt9KS5nZXQoJ2hyZWYnKSwK LSAgICAgICAgICAgICAgICApLCB1cmw9J3t9L3B1bGxzL3t9Jy5mb3JtYXQoc2VsZi5yZXBvc2l0 b3J5LnVybCwgZGF0YVsnbnVtYmVyJ10pLAorICAgICAgICAgICAgICAgICksIHVybD0ne30vcHVs bC97fScuZm9ybWF0KHNlbGYucmVwb3NpdG9yeS51cmwsIGRhdGFbJ251bWJlciddKSwKICAgICAg ICAgICAgICkKIAogICAgICAgICBkZWYgZ2V0KHNlbGYsIG51bWJlcik6CmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS90ZXN0L3B1bGxf cmVxdWVzdF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L3Rlc3QvcHVsbF9yZXF1ZXN0X3VuaXR0ZXN0LnB5CmluZGV4IGUzNGY4YjY4 ZjFmMi4uODIwZjhjMTlhNzcwIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93 ZWJraXRzY21weS93ZWJraXRzY21weS90ZXN0L3B1bGxfcmVxdWVzdF91bml0dGVzdC5weQorKysg Yi9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS90ZXN0L3B1 bGxfcmVxdWVzdF91bml0dGVzdC5weQpAQCAtMzMwLDcgKzMzMCw3IEBAIFJlYmFzZWQgJ2VuZy9w ci1icmFuY2gnIG9uICdtYWluIScKICAgICAgICAgICAgIGNhcHR1cmVkLnN0ZG91dC5nZXR2YWx1 ZSgpLAogICAgICAgICAgICAgIkNyZWF0ZWQgdGhlIGxvY2FsIGRldmVsb3BtZW50IGJyYW5jaCAn ZW5nL3ByLWJyYW5jaCchXG4iCiAgICAgICAgICAgICAiQ3JlYXRlZCAnUFIgMSB8IFtUZXN0aW5n XSBDcmVhdGluZyBjb21taXRzJyFcbiIKLSAgICAgICAgICAgICJodHRwczovL2dpdGh1Yi5leGFt cGxlLmNvbS9XZWJLaXQvV2ViS2l0L3B1bGxzLzFcbiIsCisgICAgICAgICAgICAiaHR0cHM6Ly9n aXRodWIuZXhhbXBsZS5jb20vV2ViS2l0L1dlYktpdC9wdWxsLzFcbiIsCiAgICAgICAgICkKICAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChjYXB0dXJlZC5zdGRlcnIuZ2V0dmFsdWUoKSwgJycpCiAg ICAgICAgIGxvZyA9IGNhcHR1cmVkLnJvb3QubG9nLmdldHZhbHVlKCkuc3BsaXRsaW5lcygpCkBA IC0zNjYsNyArMzY2LDcgQEAgUmViYXNlZCAnZW5nL3ByLWJyYW5jaCcgb24gJ21haW4hJwogICAg ICAgICBzZWxmLmFzc2VydEVxdWFsKAogICAgICAgICAgICAgY2FwdHVyZWQuc3Rkb3V0LmdldHZh bHVlKCksCiAgICAgICAgICAgICAiVXBkYXRlZCAnUFIgMSB8IFtUZXN0aW5nXSBBbWVuZGluZyBj b21taXRzJyFcbiIKLSAgICAgICAgICAgICJodHRwczovL2dpdGh1Yi5leGFtcGxlLmNvbS9XZWJL aXQvV2ViS2l0L3B1bGxzLzFcbiIsCisgICAgICAgICAgICAiaHR0cHM6Ly9naXRodWIuZXhhbXBs ZS5jb20vV2ViS2l0L1dlYktpdC9wdWxsLzFcbiIsCiAgICAgICAgICkKICAgICAgICAgc2VsZi5h c3NlcnRFcXVhbChjYXB0dXJlZC5zdGRlcnIuZ2V0dmFsdWUoKSwgJycpCiAgICAgICAgIGxvZyA9 IGNhcHR1cmVkLnJvb3QubG9nLmdldHZhbHVlKCkuc3BsaXRsaW5lcygpCkBAIC00MDgsNyArNDA4 LDcgQEAgUmViYXNlZCAnZW5nL3ByLWJyYW5jaCcgb24gJ21haW4hJwogICAgICAgICAgICAgIidl bmcvcHItYnJhbmNoJyBpcyBhbHJlYWR5IGFzc29jaWF0ZWQgd2l0aCAnUFIgMSB8IFtUZXN0aW5n XSBDcmVhdGluZyBjb21taXRzJywgd2hpY2ggaXMgY2xvc2VkLlxuIgogICAgICAgICAgICAgJ1dv dWxkIHlvdSBsaWtlIHRvIGNyZWF0ZSBhIG5ldyBwdWxsLXJlcXVlc3Q/IChZZXMvW05vXSk6IFxu JwogICAgICAgICAgICAgIlVwZGF0ZWQgJ1BSIDEgfCBbVGVzdGluZ10gQW1lbmRpbmcgY29tbWl0 cychXG4iCi0gICAgICAgICAgICAiaHR0cHM6Ly9naXRodWIuZXhhbXBsZS5jb20vV2ViS2l0L1dl YktpdC9wdWxscy8xXG4iLAorICAgICAgICAgICAgImh0dHBzOi8vZ2l0aHViLmV4YW1wbGUuY29t L1dlYktpdC9XZWJLaXQvcHVsbC8xXG4iLAogICAgICAgICApCiAgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwoY2FwdHVyZWQuc3RkZXJyLmdldHZhbHVlKCksICcnKQogICAgICAgICBsb2cgPSBjYXB0 dXJlZC5yb290LmxvZy5nZXR2YWx1ZSgpLnNwbGl0bGluZXMoKQo=