235500 2022-01-23 21:37:44 -0800 XPath::Step::nodesInAxis(): add null checks after Attr::ownerElement() calls 2022-01-25 16:32:16 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/32544 InRadar P2 Normal --- 1 ashvayka ashvayka clopez darin ews-watchlist webkit-bug-importer youennf oldest_to_newest 1833193 0 ashvayka 2022-01-23 21:37:44 -0800 XPath::Step::nodesInAxis(): add null checks after Attr::ownerElement() calls 1833194 1 449780 ashvayka 2022-01-23 21:39:01 -0800 Created attachment 449780 Patch 1833195 2 ews-watchlist 2022-01-23 21:41:12 -0800 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1833923 3 ashvayka 2022-01-25 16:31:46 -0800 Committed r288589 (246411@trunk): <https://commits.webkit.org/246411@trunk> 1833924 4 ashvayka 2022-01-25 16:32:12 -0800 Thank you Darin! 1833925 5 webkit-bug-importer 2022-01-25 16:32:16 -0800 <rdar://problem/88050706> 449780 2022-01-23 21:39:01 -0800 2022-01-25 14:20:34 -0800 Patch bug-235500-20220124053900.patch text/plain 6209 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4ODA3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAxLTIzICBBbGV4ZXkg U2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KKworICAgICAgICBYUGF0aDo6U3RlcDo6bm9k ZXNJbkF4aXMoKTogYWRkIG51bGwgY2hlY2tzIGFmdGVyIEF0dHI6Om93bmVyRWxlbWVudCgpIGNh bGxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU1 MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IHBhdGNoIGFkZHMgbnVsbCBjaGVja3MgZm9yIHJlc3VsdHMgb2YgQXR0cjo6b3duZXJFbGVtZW50 KCkgdG8gYXZvaWQgY3Jhc2hlcworICAgICAgICB3aGVuIGV2YWx1YXRpbmcgWFBhdGggZXhwcmVz c2lvbnMgd2l0aCBvcnBoYW5lZCBBdHRyIGFzIGEgY29udGV4dCBub2RlLgorCisgICAgICAgIElu c3BpcmVkIGJ5IHRoZSByZWNlbnQgQmxpbmsgZml4IFsxXSwgeWV0IHRoaXMgY2hhbmdlIGNvdmVy cyBhbGwgbnVsbCBwb2ludGVyCisgICAgICAgIGRlcmVmZXJlbmNpbmcgc2l0ZXMsIGFzIHByb3Zl biBieSB0aGUgdXBkYXRlZCB0ZXN0LgorCisgICAgICAgIFsxXSBodHRwczovL2J1Z3MuY2hyb21p dW0ub3JnL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD0xMjM2OTY3CisKKyAgICAgICAgVGVz dDogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb214cGF0aC94cGF0aC1ldmFsdWF0 ZS1jcmFzaC5odG1sCisKKyAgICAgICAgKiB4bWwvWFBhdGhTdGVwLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlhQYXRoOjpTdGVwOjpub2Rlc0luQXhpcyBjb25zdCk6CisKIDIwMjItMDEtMTUgIFNh bSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIENTUyBHcmFkaWVudHM6IGlu dGVycG9sYXRpb24gbW9kZSBzaG91bGQgZGVmYXVsdCB0byBPS0xhYiBpZiBhbnkgbm9uLWxlZ2Fj eSBjb2xvciBzeW50YXggY29sb3JzIGFyZSB1c2VkIGluIHRoZSBzdG9wcwpJbmRleDogU291cmNl L1dlYkNvcmUveG1sL1hQYXRoU3RlcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv eG1sL1hQYXRoU3RlcC5jcHAJKHJldmlzaW9uIDI4ODAzNCkKKysrIFNvdXJjZS9XZWJDb3JlL3ht bC9YUGF0aFN0ZXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTgsNyArMjU4LDcgQEAgdm9pZCBT dGVwOjpub2Rlc0luQXhpcyhOb2RlJiBjb250ZXh0LCBObwogICAgICAgICBjYXNlIFBhcmVudEF4 aXM6CiAgICAgICAgICAgICBpZiAoY29udGV4dC5pc0F0dHJpYnV0ZU5vZGUoKSkgewogICAgICAg ICAgICAgICAgIEVsZW1lbnQqIG5vZGUgPSBzdGF0aWNfY2FzdDxBdHRyJj4oY29udGV4dCkub3du ZXJFbGVtZW50KCk7Ci0gICAgICAgICAgICAgICAgaWYgKG5vZGVNYXRjaGVzKCpub2RlLCBQYXJl bnRBeGlzLCBtX25vZGVUZXN0KSkKKyAgICAgICAgICAgICAgICBpZiAobm9kZSAmJiBub2RlTWF0 Y2hlcygqbm9kZSwgUGFyZW50QXhpcywgbV9ub2RlVGVzdCkpCiAgICAgICAgICAgICAgICAgICAg IG5vZGVzLmFwcGVuZChub2RlKTsKICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAg ICAgQ29udGFpbmVyTm9kZSogbm9kZSA9IGNvbnRleHQucGFyZW50Tm9kZSgpOwpAQCAtMjcwLDYg KzI3MCw4IEBAIHZvaWQgU3RlcDo6bm9kZXNJbkF4aXMoTm9kZSYgY29udGV4dCwgTm8KICAgICAg ICAgICAgIE5vZGUqIG5vZGUgPSAmY29udGV4dDsKICAgICAgICAgICAgIGlmIChjb250ZXh0Lmlz QXR0cmlidXRlTm9kZSgpKSB7CiAgICAgICAgICAgICAgICAgbm9kZSA9IHN0YXRpY19jYXN0PEF0 dHImPihjb250ZXh0KS5vd25lckVsZW1lbnQoKTsKKyAgICAgICAgICAgICAgICBpZiAoIW5vZGUp CisgICAgICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgICBpZiAobm9kZU1h dGNoZXMoKm5vZGUsIEFuY2VzdG9yQXhpcywgbV9ub2RlVGVzdCkpCiAgICAgICAgICAgICAgICAg ICAgIG5vZGVzLmFwcGVuZChub2RlKTsKICAgICAgICAgICAgIH0KQEAgLTMwMCw2ICszMDIsOCBA QCB2b2lkIFN0ZXA6Om5vZGVzSW5BeGlzKE5vZGUmIGNvbnRleHQsIE5vCiAgICAgICAgIGNhc2Ug Rm9sbG93aW5nQXhpczoKICAgICAgICAgICAgIGlmIChjb250ZXh0LmlzQXR0cmlidXRlTm9kZSgp KSB7CiAgICAgICAgICAgICAgICAgTm9kZSogbm9kZSA9IHN0YXRpY19jYXN0PEF0dHImPihjb250 ZXh0KS5vd25lckVsZW1lbnQoKTsKKyAgICAgICAgICAgICAgICBpZiAoIW5vZGUpCisgICAgICAg ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgICB3aGlsZSAoKG5vZGUgPSBOb2Rl VHJhdmVyc2FsOjpuZXh0KCpub2RlKSkpIHsKICAgICAgICAgICAgICAgICAgICAgaWYgKG5vZGVN YXRjaGVzKCpub2RlLCBGb2xsb3dpbmdBeGlzLCBtX25vZGVUZXN0KSkKICAgICAgICAgICAgICAg ICAgICAgICAgIG5vZGVzLmFwcGVuZChub2RlKTsKQEAgLTMxOSw5ICszMjMsMTEgQEAgdm9pZCBT dGVwOjpub2Rlc0luQXhpcyhOb2RlJiBjb250ZXh0LCBObwogICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICBjYXNlIFByZWNlZGluZ0F4aXM6IHsKICAgICAgICAgICAgIE5vZGUqIG5vZGU7Ci0g ICAgICAgICAgICBpZiAoY29udGV4dC5pc0F0dHJpYnV0ZU5vZGUoKSkKKyAgICAgICAgICAgIGlm IChjb250ZXh0LmlzQXR0cmlidXRlTm9kZSgpKSB7CiAgICAgICAgICAgICAgICAgbm9kZSA9IHN0 YXRpY19jYXN0PEF0dHImPihjb250ZXh0KS5vd25lckVsZW1lbnQoKTsKLSAgICAgICAgICAgIGVs c2UKKyAgICAgICAgICAgICAgICBpZiAoIW5vZGUpCisgICAgICAgICAgICAgICAgICAgIHJldHVy bjsKKyAgICAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgICAgIG5vZGUgPSAmY29udGV4dDsK ICAgICAgICAgICAgIHdoaWxlIChDb250YWluZXJOb2RlKiBwYXJlbnQgPSBub2RlLT5wYXJlbnRO b2RlKCkpIHsKICAgICAgICAgICAgICAgICBmb3IgKG5vZGUgPSBOb2RlVHJhdmVyc2FsOjpwcmV2 aW91cygqbm9kZSk7IG5vZGUgIT0gcGFyZW50OyBub2RlID0gTm9kZVRyYXZlcnNhbDo6cHJldmlv dXMoKm5vZGUpKSB7CkBAIC0zODIsNiArMzg4LDggQEAgdm9pZCBTdGVwOjpub2Rlc0luQXhpcyhO b2RlJiBjb250ZXh0LCBObwogICAgICAgICAgICAgTm9kZSogbm9kZSA9ICZjb250ZXh0OwogICAg ICAgICAgICAgaWYgKGNvbnRleHQuaXNBdHRyaWJ1dGVOb2RlKCkpIHsKICAgICAgICAgICAgICAg ICBub2RlID0gc3RhdGljX2Nhc3Q8QXR0ciY+KGNvbnRleHQpLm93bmVyRWxlbWVudCgpOworICAg ICAgICAgICAgICAgIGlmICghbm9kZSkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICAgICAgICAgIGlmIChub2RlTWF0Y2hlcygqbm9kZSwgQW5jZXN0b3JPclNlbGZBeGlzLCBt X25vZGVUZXN0KSkKICAgICAgICAgICAgICAgICAgICAgbm9kZXMuYXBwZW5kKG5vZGUpOwogICAg ICAgICAgICAgfQpJbmRleDogTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCShyZXZpc2lvbiAy ODg0MjkpCisrKyBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDEtMjMgIEFsZXhleSBTaHZheWthICA8YXNodmF5 a2FAYXBwbGUuY29tPgorCisgICAgICAgIFhQYXRoOjpTdGVwOjpub2Rlc0luQXhpcygpOiBhZGQg bnVsbCBjaGVja3MgYWZ0ZXIgQXR0cjo6b3duZXJFbGVtZW50KCkgY2FsbHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTUwMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcG9ydCBXUFQgdGVzdHMgZnJv bSA8cGVuZGluZz4uCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvZG9teHBhdGgveHBh dGgtZXZhbHVhdGUtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiB3ZWItcGxh dGZvcm0tdGVzdHMvZG9teHBhdGgveHBhdGgtZXZhbHVhdGUtY3Jhc2guaHRtbDogQWRkZWQuCisK IDIwMjItMDEtMjMgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIFN1 cHBvcnQgaW50ZXJwb2xhdGluZyBjb2xvcnMgd2l0aCBtaXNzaW5nL25vbmUgY29tcG9uZW50cyB2 aWEgY29sb3ItbWl4KCkKSW5kZXg6IExheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvZG9teHBhdGgveHBhdGgtZXZhbHVhdGUtY3Jhc2gtZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9t eHBhdGgveHBhdGgtZXZhbHVhdGUtY3Jhc2gtZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkKKysr IExheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9teHBhdGgveHBh dGgtZXZhbHVhdGUtY3Jhc2gtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs OCBAQAorCitQQVNTICIuLiIKK1BBU1MgInBhcmVudCIKK1BBU1MgImFuY2VzdG9yOjoqIgorUEFT UyAiYW5jZXN0b3Itb3Itc2VsZjo6KiIKK1BBU1MgImZvbGxvd2luZzo6KiIKK1BBU1MgInByZWNl ZGluZzo6KiIKKwpJbmRleDogTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9kb214cGF0aC94cGF0aC1ldmFsdWF0ZS1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9teHBhdGgveHBhdGgt ZXZhbHVhdGUtY3Jhc2guaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbXhwYXRoL3hwYXRoLWV2YWx1YXRlLWNyYXNoLmh0 bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyNCBAQAorPCFET0NUWVBFIGh0bWw+Cis8bWV0 YSBjaGFyc2V0PSJ1dGYtOCI+Cis8dGl0bGU+RXZhbHVhdGluZyBYUGF0aCBleHByZXNzaW9ucyB3 aXRoIG9yaHBhbmVkIEF0dHIgYXMgY29udGV4dCBub2RlIGRvZXNuJ3QgY3Jhc2g8L3RpdGxlPgor PGxpbmsgcmVsPWF1dGhvciBocmVmPSJtYWlsdG86amFyaGFyQGNocm9taXVtLm9yZyI+Cis8bGlu ayByZWw9aGVscCBocmVmPSJodHRwczovL2J1Z3MuY2hyb21pdW0ub3JnL3AvY2hyb21pdW0vaXNz dWVzL2RldGFpbD9pZD0xMjM2OTY3Ij4KKzxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJu ZXNzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVw b3J0LmpzIj48L3NjcmlwdD4KKzxib2R5PgorPHNjcmlwdD4KK2ZvciAoY29uc3QgZXhwcmVzc2lv biBvZiBbCisgICAgIi4uIiwKKyAgICAicGFyZW50IiwKKyAgICAiYW5jZXN0b3I6OioiLAorICAg ICJhbmNlc3Rvci1vci1zZWxmOjoqIiwKKyAgICAiZm9sbG93aW5nOjoqIiwKKyAgICAicHJlY2Vk aW5nOjoqIiwKK10pIHsKKyAgICB0ZXN0KCgpID0+IHsKKyAgICAgICAgY29uc3Qgb3JwaGFuZWRB dHRyID0gZG9jdW1lbnQuY3JlYXRlQXR0cmlidXRlKCJmb28iKTsKKyAgICAgICAgY29uc3QgcmVz dWx0ID0gbmV3IFhQYXRoRXZhbHVhdG9yKCkuZXZhbHVhdGUoZXhwcmVzc2lvbiwgb3JwaGFuZWRB dHRyLCBudWxsLCAyKTsKKyAgICAgICAgYXNzZXJ0X3RydWUocmVzdWx0IGluc3RhbmNlb2YgWFBh dGhSZXN1bHQpOworICAgIH0sIGAiJHtleHByZXNzaW9ufSJgKTsKK30KKzwvc2NyaXB0Pgo=