235499 2022-01-23 16:19:33 -0800 AX: When disabledAttr changes, we don't need to post a notification, only update the isolated tree 2022-01-24 08:09:17 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1833158 0 tyler_w 2022-01-23 16:19:33 -0800 In https://bugs.webkit.org/show_bug.cgi?id=235246, we added: else if (attrName == disabledAttr) postNotification(element, AXObjectCache::AXDisabledStateChanged); So that we could update the isolated tree when this happens. However, posting a notification here is unnecessary work, since we can just call updateIsolatedTree directly instead. 1833159 1 webkit-bug-importer 2022-01-23 16:19:51 -0800 <rdar://problem/87947110> 1833160 2 449770 tyler_w 2022-01-23 16:23:09 -0800 Created attachment 449770 Patch 1833168 3 449770 darin 2022-01-23 16:50:08 -0800 Comment on attachment 449770 Patch I’ll take your word that this was not required. Is there some discipline where we can verify such things with tests, not just with knowledge of the code? 1833329 4 andresg_22 2022-01-24 08:09:17 -0800 I'm not certain that a notification is not required. Clients may need to know that something is now disabled or not. Even if some clients are not using it at the moment, we should post the notification for API consistency. 449770 2022-01-23 16:23:09 -0800 2022-01-23 17:44:23 -0800 Patch bug-235499-20220123182308.patch text/plain 2485 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2U3ODdjMzc3YjQ0NThl Zjk3MjM0MDY0NDY2N2VkOWJhNDE0YzdhOC4uYmY2OWE2YTg5ZGIwZDZkM2Q2ZTFmNTljNmRiMmNj M2QxZDMyNTUzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAxLTIzICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFdoZW4gZGlzYWJs ZWRBdHRyIGNoYW5nZXMsIHdlIGRvbid0IG5lZWQgdG8gcG9zdCBhIG5vdGlmaWNhdGlvbiwgb25s eSB1cGRhdGUgdGhlIGlzb2xhdGVkIHRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzNTQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzUyNDYsIHdlIGFkZGVkOgorCisgICAgICAgIGVsc2UgaWYgKGF0dHJOYW1lID09IGRp c2FibGVkQXR0cikKKyAgICAgICAgICAgIHBvc3ROb3RpZmljYXRpb24oZWxlbWVudCwgQVhPYmpl Y3RDYWNoZTo6QVhEaXNhYmxlZFN0YXRlQ2hhbmdlZCk7CisKKyAgICAgICAgU28gdGhhdCB3ZSBj b3VsZCB1cGRhdGUgdGhlIGlzb2xhdGVkIHRyZWUgd2hlbiB0aGlzIGhhcHBlbnMuIEhvd2V2ZXIs CisgICAgICAgIHBvc3RpbmcgYSBub3RpZmljYXRpb24gaGVyZSBpcyB1bm5lY2Vzc2FyeSB3b3Jr LCBzaW5jZSB3ZSBjYW4ganVzdCBjYWxsCisgICAgICAgIHVwZGF0ZUlzb2xhdGVkVHJlZSBkaXJl Y3RseSBpbnN0ZWFkLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OmhhbmRsZUF0dHJpYnV0ZUNoYW5n ZSk6CisgICAgICAgIFdoZW4gZGlzYWJsZWRBdHRyIGNoYW5nZXMsIGNhbGwgYHVwZGF0ZUlzb2xh dGVkVHJlZWAgZGlyZWN0bHkgaW5zdGVhZCBvZiBwb3N0aW5nIHVubmVjZXNzYXJ5IG5vdGlmaWNh dGlvbgorCiAyMDIyLTAxLTIzICBUeWxlciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CiAK ICAgICAgICAgQVggSXNvbGF0ZWQgVHJlZSBNb2RlOiBSZS1jb21wdXRlIEFYUHJvcGVydHlOYW1l OjpJc0VuYWJsZWQgd2hlbiBhIG5vZGUgZXhwZXJpZW5jZXMgQVhEaXNhYmxlZFN0YXRlQ2hhbmdl ZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKaW5k ZXggNDYyNzhiYjViYmJhZjIzZjA3ZTRhYmU0ZjM5NTBmMzYxZjI3N2JiOC4uNDI4YTIyZjBiOTMy ZDhiYTk5YjFlNjE0YTlkOTlhZmZiNGZiNGYzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCkBAIC0xNzg3LDEzICsxNzg3LDEzIEBAIHZvaWQg QVhPYmplY3RDYWNoZTo6aGFuZGxlQXR0cmlidXRlQ2hhbmdlKGNvbnN0IFF1YWxpZmllZE5hbWUm IGF0dHJOYW1lLCBFbGVtZW50CiAgICAgICAgIGhhbmRsZUFyaWFSb2xlQ2hhbmdlZChlbGVtZW50 KTsKICAgICBlbHNlIGlmIChhdHRyTmFtZSA9PSBhbHRBdHRyIHx8IGF0dHJOYW1lID09IHRpdGxl QXR0cikKICAgICAgICAgdGV4dENoYW5nZWQoZWxlbWVudCk7Ci0gICAgZWxzZSBpZiAoYXR0ck5h bWUgPT0gZGlzYWJsZWRBdHRyKQotICAgICAgICBwb3N0Tm90aWZpY2F0aW9uKGVsZW1lbnQsIEFY T2JqZWN0Q2FjaGU6OkFYRGlzYWJsZWRTdGF0ZUNoYW5nZWQpOwogICAgIGVsc2UgaWYgKGF0dHJO YW1lID09IGZvckF0dHIgJiYgaXM8SFRNTExhYmVsRWxlbWVudD4oKmVsZW1lbnQpKQogICAgICAg ICBsYWJlbENoYW5nZWQoZWxlbWVudCk7CiAgICAgZWxzZSBpZiAoYXR0ck5hbWUgPT0gdGFiaW5k ZXhBdHRyKQogICAgICAgICBjaGlsZHJlbkNoYW5nZWQoZWxlbWVudC0+cGFyZW50Tm9kZSgpLCBl bGVtZW50KTsKICNpZiBFTkFCTEUoQUNDRVNTSUJJTElUWV9JU09MQVRFRF9UUkVFKQorICAgIGVs c2UgaWYgKGF0dHJOYW1lID09IGRpc2FibGVkQXR0cikKKyAgICAgICAgdXBkYXRlSXNvbGF0ZWRU cmVlKGdldChlbGVtZW50KSwgQVhPYmplY3RDYWNoZTo6QVhEaXNhYmxlZFN0YXRlQ2hhbmdlZCk7 CiAgICAgZWxzZSBpZiAoYXR0ck5hbWUgPT0gbGFuZ0F0dHIpCiAgICAgICAgIHVwZGF0ZUlzb2xh dGVkVHJlZShnZXQoZWxlbWVudCksIEFYT2JqZWN0Q2FjaGU6OkFYTGFuZ3VhZ2VDaGFuZ2VkKTsK ICAgICBlbHNlIGlmIChhdHRyTmFtZSA9PSBpZEF0dHIpCg==