235493 2022-01-23 07:12:56 -0800 [GStreamer] C++20 warnings 2022-01-23 11:30:17 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris cgarcia darin ews-watchlist gustavo menard vjaquez webkit-bug-importer yurys oldest_to_newest 1833087 0 pnormand 2022-01-23 07:12:56 -0800 /app/webkit/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:456:26: warning: ISO C++20 considers use of overloaded operator '!=' (with operand types 'GstIteratorAdaptor<_GstPad>::iterator' and 'GstIteratorAdaptor<_GstPad>::iterator') to be ambiguous despite there being a unique best viable function with non-reversed arguments [-Wambiguous-reversed-operator] for (GstPad* pad : GstIteratorAdaptor<GstPad>(GUniquePtr<GstIterator>(gst_element_iterate_src_pads(m_demux.get())))) { ^ /app/webkit/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:392:14: note: candidate function with non-reversed arguments bool operator!=(const iterator& other) { return !(*this == other); } ^ /app/webkit/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:388:14: note: ambiguous candidate function with reversed arguments bool operator==(const iterator& other) ^ /app/webkit/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:471:26: warning: ISO C++20 considers use of overloaded operator '!=' (with operand types 'GstIteratorAdaptor<_GstPad>::iterator' and 'GstIteratorAdaptor<_GstPad>::iterator') to be ambiguous despite there being a unique best viable function with non-reversed arguments [-Wambiguous-reversed-operator] for (GstPad* pad : GstIteratorAdaptor<GstPad>(GUniquePtr<GstIterator>(gst_element_iterate_src_pads(m_demux.get())))) { ^ /app/webkit/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:392:14: note: candidate function with non-reversed arguments bool operator!=(const iterator& other) { return !(*this == other); } ^ /app/webkit/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:388:14: note: ambiguous candidate function with reversed arguments bool operator==(const iterator& other) ^ 2 warnings generated. 1833088 1 449749 pnormand 2022-01-23 08:25:28 -0800 Created attachment 449749 Patch 1833100 2 pnormand 2022-01-23 09:33:02 -0800 *** Bug 235075 has been marked as a duplicate of this bug. *** 1833117 3 ews-feeder 2022-01-23 11:29:02 -0800 Committed r288422 (246313@main): <https://commits.webkit.org/246313@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449749. 1833118 4 webkit-bug-importer 2022-01-23 11:30:17 -0800 <rdar://problem/87944376> 449749 2022-01-23 08:25:28 -0800 2022-01-23 11:29:05 -0800 Patch bug-235493-20220123082527.patch text/plain 1900 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2JhOTBkODNiMTk2OTA3 ZDc3ZTk1OTcwZWMzODJiZDNhNmE3NDhlZS4uNjc4MGE4M2JiOTI1YmRjMzAyZDRjZmZjNDJkOTA5 Yjk1YjQ2ZmMxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAxLTIzICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBDKysyMCB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjM1NDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4IGFtYmlndW91cy1yZXZlcnNlZC1vcGVyYXRvciB3YXJuaW5ncy4gSW4gQysr MjAgY29tcGFyaXNvbiBvcGVyYXRvcnMgKGxpa2UgYSA9PSBiKSBuZWVkCisgICAgICAgIHRvIGJl IGRlY2xhcmVkIGNvbnN0LCBzbyB0aGF0IHJldmVyc2UgY29tcGFyaXNvbnMgKGxpa2UgYiA9PSBh KSBhbHNvIHdvcmsgYXMgaW50ZW5kZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvR1N0cmVhbWVyQ29tbW9uLmg6CisgICAgICAgIChHc3RJdGVyYXRvckFkYXB0b3I6 Oml0ZXJhdG9yOjpvcGVyYXRvcj09IGNvbnN0KToKKyAgICAgICAgKEdzdEl0ZXJhdG9yQWRhcHRv cjo6aXRlcmF0b3I6Om9wZXJhdG9yIT0gY29uc3QpOgorICAgICAgICAoR3N0SXRlcmF0b3JBZGFw dG9yOjppdGVyYXRvcjo6b3BlcmF0b3I9PSk6IERlbGV0ZWQuCisgICAgICAgIChHc3RJdGVyYXRv ckFkYXB0b3I6Oml0ZXJhdG9yOjpvcGVyYXRvciE9KTogRGVsZXRlZC4KKwogMjAyMi0wMS0yMyAg QWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBFbmFi bGUgdW5pY29kZS1iaWRpOiBwbGFpbnRleHQgZm9yIElGQwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5o CmluZGV4IGQ4MmNkM2UxOGVjZTA0NzYxZDZhZDRlYzJkNTJlMmFkOWRjMzg0NjguLmU0ZTdjODg5 NGMxZDNjZjJhMDVmYTQ2OGFiMTQ2ZDA2Y2M0ZGY4OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJDb21tb24uaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyQ29tbW9u LmgKQEAgLTM4NSwxMSArMzg1LDExIEBAIHB1YmxpYzoKICAgICAgICAgICAgIHJldHVybiAqdGhp czsKICAgICAgICAgfQogCi0gICAgICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBpdGVyYXRvciYg b3RoZXIpCisgICAgICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBpdGVyYXRvciYgb3RoZXIpIGNv bnN0CiAgICAgICAgIHsKICAgICAgICAgICAgIHJldHVybiBtX2l0ZXIgPT0gb3RoZXIubV9pdGVy ICYmIG1fZG9uZSA9PSBvdGhlci5tX2RvbmU7CiAgICAgICAgIH0KLSAgICAgICAgYm9vbCBvcGVy YXRvciE9KGNvbnN0IGl0ZXJhdG9yJiBvdGhlcikgeyByZXR1cm4gISgqdGhpcyA9PSBvdGhlcik7 IH0KKyAgICAgICAgYm9vbCBvcGVyYXRvciE9KGNvbnN0IGl0ZXJhdG9yJiBvdGhlcikgY29uc3Qg eyByZXR1cm4gISgqdGhpcyA9PSBvdGhlcik7IH0KIAogICAgIHByaXZhdGU6CiAgICAgICAgIEdz dEl0ZXJhdG9yKiBtX2l0ZXI7Cg==