235490 2022-01-23 06:55:54 -0800 [Flatpak SDK] Extension points for the Flatpak Sparkle-CDM extension 2022-02-04 08:52:18 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 235489 1 pnormand pnormand aperez webkit-bug-importer oldest_to_newest 1833083 0 pnormand 2022-01-23 06:55:54 -0800 bst bits allowing our Sdk and Platform to have the extension mounted in the runtime sandbox. 1833094 1 449751 pnormand 2022-01-23 08:54:50 -0800 Created attachment 449751 [fast-cq] Patch 1837422 2 449751 aperez 2022-02-04 07:57:08 -0800 Comment on attachment 449751 [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449751&action=review > Tools/buildstream/elements/flatpak/platform.bst:84 > + no-autodownload: 'true' What's the reason to quote the booleans? They could as well be specified directly as they are valid YAML values: autodelete: False no-autodownload: True I know that there are many other instances around which are strings, but the man page for fltpak-metadata clearly states that these fields are indeed booleans (not strings). Probably this has been working fine because when saving the data back when building the image the writer that is serializing the values by chance chooses to write the strings unquoted (which is allowed in YAML) and the parser from the Flatpak tooling is magnanimous enough to accept the lowercase unquoted “true“ and “false“ strings as booleans. Or am I overthinking things here? Anyway, we know the current approach works and I am mostly wondering what's going on in reality. 1837446 3 pnormand 2022-02-04 08:48:23 -0800 I honestly have no clue what to answer, excepted that iirc I took inspiration in the FDO SDK, maybe the syntax improved since then and this has bitrotten. I can follow-up about this in a separate patch :) 1837447 4 ews-feeder 2022-02-04 08:51:29 -0800 Committed r289118 (246815@main): <https://commits.webkit.org/246815@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449751. 1837448 5 webkit-bug-importer 2022-02-04 08:52:18 -0800 <rdar://problem/88491360> 449751 2022-01-23 08:54:50 -0800 2022-02-04 08:51:31 -0800 [fast-cq] Patch bug-235490-20220123085449.patch text/plain 2178 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDE5CmRpZmYgLS1naXQgYS9Ub29scy9idWlsZHN0cmVh bS9DaGFuZ2VMb2cgYi9Ub29scy9idWlsZHN0cmVhbS9DaGFuZ2VMb2cKaW5kZXggM2E5MGU0MmE0 NmI1YWM3NWE4MTEyOTkwMjYyOTE2ZDdlODk0YTdmZi4uOWMzYzg2Zjk4NGZhMmNiODhjZDI5NzM3 MWMxODI1Y2Y5NTUyYzQ1OSAxMDA2NDQKLS0tIGEvVG9vbHMvYnVpbGRzdHJlYW0vQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL2J1aWxkc3RyZWFtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIy LTAxLTIzICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAg ICBbRmxhdHBhayBTREtdIEV4dGVuc2lvbiBwb2ludHMgZm9yIHRoZSBGbGF0cGFrIFNwYXJrbGUt Q0RNIGV4dGVuc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM1NDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWxsb3cgU3BhcmtsZS1DRE0gZXh0ZW5zaW9uIGluIFNkay9QbGF0Zm9ybSBydW50aW1l cy4gQSBmb2xsb3ctdXAgcGF0Y2ggd2lsbCBhZGQgc3VwcG9ydCBmb3IKKyAgICAgICAgdGhlIGV4 dGVuc2lvbiBpbnN0YWxsYXRpb24uCisKKyAgICAgICAgKiBlbGVtZW50cy9mbGF0cGFrL3BsYXRm b3JtLmJzdDoKKyAgICAgICAgKiBlbGVtZW50cy9mbGF0cGFrL3Nkay5ic3Q6CisKIDIwMjItMDEt MTYgIENoYW5nU2VvayBPaCAgPGNoYW5nc2Vva0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtGbGF0 cGFrIFNES10gbG9jYWwgYnVpbGQgaXMgYnJva2VuCmRpZmYgLS1naXQgYS9Ub29scy9idWlsZHN0 cmVhbS9lbGVtZW50cy9mbGF0cGFrL3BsYXRmb3JtLmJzdCBiL1Rvb2xzL2J1aWxkc3RyZWFtL2Vs ZW1lbnRzL2ZsYXRwYWsvcGxhdGZvcm0uYnN0CmluZGV4IGQyNzViYzZiMmZlOTNhNzRlNjFhMTRk MjVkNzM5MTY0ZTQ3NGYyZjAuLjBmMzg2OWEwMDYxNDY4NTQ4YjVlNWI3ZmUxM2FhMzJmMmNhYjgy NTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2J1aWxkc3RyZWFtL2VsZW1lbnRzL2ZsYXRwYWsvcGxhdGZv cm0uYnN0CisrKyBiL1Rvb2xzL2J1aWxkc3RyZWFtL2VsZW1lbnRzL2ZsYXRwYWsvcGxhdGZvcm0u YnN0CkBAIC03NywzICs3NywxMCBAQCBjb25maWc6CiAgICAgICBhZGQtbGQtcGF0aDogZXh0cmEK ICAgICAgIGF1dG9kZWxldGU6ICdmYWxzZScKICAgICAgIHZlcnNpb246ICcle2ZyZWVkZXNrdG9w LXNkay1mbGF0cGFrLWJyYW5jaH0nCisKKyAgICBFeHRlbnNpb24gb3JnLmZyZWVkZXNrdG9wLlBs YXRmb3JtLnNwYXJrbGUtY2RtOgorICAgICAgZGlyZWN0b3J5OiAnJXtsaWJ9L3NwYXJrbGUtY2Rt JworICAgICAgYXV0b2RlbGV0ZTogJ2ZhbHNlJworICAgICAgbm8tYXV0b2Rvd25sb2FkOiAndHJ1 ZScKKyAgICAgIGFkZC1sZC1wYXRoOiBsaWIKKyAgICAgIHZlcnNpb246ICcle2ZyZWVkZXNrdG9w LXNkay1mbGF0cGFrLWJyYW5jaH0nCmRpZmYgLS1naXQgYS9Ub29scy9idWlsZHN0cmVhbS9lbGVt ZW50cy9mbGF0cGFrL3Nkay5ic3QgYi9Ub29scy9idWlsZHN0cmVhbS9lbGVtZW50cy9mbGF0cGFr L3Nkay5ic3QKaW5kZXggNDVjMmEyYWY3N2ZhNDMzM2E2MzBkZjE0NThkYzg2NjY5YjMwZWQyYy4u ZTYxMjkwYTZhZDllMTExODMyMWU2MDExNDMzZTc2ODA0YWJkYmE2OSAxMDA2NDQKLS0tIGEvVG9v bHMvYnVpbGRzdHJlYW0vZWxlbWVudHMvZmxhdHBhay9zZGsuYnN0CisrKyBiL1Rvb2xzL2J1aWxk c3RyZWFtL2VsZW1lbnRzL2ZsYXRwYWsvc2RrLmJzdApAQCAtNzEsNiArNzEsMTEgQEAgY29uZmln OgogICAgICAgYWRkLWxkLXBhdGg6IGV4dHJhCiAgICAgICB2ZXJzaW9uOiAnJXtmcmVlZGVza3Rv cC1zZGstZmxhdHBhay1icmFuY2h9JwogCisgICAgRXh0ZW5zaW9uIG9yZy5mcmVlZGVza3RvcC5Q bGF0Zm9ybS5zcGFya2xlLWNkbToKKyAgICAgIGRpcmVjdG9yeTogJyV7bGlifS9zcGFya2xlLWNk bScKKyAgICAgIGFkZC1sZC1wYXRoOiBsaWIKKyAgICAgIHZlcnNpb246ICcle2ZyZWVkZXNrdG9w LXNkay1mbGF0cGFrLWJyYW5jaH0nCisKICAgICBFeHRlbnNpb24gb3JnLmZyZWVkZXNrdG9wLlNk ay5FeHRlbnNpb246CiAgICAgICBzdWJkaXJlY3RvcmllczogJ3RydWUnCiAgICAgICBkaXJlY3Rv cnk6IGxpYi9zZGsK