235486 2022-01-23 00:21:35 -0800 [GTK][a11y] Test accessibility/url-test.html fails with ATSPI 2022-01-24 08:18:49 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 230253 1 cgarcia webkit-unassigned bugs-noreply darin oldest_to_newest 1833075 0 cgarcia 2022-01-23 00:21:35 -0800 PASS element.url.indexOf('url-test1.html') != -1 is true -PASS element.url.indexOf('url-test2.html') != -1 is true +FAIL element.url.indexOf('url-test2.html') != -1 should be true. Was false. PASS element.url.indexOf('url-test3.png') != -1 is true PASS successfullyParsed is true url-test2.html is actually the fragment id, and we are getting just the path when removing the base path. 1833076 1 449746 cgarcia 2022-01-23 00:23:28 -0800 Created attachment 449746 Patch 1833110 2 449746 darin 2022-01-23 10:58:30 -0800 Comment on attachment 449746 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449746&action=review > Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1387 > + auto index = stringURL.find("LayoutTests"); Not great that we have to hardcode the directory name here. I don’t think we do that other places in the test runners. 1833332 3 cgarcia 2022-01-24 08:18:49 -0800 Committed r288444 (246333@trunk): <https://commits.webkit.org/246333@trunk> 449746 2022-01-23 00:23:28 -0800 2022-01-23 10:58:30 -0800 Patch wtr-atspi-url.diff text/plain 2009 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwODRm ZTU4MDUyNWIuLjYyZDBmNmQ0Y2NlZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAxLTIzICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVthMTF5XSBU ZXN0IGFjY2Vzc2liaWxpdHkvdXJsLXRlc3QuaHRtbCBmYWlscyB3aXRoIEFUU1BJCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU0ODYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnN1cmUgd2UgZG9uJ3Qg cmVtb3ZlIHRoZSBmcmFnbWVudCBpZCBvZiBVUkwgd2hlbiByZW1vdmluZyB0aGUgYmFzZSBwYXRo LgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdHNwaS9BY2Nl c3NpYmlsaXR5VUlFbGVtZW50QXRzcGkuY3BwOgorICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5 VUlFbGVtZW50Ojp1cmwpOgorCiAyMDIyLTAxLTE4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVthMTF5XSBTdG9wIHJlZ2lzdGVyaW5n IHRoZSB0cmVlIHdoZW4gY2xpZW50cyBhcmUgY29ubmVjdGVkIHdpdGggQVRTUEkKZGlmZiAtLWdp dCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRzcGkvQWNjZXNzaWJp bGl0eVVJRWxlbWVudEF0c3BpLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRC dW5kbGUvYXRzcGkvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0c3BpLmNwcAppbmRleCA1ZjkwNTU1 MjYwZTIuLjExYjdmM2U2ZDg2NCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9J bmplY3RlZEJ1bmRsZS9hdHNwaS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRzcGkuY3BwCisrKyBi L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRzcGkvQWNjZXNzaWJpbGl0 eVVJRWxlbWVudEF0c3BpLmNwcApAQCAtMTM4MSwxNiArMTM4MSwxNCBAQCBKU1JldGFpblB0cjxK U1N0cmluZ1JlZj4gQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dXJsKCkKICAgICBpZiAoYXhVUkwu aXNOdWxsKCkpCiAgICAgICAgIHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygi QVhVUkw6IChudWxsKSIpOwogCisgICAgYXV0byBzdHJpbmdVUkwgPSBheFVSTC5zdHJpbmcoKTsK ICAgICBpZiAoYXhVUkwuaXNMb2NhbEZpbGUoKSkgewogICAgICAgICAvLyBEbyBub3QgZXhwb3Nl IGFic29sdXRlIHBhdGhzLgotICAgICAgICBhdXRvIHBhdGggPSBheFVSTC5maWxlU3lzdGVtUGF0 aCgpOwotICAgICAgICBhdXRvIGluZGV4ID0gcGF0aC5maW5kKCJMYXlvdXRUZXN0cyIpOworICAg ICAgICBhdXRvIGluZGV4ID0gc3RyaW5nVVJMLmZpbmQoIkxheW91dFRlc3RzIik7CiAgICAgICAg IGlmIChpbmRleCAhPSBub3RGb3VuZCkKLSAgICAgICAgICAgIHBhdGggPSBwYXRoLnN1YnN0cmlu ZyhpbmRleCk7Ci0gICAgICAgIHJldHVybiBPcGFxdWVKU1N0cmluZzo6dHJ5Q3JlYXRlKG1ha2VT dHJpbmcoIkFYVVJMOiAiLCBwYXRoKSkubGVha1JlZigpOworICAgICAgICAgICAgc3RyaW5nVVJM ID0gc3RyaW5nVVJMLnN1YnN0cmluZyhpbmRleCk7CiAgICAgfQotCi0gICAgcmV0dXJuIE9wYXF1 ZUpTU3RyaW5nOjp0cnlDcmVhdGUobWFrZVN0cmluZygiQVhVUkw6ICIsIGF4VVJMLnN0cmluZygp KSkubGVha1JlZigpOworICAgIHJldHVybiBPcGFxdWVKU1N0cmluZzo6dHJ5Q3JlYXRlKG1ha2VT dHJpbmcoIkFYVVJMOiAiLCBzdHJpbmdVUkwpKS5sZWFrUmVmKCk7CiB9CiAKIGJvb2wgQWNjZXNz aWJpbGl0eVVJRWxlbWVudDo6YWRkTm90aWZpY2F0aW9uTGlzdGVuZXIoSlNWYWx1ZVJlZiBmdW5j dGlvbkNhbGxiYWNrKQo=