235484 2022-01-22 15:29:37 -0800 LocalStorage values should be 8-bit strings in memory if possible 2022-02-03 14:13:56 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 nham nham cdumez webkit-bug-importer ysuzuki oldest_to_newest 1833045 0 nham 2022-01-22 15:29:37 -0800 LocalStorage values should be 8-bit strings in memory if possible 1833047 1 449739 nham 2022-01-22 15:34:19 -0800 Created attachment 449739 Patch 1833298 2 449739 cdumez 2022-01-24 07:26:12 -0800 Comment on attachment 449739 Patch r=me 1833398 3 webkit-bug-importer 2022-01-24 11:13:08 -0800 <rdar://problem/87980407> 1837086 4 449739 nham 2022-02-03 13:34:20 -0800 Comment on attachment 449739 Patch This ended up being only neutral on Membuster. One of the websites in the benchmark has 1.4MB of LocalStorage values in its database. Unfortunately, the values are almost-ASCII but not quite; the site seems to store WebFont css in LocalStorage, and the CSS has a non-ASCII smiley face in it: @font-face { // ... src: local('☺︎'), // ... } See https://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/#smiley for more details. So the value can't actually be parsed into an 8-bit string and this optimization does nothing for that website. This is still worth doing though, so I'll land it. 1837101 5 ysuzuki 2022-02-03 14:02:17 -0800 For this kind of long-living values, making it 8bit as much as possible really makes sense! Nice 1837109 6 ews-feeder 2022-02-03 14:13:52 -0800 Committed r289078 (246784@main): <https://commits.webkit.org/246784@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449739. 449739 2022-01-22 15:34:19 -0800 2022-02-03 14:13:54 -0800 Patch bug-235484-20220122153418.patch text/plain 1744 nham U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjg5YWNmNzkzNmM1Mjk4 OTg4ZDNlZjY1OWVlMjMzMzdjYWZjMDZjZC4uZDhiYjYyOTEwMmFkN2VjMjZiYzg1MDhmNjUxYjEz MzJhZjBlZGZmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAxLTIyICBCZW4g TmhhbSAgPG5oYW1AYXBwbGUuY29tPgorCisgICAgICAgIExvY2FsU3RvcmFnZSB2YWx1ZXMgc2hv dWxkIGJlIDgtYml0IHN0cmluZ3MgaW4gbWVtb3J5IGlmIHBvc3NpYmxlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU0ODQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMb2NhbFN0b3JhZ2UgdmFsdWVzIGFy ZSBzdG9yZWQgaW50byBhIFNRTGl0ZSBjb2x1bW4gYXMgMTYtYml0IHN0cmluZ3MgYW5kIGFyZSBk ZXNlcmlhbGl6ZWQKKyAgICAgICAgYmFjayBpbnRvIG1lbW9yeSBhcyAxNi1iaXQgc3RyaW5ncy4g VG8gc2F2ZSBtZW1vcnksIHRoaXMgbWFrZXMgaXQgc28gdGhhdCB3ZSBkZXNlcmlhbGl6ZSB0aGUK KyAgICAgICAgc3RyaW5nIGludG8gYW4gOC1iaXQgc3RyaW5nIGluIG1lbW9yeSBpZiBwb3NzaWJs ZS4KKworICAgICAgICBFc3RpbWF0ZWQgd2luIG9mIH4zTUIgb24gTWVtYnVzdGVyNS4KKworICAg ICAgICAqIHBsYXRmb3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U1FMaXRlU3RhdGVtZW50Ojpjb2x1bW5CbG9iQXNTdHJpbmcpOgorCiAyMDIyLTAxLTIwICBB bGV4ZXkgU2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KIAogICAgICAgICBDYWxsYmFjayBm dW5jdGlvbnMgLyBpbnRlcmZhY2VzIHNob3VsZCB1c2UgZ2xvYmFsIG9iamVjdCBvZiBpdHMgX3Zh bHVlXyBmb3IgZXJyb3JzIGFuZCBsaWZlY3ljbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5jcHAKaW5kZXggMTcyYTAwMGI1MTVmMTExNDU2NDA3MzFm N2M0N2QxNTU5YjZjMTMzNy4uNzI1NTkwYzZmYWI4YTRhMGI2MjM3NzliNzU5N2QxZWE0NjBlM2Fi YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRlbWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5j cHAKQEAgLTI4NCw3ICsyODQsNyBAQCBTdHJpbmcgU1FMaXRlU3RhdGVtZW50Ojpjb2x1bW5CbG9i QXNTdHJpbmcoaW50IGNvbCkKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwogCiAgICAgQVNTRVJU KCEoc2l6ZSAlIHNpemVvZihVQ2hhcikpKTsKLSAgICByZXR1cm4gU3RyaW5nKHN0YXRpY19jYXN0 PGNvbnN0IFVDaGFyKj4oYmxvYiksIHNpemUgLyBzaXplb2YoVUNoYXIpKTsKKyAgICByZXR1cm4g U3RyaW5nSW1wbDo6Y3JlYXRlOEJpdElmUG9zc2libGUoc3RhdGljX2Nhc3Q8Y29uc3QgVUNoYXIq PihibG9iKSwgc2l6ZSAvIHNpemVvZihVQ2hhcikpOwogfQogCiBWZWN0b3I8dWludDhfdD4gU1FM aXRlU3RhdGVtZW50Ojpjb2x1bW5CbG9iKGludCBjb2wpCg==