235477 2022-01-22 06:37:09 -0800 What's going on with LTO_MODE? 2022-01-29 06:38:16 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build PC Linux NEW InRadar P2 Normal --- 1 mcatanzaro webkit-unassigned bugs-noreply webkit-bug-importer oldest_to_newest 1833004 0 mcatanzaro 2022-01-22 06:37:09 -0800 I notice there is an LTO_MODE CMake variable that causes ld.lld to be selected in OptionsCommon.cmake, but this makes me nervous because I don't think anything ever sets LTO_MODE. It's not a public variable, either. How is it supposed to be used? It adds its own manual -flto=${LTO_MODE} flags that would surely be redundant with the -flto=auto flags that are already used by distros that enable LTO. We might want to think about how this is supposed to work. I suppose it's OK so long as (a) nothing sets it except the end user, and (b) nothing assumes that it can be used to determine whether LTO is actually enabled. But assuming that LTO_MODE=OFF means no LTO seems very tempting. Maybe we could rename it to something like ADD_WEBKIT_LTO_FLAGS to be more clear that it's not the only way that LTO gets enabled? 1835279 1 webkit-bug-importer 2022-01-29 06:38:16 -0800 <rdar://problem/88224082>