235473 2022-01-22 01:45:18 -0800 [GTK][a11y] Do not use heap allocated timers in AccessibilityAtspi 2022-01-24 08:20:32 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 230253 1 cgarcia webkit-unassigned aboxhall andresg_22 aperez apinheiro bugs-noreply cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white oldest_to_newest 1832993 0 cgarcia 2022-01-22 01:45:18 -0800 It was needed to ensure they were constructed in the ax thread, but they are now always created in the main thread, so they can be created once in the constructor. 1832994 1 449726 cgarcia 2022-01-22 01:54:59 -0800 Created attachment 449726 Patch 1833286 2 aperez 2022-01-24 06:35:37 -0800 Nice simplification =) 1833334 3 cgarcia 2022-01-24 08:20:32 -0800 Committed r288446 (246335@trunk): <https://commits.webkit.org/246335@trunk> 449726 2022-01-22 01:54:59 -0800 2022-01-24 06:35:23 -0800 Patch wcore-atspi-timers.diff text/plain 6236 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZTRkY2JhN2U0YjguLjYyMzJlZWFjZTU1YyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDIzIEBACisyMDIyLTAxLTIyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVthMTF5XSBEbyBub3QgdXNlIGhlYXAgYWxsb2Nh dGVkIHRpbWVycyBpbiBBY2Nlc3NpYmlsaXR5QXRzcGkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTQ3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IHdhcyBuZWVkZWQgdG8gZW5zdXJlIHRoZXkgd2Vy ZSBjb25zdHJ1Y3RlZCBpbiB0aGUgYXggdGhyZWFkLCBidXQgdGhleSBhcmUgbm93IGFsd2F5cyBj cmVhdGVkIGluIHRoZSBtYWluCisgICAgICAgIHRocmVhZCwgc28gdGhleSBjYW4gYmUgY3JlYXRl ZCBvbmNlIGluIHRoZSBjb25zdHJ1Y3Rvci4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRz cGkvQWNjZXNzaWJpbGl0eUF0c3BpLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp dHlBdHNwaTo6QWNjZXNzaWJpbGl0eUF0c3BpKToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2li aWxpdHlBdHNwaTo6YWRkQ2xpZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlB dHNwaTo6cmVtb3ZlQ2xpZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlBdHNw aTo6YWRkVG9DYWNoZUlmUGVuZGluZyk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5 QXRzcGk6OmFkZEFjY2Vzc2libGUpOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eUF0 c3BpOjpjYWNoZUNsZWFyVGltZXJGaXJlZCk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmls aXR5QXRzcGk6OnNjaGVkdWxlQ2FjaGVVcGRhdGUpOiBEZWxldGVkLgorICAgICAgICAqIGFjY2Vz c2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eUF0c3BpLmg6CisKIDIwMjItMDEtMjIgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW2Ex MXldIEVtaXQgY2hpbGRyZW4tY2hhbmdlZDpyZW1vdmUgc2lnbmFsIGV2ZW4gZm9yIGlnbm9yZWQg b2JqZWN0cyB3aXRoIEFUU1BJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlBdHNwaS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlBdHNwaS5jcHAKaW5kZXggMTM5NjFjNTZhZGFhLi5i ZjQxMjk4OWUwNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRz cGkvQWNjZXNzaWJpbGl0eUF0c3BpLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlBdHNwaS5jcHAKQEAgLTM4LDYgKzM4LDE0IEBAIEFjY2Vz c2liaWxpdHlBdHNwaSYgQWNjZXNzaWJpbGl0eUF0c3BpOjpzaW5nbGV0b24oKQogICAgIHJldHVy biBhdHNwaTsKIH0KIAorQWNjZXNzaWJpbGl0eUF0c3BpOjpBY2Nlc3NpYmlsaXR5QXRzcGkoKQor ICAgIDogbV9jYWNoZVVwZGF0ZVRpbWVyKFJ1bkxvb3A6Om1haW4oKSwgdGhpcywgJkFjY2Vzc2li aWxpdHlBdHNwaTo6Y2FjaGVVcGRhdGVUaW1lckZpcmVkKQorICAgICwgbV9jYWNoZUNsZWFyVGlt ZXIoUnVuTG9vcDo6bWFpbigpLCB0aGlzLCAmQWNjZXNzaWJpbGl0eUF0c3BpOjpjYWNoZUNsZWFy VGltZXJGaXJlZCkKK3sKKyAgICBtX2NhY2hlVXBkYXRlVGltZXIuc2V0UHJpb3JpdHkoUnVuTG9v cFNvdXJjZVByaW9yaXR5OjpSdW5Mb29wRGlzcGF0Y2hlcik7CisgICAgbV9jYWNoZUNsZWFyVGlt ZXIuc2V0UHJpb3JpdHkoUnVuTG9vcFNvdXJjZVByaW9yaXR5OjpSZWxlYXNlVW51c2VkUmVzb3Vy Y2VzVGltZXIpOworfQorCiB2b2lkIEFjY2Vzc2liaWxpdHlBdHNwaTo6Y29ubmVjdChjb25zdCBT dHJpbmcmIGJ1c0FkZHJlc3MpCiB7CiAgICAgaWYgKGJ1c0FkZHJlc3MuaXNFbXB0eSgpKQpAQCAt MTkxLDcgKzE5OSw3IEBAIHZvaWQgQWNjZXNzaWJpbGl0eUF0c3BpOjphZGRDbGllbnQoY29uc3Qg Y2hhciogZGJ1c05hbWUpCiAgICAgaWYgKCFhZGRSZXN1bHQuaXNOZXdFbnRyeSkKICAgICAgICAg cmV0dXJuOwogCi0gICAgbV9jYWNoZUNsZWFyVGltZXIgPSBudWxscHRyOworICAgIG1fY2FjaGVD bGVhclRpbWVyLnN0b3AoKTsKIAogICAgIGFkZFJlc3VsdC5pdGVyYXRvci0+dmFsdWUgPSBnX2Ri dXNfY29ubmVjdGlvbl9zaWduYWxfc3Vic2NyaWJlKG1fY29ubmVjdGlvbi5nZXQoKSwgbnVsbHB0 ciwgIm9yZy5mcmVlZGVza3RvcC5EQnVzIiwgIk5hbWVPd25lckNoYW5nZWQiLCBudWxscHRyLCBk YnVzTmFtZSwKICAgICAgICAgR19EQlVTX1NJR05BTF9GTEFHU19NQVRDSF9BUkcwX05BTUVTUEFD RSwgW10oR0RCdXNDb25uZWN0aW9uKiwgY29uc3QgZ2NoYXIqLCBjb25zdCBnY2hhciosIGNvbnN0 IGdjaGFyKiwgY29uc3QgZ2NoYXIqLCBHVmFyaWFudCogcGFyYW1ldGVycywgZ3BvaW50ZXIgdXNl ckRhdGEpIHsKQEAgLTIxNywxNCArMjI1LDggQEAgdm9pZCBBY2Nlc3NpYmlsaXR5QXRzcGk6OnJl bW92ZUNsaWVudChjb25zdCBjaGFyKiBkYnVzTmFtZSkKICAgICAgICAgcmV0dXJuOwogCiAgICAg bV9jYWNoZVVwZGF0ZUxpc3QuY2xlYXIoKTsKLSAgICBtX2NhY2hlVXBkYXRlVGltZXItPnN0b3Ao KTsKLQotICAgIGlmICghbV9jYWNoZUNsZWFyVGltZXIpIHsKLSAgICAgICAgbV9jYWNoZUNsZWFy VGltZXIgPSBtYWtlVW5pcXVlPFJ1bkxvb3A6OlRpbWVyPEFjY2Vzc2liaWxpdHlBdHNwaT4+KFJ1 bkxvb3A6OmN1cnJlbnQoKSwgdGhpcywgJkFjY2Vzc2liaWxpdHlBdHNwaTo6Y2FjaGVDbGVhclRp bWVyRmlyZWQpOwotICAgICAgICBtX2NhY2hlQ2xlYXJUaW1lci0+c2V0UHJpb3JpdHkoUnVuTG9v cFNvdXJjZVByaW9yaXR5OjpSZWxlYXNlVW51c2VkUmVzb3VyY2VzVGltZXIpOwotICAgIH0KLQot ICAgIG1fY2FjaGVDbGVhclRpbWVyLT5zdGFydE9uZVNob3QoMTBfcyk7CisgICAgbV9jYWNoZVVw ZGF0ZVRpbWVyLnN0b3AoKTsKKyAgICBtX2NhY2hlQ2xlYXJUaW1lci5zdGFydE9uZVNob3QoMTBf cyk7CiB9CiAKIGJvb2wgQWNjZXNzaWJpbGl0eUF0c3BpOjpzaG91bGRFbWl0U2lnbmFsKGNvbnN0 IGNoYXIqIGludGVyZmFjZSwgY29uc3QgY2hhciogbmFtZSwgY29uc3QgY2hhciogZGV0YWlsKQpA QCAtNzg4LDggKzc5MCw4IEBAIHZvaWQgQWNjZXNzaWJpbGl0eUF0c3BpOjphZGRUb0NhY2hlSWZQ ZW5kaW5nKEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaSYgYXRzcGlPYmplCiAgICAgICAgIHJldHVy bjsKIAogICAgIGFkZFRvQ2FjaGVJZk5lZWRlZChhdHNwaU9iamVjdCk7Ci0gICAgaWYgKG1fY2Fj aGVVcGRhdGVUaW1lciAmJiBtX2NhY2hlVXBkYXRlTGlzdC5pc0VtcHR5KCkpCi0gICAgICAgIG1f Y2FjaGVVcGRhdGVUaW1lciA9IG51bGxwdHI7CisgICAgaWYgKG1fY2FjaGVVcGRhdGVMaXN0Lmlz RW1wdHkoKSkKKyAgICAgICAgbV9jYWNoZVVwZGF0ZVRpbWVyLnN0b3AoKTsKIH0KIAogdm9pZCBB Y2Nlc3NpYmlsaXR5QXRzcGk6OmNhY2hlVXBkYXRlVGltZXJGaXJlZCgpCkBAIC03OTgsMjIgKzgw MCwxNCBAQCB2b2lkIEFjY2Vzc2liaWxpdHlBdHNwaTo6Y2FjaGVVcGRhdGVUaW1lckZpcmVkKCkK ICAgICAgICAgYWRkVG9DYWNoZUlmTmVlZGVkKCptX2NhY2hlVXBkYXRlTGlzdC50YWtlRmlyc3Qo KSk7CiB9CiAKLXZvaWQgQWNjZXNzaWJpbGl0eUF0c3BpOjpzY2hlZHVsZUNhY2hlVXBkYXRlKCkK LXsKLSAgICBpZiAoIW1fY2FjaGVVcGRhdGVUaW1lcikKLSAgICAgICAgbV9jYWNoZVVwZGF0ZVRp bWVyID0gbWFrZVVuaXF1ZTxSdW5Mb29wOjpUaW1lcjxBY2Nlc3NpYmlsaXR5QXRzcGk+PihSdW5M b29wOjpjdXJyZW50KCksIHRoaXMsICZBY2Nlc3NpYmlsaXR5QXRzcGk6OmNhY2hlVXBkYXRlVGlt ZXJGaXJlZCk7Ci0KLSAgICBpZiAoIW1fY2FjaGVVcGRhdGVUaW1lci0+aXNBY3RpdmUoKSkKLSAg ICAgICAgbV9jYWNoZVVwZGF0ZVRpbWVyLT5zdGFydE9uZVNob3QoMF9zKTsKLX0KLQogdm9pZCBB Y2Nlc3NpYmlsaXR5QXRzcGk6OmFkZEFjY2Vzc2libGUoQWNjZXNzaWJpbGl0eU9iamVjdEF0c3Bp JiBhdHNwaU9iamVjdCkKIHsKICAgICBpZiAoIW1fY29ubmVjdGlvbikKICAgICAgICAgcmV0dXJu OwogCiAgICAgbV9jYWNoZVVwZGF0ZUxpc3QuYWRkKCZhdHNwaU9iamVjdCk7Ci0gICAgc2NoZWR1 bGVDYWNoZVVwZGF0ZSgpOworICAgIGlmICghbV9jYWNoZVVwZGF0ZVRpbWVyLmlzQWN0aXZlKCkp CisgICAgICAgIG1fY2FjaGVVcGRhdGVUaW1lci5zdGFydE9uZVNob3QoMF9zKTsKIH0KIAogdm9p ZCBBY2Nlc3NpYmlsaXR5QXRzcGk6OnJlbW92ZUFjY2Vzc2libGUoQWNjZXNzaWJpbGl0eU9iamVj dEF0c3BpJiBhdHNwaU9iamVjdCkKQEAgLTg0Niw4ICs4NDAsOCBAQCB2b2lkIEFjY2Vzc2liaWxp dHlBdHNwaTo6Y2FjaGVDbGVhclRpbWVyRmlyZWQoKQogICAgIG1fY2FjaGUuY2xlYXIoKTsKIAog ICAgIFJFTEVBU0VfQVNTRVJUKG1fY2FjaGVVcGRhdGVMaXN0LmlzRW1wdHkoKSk7Ci0gICAgbV9j YWNoZVVwZGF0ZVRpbWVyID0gbnVsbHB0cjsKLSAgICBtX2NhY2hlQ2xlYXJUaW1lciA9IG51bGxw dHI7CisgICAgbV9jYWNoZVVwZGF0ZVRpbWVyLnN0b3AoKTsKKyAgICBtX2NhY2hlQ2xlYXJUaW1l ci5zdG9wKCk7CiB9CiAKIG5hbWVzcGFjZSBBY2Nlc3NpYmlsaXR5IHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eUF0c3BpLmggYi9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlBdHNwaS5oCmlu ZGV4IDM1NGIxOTYwNWRhMS4uZTlmMjUyYTFlOTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlBdHNwaS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eUF0c3BpLmgKQEAgLTkwLDcg KzkwLDcgQEAgcHVibGljOgogI2VuZGlmCiAKIHByaXZhdGU6Ci0gICAgQWNjZXNzaWJpbGl0eUF0 c3BpKCkgPSBkZWZhdWx0OworICAgIEFjY2Vzc2liaWxpdHlBdHNwaSgpOwogCiAgICAgc3RydWN0 IFBlbmRpbmdSb290UmVnaXN0cmF0aW9uIHsKICAgICAgICAgUmVmPEFjY2Vzc2liaWxpdHlSb290 QXRzcGk+IHJvb3Q7CkBAIC0xMDksNyArMTA5LDYgQEAgcHJpdmF0ZToKICAgICB2b2lkIGFkZFRv Q2FjaGVJZk5lZWRlZChBY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkmKTsKICAgICB2b2lkIGFkZFRv Q2FjaGVJZlBlbmRpbmcoQWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpJik7CiAgICAgdm9pZCByZW1v dmVBY2Nlc3NpYmxlKEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaSYpOwotICAgIHZvaWQgc2NoZWR1 bGVDYWNoZVVwZGF0ZSgpOwogICAgIHZvaWQgY2FjaGVVcGRhdGVUaW1lckZpcmVkKCk7CiAgICAg dm9pZCBjYWNoZUNsZWFyVGltZXJGaXJlZCgpOwogCkBAIC0xMzksOCArMTM4LDggQEAgcHJpdmF0 ZToKICAgICB1bnNpZ25lZCBtX2NhY2hlSUQgeyAwIH07CiAgICAgSGFzaE1hcDxTdHJpbmcsIEFj Y2Vzc2liaWxpdHlPYmplY3RBdHNwaSo+IG1fY2FjaGU7CiAgICAgTGlzdEhhc2hTZXQ8UmVmUHRy PEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaT4+IG1fY2FjaGVVcGRhdGVMaXN0OwotICAgIHN0ZDo6 dW5pcXVlX3B0cjxSdW5Mb29wOjpUaW1lcjxBY2Nlc3NpYmlsaXR5QXRzcGk+PiBtX2NhY2hlVXBk YXRlVGltZXI7Ci0gICAgc3RkOjp1bmlxdWVfcHRyPFJ1bkxvb3A6OlRpbWVyPEFjY2Vzc2liaWxp dHlBdHNwaT4+IG1fY2FjaGVDbGVhclRpbWVyOworICAgIFJ1bkxvb3A6OlRpbWVyPEFjY2Vzc2li aWxpdHlBdHNwaT4gbV9jYWNoZVVwZGF0ZVRpbWVyOworICAgIFJ1bkxvb3A6OlRpbWVyPEFjY2Vz c2liaWxpdHlBdHNwaT4gbV9jYWNoZUNsZWFyVGltZXI7CiAjaWYgRU5BQkxFKERFVkVMT1BFUl9N T0RFKQogICAgIEhhc2hNYXA8dm9pZCosIE5vdGlmaWNhdGlvbk9ic2VydmVyPiBtX25vdGlmaWNh dGlvbk9ic2VydmVyczsKICNlbmRpZgo=