235465 2022-01-21 18:42:38 -0800 MediaPlayerPrivateRemote::play() and MediaPlayerPrivateRemote::pause() modify m_cachedState.paused 2022-01-28 18:43:16 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 peng.liu6 webkit-unassigned webkit-bug-importer oldest_to_newest 1832957 0 peng.liu6 2022-01-21 18:42:38 -0800 The following change is desired, but it will lead to a test timeout. (media/track/track-cues-pause-on-exit.html) diff --git a/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp b/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp index 9a6429437842f43db6da1c25011ed4a544cbf361..cd1c9eaa70f47ecb7cf09b69c8c0bbdd00f29f43 100644 --- a/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp +++ b/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp @@ -227,13 +227,11 @@ void MediaPlayerPrivateRemote::prepareToPlay() void MediaPlayerPrivateRemote::play() { - m_cachedState.paused = false; connection().send(Messages::RemoteMediaPlayerProxy::Play(), m_id); } void MediaPlayerPrivateRemote::pause() { - m_cachedState.paused = true; auto now = MonotonicTime::now(); m_cachedMediaTime += MediaTime::createWithDouble(m_rate * (now - m_cachedMediaTimeQueryTime).value()); m_cachedMediaTimeQueryTime = now; 1835214 1 webkit-bug-importer 2022-01-28 18:43:16 -0800 <rdar://problem/88214629>