235458 2022-01-21 15:18:19 -0800 Build failure with GCC 12: no matching function for call to 'end(LChar [7])' 2022-01-24 12:29:33 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235445 P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply mcatanzaro mgorse oldest_to_newest 1832908 0 mcatanzaro 2022-01-21 15:18:19 -0800 Next challenge in attempting to build with GCC 12: something is wrong with IntegerToStringConversion.h, and it's unclear how to fix it. I'll need to try a few more things.... In file included from /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/WTFString.h:30, from /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/URL.h:28, from /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/URL.cpp:28: /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/IntegerToStringConversion.h: In instantiation of 'void WTF::writeIntegerToBufferImpl(UnsignedIntegerType, CharacterType*) [with CharacterType = unsigned char; UnsignedIntegerType = short unsigned int; PositiveOrNegativeNumber NumberType = WTF::PositiveNumber]': /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/IntegerToStringConversion.h:95:84: required from 'void WTF::writeIntegerToBuffer(IntegerType, CharacterType*) [with CharacterType = unsigned char; IntegerType = short unsigned int]' /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/StringConcatenateNumbers.h:45:74: required from 'void WTF::StringTypeAdapter<Integer, typename std::enable_if<is_integral_v<CharacterType>, void>::type>::writeTo(CharacterType*) const [with CharacterType = unsigned char; Integer = short unsigned int; typename std::enable_if<is_integral_v<CharacterType>, void>::type = void]' /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/StringConcatenate.h:430:33: recursively required from 'void WTF::stringTypeAdapterAccumulator(ResultType*, Adapter, Adapters ...) [with ResultType = unsigned char; Adapter = StringTypeAdapter<char, void>; Adapters = {StringTypeAdapter<short unsigned int, void>}]' /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/StringConcatenate.h:430:33: required from 'void WTF::stringTypeAdapterAccumulator(ResultType*, Adapter, Adapters ...) [with ResultType = unsigned char; Adapter = StringTypeAdapter<StringView, void>; Adapters = {StringTypeAdapter<char, void>, StringTypeAdapter<short unsigned int, void>}]' /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/StringConcatenate.h:450:41: required from 'WTF::String WTF::tryMakeStringFromAdapters(StringTypeAdapter, StringTypeAdapters ...) [with StringTypeAdapter = StringTypeAdapter<StringView, void>; StringTypeAdapters = {StringTypeAdapter<char, void>, StringTypeAdapter<short unsigned int, void>}]' /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/StringConcatenate.h:469:37: required from 'WTF::String WTF::tryMakeString(StringTypes ...) [with StringTypes = {StringView, char, short unsigned int}]' /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/StringConcatenate.h:475:34: required from 'WTF::String WTF::makeString(StringTypes ...) [with StringTypes = {StringView, char, short unsigned int}]' /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/URL.cpp:152:26: required from here /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/IntegerToStringConversion.h:69:26: error: no matching function for call to 'end(LChar [7])' 69 | LChar* end = std::end(buf); | ~~~~~~~~^~~~~ In file included from /usr/include/c++/12/variant:36, from /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/StdLibExtras.h:32, from /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/FastMalloc.h:26, from /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/config.h:31, from /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/URL.cpp:27: /usr/include/c++/12/initializer_list:101:5: note: candidate: 'template<class _Tp> constexpr const _Tp* std::end(initializer_list<_Tp>)' 101 | end(initializer_list<_Tp> __ils) noexcept | ^~~ /usr/include/c++/12/initializer_list:101:5: note: template argument deduction/substitution failed: /builddir/build/BUILD/webkitgtk-2.35.1/Source/WTF/wtf/text/IntegerToStringConversion.h:69:26: note: mismatched types 'std::initializer_list<_Tp>' and 'LChar*' {aka 'unsigned char*'} 69 | LChar* end = std::end(buf); | ~~~~~~~~^~~~~ 1833272 1 mgorse 2022-01-24 06:15:32 -0800 I saw that, too, but only for 2.34.x. Including <string> fixes it there for me. 1833359 2 mcatanzaro 2022-01-24 09:14:13 -0800 (In reply to Mike Gorse from comment #1) > I saw that, too, but only for 2.34.x. Including <string> fixes it there for > me. Huh, wouldn't have guessed that. Thanks.... 1833390 3 mcatanzaro 2022-01-24 10:53:49 -0800 (In reply to Mike Gorse from comment #1) > I saw that, too, but only for 2.34.x. Including <string> fixes it there for > me. That indeed allows me to build 2.35.1. I will land this #include <string> anyway. Even if it's included from someplace else nowadays in trunk, it reduces the chance of trouble again in the future. 1833405 4 449833 mcatanzaro 2022-01-24 11:22:27 -0800 Created attachment 449833 Patch for landing 1833435 5 ews-feeder 2022-01-24 12:29:30 -0800 Committed r288460 (246346@main): <https://commits.webkit.org/246346@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449833. 449833 2022-01-24 11:22:27 -0800 2022-01-24 12:29:32 -0800 Patch for landing bug-235458-20220124132226.patch text/plain 1076 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRlZWVkOGYxMWQ3MTk3NjJmZTg3OTM2 YzNkOTFhYTQyZmUyMDIxMWYuLjE2NzUzMGQ5ODBhOGVhOGEyNDRlOGIyMDM0YWM3NWFlMjIxZjcy M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjItMDEtMjQgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgQnVpbGQgZmFpbHVyZSB3aXRoIEdDQyAx Mjogbm8gbWF0Y2hpbmcgZnVuY3Rpb24gZm9yIGNhbGwgdG8gJ2VuZChMQ2hhciBbN10pJworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NDU4CisKKyAg ICAgICAgVW5yZXZpZXdlZC4gSnVzdCBuZWVkIHRvICNpbmNsdWRlIDxzdHJpbmc+IGhlcmUuCisK KyAgICAgICAgKiB3dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmg6CisKIDIwMjIt MDEtMjEgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlND XSBSZWxheCBEYXRlLnBhcnNlIHJlcXVpcmVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24uaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQv SW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oCmluZGV4IDIwYWYzOTZlNjdjN2ExN2JlMDEyMDNh ZmQxOWI2NGQ4MWRjODY5YmIuLjBjOWEyZjEwYzNkMmE3YmJlZDlhNDU0NTI5M2VkMTg1OWZkYjdk YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvSW50ZWdlclRvU3RyaW5nQ29udmVy c2lvbi5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lv bi5oCkBAIC0yMSw2ICsyMSw3IEBACiAKICNwcmFnbWEgb25jZQogCisjaW5jbHVkZSA8c3RyaW5n PgogI2luY2x1ZGUgPHd0Zi90ZXh0L0xDaGFyLmg+CiAKIG5hbWVzcGFjZSBXVEYgewo=