235432 2022-01-21 02:10:27 -0800 Scrolling while focusing an element should take into account scroll margin 2022-02-15 06:54:15 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mrobinson mrobinson simon.fraser webkit-bug-importer oldest_to_newest 1832712 0 mrobinson 2022-01-21 02:10:27 -0800 CSS scroll-margin should come into play when focusing an element. The css-scroll-snap-1 [1] specification says: ``` Similarly the 'scroll-margin' property can be used on any box to adjust its visual area for the purpose of scroll-into-view operations. ``` Focusing triggers this kind of operation. 1. https://drafts.csswg.org/css-scroll-snap/ 1832713 1 449647 mrobinson 2022-01-21 02:13:48 -0800 Created attachment 449647 Patch 1834863 2 webkit-bug-importer 2022-01-28 02:11:15 -0800 <rdar://problem/88176885> 1841684 3 ews-feeder 2022-02-15 06:54:11 -0800 Committed r289810 (247271@main): <https://commits.webkit.org/247271@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449647. 449647 2022-01-21 02:13:48 -0800 2022-02-15 06:54:13 -0800 Patch bug-235432-20220121111346.patch text/plain 3525 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWMxYTE2NDg2MjdkMTll NmEwMTE3YzVlMWNmZmRkNTg4MzI0MThlMi4uNWY2YjcyYjBhNmQ2MWJkZTJkZWE5ODQ2NDNiOThk MGE1MTQ4NzRmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAxLTIxICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25Ad2Via2l0Lm9yZz4KKworICAgICAgICBTY3JvbGxpbmcg d2hpbGUgZm9jdXNpbmcgYW4gZWxlbWVudCBzaG91bGQgdGFrZSBpbnRvIGFjY291bnQgc2Nyb2xs IG1hcmdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjM1NDMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiBUaGlzIGlzIGNvdmVyZWQgYnkgZXhpc3RpbmcgV1BUIHRlc3RzLgorCisg ICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3 OjpzY3JvbGxUb0ZvY3VzZWRFbGVtZW50SW50ZXJuYWwpOiBSZXNwZWN0IHRoZSBzY3JvbGwgbWFy Z2luCisgICAgICAgIHdoZW4gZm9jdXNpbmcgYW4gZWxlbWVudC4KKwogMjAyMi0wMS0yMSAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQHdlYmtpdC5vcmc+CiAKICAgICAgICAgZWxlbWVudC5z Y3JvbGxJbnRvVmlldygpIHNvbWV0aW1lcyBkb2Vzbid0IHNjcm9sbApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuY3BwCmluZGV4IDE2YjFlMjI5NGY0NjdlYTNmMGYwNzY3MjRiZDBjMDg3MDQ4ZmVlZTYu LmRkZjQ4MjNjMGZmNThjMmU2NjVlODAyMDE0MWE5MmU5OWYyODBjMDkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAKQEAgLTI0NDAsNyArMjQ0MCw3IEBAIHZvaWQgRnJhbWVWaWV3OjpzY3Jv bGxUb0ZvY3VzZWRFbGVtZW50SW50ZXJuYWwoKQogICAgICAgICByZXR1cm47CiAKICAgICBib29s IGluc2lkZUZpeGVkOwotICAgIExheW91dFJlY3QgYWJzb2x1dGVCb3VuZHMgPSByZW5kZXJlci0+ YWJzb2x1dGVBbmNob3JSZWN0KCZpbnNpZGVGaXhlZCk7CisgICAgTGF5b3V0UmVjdCBhYnNvbHV0 ZUJvdW5kcyA9IHJlbmRlcmVyLT5hYnNvbHV0ZUFuY2hvclJlY3RXaXRoU2Nyb2xsTWFyZ2luKCZp bnNpZGVGaXhlZCk7CiAgICAgcmVuZGVyZXItPnNjcm9sbFJlY3RUb1Zpc2libGUoYWJzb2x1dGVC b3VuZHMsIGluc2lkZUZpeGVkLCB7IG1fc2VsZWN0aW9uUmV2ZWFsTW9kZUZvckZvY3VzZWRFbGVt ZW50LCBTY3JvbGxBbGlnbm1lbnQ6OmFsaWduQ2VudGVySWZOZWVkZWQsIFNjcm9sbEFsaWdubWVu dDo6YWxpZ25DZW50ZXJJZk5lZWRlZCwgU2hvdWxkQWxsb3dDcm9zc09yaWdpblNjcm9sbGluZzo6 Tm8gfSk7CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCA0YjcxYmEyZDEzZDMwNGYwYjY3NWUzNzExMzYyZjc0ODg5NTY3 ZWM1Li5iM2Y0ODZiYjc3ZWZiNGQ3OTMyYjZjYTkxNGQxYjQ3YWJlZWIzNTFmIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMjItMDEtMjEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkB3ZWJr aXQub3JnPgorCisgICAgICAgIFNjcm9sbGluZyB3aGlsZSBmb2N1c2luZyBhbiBlbGVtZW50IHNo b3VsZCB0YWtlIGludG8gYWNjb3VudCBzY3JvbGwgbWFyZ2luCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU0MzIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6IE1hcmsgdHdv IHRlc3RzIGFzIHBhc3NpbmcuCisKIDIwMjItMDEtMjEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2Jp bnNvbkB3ZWJraXQub3JnPgogCiAgICAgICAgIGVsZW1lbnQuc2Nyb2xsSW50b1ZpZXcoKSBzb21l dGltZXMgZG9lc24ndCBzY3JvbGwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3Rh dGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDZiZTUxZTE2MGRjOTc5 NmI1MmU4YjRhYjM0Yjg4ZDczNTg0ZWJiYTUuLmRhMjViZmNhZjM5YmVhNjhkZmVlZGU5NzFhYjYz YTZlYTRmYTdjYTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysr IGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNDY1NiwxMSArNDY1Niw5IEBAIHdl YmtpdC5vcmcvYi8yMTU1MzEgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3Nz LWJhY2tncm91bmRzL2JhY2tncm91CiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nz cy9jc3Mtc2Nyb2xsLXNuYXAvc2Nyb2xsLXNuYXAtcm9vdC0wMDMuaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXNjcm9sbC1z bmFwL3Njcm9sbC10YXJnZXQtYWxpZ24tMDAxLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIGlt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1zY3JvbGwtc25hcC9zY3JvbGwt dGFyZ2V0LWFsaWduLTAwMi5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi1pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mtc2Nyb2xsLXNuYXAvc2Nyb2xsLXRhcmdldC1hbGln bi0wMDMuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9jc3MvY3NzLXNjcm9sbC1zbmFwL3Njcm9sbC10YXJnZXQtc25hcC0wMDEuaHRtbCBb IEltYWdlT25seUZhaWx1cmUgXQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3Mv Y3NzLXNjcm9sbC1zbmFwL3Njcm9sbC10YXJnZXQtc25hcC0wMDIuaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQogd2Via2l0Lm9yZy9iLzIxODMyNSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2Nzcy9jc3Mtc2Nyb2xsLXNuYXAvc2Nyb2xsLXRhcmdldC1tYXJnaW4tMDAxLmh0bWwgWyBQ YXNzIEltYWdlT25seUZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzIxODMyNSBpbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mtc2Nyb2xsLXNuYXAvc2Nyb2xsLXRhcmdldC1tYXJn aW4tMDAzLmh0bWwgWyBQYXNzIEltYWdlT25seUZhaWx1cmUgXQogCiAjIENvY29hLW9ubHkKIGh0 dHAvdGVzdHMvbWVkaWEvaGxzL2hscy1oZHItc3dpdGNoLmh0bWwgWyBTa2lwIF0K