<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>235427</bug_id>
          
          <creation_ts>2022-01-20 17:37:10 -0800</creation_ts>
          <short_desc>[webkitscmpy] Stop killing finished processes</short_desc>
          <delta_ts>2022-01-21 10:32:44 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1832637</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-01-20 17:37:10 -0800</bug_when>
    <thetext>show-identifier failed with error &quot;ProcessLookupError: [Errno 3] No such process&quot; in https://build.webkit.org/#/builders/56/builds/8455/steps/4/logs/stdio

Traceback (most recent call last):
  File &quot;Tools/Scripts/git-webkit&quot;, line 69, in &lt;module&gt;
    sys.exit(program.main(
  File &quot;/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py&quot;, line 134, in main
    return parsed.main(
  File &quot;/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py&quot;, line 116, in main
    return Info.main(args, repository=repository, reference=args.argument[0], **kwargs)
  File &quot;/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py&quot;, line 56, in main
    commit = repository.find(reference, include_log=args.include_log)
  File &quot;/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py&quot;, line 169, in find
    return self.commit(
  File &quot;/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py&quot;, line 444, in commit
    self.cache.populate(branch=branch)
  File &quot;/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py&quot;, line 130, in populate
    log.kill()
  File &quot;/usr/lib/python3.8/subprocess.py&quot;, line 1943, in kill
    self.send_signal(signal.SIGKILL)
  File &quot;/usr/lib/python3.8/subprocess.py&quot;, line 1933, in send_signal
    os.kill(self.pid, sig)
ProcessLookupError: [Errno 3] No such process</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1832787</commentid>
    <comment_count>1</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-01-21 09:13:11 -0800</bug_when>
    <thetext>Looks like we&apos;re failing to check if the process is still running before killing it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1832788</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-01-21 09:13:27 -0800</bug_when>
    <thetext>&lt;rdar://problem/87887233&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1832789</commentid>
    <comment_count>3</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-01-21 09:16:43 -0800</bug_when>
    <thetext>Pull-request: https://github.com/WebKit/WebKit/pull/86</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1832807</commentid>
    <comment_count>4</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-01-21 10:32:44 -0800</bug_when>
    <thetext>246268@main (r288366)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>