235423 2022-01-20 16:07:01 -0800 [libpas] Ensure pas_allocation_callback and pas_deallocation_callback are initialized as NULL 2022-01-21 14:14:58 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki fpizlo mark.lam webkit-bug-importer oldest_to_newest 1832605 0 ysuzuki 2022-01-20 16:07:01 -0800 [JSC] Ensure pas_allocation_callback and pas_deallocation_callback are initialized as NULL 1832606 1 449618 ysuzuki 2022-01-20 16:08:20 -0800 Created attachment 449618 Patch 1832607 2 449619 ysuzuki 2022-01-20 16:09:55 -0800 Created attachment 449619 Patch 1832608 3 449619 mark.lam 2022-01-20 16:11:51 -0800 Comment on attachment 449619 Patch r=me 1832638 4 ews-feeder 2022-01-20 17:37:50 -0800 Committed r288339 (246245@main): <https://commits.webkit.org/246245@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449619. 1832639 5 webkit-bug-importer 2022-01-20 17:38:18 -0800 <rdar://problem/87859879> 1832651 6 449619 fpizlo 2022-01-20 18:47:13 -0800 Comment on attachment 449619 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449619&action=review > Source/bmalloc/libpas/src/libpas/pas_allocation_callbacks.c:33 > +pas_allocation_callback_t pas_allocation_callback = NULL; > +pas_deallocation_callback_t pas_deallocation_callback = NULL; The "_t" suffix isn't used by any types in libpas other than this. I think that the way that I would normally do this is call the type "pas_allocation_callback" and call the variable "pas_allocation_callback_instance". Saying "pas_allocation_callback_type" could be cool too. 1832882 7 ysuzuki 2022-01-21 14:00:07 -0800 Committed r288381 (246278@trunk): <https://commits.webkit.org/246278@trunk> 1832887 8 ysuzuki 2022-01-21 14:14:58 -0800 (In reply to Filip Pizlo from comment #6) > Comment on attachment 449619 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449619&action=review > > > Source/bmalloc/libpas/src/libpas/pas_allocation_callbacks.c:33 > > +pas_allocation_callback_t pas_allocation_callback = NULL; > > +pas_deallocation_callback_t pas_deallocation_callback = NULL; > > The "_t" suffix isn't used by any types in libpas other than this. I think > that the way that I would normally do this is call the type > "pas_allocation_callback" and call the variable > "pas_allocation_callback_instance". Saying "pas_allocation_callback_type" > could be cool too. Changed the typenames. 449618 2022-01-20 16:08:20 -0800 2022-01-20 16:09:53 -0800 Patch bug-235423-20220120160819.patch text/plain 3004 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggZWYyODdjMzUxYzE5YTRi ZjBjMTNhZTZiMGY2YTI0ZDBjYTMzYTVhYy4uZmNjYmNiM2MwZmM1MmQ0ZTY2ZjE4ZTQyMDFjYjk1 YmU0YTQzNmVjOCAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAxLTIwICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW0pTQ10gRW5zdXJlIHBh c19hbGxvY2F0aW9uX2NhbGxiYWNrIGFuZCBwYXNfZGVhbGxvY2F0aW9uX2NhbGxiYWNrIGFyZSBp bml0aWFsaXplZCBhcyBOVUxMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMzU0MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTb21lIGNvbXBpbGVyIG9wdGlvbnMgY2F1c2UgbGluay1mYWlsdXJlIHdoZW4g d2UgZG8gbm90IGV4cGxpY2l0bHkgaW5pdGlhbGl6ZSB0aGVzZSB2YXJpYWJsZXMKKyAgICAgICAg aW4gdGhlIEMgZmlsZSAoYnV0IGl0IGlzIG5vdCBuZWNlc3Nhcnkgc3RyaWN0bHkgc3BlYWtpbmcp LiBUaGlzIHBhdGNoIGNsZWFucyB1cCBhbmQgaW5pdGlhbGl6ZXMKKyAgICAgICAgdGhlbSB3aXRo IE5VTEwuCisKKyAgICAgICAgKiBsaWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxsb2NhdGlvbl9jYWxs YmFja3MuYzoKKyAgICAgICAgKiBsaWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxsb2NhdGlvbl9jYWxs YmFja3MuaDoKKwogMjAyMi0wMS0xOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgogCiAgICAgICAgIFtsaWJwYXNdIERpc2FibGUgUEFTX0FTU0VSVCBvbiBEYXJ3aW4gQVJNNjQg KG5vdCBpbiBBUk02NEUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xp YnBhcy9wYXNfYWxsb2NhdGlvbl9jYWxsYmFja3MuYyBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9z cmMvbGlicGFzL3Bhc19hbGxvY2F0aW9uX2NhbGxiYWNrcy5jCmluZGV4IGNmM2VlN2YyMDI4ODM0 ZjAyMmFkNTdkNGRkZjA0NDVmNmE4Y2ZmZWIuLjUwOTAxYzEzODUwMDUxY2VmOTkwYzhjYWI1YTZk NzRlZDAzNjcwOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFz L3Bhc19hbGxvY2F0aW9uX2NhbGxiYWNrcy5jCisrKyBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9z cmMvbGlicGFzL3Bhc19hbGxvY2F0aW9uX2NhbGxiYWNrcy5jCkBAIC0yOSwxNiArMjksNyBAQAog CiAjaW5jbHVkZSAicGFzX2FsbG9jYXRpb25fY2FsbGJhY2tzLmgiCiAKLXZvaWQgKCpwYXNfYWxs b2NhdGlvbl9jYWxsYmFjaykoCi0gICAgdm9pZCogcmVzdWx0aW5nX2Jhc2UsCi0gICAgc2l6ZV90 IHNpemUsCi0gICAgcGFzX2hlYXBfa2luZCBoZWFwX2tpbmQsCi0gICAgY29uc3QgY2hhciogbmFt ZSwKLSAgICBwYXNfYWxsb2NhdGlvbl9raW5kIGFsbG9jYXRpb25fa2luZCk7Ci12b2lkICgqcGFz X2RlYWxsb2NhdGlvbl9jYWxsYmFjaykoCi0gICAgdm9pZCogYmFzZSwKLSAgICBzaXplX3Qgc2l6 ZSwKLSAgICBwYXNfaGVhcF9raW5kIGhlYXBfa2luZCwKLSAgICBwYXNfYWxsb2NhdGlvbl9raW5k IGFsbG9jYXRpb25fa2luZCk7CitwYXNfYWxsb2NhdGlvbl9jYWxsYmFja190IHBhc19hbGxvY2F0 aW9uX2NhbGxiYWNrID0gTlVMTDsKK3Bhc19kZWFsbG9jYXRpb25fY2FsbGJhY2tfdCBwYXNfZGVh bGxvY2F0aW9uX2NhbGxiYWNrID0gTlVMTDsKIAogI2VuZGlmIC8qIExJQlBBU19FTkFCTEVEICov CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxsb2Nh dGlvbl9jYWxsYmFja3MuaCBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19h bGxvY2F0aW9uX2NhbGxiYWNrcy5oCmluZGV4IDQzYmVhNzA1MGQyMmZiMGJiNWZlMTg4MDdjNjFh ZTU1YWYxMWVmZDUuLjFjNjE4N2E3MmU1NTQzNzY4NTI0ZDc4YzQwYzMxNzkyNTEyY2YxOTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19hbGxvY2F0aW9u X2NhbGxiYWNrcy5oCisrKyBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19h bGxvY2F0aW9uX2NhbGxiYWNrcy5oCkBAIC0zMiwxOCArMzIsMjEgQEAKIAogUEFTX0JFR0lOX0VY VEVSTl9DOwogCi1QQVNfQVBJIGV4dGVybiB2b2lkICgqcGFzX2FsbG9jYXRpb25fY2FsbGJhY2sp KAordHlwZWRlZiB2b2lkKCpwYXNfYWxsb2NhdGlvbl9jYWxsYmFja190KSgKICAgICB2b2lkKiBy ZXN1bHRpbmdfYmFzZSwKICAgICBzaXplX3Qgc2l6ZSwKICAgICBwYXNfaGVhcF9raW5kIGhlYXBf a2luZCwKICAgICBjb25zdCBjaGFyKiBuYW1lLAogICAgIHBhc19hbGxvY2F0aW9uX2tpbmQgYWxs b2NhdGlvbl9raW5kKTsKLVBBU19BUEkgZXh0ZXJuIHZvaWQgKCpwYXNfZGVhbGxvY2F0aW9uX2Nh bGxiYWNrKSgKK3R5cGVkZWYgdm9pZCgqcGFzX2RlYWxsb2NhdGlvbl9jYWxsYmFja190KSgKICAg ICB2b2lkKiBiYXNlLAogICAgIHNpemVfdCBzaXplLCAvKiBUaGlzIGlzIHplcm8gZm9yIG5vbi1m cmVlIGhlYXBzIGxpa2UgdXRpbGl0eS4gKi8KICAgICBwYXNfaGVhcF9raW5kIGhlYXBfa2luZCwK ICAgICBwYXNfYWxsb2NhdGlvbl9raW5kIGFsbG9jYXRpb25fa2luZCk7CiAKK1BBU19BUEkgZXh0 ZXJuIHBhc19hbGxvY2F0aW9uX2NhbGxiYWNrX3QgcGFzX2FsbG9jYXRpb25fY2FsbGJhY2s7CitQ QVNfQVBJIGV4dGVybiBwYXNfZGVhbGxvY2F0aW9uX2NhbGxiYWNrX3QgcGFzX2RlYWxsb2NhdGlv bl9jYWxsYmFjazsKKwogc3RhdGljIGlubGluZSB2b2lkIHBhc19kaWRfYWxsb2NhdGUoCiAgICAg dm9pZCogcmVzdWx0aW5nX2Jhc2UsCiAgICAgc2l6ZV90IHNpemUsCg== 449619 2022-01-20 16:09:55 -0800 2022-01-20 17:37:51 -0800 Patch bug-235423-20220120160954.patch text/plain 3007 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggZWYyODdjMzUxYzE5YTRi ZjBjMTNhZTZiMGY2YTI0ZDBjYTMzYTVhYy4uYjQ1NzQ1ODA3ZGI2MmZkNmQ0YjUxYjkyOGYzMTky NTkxYzY5NTMwMiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAxLTIwICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW2xpYnBhc10gRW5zdXJl IHBhc19hbGxvY2F0aW9uX2NhbGxiYWNrIGFuZCBwYXNfZGVhbGxvY2F0aW9uX2NhbGxiYWNrIGFy ZSBpbml0aWFsaXplZCBhcyBOVUxMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzU0MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTb21lIGNvbXBpbGVyIG9wdGlvbnMgY2F1c2UgbGluay1mYWlsdXJlIHdo ZW4gd2UgZG8gbm90IGV4cGxpY2l0bHkgaW5pdGlhbGl6ZSB0aGVzZSB2YXJpYWJsZXMKKyAgICAg ICAgaW4gdGhlIEMgZmlsZSAoYnV0IGl0IGlzIG5vdCBuZWNlc3Nhcnkgc3RyaWN0bHkgc3BlYWtp bmcpLiBUaGlzIHBhdGNoIGNsZWFucyB1cCBhbmQgaW5pdGlhbGl6ZXMKKyAgICAgICAgdGhlbSB3 aXRoIE5VTEwuCisKKyAgICAgICAgKiBsaWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxsb2NhdGlvbl9j YWxsYmFja3MuYzoKKyAgICAgICAgKiBsaWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxsb2NhdGlvbl9j YWxsYmFja3MuaDoKKwogMjAyMi0wMS0xOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUu Y29tPgogCiAgICAgICAgIFtsaWJwYXNdIERpc2FibGUgUEFTX0FTU0VSVCBvbiBEYXJ3aW4gQVJN NjQgKG5vdCBpbiBBUk02NEUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3Jj L2xpYnBhcy9wYXNfYWxsb2NhdGlvbl9jYWxsYmFja3MuYyBiL1NvdXJjZS9ibWFsbG9jL2xpYnBh cy9zcmMvbGlicGFzL3Bhc19hbGxvY2F0aW9uX2NhbGxiYWNrcy5jCmluZGV4IGNmM2VlN2YyMDI4 ODM0ZjAyMmFkNTdkNGRkZjA0NDVmNmE4Y2ZmZWIuLjUwOTAxYzEzODUwMDUxY2VmOTkwYzhjYWI1 YTZkNzRlZDAzNjcwOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGli cGFzL3Bhc19hbGxvY2F0aW9uX2NhbGxiYWNrcy5jCisrKyBiL1NvdXJjZS9ibWFsbG9jL2xpYnBh cy9zcmMvbGlicGFzL3Bhc19hbGxvY2F0aW9uX2NhbGxiYWNrcy5jCkBAIC0yOSwxNiArMjksNyBA QAogCiAjaW5jbHVkZSAicGFzX2FsbG9jYXRpb25fY2FsbGJhY2tzLmgiCiAKLXZvaWQgKCpwYXNf YWxsb2NhdGlvbl9jYWxsYmFjaykoCi0gICAgdm9pZCogcmVzdWx0aW5nX2Jhc2UsCi0gICAgc2l6 ZV90IHNpemUsCi0gICAgcGFzX2hlYXBfa2luZCBoZWFwX2tpbmQsCi0gICAgY29uc3QgY2hhciog bmFtZSwKLSAgICBwYXNfYWxsb2NhdGlvbl9raW5kIGFsbG9jYXRpb25fa2luZCk7Ci12b2lkICgq cGFzX2RlYWxsb2NhdGlvbl9jYWxsYmFjaykoCi0gICAgdm9pZCogYmFzZSwKLSAgICBzaXplX3Qg c2l6ZSwKLSAgICBwYXNfaGVhcF9raW5kIGhlYXBfa2luZCwKLSAgICBwYXNfYWxsb2NhdGlvbl9r aW5kIGFsbG9jYXRpb25fa2luZCk7CitwYXNfYWxsb2NhdGlvbl9jYWxsYmFja190IHBhc19hbGxv Y2F0aW9uX2NhbGxiYWNrID0gTlVMTDsKK3Bhc19kZWFsbG9jYXRpb25fY2FsbGJhY2tfdCBwYXNf ZGVhbGxvY2F0aW9uX2NhbGxiYWNrID0gTlVMTDsKIAogI2VuZGlmIC8qIExJQlBBU19FTkFCTEVE ICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxs b2NhdGlvbl9jYWxsYmFja3MuaCBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bh c19hbGxvY2F0aW9uX2NhbGxiYWNrcy5oCmluZGV4IDQzYmVhNzA1MGQyMmZiMGJiNWZlMTg4MDdj NjFhZTU1YWYxMWVmZDUuLjFjNjE4N2E3MmU1NTQzNzY4NTI0ZDc4YzQwYzMxNzkyNTEyY2YxOTIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19hbGxvY2F0 aW9uX2NhbGxiYWNrcy5oCisrKyBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bh c19hbGxvY2F0aW9uX2NhbGxiYWNrcy5oCkBAIC0zMiwxOCArMzIsMjEgQEAKIAogUEFTX0JFR0lO X0VYVEVSTl9DOwogCi1QQVNfQVBJIGV4dGVybiB2b2lkICgqcGFzX2FsbG9jYXRpb25fY2FsbGJh Y2spKAordHlwZWRlZiB2b2lkKCpwYXNfYWxsb2NhdGlvbl9jYWxsYmFja190KSgKICAgICB2b2lk KiByZXN1bHRpbmdfYmFzZSwKICAgICBzaXplX3Qgc2l6ZSwKICAgICBwYXNfaGVhcF9raW5kIGhl YXBfa2luZCwKICAgICBjb25zdCBjaGFyKiBuYW1lLAogICAgIHBhc19hbGxvY2F0aW9uX2tpbmQg YWxsb2NhdGlvbl9raW5kKTsKLVBBU19BUEkgZXh0ZXJuIHZvaWQgKCpwYXNfZGVhbGxvY2F0aW9u X2NhbGxiYWNrKSgKK3R5cGVkZWYgdm9pZCgqcGFzX2RlYWxsb2NhdGlvbl9jYWxsYmFja190KSgK ICAgICB2b2lkKiBiYXNlLAogICAgIHNpemVfdCBzaXplLCAvKiBUaGlzIGlzIHplcm8gZm9yIG5v bi1mcmVlIGhlYXBzIGxpa2UgdXRpbGl0eS4gKi8KICAgICBwYXNfaGVhcF9raW5kIGhlYXBfa2lu ZCwKICAgICBwYXNfYWxsb2NhdGlvbl9raW5kIGFsbG9jYXRpb25fa2luZCk7CiAKK1BBU19BUEkg ZXh0ZXJuIHBhc19hbGxvY2F0aW9uX2NhbGxiYWNrX3QgcGFzX2FsbG9jYXRpb25fY2FsbGJhY2s7 CitQQVNfQVBJIGV4dGVybiBwYXNfZGVhbGxvY2F0aW9uX2NhbGxiYWNrX3QgcGFzX2RlYWxsb2Nh dGlvbl9jYWxsYmFjazsKKwogc3RhdGljIGlubGluZSB2b2lkIHBhc19kaWRfYWxsb2NhdGUoCiAg ICAgdm9pZCogcmVzdWx0aW5nX2Jhc2UsCiAgICAgc2l6ZV90IHNpemUsCg==