235421 2022-01-20 14:20:18 -0800 WebAuthn API Error message poorly written for missing pubKeyCredParams 2022-05-26 14:47:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. Safari 15 Mac (Intel) macOS 11 RESOLVED FIXED InRadar P2 Minor --- 237109 1 info pascoe bfulgham ews-watchlist jiewen_tan pascoe webkit-bug-importer oldest_to_newest 1832582 0 info 2022-01-20 14:20:18 -0800 Hello all, After doing regression testing for our (ForgeRock) SDK and its WebAuthn implementation, we came across this error in Safari that was impossible to understand: > No desired properties of the to be created credential are provided The only thing that helped us figure out the underlying issue (after a Google search) was the code comment above this line of code in your Github repo: https://github.com/WebKit/webkit/blob/main/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp#L143. I would like to suggest that this error message be rewritten to help others find the cause of the error. Thanks, Justin 1832768 1 webkit-bug-importer 2022-01-21 08:24:23 -0800 <rdar://problem/87884875> 1844926 2 452915 pascoe 2022-02-22 16:36:16 -0800 Created attachment 452915 Patch 1845176 3 452991 pascoe 2022-02-23 09:38:33 -0800 Created attachment 452991 Patch 1845197 4 452991 bfulgham 2022-02-23 10:06:41 -0800 Comment on attachment 452991 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452991&action=review > Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:144 > + promise.reject(Exception { NotSupportedError, "No desired properties of the to be created credential are provided (No valid values in options.pubKeyCredParams)."_s }); This message is strangely worded. Is it defined by a spec? Actually, doesn't step 10 say [1]: [... if options.pubKeyCredParams's size is zero]: "ero Append the following pairs of PublicKeyCredentialType and COSEAlgorithmIdentifier values to credTypesAndPubKeyAlgs: public-key and -7 ("ES256"). public-key and -257 ("RS256"). [1] "https://www.w3.org/TR/webauthn-2/#CreateCred-DetermineRpId 1845198 5 452991 bfulgham 2022-02-23 10:09:03 -0800 Comment on attachment 452991 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452991&action=review >> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:144 >> + promise.reject(Exception { NotSupportedError, "No desired properties of the to be created credential are provided (No valid values in options.pubKeyCredParams)."_s }); > > This message is strangely worded. Is it defined by a spec? > > Actually, doesn't step 10 say [1]: > > [... if options.pubKeyCredParams's size is zero]: "ero > Append the following pairs of PublicKeyCredentialType and COSEAlgorithmIdentifier values to credTypesAndPubKeyAlgs: > > public-key and -7 ("ES256"). > public-key and -257 ("RS256"). > > [1] "https://www.w3.org/TR/webauthn-2/#CreateCred-DetermineRpId At any rate, maybe the message could be something like: "Unable to create a credential because options.pubKeyCredParams is empty"? 1845294 6 453021 pascoe 2022-02-23 13:33:33 -0800 Created attachment 453021 Patch 1845295 7 453021 bfulgham 2022-02-23 13:34:20 -0800 Comment on attachment 453021 Patch r=me 1845323 8 ews-feeder 2022-02-23 14:34:58 -0800 Committed r290392 (247706@main): <https://commits.webkit.org/247706@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453021. 1872128 9 bfulgham 2022-05-26 14:47:10 -0700 This fix shipped with Safari 15.5 (all platforms). 452915 2022-02-22 16:36:16 -0800 2022-02-23 09:38:32 -0800 Patch bug-235421-20220222163615.patch text/plain 2032 pascoe U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGJjZWUxYTYwMzAwYzMz YzMzMzM1Y2E1N2ZlOTY4ZTQ5Y2MzNGFmNy4uZGJlMjk2ZTQ4M2U3YmQ1MjM3MmFmZTVkMzM1YzA5 ZjlmMzZmOWE0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAyLTIyICBKIFBh c2NvZSAgPGpfcGFzY29lQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIEltcHJvdmUg ZXJyb3IgbWVzc2FnZSBmb3IgbWlzc2luZyBwdWJLZXlDcmVkUGFyYW1zCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU0MjEKKyAgICAgICAgcmRhcjov Lzg3ODg0ODc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2UgaGF2ZSBzZWVuIGNvbmZ1c2lvbiBmcm9tIGxpYnJhcnkgYXV0aG9ycyBhcm91bmQgdGhl IGxhbmd1YWdlCisgICAgICAgIHVzZWQgaW4gdGhpcyBlcnJvciBub3QgaW5kaWNhdGluZyBlbm91 Z2ggaW5mb3JtYXRpb24gYWJvdXQgd2hhdAorICAgICAgICB0aGUgcHJvYmxlbSBpcy4gVGhpcyBw YXRjaCBhZGRzIGFkZGl0aW9uYWwgaW5mb3JtYXRpb24sIHVzZWZ1bAorICAgICAgICB0byBkZXZl bG9wZXJzIHNlZWluZyB0aGlzIGVycm9yLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdXRobi9B dXRoZW50aWNhdG9yQ29vcmRpbmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXV0aGVudGlj YXRvckNvb3JkaW5hdG9yOjpjcmVhdGUgY29uc3QpOgorCiAyMDIyLTAyLTIyICBGcsOpZMOpcmlj IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAgICAgICAgIG51bGwgcHRyIGRlcmVmIHZpYSBX ZWJYUlN5c3RlbTo6cmVxdWVzdFNlc3Npb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2ViYXV0aG4vQXV0aGVudGljYXRvckNvb3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViYXV0aG4vQXV0aGVudGljYXRvckNvb3JkaW5hdG9yLmNwcAppbmRleCA1 NDk2NWZmMmVhZWNlYWU3ZWM4ODcwMGVjNjJmMTQzNzljN2ZkYTFlLi44MWQ1ODQ1YTUyMDkxZWRk ZGVkZjk5ZTA0M2Y1MzJkODYxZGE0YzFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3dlYmF1dGhuL0F1dGhlbnRpY2F0b3JDb29yZGluYXRvci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy93ZWJhdXRobi9BdXRoZW50aWNhdG9yQ29vcmRpbmF0b3IuY3BwCkBAIC0x NDEsNyArMTQxLDcgQEAgdm9pZCBBdXRoZW50aWNhdG9yQ29vcmRpbmF0b3I6OmNyZWF0ZShjb25z dCBEb2N1bWVudCYgZG9jdW1lbnQsIGNvbnN0IFB1YmxpY0tleUMKICAgICAvLyBNb3N0IG9mIHRo ZSBqb2JzIGFyZSBkb25lIGJ5IGJpbmRpbmdzLiBIb3dldmVyLCB3ZSBjYW4ndCBrbm93IGlmIHRo ZSBKU1ZhbHVlIG9mIG9wdGlvbnMucHViS2V5Q3JlZFBhcmFtcwogICAgIC8vIGlzIGVtcHR5IG9y IG5vdC4gUmV0dXJuIE5vdFN1cHBvcnRlZEVycm9yIGFzIGxvbmcgYXMgaXQgaXMgZW1wdHkuCiAg ICAgaWYgKG9wdGlvbnMucHViS2V5Q3JlZFBhcmFtcy5pc0VtcHR5KCkpIHsKLSAgICAgICAgcHJv bWlzZS5yZWplY3QoRXhjZXB0aW9uIHsgTm90U3VwcG9ydGVkRXJyb3IsICJObyBkZXNpcmVkIHBy b3BlcnRpZXMgb2YgdGhlIHRvIGJlIGNyZWF0ZWQgY3JlZGVudGlhbCBhcmUgcHJvdmlkZWQuIl9z IH0pOworICAgICAgICBwcm9taXNlLnJlamVjdChFeGNlcHRpb24geyBOb3RTdXBwb3J0ZWRFcnJv ciwgIk5vIGRlc2lyZWQgcHJvcGVydGllcyBvZiB0aGUgdG8gYmUgY3JlYXRlZCBjcmVkZW50aWFs IGFyZSBwcm92aWRlZCAoTm8gdmFsaWQgdmFsdWVzIGluIG9wdGlvbnMucHViS2V5Q3JlZFBhcmFt cykuIl9zIH0pOwogICAgICAgICByZXR1cm47CiAgICAgfQogCg== 452991 2022-02-23 09:38:33 -0800 2022-02-23 13:33:31 -0800 Patch bug-235421-20220223093833.patch text/plain 3663 pascoe U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA5M2U1ZjI2MTY1MDI3 MGI3NTc2ZTQ2YTg3YzFkMWQ4OTAyMGRiZC4uOGIyZmNkNWUyMzhlNjYzOWZiNzhlODdlZDQ2OTI0 MzU1YzYwMTgxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAyLTIyICBKIFBh c2NvZSAgPGpfcGFzY29lQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIEltcHJvdmUg ZXJyb3IgbWVzc2FnZSBmb3IgbWlzc2luZyBwdWJLZXlDcmVkUGFyYW1zCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU0MjEKKyAgICAgICAgcmRhcjov Lzg3ODg0ODc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2UgaGF2ZSBzZWVuIGNvbmZ1c2lvbiBmcm9tIGxpYnJhcnkgYXV0aG9ycyBhcm91bmQgdGhl IGxhbmd1YWdlCisgICAgICAgIHVzZWQgaW4gdGhpcyBlcnJvciBub3QgaW5kaWNhdGluZyBlbm91 Z2ggaW5mb3JtYXRpb24gYWJvdXQgd2hhdAorICAgICAgICB0aGUgcHJvYmxlbSBpcy4gVGhpcyBw YXRjaCBhZGRzIGFkZGl0aW9uYWwgaW5mb3JtYXRpb24sIHVzZWZ1bAorICAgICAgICB0byBkZXZl bG9wZXJzIHNlZWluZyB0aGlzIGVycm9yLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdXRobi9B dXRoZW50aWNhdG9yQ29vcmRpbmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXV0aGVudGlj YXRvckNvb3JkaW5hdG9yOjpjcmVhdGUgY29uc3QpOgorCiAyMDIyLTAyLTIzICBEaWVnbyBQaW5v IEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gVW5yZXZpZXdlZCwg YnVpbGQgZml4IGZvciBEZWJpYW4gU3RhYmxlIGFmdGVyIHIyOTAzNjYKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vQXV0aGVudGljYXRvckNvb3JkaW5hdG9yLmNw cCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vQXV0aGVudGljYXRvckNvb3JkaW5h dG9yLmNwcAppbmRleCBkNDAwNzUxN2FmZmZjM2Y5NGQzYWY3MTllZDk5ZDlmOThkYzdkYjQxLi45 YjYzYjQwOWZmMWZlMWY5YzU3MDg1NmYzZjExYmFhMmY5NTc3MWM3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1dGhuL0F1dGhlbnRpY2F0b3JDb29yZGluYXRvci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRobi9BdXRoZW50aWNhdG9yQ29vcmRp bmF0b3IuY3BwCkBAIC0xNDEsNyArMTQxLDcgQEAgdm9pZCBBdXRoZW50aWNhdG9yQ29vcmRpbmF0 b3I6OmNyZWF0ZShjb25zdCBEb2N1bWVudCYgZG9jdW1lbnQsIGNvbnN0IFB1YmxpY0tleUMKICAg ICAvLyBNb3N0IG9mIHRoZSBqb2JzIGFyZSBkb25lIGJ5IGJpbmRpbmdzLiBIb3dldmVyLCB3ZSBj YW4ndCBrbm93IGlmIHRoZSBKU1ZhbHVlIG9mIG9wdGlvbnMucHViS2V5Q3JlZFBhcmFtcwogICAg IC8vIGlzIGVtcHR5IG9yIG5vdC4gUmV0dXJuIE5vdFN1cHBvcnRlZEVycm9yIGFzIGxvbmcgYXMg aXQgaXMgZW1wdHkuCiAgICAgaWYgKG9wdGlvbnMucHViS2V5Q3JlZFBhcmFtcy5pc0VtcHR5KCkp IHsKLSAgICAgICAgcHJvbWlzZS5yZWplY3QoRXhjZXB0aW9uIHsgTm90U3VwcG9ydGVkRXJyb3Is ICJObyBkZXNpcmVkIHByb3BlcnRpZXMgb2YgdGhlIHRvIGJlIGNyZWF0ZWQgY3JlZGVudGlhbCBh cmUgcHJvdmlkZWQuIl9zIH0pOworICAgICAgICBwcm9taXNlLnJlamVjdChFeGNlcHRpb24geyBO b3RTdXBwb3J0ZWRFcnJvciwgIk5vIGRlc2lyZWQgcHJvcGVydGllcyBvZiB0aGUgdG8gYmUgY3Jl YXRlZCBjcmVkZW50aWFsIGFyZSBwcm92aWRlZCAoTm8gdmFsaWQgdmFsdWVzIGluIG9wdGlvbnMu cHViS2V5Q3JlZFBhcmFtcykuIl9zIH0pOwogICAgICAgICByZXR1cm47CiAgICAgfQogCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggNWZjOGYzMmE4OGM4NWI3MDZmYmNhZGE5YWNjNmQ1ZjZlODMxYjM4MC4uODM4NTBiNzU0NWNi YTgwYzNjZmJhYjk5NGRlZDZlZWVlNzJhNDNlZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIy LTAyLTIzICBKIFBhc2NvZSAgPGpfcGFzY29lQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0 aG5dIEltcHJvdmUgZXJyb3IgbWVzc2FnZSBmb3IgbWlzc2luZyBwdWJLZXlDcmVkUGFyYW1zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU0MjEKKyAg ICAgICAgcmRhcjovLzg3ODg0ODc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVXBkYXRlIHRlc3QgdG8gcmVmbGVjdCBuZXcgZXJyb3IgbWVzc2FnZS4K KworICAgICAgICAqIGh0dHAvd3B0L3dlYmF1dGhuL3B1YmxpYy1rZXktY3JlZGVudGlhbC1jcmVh dGUtZmFpbHVyZS5odHRwcy5odG1sOgorCiAyMDIyLTAyLTIzICBBbGVqYW5kcm8gRy4gQ2FzdHJv ICA8YWxleEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5pbmcu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3dwdC93ZWJhdXRobi9wdWJsaWMta2V5LWNy ZWRlbnRpYWwtY3JlYXRlLWZhaWx1cmUuaHR0cHMuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvd3B0 L3dlYmF1dGhuL3B1YmxpYy1rZXktY3JlZGVudGlhbC1jcmVhdGUtZmFpbHVyZS5odHRwcy5odG1s CmluZGV4IDIzNTFjMjE2YTExMGE1NDE5ZGVkZWEzYTU1ZDc2ZTU4NmZmZjY1YzUuLmVjYWY4ZGFk OTBmY2QyYjc4ZTZhMDUxYzc3NjlmM2ZhNDZiNjU5OTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2h0dHAvd3B0L3dlYmF1dGhuL3B1YmxpYy1rZXktY3JlZGVudGlhbC1jcmVhdGUtZmFpbHVyZS5o dHRwcy5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvd3B0L3dlYmF1dGhuL3B1YmxpYy1rZXkt Y3JlZGVudGlhbC1jcmVhdGUtZmFpbHVyZS5odHRwcy5odG1sCkBAIC02OCw3ICs2OCw3IEBACiAg ICAgICAgIH07CiAKICAgICAgICAgcmV0dXJuIHByb21pc2VSZWplY3RzKHQsICJOb3RTdXBwb3J0 ZWRFcnJvciIsCi0gICAgICAgICAgICBuYXZpZ2F0b3IuY3JlZGVudGlhbHMuY3JlYXRlKG9wdGlv bnMpLCAiTm8gZGVzaXJlZCBwcm9wZXJ0aWVzIG9mIHRoZSB0byBiZSBjcmVhdGVkIGNyZWRlbnRp YWwgYXJlIHByb3ZpZGVkLiIpOworICAgICAgICAgICAgbmF2aWdhdG9yLmNyZWRlbnRpYWxzLmNy ZWF0ZShvcHRpb25zKSwgIk5vIGRlc2lyZWQgcHJvcGVydGllcyBvZiB0aGUgdG8gYmUgY3JlYXRl ZCBjcmVkZW50aWFsIGFyZSBwcm92aWRlZCAoTm8gdmFsaWQgdmFsdWVzIGluIG9wdGlvbnMucHVi S2V5Q3JlZFBhcmFtcykuIik7CiAgICAgfSwgIlB1YmxpY0tleUNyZWRlbnRpYWwncyBbW2NyZWF0 ZV1dIHdpdGggYW4gZW1wdHkgcHViS2V5Q3JlZFBhcmFtcyIpOwogCiAgICAgcHJvbWlzZV90ZXN0 KGZ1bmN0aW9uKHQpIHsK 453021 2022-02-23 13:33:33 -0800 2022-02-23 14:35:02 -0800 Patch bug-235421-20220223133332.patch text/plain 3597 pascoe U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNiZDAzZDZkNWZiZWYw NmE1ZDMyZGE0ZTM1YjNiMDE4MTZmMGZkZC4uYWRjMWI3NzEyNzI1YmRlZmI3NDVhYjRkZTQyNDVh MjgxN2NjMjc1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAyLTIzICBKIFBh c2NvZSAgPGpfcGFzY29lQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIEltcHJvdmUg ZXJyb3IgbWVzc2FnZSBmb3IgbWlzc2luZyBwdWJLZXlDcmVkUGFyYW1zCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU0MjEKKyAgICAgICAgcmRhcjov Lzg3ODg0ODc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2UgaGF2ZSBzZWVuIGNvbmZ1c2lvbiBmcm9tIGxpYnJhcnkgYXV0aG9ycyBhcm91bmQgdGhl IGxhbmd1YWdlCisgICAgICAgIHVzZWQgaW4gdGhpcyBlcnJvciBub3QgaW5kaWNhdGluZyBlbm91 Z2ggaW5mb3JtYXRpb24gYWJvdXQgd2hhdAorICAgICAgICB0aGUgcHJvYmxlbSBpcy4gVGhpcyBw YXRjaCBhZGRzIGFkZGl0aW9uYWwgaW5mb3JtYXRpb24sIHVzZWZ1bAorICAgICAgICB0byBkZXZl bG9wZXJzIHNlZWluZyB0aGlzIGVycm9yLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdXRobi9B dXRoZW50aWNhdG9yQ29vcmRpbmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXV0aGVudGlj YXRvckNvb3JkaW5hdG9yOjpjcmVhdGUgY29uc3QpOgorCiAyMDIyLTAyLTIzICBKIFBhc2NvZSAg PGpfcGFzY29lQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQXV0aG5dIHVzZXJIYW5kbGUgbm90 IG1hcmtlZCBudWxsYWJsZSBpbiBfV0tXZWJBdXRoZW50aWNhdGlvbkFzc2VydGlvblJlc3BvbnNl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1dGhuL0F1dGhlbnRpY2F0 b3JDb29yZGluYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1dGhuL0F1dGhl bnRpY2F0b3JDb29yZGluYXRvci5jcHAKaW5kZXggZDQwMDc1MTdhZmZmYzNmOTRkM2FmNzE5ZWQ5 OWQ5Zjk4ZGM3ZGI0MS4uNTU2MWZlYzBjZGRjZmRmNzBhZTQzNjNlOGNhMTU0OTFlOGFlYjMzMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRobi9BdXRoZW50aWNhdG9y Q29vcmRpbmF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vQXV0 aGVudGljYXRvckNvb3JkaW5hdG9yLmNwcApAQCAtMTQxLDcgKzE0MSw3IEBAIHZvaWQgQXV0aGVu dGljYXRvckNvb3JkaW5hdG9yOjpjcmVhdGUoY29uc3QgRG9jdW1lbnQmIGRvY3VtZW50LCBjb25z dCBQdWJsaWNLZXlDCiAgICAgLy8gTW9zdCBvZiB0aGUgam9icyBhcmUgZG9uZSBieSBiaW5kaW5n cy4gSG93ZXZlciwgd2UgY2FuJ3Qga25vdyBpZiB0aGUgSlNWYWx1ZSBvZiBvcHRpb25zLnB1Yktl eUNyZWRQYXJhbXMKICAgICAvLyBpcyBlbXB0eSBvciBub3QuIFJldHVybiBOb3RTdXBwb3J0ZWRF cnJvciBhcyBsb25nIGFzIGl0IGlzIGVtcHR5LgogICAgIGlmIChvcHRpb25zLnB1YktleUNyZWRQ YXJhbXMuaXNFbXB0eSgpKSB7Ci0gICAgICAgIHByb21pc2UucmVqZWN0KEV4Y2VwdGlvbiB7IE5v dFN1cHBvcnRlZEVycm9yLCAiTm8gZGVzaXJlZCBwcm9wZXJ0aWVzIG9mIHRoZSB0byBiZSBjcmVh dGVkIGNyZWRlbnRpYWwgYXJlIHByb3ZpZGVkLiJfcyB9KTsKKyAgICAgICAgcHJvbWlzZS5yZWpl Y3QoRXhjZXB0aW9uIHsgTm90U3VwcG9ydGVkRXJyb3IsICJVbmFibGUgdG8gY3JlYXRlIGNyZWRl bnRpYWwgYmVjYXVzZSBvcHRpb25zLnB1YktleUNyZWRQYXJhbXMgaXMgZW1wdHkuIl9zIH0pOwog ICAgICAgICByZXR1cm47CiAgICAgfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDQ4ZjY4MTY1MDBhM2M1OTFhODg5MjE5 MzYwZGNhMjllMzkyNTJmZi4uMDQxOGQ2NDA4ZGExNmFkYTFlZDlmYjQ1NzcwYmY4NGQ5ZWM1NjYw ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTIzICBKIFBhc2NvZSAgPGpfcGFzY29l QGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIEltcHJvdmUgZXJyb3IgbWVzc2FnZSBm b3IgbWlzc2luZyBwdWJLZXlDcmVkUGFyYW1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU0MjEKKyAgICAgICAgcmRhcjovLzg3ODg0ODc1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRlc3Qg dG8gcmVmbGVjdCBuZXcgZXJyb3IgbWVzc2FnZS4KKworICAgICAgICAqIGh0dHAvd3B0L3dlYmF1 dGhuL3B1YmxpYy1rZXktY3JlZGVudGlhbC1jcmVhdGUtZmFpbHVyZS5odHRwcy5odG1sOgorCiAy MDIyLTAyLTIzICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkIGdhcmRlbmluZyBmb3IgR1BVIFByb2Nlc3MgYm90LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaHR0cC93cHQvd2ViYXV0aG4vcHVibGljLWtleS1jcmVkZW50aWFsLWNyZWF0ZS1mYWlsdXJl Lmh0dHBzLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC93ZWJhdXRobi9wdWJsaWMta2V5LWNy ZWRlbnRpYWwtY3JlYXRlLWZhaWx1cmUuaHR0cHMuaHRtbAppbmRleCAyMzUxYzIxNmExMTBhNTQx OWRlZGVhM2E1NWQ3NmU1ODZmZmY2NWM1Li5hYmMzNDU1OGU5YjNhN2RlMGNkYjQwZmQyMDIzMmYy MTZmZWY5ZDc1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3dwdC93ZWJhdXRobi9wdWJs aWMta2V5LWNyZWRlbnRpYWwtY3JlYXRlLWZhaWx1cmUuaHR0cHMuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9odHRwL3dwdC93ZWJhdXRobi9wdWJsaWMta2V5LWNyZWRlbnRpYWwtY3JlYXRlLWZhaWx1 cmUuaHR0cHMuaHRtbApAQCAtNjgsNyArNjgsNyBAQAogICAgICAgICB9OwogCiAgICAgICAgIHJl dHVybiBwcm9taXNlUmVqZWN0cyh0LCAiTm90U3VwcG9ydGVkRXJyb3IiLAotICAgICAgICAgICAg bmF2aWdhdG9yLmNyZWRlbnRpYWxzLmNyZWF0ZShvcHRpb25zKSwgIk5vIGRlc2lyZWQgcHJvcGVy dGllcyBvZiB0aGUgdG8gYmUgY3JlYXRlZCBjcmVkZW50aWFsIGFyZSBwcm92aWRlZC4iKTsKKyAg ICAgICAgICAgIG5hdmlnYXRvci5jcmVkZW50aWFscy5jcmVhdGUob3B0aW9ucyksICJVbmFibGUg dG8gY3JlYXRlIGNyZWRlbnRpYWwgYmVjYXVzZSBvcHRpb25zLnB1YktleUNyZWRQYXJhbXMgaXMg ZW1wdHkuIik7CiAgICAgfSwgIlB1YmxpY0tleUNyZWRlbnRpYWwncyBbW2NyZWF0ZV1dIHdpdGgg YW4gZW1wdHkgcHViS2V5Q3JlZFBhcmFtcyIpOwogCiAgICAgcHJvbWlzZV90ZXN0KGZ1bmN0aW9u KHQpIHsK