235413 2022-01-20 11:18:00 -0800 [fast-cq] [macOS] Various tests hit debug assertions under `SearchBuffer::search` after system ICU changes 2022-01-20 15:10:29 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi darin ews-watchlist mifenton thorton webkit-bug-importer wenson_hsieh ysuzuki oldest_to_newest 1832506 0 wenson_hsieh 2022-01-20 11:18:00 -0800 rdar://87423185 1832510 1 449598 wenson_hsieh 2022-01-20 11:31:05 -0800 Created attachment 449598 Patch 1832513 2 449598 darin 2022-01-20 11:43:12 -0800 Comment on attachment 449598 Patch I think it’s likely we have other places where we are checking against U_ZERO_ERROR where we really mean U_SUCCESS. 1832518 3 wenson_hsieh 2022-01-20 11:58:35 -0800 Thanks for the review! (In reply to Darin Adler from comment #2) > Comment on attachment 449598 [details] > Patch > > I think it’s likely we have other places where we are checking against > U_ZERO_ERROR where we really mean U_SUCCESS. Yes — it's certainly possible. I locally only ran a subset of layout tests that use text iterators (`accessibility`, `fast`, and `editing`), and didn't see any other ICU-related crashes/assertions, but did not run the full suite. I think I'll land this change sooner to stop Mac layout tests from exiting early, and then see if there are any more places where we need similar treatment w.r.t. status codes from ICU. 1832540 4 darin 2022-01-20 13:01:08 -0800 (In reply to Wenson Hsieh from comment #3) > I think I'll land this change sooner to stop Mac layout tests from exiting > early, and then see if there are any more places where we need similar > treatment w.r.t. status codes from ICU. Yes, I was talking about future proofing. Completely agree about landing just this. Also, since this change is inside an assertion only, we can rest easy that it only affects debug builds. 1832578 5 ews-feeder 2022-01-20 14:09:36 -0800 Found 1 new test failure: imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html 1832590 6 ews-feeder 2022-01-20 15:10:26 -0800 Committed r288327 (246239@main): <https://commits.webkit.org/246239@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449598. 449598 2022-01-20 11:31:05 -0800 2022-01-20 15:10:28 -0800 Patch bug-235413-20220120113104.patch text/plain 2204 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjg5YWNmNzkzNmM1Mjk4 OTg4ZDNlZjY1OWVlMjMzMzdjYWZjMDZjZC4uYjUxOGIzMzJlMzI5NjUxNzdiZjA0ZTZiY2NlNGNk NmJjMDMyYThlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIyLTAxLTIwICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gVmFy aW91cyB0ZXN0cyBoaXQgZGVidWcgYXNzZXJ0aW9ucyB1bmRlciBgU2VhcmNoQnVmZmVyOjpzZWFy Y2hgIGFmdGVyIHN5c3RlbSBJQ1UgY2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NDEzCisgICAgICAgIHJkYXI6Ly84NzQyMzE4NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIHVwZ3Jh ZGluZyB0aGUgc3lzdGVtIElDVSB2ZXJzaW9uIHRvIElDVSA3MCwgbWFueSBsYXlvdXQgdGVzdHMg dGhhdCBhdHRlbXB0IHRvIHVzZSBUZXh0SXRlcmF0b3Igb24gbWFjT1MKKyAgICAgICAgKGUuZy4g dGVzdHMgaW4gYGFjY2Vzc2liaWxpdHkvbWFjYCkgaGl0IGRlYnVnIGFzc2VydGlvbnMgdW5kZXJu ZWF0aCBgV2ViQ29yZTo6U2VhcmNoQnVmZmVyOjpzZWFyY2hgOyB0aGlzIGlzCisgICAgICAgIGJl Y2F1c2UgSUNVIG5vdyBlbWl0cyBgVV9VU0lOR19ERUZBVUxUX1dBUk5JTkdgIGFzIHRoZSBlcnJv ciBjb2RlIHdoZW4gY2FsbGluZyBgdXNlYXJjaF9uZXh0KClgLCBpbnN0ZWFkIG9mCisgICAgICAg IGBVX1pFUk9fRVJST1JgLCBsaWtlIGl0IGRpZCBpbiBwcmV2aW91cyB2ZXJzaW9ucy4KKworICAg ICAgICBUaGlzIHdhcm5pbmcgaXMgcHJvcGFnYXRlZCBkdWUgdG8gSUNVIGZhbGxpbmcgYmFjayB0 byB0aGUgcm9vdCBsb2NhbGUgKGBrUm9vdExvY2FsZU5hbWVgKSB3aGVuIGNyZWF0aW5nIGFuCisg ICAgICAgIGBpY3U6OkJyZWFrSXRlcmF0b3JgLCBhbmQgYXBwZWFycyB0byBiZSBiZW5pZ24uIFdl IGNhbiBhZGRyZXNzIHRoaXMgYnkgcmVsYXhpbmcgdGhlIGRlYnVnIGFzc2VydGlvbiBpbiB0aGlz CisgICAgICAgIG1ldGhvZCB0byBqdXN0IGNoZWNrIHRoYXQgdGhlIGVycm9yIGNvZGUgaW5kaWNh dGVzIHN1Y2Nlc3MgKGkuZS4gIndhcm5pbmcsIG9yIG5vIGVycm9yIiksIHJhdGhlciB0aGFuIHN0 cmljdGx5CisgICAgICAgIGJlaW5nIGVxdWFsIHRvIGBVX1pFUk9fRVJST1JgLgorCisgICAgICAg ICogZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VhcmNoQnVm ZmVyOjpzZWFyY2gpOgorCiAyMDIyLTAxLTIwICBBbGV4ZXkgU2h2YXlrYSAgPGFzaHZheWthQGFw cGxlLmNvbT4KIAogICAgICAgICBDYWxsYmFjayBmdW5jdGlvbnMgLyBpbnRlcmZhY2VzIHNob3Vs ZCB1c2UgZ2xvYmFsIG9iamVjdCBvZiBpdHMgX3ZhbHVlXyBmb3IgZXJyb3JzIGFuZCBsaWZlY3lj bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcAppbmRleCBmYTBlMGJmOWJi NWE2NTJjNDFmMjViM2YyNmMxYjQwNGI1NzNkNjZjLi4yNTliMDcyN2UzMzU1ZWRkNDg3ZTAyYjRl NjRkNmQ2ZGRlNjJlNGQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJ dGVyYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3Bw CkBAIC0yMTkzLDcgKzIxOTMsNyBAQCBpbmxpbmUgc2l6ZV90IFNlYXJjaEJ1ZmZlcjo6c2VhcmNo KHNpemVfdCYgc3RhcnQpCiAgICAgQVNTRVJUKHN0YXR1cyA9PSBVX1pFUk9fRVJST1IpOwogCiAg ICAgaW50IG1hdGNoU3RhcnQgPSB1c2VhcmNoX25leHQoc2VhcmNoZXIsICZzdGF0dXMpOwotICAg IEFTU0VSVChzdGF0dXMgPT0gVV9aRVJPX0VSUk9SKTsKKyAgICBBU1NFUlQoVV9TVUNDRVNTKHN0 YXR1cykpOwogCiBuZXh0TWF0Y2g6CiAgICAgaWYgKCEobWF0Y2hTdGFydCA+PSAwICYmIHN0YXRp Y19jYXN0PHNpemVfdD4obWF0Y2hTdGFydCkgPCBzaXplKSkgewo=