235401 2022-01-20 06:37:54 -0800 REGRESSION(r288200): [GTK][WPE] Build broken on Ubuntu 18.04 and Debian 10 2022-02-02 12:49:42 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235336 https://bugs.webkit.org/show_bug.cgi?id=236036 InRadar P2 Normal --- 1 dpino dpino aperez benjamin bugs-noreply cdumez cmarcelo darin ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1832406 0 dpino 2022-01-20 06:37:54 -0800 Build broke on Ubuntu 18.04 after r288200. Stacktrace: /usr/lib/ccache/g++-8 -DBUILDING_GTK__=1 -DBUILDING_LLIntOffsetsExtractor -DBUILDING_WITH_CMAKE=1 -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DHAVE_CONFIG_H=1 -DJSC_COMPILATION -DJSC_GLIB_API_ENABLED -DPAS_BMALLOC=1 -DSTATICALLY_LINKED_WITH_WTF -DSTATICALLY_LINKED_WITH_bmalloc -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -IJavaScriptCore/Headers -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I. -I../../Source/JavaScriptCore -I../../Source/JavaScriptCore/API -I../../Source/JavaScriptCore/assembler -I../../Source/JavaScriptCore/b3 -I../../Source/JavaScriptCore/b3/air -I../../Source/JavaScriptCore/bindings -I../../Source/JavaScriptCore/builtins -I../../Source/JavaScriptCore/bytecode -I../../Source/JavaScriptCore/bytecompiler -I../../Source/JavaScriptCore/dfg -I../../Source/JavaScriptCore/disassembler -I../../Source/JavaScriptCore/disassembler/ARM64 -I../../Source/JavaScriptCore/disassembler/zydis/Zydis -I../../Source/JavaScriptCore/domjit -I../../Source/JavaScriptCore/ftl -I../../Source/JavaScriptCore/heap -I../../Source/JavaScriptCore/debugger -I../../Source/JavaScriptCore/inspector -I../../Source/JavaScriptCore/inspector/agents -I../../Source/JavaScriptCore/inspector/augmentable -I../../Source/JavaScriptCore/inspector/remote -I../../Source/JavaScriptCore/interpreter -I../../Source/JavaScriptCore/jit -I../../Source/JavaScriptCore/llint -I../../Source/JavaScriptCore/parser -I../../Source/JavaScriptCore/profiler -I../../Source/JavaScriptCore/runtime -I../../Source/JavaScriptCore/tools -I../../Source/JavaScriptCore/wasm -I../../Source/JavaScriptCore/wasm/js -I../../Source/JavaScriptCore/yarr -IJavaScriptCore/DerivedSources -IJavaScriptCore/DerivedSources/inspector -IJavaScriptCore/DerivedSources/runtime -IJavaScriptCore/DerivedSources/yarr -I../../Source/JavaScriptCore/API/glib -IJavaScriptCoreGLib/DerivedSources/jsc -IJavaScriptCoreGLib/Headers -I../../Source/JavaScriptCore/inspector/remote/glib -IWTF/Headers -Ibmalloc/Headers -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -fPIE -fvisibility=hidden -std=c++2a -MD -MT Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o -MF Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o.d -o Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o -c ../../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp In file included from WTF/Headers/wtf/StdLibExtras.h:33, from WTF/Headers/wtf/FastMalloc.h:26, from ../../Source/JavaScriptCore/config.h:38, from ../../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26: ../../Source/JavaScriptCore/wasm/WasmCompilationMode.h: In function ‘constexpr bool JSC::Wasm::isOSREntry(JSC::Wasm::CompilationMode)’: WTF/Headers/wtf/Assertions.h:283:49: error: call to non-‘constexpr’ function ‘void WTFCrash()’ #define CRASH_UNDER_CONSTEXPR_CONTEXT() WTFCrash() ~~~~~~~~^~ WTF/Headers/wtf/Assertions.h:651:9: note: in expansion of macro ‘CRASH_UNDER_CONSTEXPR_CONTEXT’ CRASH_UNDER_CONSTEXPR_CONTEXT(); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/JavaScriptCore/wasm/WasmCompilationMode.h:53:5: note: in expansion of macro ‘RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT’ RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT(false); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/JavaScriptCore/wasm/WasmCompilationMode.h: In function ‘constexpr bool JSC::Wasm::isAnyBBQ(JSC::Wasm::CompilationMode)’: WTF/Headers/wtf/Assertions.h:283:49: error: call to non-‘constexpr’ function ‘void WTFCrash()’ #define CRASH_UNDER_CONSTEXPR_CONTEXT() WTFCrash() ~~~~~~~~^~ WTF/Headers/wtf/Assertions.h:651:9: note: in expansion of macro ‘CRASH_UNDER_CONSTEXPR_CONTEXT’ CRASH_UNDER_CONSTEXPR_CONTEXT(); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/JavaScriptCore/wasm/WasmCompilationMode.h:68:5: note: in expansion of macro ‘RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT’ RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT(false); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/JavaScriptCore/wasm/WasmCompilationMode.h: In function ‘constexpr bool JSC::Wasm::isAnyOMG(JSC::Wasm::CompilationMode)’: WTF/Headers/wtf/Assertions.h:283:49: error: call to non-‘constexpr’ function ‘void WTFCrash()’ #define CRASH_UNDER_CONSTEXPR_CONTEXT() WTFCrash() ~~~~~~~~^~ WTF/Headers/wtf/Assertions.h:651:9: note: in expansion of macro ‘CRASH_UNDER_CONSTEXPR_CONTEXT’ CRASH_UNDER_CONSTEXPR_CONTEXT(); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/JavaScriptCore/wasm/WasmCompilationMode.h:83:5: note: in expansion of macro ‘RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT’ RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT(false); 1832408 1 449570 dpino 2022-01-20 06:47:05 -0800 Created attachment 449570 Patch 1832413 2 449570 mcatanzaro 2022-01-20 07:24:23 -0800 Comment on attachment 449570 Patch So RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT doesn't actually work. Sigh. Please use IGNORE_RETURN_TYPE_WARNINGS_BEGIN/END then, to avoid reintroducing -Wreturn-type. 1832414 3 mcatanzaro 2022-01-20 07:28:10 -0800 Actually, maybe we can fix it. 1832416 4 449574 mcatanzaro 2022-01-20 07:46:06 -0800 Created attachment 449574 Patch 1832417 5 mcatanzaro 2022-01-20 07:46:45 -0800 I think this will work, but I haven't tested it on Ubuntu 18.04. If it doesn't work, then IGNORE_RETURN_TYPE_WARNINGS_BEGIN/END is the easy solution. 1832449 6 darin 2022-01-20 08:53:49 -0800 CRASH_UNDER_CONSTEXPR_CONTEXT needs to be fixed to work on Ubuntu; if not to fix this bug, in the future. 1832469 7 mcatanzaro 2022-01-20 09:49:19 -0800 Note it's only a problem for old compiler versions. (Normal RELEASE_ASSERT() seems to work perfectly fine under constexpr already, so there doesn't seem to be a need for the _UNDER_CONSTEXPR_CONTEXT versions anymore with newer GCC, unless Clang doesn't like it.) 1832647 8 dpino 2022-01-20 18:13:23 -0800 I tested Michael's patch on Ubuntu 18.04 and it builds fine. 1833275 9 dpino 2022-01-24 06:19:19 -0800 It seems this build error is also happening in Debian 10. Debian 10 uses GCC8.3. https://build.webkit.org/#/builders/46 1833360 10 mcatanzaro 2022-01-24 09:14:39 -0800 Since this is a build break, I will land it unreviewed. 1833361 11 mcatanzaro 2022-01-24 09:15:56 -0800 Actually... a change in fundamental macros like this should be approved by one other reviewer. I will ping some reviewers. 1833412 12 449574 aperez 2022-01-24 11:37:12 -0800 Comment on attachment 449574 Patch It looks like making the constexpr-crash version of the macros expand to the corresponding implementation (as done in your patch) should have been part of the fix for bug #186536 but we missed the change there =) 1833427 13 ews-feeder 2022-01-24 12:14:53 -0800 Committed r288459 (246345@main): <https://commits.webkit.org/246345@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449574. 1833428 14 webkit-bug-importer 2022-01-24 12:15:18 -0800 <rdar://problem/87983893> 449570 2022-01-20 06:47:05 -0800 2022-01-20 07:46:02 -0800 Patch bug-235401-20220120224702.patch text/plain 1974 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4Mjc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MWMyZTY2NTlmNDFiMDYyYjE5YmRjM2Q5MWMzZTQ0MjI3NTM3NDhmLi40MTU2OTI0ZWI3MzgzOWNi N2Y1YmYzNmZmODAyN2RiZTAyOGRkMmRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMi0wMS0yMCAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFJFR1JFU0lPTihyMjg4MjAwKTogW0dUS11bV1BFXSBCdWlsZCBicm9r ZW4gb24gVWJ1bnR1IDE4LjA0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMzU0MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHdhc20vV2FzbUNvbXBpbGF0aW9uTW9kZS5oOiBSZW1vdmUgUkVMRUFTRV9B U1NFUlRfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQgCisgICAgICAgIGd1YXJkcyBhdCB0aGUgZW5k IG9mIGZ1bmN0aW9ucy4KKyAgICAgICAgKEpTQzo6V2FzbTo6aXNPU1JFbnRyeSk6CisgICAgICAg IChKU0M6Oldhc206OmlzQW55QkJRKToKKyAgICAgICAgKEpTQzo6V2FzbTo6aXNBbnlPTUcpOgor CiAyMDIyLTAxLTE5ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAg ICAgW0pTQ10gSW1wbGVtZW50IFRlbXBvcmFsLk5vdy5pbnN0YW50KCkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21Db21waWxhdGlvbk1vZGUuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93YXNtL1dhc21Db21waWxhdGlvbk1vZGUuaAppbmRleCA2ZjEzNGUzM2Vi OGViZGQzODg4ZmRiMDY4ZGY3YmZjZDBjNDIyNWZkLi4xZTNmMmYwOGVlM2JjYjFkNGE1MjAwOTkw N2EyZGQ5ZTYyMmM0YzY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9X YXNtQ29tcGlsYXRpb25Nb2RlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2Fz bUNvbXBpbGF0aW9uTW9kZS5oCkBAIC01MCw3ICs1MCw2IEBAIGNvbnN0ZXhwciBpbmxpbmUgYm9v bCBpc09TUkVudHJ5KENvbXBpbGF0aW9uTW9kZSBjb21waWxhdGlvbk1vZGUpCiAgICAgY2FzZSBD b21waWxhdGlvbk1vZGU6Ok9NR0Zvck9TUkVudHJ5TW9kZToKICAgICAgICAgcmV0dXJuIHRydWU7 CiAgICAgfQotICAgIFJFTEVBU0VfQVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05URVhUKGZhbHNl KTsKIH0KIAogY29uc3RleHByIGlubGluZSBib29sIGlzQW55QkJRKENvbXBpbGF0aW9uTW9kZSBj b21waWxhdGlvbk1vZGUpCkBAIC02NSw3ICs2NCw2IEBAIGNvbnN0ZXhwciBpbmxpbmUgYm9vbCBp c0FueUJCUShDb21waWxhdGlvbk1vZGUgY29tcGlsYXRpb25Nb2RlKQogICAgIGNhc2UgQ29tcGls YXRpb25Nb2RlOjpFbWJlZGRlckVudHJ5cG9pbnRNb2RlOgogICAgICAgICByZXR1cm4gZmFsc2U7 CiAgICAgfQotICAgIFJFTEVBU0VfQVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05URVhUKGZhbHNl KTsKIH0KIAogY29uc3RleHByIGlubGluZSBib29sIGlzQW55T01HKENvbXBpbGF0aW9uTW9kZSBj b21waWxhdGlvbk1vZGUpCkBAIC04MCw3ICs3OCw2IEBAIGNvbnN0ZXhwciBpbmxpbmUgYm9vbCBp c0FueU9NRyhDb21waWxhdGlvbk1vZGUgY29tcGlsYXRpb25Nb2RlKQogICAgIGNhc2UgQ29tcGls YXRpb25Nb2RlOjpFbWJlZGRlckVudHJ5cG9pbnRNb2RlOgogICAgICAgICByZXR1cm4gZmFsc2U7 CiAgICAgfQotICAgIFJFTEVBU0VfQVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05URVhUKGZhbHNl KTsKIH0KIAogfSB9IC8vIG5hbWVzcGFjZSBKU0M6Oldhc20K 449574 2022-01-20 07:46:06 -0800 2022-01-24 12:14:57 -0800 Patch bug-235401-20220120094605.patch text/plain 1659 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4Mjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU2NWQxYzdhMjI4MTMxMmE5YTg4YzRi MDFiMjJmZjA2MzExYzdiMDYuLjVmZDc3YmVjNDU0MDAyNGJiN2I2YjVkOWQ5N2M1ZWNmNDFkOTAy MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDEtMjAgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgUkVHUkVTSU9OKHIyODgyMDApOiBbR1RL XVtXUEVdIEJ1aWxkIGJyb2tlbiBvbiBVYnVudHUgMTguMDQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTQwMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaW1wbGVtZW50cyBXVEZfQ1JBU0hfVU5E RVJfQ09OU1RFWFBSX0NPTlRFWFQoKSBwcm9wZXJseSBmb3IgY29tcGF0aWJpbGl0eSB3aXRoIG9s ZGVyCisgICAgICAgIGNvbXBpbGVycy4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisK IDIwMjItMDEtMTkgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAg ICBbSlNDXSBJbXBsZW1lbnQgVGVtcG9yYWwuTm93Lmluc3RhbnQoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCmlu ZGV4IGJmMTFmYzE3MDgzNTg4YTkxOGFiZGZlZTRkZDgwOTBmZGYyNGI3YjIuLjU3YWU2MDZiZjdh YTJjNjFjNWQ4NGIyOGYxN2ZmMWE1MDNhNjM1ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L0Fzc2VydGlvbnMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKQEAgLTI3Mywx NCArMjczLDE0IEBAIFdURl9FWFBPUlRfUFJJVkFURSBib29sIFdURklzRGVidWdnZXJBdHRhY2hl ZCh2b2lkKTsKICNlbGlmICFFTkFCTEUoREVWRUxPUEVSX01PREUpICYmICFPUyhEQVJXSU4pCiAj aWZkZWYgX19jcGx1c3BsdXMKICNkZWZpbmUgQ1JBU0goKSBzdGQ6OmFib3J0KCkKLSNkZWZpbmUg Q1JBU0hfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQoKSBzdGQ6OmFib3J0KCkKKyNkZWZpbmUgQ1JB U0hfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQoKSBXVEZCcmVha3BvaW50VHJhcFVuZGVyQ29uc3Rl eHByQ29udGV4dCgpCiAjZWxzZQogI2RlZmluZSBDUkFTSCgpIGFib3J0KCkKLSNkZWZpbmUgQ1JB U0hfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQoKSBhYm9ydCgpCisjZGVmaW5lIENSQVNIX1VOREVS X0NPTlNURVhQUl9DT05URVhUKCkgV1RGQnJlYWtwb2ludFRyYXBVbmRlckNvbnN0ZXhwckNvbnRl eHQoKQogI2VuZGlmIC8vIF9fY3BsdXNwbHVzCiAjZWxzZQogI2RlZmluZSBDUkFTSCgpIFdURkNy YXNoKCkKLSNkZWZpbmUgQ1JBU0hfVU5ERVJfQ09OU1RFWFBSX0NPTlRFWFQoKSBXVEZDcmFzaCgp CisjZGVmaW5lIENSQVNIX1VOREVSX0NPTlNURVhQUl9DT05URVhUKCkgV1RGQnJlYWtwb2ludFRy YXBVbmRlckNvbnN0ZXhwckNvbnRleHQoKQogI2VuZGlmCiAKICNlbmRpZiAvLyAhZGVmaW5lZChD UkFTSCkK