235392 2022-01-19 20:20:13 -0800 [LFC][IFC] Implement TextUtil::directionForTextContent 2022-01-20 19:00:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1832337 0 zalan 2022-01-19 20:20:13 -0800 ssia 1832339 1 449549 zalan 2022-01-19 20:24:37 -0800 Created attachment 449549 Patch 1832448 2 449585 zalan 2022-01-20 08:52:54 -0800 Created attachment 449585 Patch 1832451 3 449585 koivisto 2022-01-20 08:58:09 -0800 Comment on attachment 449585 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449585&action=review > Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:345 > +TextDirection TextUtil::directionForTextContent(StringView content) > { > - ASSERT_NOT_IMPLEMENTED_YET(); > - return TextDirection::LTR; > + if (content.is8Bit()) > + return TextDirection::LTR; > + return ubidi_getBaseDirection(content.characters16(), content.length()) == UBIDI_RTL ? TextDirection::RTL : TextDirection::LTR; > } Nice 1832652 4 ews-feeder 2022-01-20 18:59:23 -0800 Committed r288343 (246249@main): <https://commits.webkit.org/246249@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449585. 1832653 5 webkit-bug-importer 2022-01-20 19:00:17 -0800 <rdar://problem/87862754> 449549 2022-01-19 20:24:37 -0800 2022-01-20 08:52:52 -0800 Patch bug-235392-20220119202436.patch text/plain 2064 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGEwN2FiNTlkOGU3ZTFi ZGUyNmYxZTRlOWUwYmU5NTZlOGIyMDNmNy4uNWI4Nzg4ZmU0YzQyYjkyY2M0MDQyMTYwYTYzOThm N2RjYTE5MzcxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAxLTE5ICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIEltcGxlbWVu dCBUZXh0VXRpbDo6ZGlyZWN0aW9uRm9yVGV4dENvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTM5MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExldCdzIGNoZWNrIHdpdGggdWJpZGlfZ2V0QmFz ZURpcmVjdGlvbiB3aGF0IHRoZSBjb250ZW50IGRpcmVjdGlvbiBpcy4gV2UgdXNlIHRoaXMKKyAg ICAgICAgZGlyZWN0aW9uIHZhbHVlIHRvIGRyaXZlIHRoZSBsaW5lIGJhc2VkICJjb250ZW50IGFs aWdubWVudCIuCisKKyAgICAgICAgKiBsYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS90 ZXh0L1RleHRVdGlsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6VGV4dFV0aWw6OmRp cmVjdGlvbkZvclRleHRDb250ZW50KToKKwogMjAyMi0wMS0xOSAgQWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBBZGQgTGluZUNvbnRlbnQ6OmlubGlu ZUJhc2VEaXJlY3Rpb24gdG8gc3VwcG9ydCBsaW5lIGJhc2VkIGlubGluZSBkaXJlY3Rpb24KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5l L3RleHQvVGV4dFV0aWwuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250 ZXh0cy9pbmxpbmUvdGV4dC9UZXh0VXRpbC5jcHAKaW5kZXggMWQ5YjhkZDI2ZmU0ZDAwYTBiODc3 NDhkNjkyMTRiYzdiYmJjNzdmOS4uZDYwMzhkYjExMjcyZDViZWM0YjRiNDdlOWM5NWU3MmIwMGY0 YzZkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0 cy9pbmxpbmUvdGV4dC9UZXh0VXRpbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zv cm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvdGV4dC9UZXh0VXRpbC5jcHAKQEAgLTM2LDYgKzM2LDcg QEAKICNpbmNsdWRlICJSZW5kZXJCb3guaCIKICNpbmNsdWRlICJSZW5kZXJTdHlsZS5oIgogI2lu Y2x1ZGUgIlN1cnJvZ2F0ZVBhaXJBd2FyZVRleHRJdGVyYXRvci5oIgorI2luY2x1ZGUgPHVuaWNv ZGUvdWJpZGkuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9UZXh0QnJlYWtJdGVyYXRvci5oPgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0zMzYsMTAgKzMzNywxMSBAQCBzaXplX3QgVGV4dFV0aWw6 OmZpcnN0VXNlclBlcmNlaXZlZENoYXJhY3Rlckxlbmd0aChjb25zdCBJbmxpbmVUZXh0SXRlbSYg aW5saW5lVAogICAgIHJldHVybiBuZXh0UG9zaXRpb24gLSBpbmxpbmVUZXh0SXRlbS5zdGFydCgp OwogfQogCi1UZXh0RGlyZWN0aW9uIFRleHRVdGlsOjpkaXJlY3Rpb25Gb3JUZXh0Q29udGVudChT dHJpbmdWaWV3KQorVGV4dERpcmVjdGlvbiBUZXh0VXRpbDo6ZGlyZWN0aW9uRm9yVGV4dENvbnRl bnQoU3RyaW5nVmlldyBjb250ZW50KQogewotICAgIEFTU0VSVF9OT1RfSU1QTEVNRU5URURfWUVU KCk7Ci0gICAgcmV0dXJuIFRleHREaXJlY3Rpb246OkxUUjsKKyAgICBpZiAoY29udGVudC5pczhC aXQoKSkKKyAgICAgICAgcmV0dXJuIFRleHREaXJlY3Rpb246OlJUTDsKKyAgICByZXR1cm4gdWJp ZGlfZ2V0QmFzZURpcmVjdGlvbihjb250ZW50LmNoYXJhY3RlcnMxNigpLCBjb250ZW50Lmxlbmd0 aCgpKSA9PSBVQklESV9SVEwgPyBUZXh0RGlyZWN0aW9uOjpSVEwgOiBUZXh0RGlyZWN0aW9uOjpM VFI7CiB9CiAKIH0K 449585 2022-01-20 08:52:54 -0800 2022-01-20 18:59:24 -0800 Patch bug-235392-20220120085254.patch text/plain 2064 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4Mjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzUwOWI5YzYxMjgzM2Zm ZDZmYmJkOTdmMTEzMGFiY2M5YWU2MjY4Yy4uYTk3YjEwNGM3ODc2MTE1MmNkMzNhYjI1NjRlZTIz N2IxMWZlNTM5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAxLTIwICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIEltcGxlbWVu dCBUZXh0VXRpbDo6ZGlyZWN0aW9uRm9yVGV4dENvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTM5MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExldCdzIGNoZWNrIHdpdGggdWJpZGlfZ2V0QmFz ZURpcmVjdGlvbiB3aGF0IHRoZSBjb250ZW50IGRpcmVjdGlvbiBpcy4gV2UgdXNlIHRoaXMKKyAg ICAgICAgZGlyZWN0aW9uIHZhbHVlIHRvIGRyaXZlIHRoZSBsaW5lIGJhc2VkICJjb250ZW50IGFs aWdubWVudCIuCisKKyAgICAgICAgKiBsYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS90 ZXh0L1RleHRVdGlsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6VGV4dFV0aWw6OmRp cmVjdGlvbkZvclRleHRDb250ZW50KToKKwogMjAyMi0wMS0yMCAgQWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBBZGQgTGluZUNvbnRlbnQ6OmlubGlu ZUJhc2VEaXJlY3Rpb24gdG8gc3VwcG9ydCBsaW5lIGJhc2VkIGlubGluZSBkaXJlY3Rpb24KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5l L3RleHQvVGV4dFV0aWwuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250 ZXh0cy9pbmxpbmUvdGV4dC9UZXh0VXRpbC5jcHAKaW5kZXggMWQ5YjhkZDI2ZmU0ZDAwYTBiODc3 NDhkNjkyMTRiYzdiYmJjNzdmOS4uY2QyMzFmY2QzOGY4MzZlNjM2NjZhYWFiN2EzMTc0NGU5NDll NTBiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0 cy9pbmxpbmUvdGV4dC9UZXh0VXRpbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zv cm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvdGV4dC9UZXh0VXRpbC5jcHAKQEAgLTM2LDYgKzM2LDcg QEAKICNpbmNsdWRlICJSZW5kZXJCb3guaCIKICNpbmNsdWRlICJSZW5kZXJTdHlsZS5oIgogI2lu Y2x1ZGUgIlN1cnJvZ2F0ZVBhaXJBd2FyZVRleHRJdGVyYXRvci5oIgorI2luY2x1ZGUgPHVuaWNv ZGUvdWJpZGkuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9UZXh0QnJlYWtJdGVyYXRvci5oPgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0zMzYsMTAgKzMzNywxMSBAQCBzaXplX3QgVGV4dFV0aWw6 OmZpcnN0VXNlclBlcmNlaXZlZENoYXJhY3Rlckxlbmd0aChjb25zdCBJbmxpbmVUZXh0SXRlbSYg aW5saW5lVAogICAgIHJldHVybiBuZXh0UG9zaXRpb24gLSBpbmxpbmVUZXh0SXRlbS5zdGFydCgp OwogfQogCi1UZXh0RGlyZWN0aW9uIFRleHRVdGlsOjpkaXJlY3Rpb25Gb3JUZXh0Q29udGVudChT dHJpbmdWaWV3KQorVGV4dERpcmVjdGlvbiBUZXh0VXRpbDo6ZGlyZWN0aW9uRm9yVGV4dENvbnRl bnQoU3RyaW5nVmlldyBjb250ZW50KQogewotICAgIEFTU0VSVF9OT1RfSU1QTEVNRU5URURfWUVU KCk7Ci0gICAgcmV0dXJuIFRleHREaXJlY3Rpb246OkxUUjsKKyAgICBpZiAoY29udGVudC5pczhC aXQoKSkKKyAgICAgICAgcmV0dXJuIFRleHREaXJlY3Rpb246OkxUUjsKKyAgICByZXR1cm4gdWJp ZGlfZ2V0QmFzZURpcmVjdGlvbihjb250ZW50LmNoYXJhY3RlcnMxNigpLCBjb250ZW50Lmxlbmd0 aCgpKSA9PSBVQklESV9SVEwgPyBUZXh0RGlyZWN0aW9uOjpSVEwgOiBUZXh0RGlyZWN0aW9uOjpM VFI7CiB9CiAKIH0K