235372 2022-01-19 12:22:17 -0800 [bmalloc][32-bits] Build error in libpas after r285853 2022-02-10 16:46:31 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Other Linux RESOLVED FIXED InRadar P2 Normal --- 230841 1 psaavedra psaavedra fpizlo ggaren mark.lam saam webkit-bug-importer ysuzuki oldest_to_newest 1832148 0 psaavedra 2022-01-19 12:22:17 -0800 Getting this error during compiling WPE/WebKit for an 32-bits target (ARM32) ``` tmp/work/cortexa9t2hf-neon-imx-poky-linux-gnueabi/wpewebkit/trunk+httpsAUTOINC+f8506f6a3b-r0/build/bmalloc/Headers/bmalloc/pas_utils.h: At global scope: tmp/work/cortexa9t2hf-neon-imx-poky-linux-gnueabi/wpewebkit/trunk+httpsAUTOINC+f8506f6a3b-r0/build/bmalloc/Headers/bmalloc/pas_utils.h:633:9: error: '__uint128_t' does not name a type; did you mean '__uint8_t'? 633 | typedef __uint128_t pas_pair; | ^~~~~~~~~~~ | __uint8_t tmp/work/cortexa9t2hf-neon-imx-poky-linux-gnueabi/wpewebkit/trunk+httpsAUTOINC+f8506f6a3b-r0/build/bmalloc/Headers/bmalloc/pas_utils.h:635:15: error: 'pas_pair' does not name a type ``` BENABLE_LIBPAS = 0 The error can be related with the changes done in https://trac.webkit.org/changeset/285853/webkit. In particular, with those associated to the point 8: commit cc83e6240649bfe828f932d1d7fa96f090d706b0 Author: Yusuke Suzuki <ysuzuki@apple.com> Date: Tue Nov 16 07:02:45 2021 +0000 [libpas] Build and enable libpas on 64bit JSCOnly https://bugs.webkit.org/show_bug.cgi?id=233097 Reviewed by Filip Pizlo. This patch makes libpas built on 64bit Linux. And now enabling it on JSCOnly port. libpas is built in C and tailored to the current clang. It made building libpas on GCC hard since GCC is stricter on C languages. 1. C does not handle `const` variables as constants. So libpas's config is not strictly constant in the C spec, and GCC actually rejects it. To make it built correctly, we need to build them in C++. In this patch, when building libpas via CMake, we build some libpas C files as C++. 2. GCC C++ does not allow designated initializer for array. We work-around this problem by adding cpp_initialization_t constexpr constructors only when building these headers in C++ compiler. 3. Atomic operations are using clang extension, so they cannot be built with GCC. This patch adds GCC version of these implementations. 4. Add PAS_OS(DARWIN) ifdefs for Darwin specific code (e.g. malloc handling). 5. Add explicit cast / PAS_UNUSED_PARAM since GCC emits warnings 6. Use (unsigned long long) explicit cast for printing uint64_t via `%llx` / `%llu` since uint64_t definition is `unsigned long int` in GCC (while clang's one is `unsigned long long`). 7. Reorder designated initializer for structures since not following to the definition ordering becomes compile error in GCC. [THIS] 8. Use __uint128_t for pas_pair in GCC to avoid compile error. 1832153 1 449507 psaavedra 2022-01-19 12:24:07 -0800 Created attachment 449507 patch 1832169 2 psaavedra 2022-01-19 12:30:34 -0800 128-bit integer type is only available for 64-bit targets. In >=GCC 4.6you can use __SIZEOF_INT128__ to detect it. I just uploaded a functional patch that fix the build error by checking and falling back to an 64 bits long type the 128-bit is not available. 1832198 3 449507 ysuzuki 2022-01-19 13:22:57 -0800 Comment on attachment 449507 patch libpas does not support 32bit environment. So the right fix is ensuring that all built libpas C files are guarded by LIBPAS_ENABLED so that we do not build this file. Can you paste which file is including pas_utils.h? 1832206 4 ysuzuki 2022-01-19 13:32:50 -0800 I wonder if this is broken due to bug 230841 1832220 5 ysuzuki 2022-01-19 13:45:51 -0800 And I also wonder if this fixed this issue. https://bugs.webkit.org/show_bug.cgi?id=235275 1832397 6 psaavedra 2022-01-20 04:43:53 -0800 (In reply to Yusuke Suzuki from comment #3) > Comment on attachment 449507 [details] > patch > > libpas does not support 32bit environment. So the right fix is ensuring that > all built libpas C files are guarded by LIBPAS_ENABLED so that we do not > build this file. > Can you paste which file is including pas_utils.h? The failure comes from here : ``` In file included from /workspace/sources/wpewebkit/Source/WebCore/platform/graphics/HEVCUtilities.cpp:38: /tmp/work/cortexa9t2hf-neon-imx-poky-linux-gnueabi/wpewebkit/trunk+https999-r0/wpewebkit-trunk+https999/bmalloc/Headers/bmalloc/pas_utils.h: In function 'bool pas_compare_and_swap_uintptr_weak(uintptr_t*, uintptr_t, uintptr_t)': /tmp/work/cortexa9t2hf-neon-imx-poky-linux-gnueabi/wpewebkit/trunk+https999-r0/wpewebkit-trunk+https999/bmalloc/Headers/bmalloc/pas_utils.h:557:45: warning: cast from 'uintptr_t*' {aka 'unsigned int*'} to 'uint64_t*' {aka 'long long unsigned int*'} increases required alignment of target type [-Wcast-align] 557 | return pas_compare_and_swap_uint64_weak((uint64_t*)ptr, (uint64_t)old_value, (uint64_t)new_value); | ^~~~~~~~~~~~~~ /tmp/work/cortexa9t2hf-neon-imx-poky-linux-gnueabi/wpewebkit/trunk+https999-r0/wpewebkit-trunk+https999/bmalloc/Headers/bmalloc/pas_utils.h: In function 'uintptr_t pas_compare_and_swap_uintptr_strong(uintptr_t*, uintptr_t, uintptr_t)': /tmp/work/cortexa9t2hf-neon-imx-poky-linux-gnueabi/wpewebkit/trunk+https999-r0/wpewebkit-trunk+https999/bmalloc/Headers/bmalloc/pas_utils.h:562:58: warning: cast from 'uintptr_t*' {aka 'unsigned int*'} to 'uint64_t*' {aka 'long long unsigned int*'} increases required alignment of target type [-Wcast-align] 562 | return (uintptr_t)pas_compare_and_swap_uint64_strong((uint64_t*)ptr, (uint64_t)old_value, (uint64_t)new_value); | ^~~~~~~~~~~~~~ /tmp/work/cortexa9t2hf-neon-imx-poky-linux-gnueabi/wpewebkit/trunk+https999-r0/wpewebkit-trunk+https999/bmalloc/Headers/bmalloc/pas_utils.h: At global scope: /tmp/work/cortexa9t2hf-neon-imx-poky-linux-gnueabi/wpewebkit/trunk+https999-r0/wpewebkit-trunk+https999/bmalloc/Headers/bmalloc/pas_utils.h:633:9: error: '__uint128_t' does not name a type; did you mean '__uint8_t'? 633 | typedef __uint128_t pas_pair; | ^~~~~~~~~~~ | __uint8_t ``` It took me time because the non unified-build was broken. A tentative patch it could be something like this: ``` --- a/Source/WebCore/platform/graphics/HEVCUtilities.cpp +++ b/Source/WebCore/platform/graphics/HEVCUtilities.cpp @@ -34,7 +34,7 @@ #include <wtf/SortedArrayMap.h> #include <wtf/text/StringToIntegerConversion.h> -#if __has_include(<bmalloc/pas_utils.h>) +#if LIBPAS_ENABLED #include <bmalloc/pas_utils.h> #endif @@ -42,7 +42,7 @@ namespace WebCore { static inline uint32_t reverseBits(uint32_t value) { -#if __has_include(<bmalloc/pas_utils.h>) +#if LIBPAS_ENABLED return pas_reverse(value); #else // From pas_reverse(): ``` 1832398 7 449565 psaavedra 2022-01-20 04:47:12 -0800 Created attachment 449565 patch 1832465 8 psaavedra 2022-01-20 09:34:51 -0800 (In reply to Yusuke Suzuki from comment #5) > And I also wonder if this fixed this issue. > https://bugs.webkit.org/show_bug.cgi?id=235275 Yes, based on the previous comment that change should be fix the issue. 1832467 9 psaavedra 2022-01-20 09:35:28 -0800 (In reply to Pablo Saavedra from comment #8) > (In reply to Yusuke Suzuki from comment #5) > > And I also wonder if this fixed this issue. > > https://bugs.webkit.org/show_bug.cgi?id=235275 > > Yes, based on the previous comment that change should be fix the issue. I will test it in local just for a double-check. 1832536 10 psaavedra 2022-01-20 12:47:54 -0800 Fixed. Thanks for your help ysuzuki. 1832537 11 webkit-bug-importer 2022-01-20 12:48:18 -0800 <rdar://problem/87844683> 449507 2022-01-19 12:24:07 -0800 2022-01-20 04:46:18 -0800 patch bug-235372-20220119212406.patch text/plain 1703 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggNzNiOGE0M2QwN2EwYjA4 NDBlNWIxZjk4MWUxMTRiOTY3YmViYWE1NS4uYzYwM2MyYTk4ZGI1ZDNhMDI5MWFmNjMyNzhhMjRi ZTQ1Y2Q4NmFhMiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTAxLTE5ICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtibWFsbG9jXVsz Mi1iaXRzXSBCdWlsZCBlcnJvciBpbiBsaWJwYXMgYWZ0ZXIgcjI4NTg1MworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1MzcyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsaWJwYXMvc3JjL2xpYnBhcy9w YXNfdXRpbHMuaDoKKyAgICAgICAgKHBhc19wYWlyX2NyZWF0ZSk6CisgICAgICAgIChwYXNfcGFp cl9oaWdoKToKKwogMjAyMi0wMS0wNCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CiAKICAgICAgICAgW1BBU10gY29uc3RhbnQtbG9naWNhbC1vcGVyYW5kIGNsYW5nIHdh cm5pbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNf dXRpbHMuaCBiL1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc191dGlscy5oCmlu ZGV4IGRiYTFmYjI3MTc4NzQ0NTM1YjA1N2EyMmU0MzMxYmY0ZDg5NzEwYTMuLmJkMWQ3MTJkZGIz Yzk2N2ZmMWI1MTU5M2I3YjJiMmQyZmViZDRmMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9j L2xpYnBhcy9zcmMvbGlicGFzL3Bhc191dGlscy5oCisrKyBiL1NvdXJjZS9ibWFsbG9jL2xpYnBh cy9zcmMvbGlicGFzL3Bhc191dGlscy5oCkBAIC02MzAsMTEgKzYzMCwxOSBAQCBzdGF0aWMgaW5s aW5lIHVpbnRwdHJfdCBwYXNfcGFpcl9oaWdoKHBhc19wYWlyIHBhaXIpCiAKICNlbHNlCiAKKyNp ZmRlZiBfX1NJWkVPRl9JTlQxMjhfXwogdHlwZWRlZiBfX3VpbnQxMjhfdCBwYXNfcGFpcjsKKyNl bHNlCit0eXBlZGVmIF9fdWludDY0X3QgcGFzX3BhaXI7CisjZW5kaWYKIAogc3RhdGljIGlubGlu ZSBwYXNfcGFpciBwYXNfcGFpcl9jcmVhdGUodWludHB0cl90IGxvdywgdWludHB0cl90IGhpZ2gp CiB7CisjaWZkZWYgX19TSVpFT0ZfSU5UMTI4X18KICAgICByZXR1cm4gKChwYXNfcGFpcilsb3cp IHwgKChwYXNfcGFpcikoaGlnaCkgPDwgNjQpOworI2Vsc2UKKyAgICByZXR1cm4gKChwYXNfcGFp cilsb3cpIHwgKChwYXNfcGFpcikoaGlnaCkgPDwgMzIpOworI2VuZGlmCiB9CiAKIHN0YXRpYyBp bmxpbmUgdWludHB0cl90IHBhc19wYWlyX2xvdyhwYXNfcGFpciBwYWlyKQpAQCAtNjQ0LDcgKzY1 MiwxMSBAQCBzdGF0aWMgaW5saW5lIHVpbnRwdHJfdCBwYXNfcGFpcl9sb3cocGFzX3BhaXIgcGFp cikKIAogc3RhdGljIGlubGluZSB1aW50cHRyX3QgcGFzX3BhaXJfaGlnaChwYXNfcGFpciBwYWly KQogeworI2lmZGVmIF9fU0laRU9GX0lOVDEyOF9fCiAgICAgcmV0dXJuIHBhaXIgPj4gNjQ7Cisj ZWxzZQorICAgIHJldHVybiBwYWlyID4+IDMyOworI2VuZGlmCiB9CiAKICNlbmRpZgo= 449565 2022-01-20 04:47:12 -0800 2022-02-10 16:46:31 -0800 patch bug-235372-20220120134711.patch text/plain 1448 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggNzNiOGE0M2QwN2EwYjA4 NDBlNWIxZjk4MWUxMTRiOTY3YmViYWE1NS4uYzYwM2MyYTk4ZGI1ZDNhMDI5MWFmNjMyNzhhMjRi ZTQ1Y2Q4NmFhMiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTAxLTE5ICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtibWFsbG9jXVsz Mi1iaXRzXSBCdWlsZCBlcnJvciBpbiBsaWJwYXMgYWZ0ZXIgcjI4NTg1MworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1MzcyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsaWJwYXMvc3JjL2xpYnBhcy9w YXNfdXRpbHMuaDoKKyAgICAgICAgKHBhc19wYWlyX2NyZWF0ZSk6CisgICAgICAgIChwYXNfcGFp cl9oaWdoKToKKwogMjAyMi0wMS0wNCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CiAKICAgICAgICAgW1BBU10gY29uc3RhbnQtbG9naWNhbC1vcGVyYW5kIGNsYW5nIHdh cm5pbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9IRVZD VXRpbGl0aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0hFVkNVdGls aXRpZXMuY3BwCmluZGV4IGE5MGQ0MWZmNDIzMjc5NjNhNDdlNWM0M2U3NWYzM2NhZDk0YzQ5YmUu Ljc5ZGMyOTBmMzI0Yjg5ODM0MzMxZGQzZjY4NThmMTZmYjQyZmEwM2UgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0hFVkNVdGlsaXRpZXMuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0hFVkNVdGlsaXRpZXMuY3BwCkBAIC0zNCw3 ICszNCw3IEBACiAjaW5jbHVkZSA8d3RmL1NvcnRlZEFycmF5TWFwLmg+CiAjaW5jbHVkZSA8d3Rm L3RleHQvU3RyaW5nVG9JbnRlZ2VyQ29udmVyc2lvbi5oPgogCi0jaWYgX19oYXNfaW5jbHVkZSg8 Ym1hbGxvYy9wYXNfdXRpbHMuaD4pCisjaWYgTElCUEFTX0VOQUJMRUQKICNpbmNsdWRlIDxibWFs bG9jL3Bhc191dGlscy5oPgogI2VuZGlmCiAKQEAgLTQyLDcgKzQyLDcgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogCiBzdGF0aWMgaW5saW5lIHVpbnQzMl90IHJldmVyc2VCaXRzKHVpbnQzMl90IHZh bHVlKQogewotI2lmIF9faGFzX2luY2x1ZGUoPGJtYWxsb2MvcGFzX3V0aWxzLmg+KQorI2lmIExJ QlBBU19FTkFCTEVECiAgICAgcmV0dXJuIHBhc19yZXZlcnNlKHZhbHVlKTsKICNlbHNlCiAgICAg Ly8gRnJvbSBwYXNfcmV2ZXJzZSgpOgo=