235362 2022-01-19 06:23:21 -0800 AVAudioSessionCaptureDeviceManager is not always computing the right default input device 2022-01-24 08:05:04 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf darin eric.carlson ews-watchlist ggaren glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1832010 0 youennf 2022-01-19 06:23:21 -0800 AVAudioSessionCaptureDeviceManager is not always computing the right default input device 1832011 1 youennf 2022-01-19 06:25:23 -0800 <rdar://87707090> 1832014 2 449479 youennf 2022-01-19 06:31:07 -0800 Created attachment 449479 Patch 1832067 3 449479 darin 2022-01-19 10:07:37 -0800 Comment on attachment 449479 Patch What is our testing strategy for these kinds of things? I worry that we could easily break this and would not notice. 1832362 4 youennf 2022-01-19 23:52:52 -0800 (In reply to Darin Adler from comment #3) > Comment on attachment 449479 [details] > Patch > > What is our testing strategy for these kinds of things? I worry that we > could easily break this and would not notice. This whole area sadly resorts on manual testing. It would be nice to automate more this area but this requires efforts outside WebKit. I guess I can add some some manual test pages to help validating non regressions easily. 1832371 5 ews-feeder 2022-01-20 00:37:36 -0800 Committed r288275 (246213@main): <https://commits.webkit.org/246213@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449479. 1832780 6 449479 ggaren 2022-01-21 09:00:58 -0800 Comment on attachment 449479 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449479&action=review > Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:243 > + RELEASE_LOG_INFO(WebRTC, "AVAudioSessionCaptureDeviceManager using previous default input"); Isn't it the other side of the if branch that uses m_lastDefaultMicrophone as defaultInput? 1832781 7 ggaren 2022-01-21 09:01:41 -0800 Can we at least verify WebKit's internal behavior through mocking? That wouldn't prove that the mic actually worked, but it would prove that our code did what we thought it would. 1833293 8 449479 youennf 2022-01-24 07:22:30 -0800 Comment on attachment 449479 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449479&action=review >> Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:243 >> + RELEASE_LOG_INFO(WebRTC, "AVAudioSessionCaptureDeviceManager using previous default input"); > > Isn't it the other side of the if branch that uses m_lastDefaultMicrophone as defaultInput? Right, will fix it. 1833297 9 youennf 2022-01-24 07:23:37 -0800 (In reply to Geoffrey Garen from comment #7) > Can we at least verify WebKit's internal behavior through mocking? That > wouldn't prove that the mic actually worked, but it would prove that our > code did what we thought it would. AVAudioSessionCaptureDeviceManager is not mocked at all like CoreAudioSharedUnit is. But we should probably try to do so. I'll think more about it. 1833300 10 youennf 2022-01-24 07:31:16 -0800 Reopening to attach new patch. 1833301 11 449812 youennf 2022-01-24 07:31:20 -0800 Created attachment 449812 Patch 1833324 12 ews-feeder 2022-01-24 08:05:00 -0800 Committed r288441 (246330@main): <https://commits.webkit.org/246330@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449812. 449479 2022-01-19 06:31:07 -0800 2022-01-24 07:31:10 -0800 Patch bug-235362-20220119153105.patch text/plain 3486 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZkYmMzZGIzNWZjOGI5 MjIwODczOWM0MGFkNDE3NmRhYzVkMDI1Ny4uMWRkZjU0ZDg0NjFmMDQxNjUwOWM1Mzc2NWNiYzhk MWFhZTUyZmVmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAxLTE5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBVkF1ZGlvU2Vzc2lvbkNh cHR1cmVEZXZpY2VNYW5hZ2VyIGlzIG5vdCBhbHdheXMgY29tcHV0aW5nIHRoZSByaWdodCBkZWZh dWx0IGlucHV0IGRldmljZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjM1MzYyCisgICAgICAgIDxyZGFyOi8vODc3MDcwOTA+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZXRpbWVzIHRoZSBkZWZhdWx0 SW5wdXQgaXMgbm90IGF2YWlsYWJsZSwgaW4gd2hpY2ggY2FzZSBpdCBpcyBnb29kIHRvIHJlc29y dCB0byB0aGUgcHJldmlvdXMgZGVmYXVsdCBkZXZpY2UgaWYgYXZhaWxhYmxlLgorICAgICAgICBU aGlzIGZpeCBwcmV2ZW50cyB0aGUgZm9sbG93aW5nIGNhc2UgdG8gaGFwcGVuOgorICAgICAgICAt IFdlIHN0YXJ0IHJlbmRlcmluZyBXZWJSVEMgYXVkaW8gb24gc29tZSBvdXRwdXQsIHNheSBBaXJQ b2RzCisgICAgICAgIC0gV2Ugc3RhcnQgY2FwdHVyaW5nIG1pY3JvcGhvbmUsIGJ1dCB0aGUgZGVm YXVsdCBtaWNyb3Bob25lIGlzIG5vdCB0aGUgQWlyUG9kcyBvbmUgKHdoaWxlIGl0IHByb2JhYmx5 IHNob3VsZCwgdGhpcyBpcyBub3QgYWx3YXlzIHRoZSBjYXNlKS4KKyAgICAgICAgLSBXZSBtaWdy YXRlIGF1ZGlvIHJlbmRlcmluZyB0byBWUElPIHdoaWNoIHdpbGwgb3V0cHV0IGF1ZGlvIHRvIHRo ZSBzYW1lIGRldmljZSBhcyB0aGUgaW5wdXQgbWljcm9waG9uZSBpZiBmZWFzaWJsZSAodHlwaWNh bGx5IGJ1aWx0aW4gc3BlYWtlcikuCisgICAgICAgIC0gQXVkaW8gaXMgbm93IGZsb3dpbmcgb24g YnVpbHRpbiBzcGVha2VyIGluc3RlYWQgb2YgQWlyUG9kcy4KKworICAgICAgICBNYW51YWxseSB0 ZXN0ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9pb3MvQVZBdWRpb1Nlc3Np b25DYXB0dXJlRGV2aWNlTWFuYWdlci5oOgorICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFt L2lvcy9BVkF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2VNYW5hZ2VyLm1tOgorCiAyMDIyLTAxLTE5 ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBIHNhbmRib3hl ZCBkb2N1bWVudCBzaG91bGQgbm90IHJldXNlIGl0cyBzZXJ2aWNlIHdvcmtlciBjbGllbnQgSUQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2lvcy9BVkF1 ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2VNYW5hZ2VyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9pb3MvQVZBdWRpb1Nlc3Npb25DYXB0dXJlRGV2aWNlTWFuYWdlci5oCmlu ZGV4IGIyOGU3NzIyYzk2YzExMjE2NjQ2MzA0Zjk0YTMxOTc1NTg0MGY4ZTAuLjBmZjcyZTJiY2I1 MzMzZTk5Y2EwZjZjZTVlZDYxZTc2MjA1MmJlZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL21lZGlhc3RyZWFtL2lvcy9BVkF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2VNYW5h Z2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vaW9zL0FWQXVk aW9TZXNzaW9uQ2FwdHVyZURldmljZU1hbmFnZXIuaApAQCAtMzMsNiArMzMsNyBAQAogI2luY2x1 ZGUgPHd0Zi9Xb3JrUXVldWUuaD4KIAogT0JKQ19DTEFTUyBBVkF1ZGlvU2Vzc2lvbjsKK09CSkNf Q0xBU1MgQVZBdWRpb1Nlc3Npb25Qb3J0RGVzY3JpcHRpb247CiBPQkpDX0NMQVNTIFdlYkFWQXVk aW9TZXNzaW9uQXZhaWxhYmxlSW5wdXRzTGlzdGVuZXI7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK QEAgLTgzLDYgKzg0LDcgQEAgcHJpdmF0ZToKICAgICBBdWRpb1Nlc3Npb25TdGF0ZSBtX2F1ZGlv U2Vzc2lvblN0YXRlIHsgQXVkaW9TZXNzaW9uU3RhdGU6Ok5vdE5lZWRlZCB9OwogICAgIFN0cmlu ZyBtX3ByZWZlcnJlZEF1ZGlvRGV2aWNlVUlEOwogICAgIGJvb2wgbV9yZWNvbXB1dGVEZXZpY2Vz IHsgdHJ1ZSB9OworICAgIG11dGFibGUgUmV0YWluUHRyPEFWQXVkaW9TZXNzaW9uUG9ydERlc2Ny aXB0aW9uPiBtX2xhc3REZWZhdWx0TWljcm9waG9uZTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2lv cy9BVkF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2VNYW5hZ2VyLm1tIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWVkaWFzdHJlYW0vaW9zL0FWQXVkaW9TZXNzaW9uQ2FwdHVyZURldmljZU1hbmFn ZXIubW0KaW5kZXggNmQ0NWExMDc2MWFkNGUzZWY4Y2NmYzM0NmMwNDRhYTMyN2IxOTU1NS4uZTlj MzcyOWU2NDYxYjI4OTE5YmQwNTU4OWI2ZTY2MTk5N2IwMjc3MCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vaW9zL0FWQXVkaW9TZXNzaW9uQ2FwdHVyZURl dmljZU1hbmFnZXIubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v aW9zL0FWQXVkaW9TZXNzaW9uQ2FwdHVyZURldmljZU1hbmFnZXIubW0KQEAgLTIzNyw2ICsyMzcs MTIgQEAgdm9pZCBBVkF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2VNYW5hZ2VyOjphY3RpdmF0ZUF1 ZGlvU2Vzc2lvbigpCiBWZWN0b3I8QVZBdWRpb1Nlc3Npb25DYXB0dXJlRGV2aWNlPiBBVkF1ZGlv U2Vzc2lvbkNhcHR1cmVEZXZpY2VNYW5hZ2VyOjpyZXRyaWV2ZUF1ZGlvU2Vzc2lvbkNhcHR1cmVE ZXZpY2VzKCkgY29uc3QKIHsKICAgICBhdXRvICpkZWZhdWx0SW5wdXQgPSBbbV9hdWRpb1Nlc3Np b24gY3VycmVudFJvdXRlXS5pbnB1dHMuZmlyc3RPYmplY3Q7CisgICAgaWYgKCFkZWZhdWx0SW5w dXQpCisgICAgICAgIGRlZmF1bHRJbnB1dCA9IG1fbGFzdERlZmF1bHRNaWNyb3Bob25lLmdldCgp OworICAgIGVsc2UgeworICAgICAgICBSRUxFQVNFX0xPR19JTkZPKFdlYlJUQywgIkFWQXVkaW9T ZXNzaW9uQ2FwdHVyZURldmljZU1hbmFnZXIgdXNpbmcgcHJldmlvdXMgZGVmYXVsdCBpbnB1dCIp OworICAgICAgICBtX2xhc3REZWZhdWx0TWljcm9waG9uZSA9IGRlZmF1bHRJbnB1dDsKKyAgICB9 CiAgICAgYXV0byBhdmFpbGFibGVJbnB1dHMgPSBbbV9hdWRpb1Nlc3Npb24gYXZhaWxhYmxlSW5w dXRzXTsKIAogICAgIFZlY3RvcjxBVkF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2U+IG5ld0F1ZGlv RGV2aWNlczsK 449812 2022-01-24 07:31:20 -0800 2022-01-24 08:05:02 -0800 Patch bug-235362-20220124163118.patch text/plain 2024 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY3YzBkODQ3NDE4NTJk MTEzZDk1MTI4MGI1YTg1ZTg3MTIyMzdmYi4uMmI5ZDIyMzdjMzk4YWY0YTA0NTExNzc5ZWY0YzZi N2E4NDUzZjk5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAxLTI0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBVkF1ZGlvU2Vzc2lvbkNh cHR1cmVEZXZpY2VNYW5hZ2VyIGlzIG5vdCBhbHdheXMgY29tcHV0aW5nIHRoZSByaWdodCBkZWZh dWx0IGlucHV0IGRldmljZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjM1MzYyCisgICAgICAgIDxyZGFyOi8vODc3MDcwOTA+CisKKyAgICAgICAgQWRk cmVzc2luZyBwb3N0IGNvbW1pdCBjb21tZW50cy4KKworICAgICAgICBSZXZpZXdlZCBieSBFcmlj IENhcmxzb24gYW5kIEdlb2ZmIEdhcmVuLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJl YW0vaW9zL0FWQXVkaW9TZXNzaW9uQ2FwdHVyZURldmljZU1hbmFnZXIubW06CisgICAgICAgIEZp eGVkIHRoZSByZWxlYXNlIGxvZ2dpbmcuCisKIDIwMjItMDEtMjQgIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFsgaU9TIFJlbGVhc2UgXSBmYXN0L21lZGlhc3Ry ZWFtL21lZGlhRWxlbWVudC1nYy5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vaW9zL0FWQXVkaW9TZXNzaW9uQ2Fw dHVyZURldmljZU1hbmFnZXIubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9pb3MvQVZBdWRpb1Nlc3Npb25DYXB0dXJlRGV2aWNlTWFuYWdlci5tbQppbmRleCBlOWMzNzI5 ZTY0NjFiMjg5MTliZDA1NTg5YjZlNjYxOTk3YjAyNzcwLi44OGNhMjdlYWI4NTAxZTQ0ZGIwNzVi ZThhYTFkZTUyZTZkZWYyMGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9pb3MvQVZBdWRpb1Nlc3Npb25DYXB0dXJlRGV2aWNlTWFuYWdlci5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9pb3MvQVZBdWRpb1Nlc3Npb25D YXB0dXJlRGV2aWNlTWFuYWdlci5tbQpAQCAtMjM3LDEyICsyMzcsMTIgQEAgdm9pZCBBVkF1ZGlv U2Vzc2lvbkNhcHR1cmVEZXZpY2VNYW5hZ2VyOjphY3RpdmF0ZUF1ZGlvU2Vzc2lvbigpCiBWZWN0 b3I8QVZBdWRpb1Nlc3Npb25DYXB0dXJlRGV2aWNlPiBBVkF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZp Y2VNYW5hZ2VyOjpyZXRyaWV2ZUF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2VzKCkgY29uc3QKIHsK ICAgICBhdXRvICpkZWZhdWx0SW5wdXQgPSBbbV9hdWRpb1Nlc3Npb24gY3VycmVudFJvdXRlXS5p bnB1dHMuZmlyc3RPYmplY3Q7Ci0gICAgaWYgKCFkZWZhdWx0SW5wdXQpCi0gICAgICAgIGRlZmF1 bHRJbnB1dCA9IG1fbGFzdERlZmF1bHRNaWNyb3Bob25lLmdldCgpOwotICAgIGVsc2UgeworICAg IGlmICghZGVmYXVsdElucHV0KSB7CiAgICAgICAgIFJFTEVBU0VfTE9HX0lORk8oV2ViUlRDLCAi QVZBdWRpb1Nlc3Npb25DYXB0dXJlRGV2aWNlTWFuYWdlciB1c2luZyBwcmV2aW91cyBkZWZhdWx0 IGlucHV0Iik7CisgICAgICAgIGRlZmF1bHRJbnB1dCA9IG1fbGFzdERlZmF1bHRNaWNyb3Bob25l LmdldCgpOworICAgIH0gZWxzZQogICAgICAgICBtX2xhc3REZWZhdWx0TWljcm9waG9uZSA9IGRl ZmF1bHRJbnB1dDsKLSAgICB9CisKICAgICBhdXRvIGF2YWlsYWJsZUlucHV0cyA9IFttX2F1ZGlv U2Vzc2lvbiBhdmFpbGFibGVJbnB1dHNdOwogCiAgICAgVmVjdG9yPEFWQXVkaW9TZXNzaW9uQ2Fw dHVyZURldmljZT4gbmV3QXVkaW9EZXZpY2VzOwo=