235346 2022-01-18 19:44:56 -0800 ColorTypes are no longer constexpr in debug builds due to std::isnan() in range assertions 2022-01-19 09:26:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam thorton webkit-bug-importer oldest_to_newest 1831929 0 sam 2022-01-18 19:44:56 -0800 ColorTypes are no longer constexpr in debug builds due to std::isnan() in range assertions 1831930 1 449456 sam 2022-01-18 19:47:19 -0800 Created attachment 449456 Patch 1831936 2 449456 thorton 2022-01-18 20:26:37 -0800 Comment on attachment 449456 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449456&action=review > Source/WebCore/platform/graphics/ColorTypes.h:138 > + // FIXME: Replace std::isnan() once std::isnan() is constexpr. missing a `with`, I think. 1831942 3 ews-feeder 2022-01-18 21:16:34 -0800 Committed r288181 (246162@main): <https://commits.webkit.org/246162@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449456. 1831943 4 webkit-bug-importer 2022-01-18 21:17:20 -0800 <rdar://problem/87751737> 1832055 5 sam 2022-01-19 09:26:35 -0800 (In reply to Tim Horton from comment #2) > Comment on attachment 449456 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449456&action=review > > > Source/WebCore/platform/graphics/ColorTypes.h:138 > > + // FIXME: Replace std::isnan() once std::isnan() is constexpr. > > missing a `with`, I think. Indeed. 449456 2022-01-18 19:47:19 -0800 2022-01-18 21:19:54 -0800 Patch bug-235346-20220118194718.patch text/plain 2805 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4ODE3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAxLTE4ICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBDb2xvclR5cGVzIGFyZSBubyBsb25n ZXIgY29uc3RleHByIGluIGRlYnVnIGJ1aWxkcyBkdWUgdG8gc3RkOjppc25hbigpIGluIHJhbmdl IGFzc2VydGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM1MzQ2CisKKyAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgUmVw bGFjZSBzdGQ6OmlzbmFuKCkgaW4gY29sb3IgdHlwZSByYW5nZSBhc3NlcnRpb25zIHdpdGggYSBj b25zdGV4cHIgdmFyaWFudCB1c2luZyB0aGUgeCAhPSB4CisgICAgICAgIGNvbnN0cnVjdGlvbiBm b3IgZGV0ZWN0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3JUeXBlcy5o OgorICAgICAgICAoV2ViQ29yZTo6Y29uc3RleHBySXNOYU4pOgorICAgICAgICAoV2ViQ29yZTo6 YXNzZXJ0SW5SYW5nZSk6CisKIDIwMjItMDEtMTggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBXaGVuIGluc2VydGluZyBhIHNlbGVjdGVkIDxvcHRpb24+IGluIGEg PHNlbGVjdD4gZWxlbWVudCwgaXRzIHNlbGVjdGVkIHN0YXRlIHNob3VsZCByZW1haW4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yVHlwZXMuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db2xvclR5cGVzLmgJKHJldmlz aW9uIDI4ODE1MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yVHlw ZXMuaAkod29ya2luZyBjb3B5KQpAQCAtMTMyLDE3ICsxMzIsMjQgQEAgdGVtcGxhdGU8dHlwZW5h bWUgQ29sb3JUeXBlLCB0eXBlbmFtZSBULCB0eXBlbmFtZSBBbHBoCiAKICNpZiBBU1NFUlRfRU5B QkxFRAogCit0ZW1wbGF0ZTx0eXBlbmFtZSBDb21wb25lbnRUeXBlPgorY29uc3RleHByIGJvb2wg Y29uc3RleHBySXNOYU4oQ29tcG9uZW50VHlwZSB2YWx1ZSkKK3sKKyAgICAvLyBGSVhNRTogUmVw bGFjZSBzdGQ6OmlzbmFuKCkgb25jZSBzdGQ6OmlzbmFuKCkgaXMgY29uc3RleHByLgorICAgIHJl dHVybiB2YWx1ZSAhPSB2YWx1ZTsKK30KKwogdGVtcGxhdGU8dHlwZW5hbWUgQ29sb3JUeXBlLCB0 eXBlbmFtZSBzdGQ6OmVuYWJsZV9pZl90PHN0ZDo6aXNfc2FtZV92PHR5cGVuYW1lIENvbG9yVHlw ZTo6Q29tcG9uZW50VHlwZSwgZmxvYXQ+PiogPSBudWxscHRyPgogY29uc3RleHByIHZvaWQgYXNz ZXJ0SW5SYW5nZShDb2xvclR5cGUgY29sb3IpCiB7CiAgICAgYXV0byBjb21wb25lbnRzID0gYXND b2xvckNvbXBvbmVudHMoY29sb3IudW5yZXNvbHZlZCgpKTsKICAgICBmb3IgKHVuc2lnbmVkIGkg PSAwOyBpIDwgMzsgKytpKSB7Ci0gICAgICAgIGlmIChzdGQ6OmlzbmFuKGNvbXBvbmVudHNbaV0p KQorICAgICAgICBpZiAoY29uc3RleHBySXNOYU4oY29tcG9uZW50c1tpXSkpCiAgICAgICAgICAg ICBjb250aW51ZTsKICAgICAgICAgQVNTRVJUX1dJVEhfTUVTU0FHRShjb21wb25lbnRzW2ldID49 IENvbG9yVHlwZTo6TW9kZWw6OmNvbXBvbmVudEluZm9baV0ubWluLCAiQ29tcG9uZW50IGF0IGlu ZGV4ICVkIGlzICVmIGFuZCBpcyBsZXNzIHRoYW4gdGhlIGFsbG93ZWQgbWluaW11bSAlZiIsIGks ICBjb21wb25lbnRzW2ldLCBDb2xvclR5cGU6Ok1vZGVsOjpjb21wb25lbnRJbmZvW2ldLm1pbik7 CiAgICAgICAgIEFTU0VSVF9XSVRIX01FU1NBR0UoY29tcG9uZW50c1tpXSA8PSBDb2xvclR5cGU6 Ok1vZGVsOjpjb21wb25lbnRJbmZvW2ldLm1heCwgIkNvbXBvbmVudCBhdCBpbmRleCAlZCBpcyAl ZiBhbmQgaXMgZ3JlYXRlciB0aGFuIHRoZSBhbGxvd2VkIG1heGltdW0gJWYiLCBpLCAgY29tcG9u ZW50c1tpXSwgQ29sb3JUeXBlOjpNb2RlbDo6Y29tcG9uZW50SW5mb1tpXS5tYXgpOwogICAgIH0K LSAgICBpZiAoIXN0ZDo6aXNuYW4oY29tcG9uZW50c1szXSkpIHsKKyAgICBpZiAoY29uc3RleHBy SXNOYU4oY29tcG9uZW50c1szXSkpIHsKICAgICAgICAgQVNTRVJUX1dJVEhfTUVTU0FHRShjb21w b25lbnRzWzNdID49IEFscGhhVHJhaXRzPHR5cGVuYW1lIENvbG9yVHlwZTo6Q29tcG9uZW50VHlw ZT46OnRyYW5zcGFyZW50LCAiQWxwaGEgaXMgJWYgYW5kIGlzIGxlc3MgdGhhbiB0aGUgYWxsb3dl ZCBtaW5pbXVtICh0cmFuc3BhcmVudCkgJWYiLCBjb21wb25lbnRzWzNdLCBBbHBoYVRyYWl0czx0 eXBlbmFtZSBDb2xvclR5cGU6OkNvbXBvbmVudFR5cGU+Ojp0cmFuc3BhcmVudCk7CiAgICAgICAg IEFTU0VSVF9XSVRIX01FU1NBR0UoY29tcG9uZW50c1szXSA8PSBBbHBoYVRyYWl0czx0eXBlbmFt ZSBDb2xvclR5cGU6OkNvbXBvbmVudFR5cGU+OjpvcGFxdWUsICJBbHBoYSBpcyAlZiBhbmQgaXMg Z3JlYXRlciB0aGFuIHRoZSBhbGxvd2VkIG1heGltdW0gKG9wYXF1ZSkgJWYiLCBjb21wb25lbnRz WzNdLCBBbHBoYVRyYWl0czx0eXBlbmFtZSBDb2xvclR5cGU6OkNvbXBvbmVudFR5cGU+OjpvcGFx dWUpOwogICAgIH0K