235322 2022-01-18 10:23:06 -0800 Adding iframe flushes microtasks synchronously with dirty stack 2023-01-24 11:40:43 -0800 1 1 1 Unclassified WebKit DOM Safari 15 All All RESOLVED FIXED InRadar P2 Normal --- 1 dan.abramov rniwa 993634344 achristensen akseli+webkit cdumez esprehn+autocc ews-watchlist ikerins japhet jason kangil.han matt.dentremont rniwa simon.fraser webkit-bug-importer oldest_to_newest 1831723 0 449401 dan.abramov 2022-01-18 10:23:06 -0800 Created attachment 449401 repro Microtasks are supposed to run on a clean stack. However, Safari flushes microtasks synchronously if you append an iframe to the page. This breaks expectations for libraries like React/Preact, and possibly others: - https://github.com/facebook/react/issues/22459 - https://github.com/preactjs/preact/issues/2814 Here is a simple repro: ``` queueMicrotask(() => { console.log("--- in microtask ---"); }); console.log("will add iframe"); const iframe = document.createElement("iframe"); iframe.src = "localhost"; document.body.appendChild(iframe); console.log("did add iframe"); ``` You need to run it with http server to repro. It doesn't repro from file://. Expected output: ``` will add iframe did add iframe --- in microtask --- ``` Safari output: ``` will add iframe --- in microtask --- did add iframe ``` 1831785 1 jason 2022-01-18 13:20:46 -0800 I spent a bit of time checking various forms of this issue: https://jsfiddle.net/developit/u6xztc93/ I was able to narrow the issue down: - microtasks are only flushed in the realm of the frame's ownerDocument. - flush is *not* triggered for sandboxed iframes. - flush *is* triggered for cross-origin iframes. (presumably because it's not known to be cross-origin at append time) - flush *is* triggered for iframes within <svg><foreignObject>. - other elements (svg/img/video/object/embed) do not trigger flush. 1833765 2 webkit-bug-importer 2022-01-25 10:23:43 -0800 <rdar://problem/88031232> 1878962 3 rniwa 2022-06-28 22:50:38 -0700 I don't think this is a regression. The issue really stems from the fact we're still firing DOMContentLoaded and load events synchronously in Document::finishedParsing(). Since this code gets to run when inserting an iframe as a part of creating the initial empty document, we end up performing the microtask checkpoint. Making DOMContentLoaded and load events fully asynchronous is a major undertaking but we can workaround this specific issue by detecting that's what's about to happen and avoid performing microtask checkpoint. 1878969 4 460532 rniwa 2022-06-28 23:53:55 -0700 Created attachment 460532 WIP We can detect the case where we're creating initial empty document like this. But this doesn't work when we're implicitly navigating to about:blank (blank iframe). 1878975 5 rniwa 2022-06-29 01:11:38 -0700 Yikes. This must be a regression from https://trac.webkit.org/r234944. 1878976 6 460534 rniwa 2022-06-29 01:13:19 -0700 Created attachment 460534 WIP2 1879069 7 rniwa 2022-06-29 11:07:49 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1907 1879073 8 460549 rniwa 2022-06-29 11:19:13 -0700 Created attachment 460549 Patch 1879075 9 rniwa 2022-06-29 11:23:39 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1909 1879528 10 ews-feeder 2022-06-30 14:40:46 -0700 Committed 252015@main (ea74655e102a): <https://commits.webkit.org/252015@main> Reviewed commits have been landed. Closing PR #1909 and removing active labels. 1889296 11 rniwa 2022-08-05 17:40:22 -0700 *** Bug 243488 has been marked as a duplicate of this bug. *** 1927843 12 matt.dentremont 2023-01-24 09:47:57 -0800 The commit for the fix doesn't seem to be part of any Safari-specific git tags, but it is in Safari branches safari-7614.1.20-branch all the way up to safari-7615.1.9-branch. I see it mentioned in the Safari tech preview 150 release notes, but not in any of the mainline release notes. Is this released to the general public yet? 1927882 13 rniwa 2023-01-24 11:40:43 -0800 (In reply to Matt d'Entremont from comment #12) > The commit for the fix doesn't seem to be part of any Safari-specific git > tags, but it is in Safari branches safari-7614.1.20-branch all the way up to > safari-7615.1.9-branch. > > I see it mentioned in the Safari tech preview 150 release notes, but not in > any of the mainline release notes. > > Is this released to the general public yet? It should be in Safari 16. 449401 2022-01-18 10:23:06 -0800 2022-01-18 10:23:06 -0800 repro bug.html text/html 400 dan.abramov PGJ1dHRvbiBpZD0iYnV0dG9uIj5jbGljayBtZTwvYnV0dG9uPgo8c2NyaXB0PgppZiAobG9jYXRp b24uaHJlZi5zdGFydHNXaXRoKCdmaWxlJykpIHsKICBhbGVydCgneW91IGhhdmUgdG8gc2VydmUg dGhpcyB3aXRoIGh0dHAgdG8gcmVwcm8gdGhlIGJ1ZycpCn0KCnF1ZXVlTWljcm90YXNrKCgpID0+ IHsKICBjb25zb2xlLmxvZygiLS0tIGluIG1pY3JvdGFzayAtLS0iKTsKfSk7CmNvbnNvbGUubG9n KCJ3aWxsIGFkZCBpZnJhbWUiKTsKY29uc3QgaWZyYW1lID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiaWZyYW1lIik7CmlmcmFtZS5zcmMgPSAibG9jYWxob3N0IjsKZG9jdW1lbnQuYm9keS5hcHBl bmRDaGlsZChpZnJhbWUpOwpjb25zb2xlLmxvZygiZGlkIGFkZCBpZnJhbWUiKTsKCjwvc2NyaXB0 Pg== 460532 2022-06-28 23:53:55 -0700 2022-06-29 11:20:10 -0700 WIP wip235322.patch text/plain 939 rniwa ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGY0OTU4NzY4YjAzMy4uNmQxMzYzOTU1MTRjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTYyMTgsNyArNjIxOCwxMSBAQCB2b2lkIERvY3Vt ZW50OjpmaW5pc2hlZFBhcnNpbmcoKQogICAgIH0KIAogICAgIC8vIEZJWE1FOiBTY2hlZHVsZSBh IHRhc2sgdG8gZmlyZSBET01Db250ZW50TG9hZGVkIGV2ZW50IGluc3RlYWQuIFNlZSB3ZWJraXQu b3JnL2IvODI5MzEKLSAgICBldmVudExvb3AoKS5wZXJmb3JtTWljcm90YXNrQ2hlY2twb2ludCgp OworICAgIC8vIEF2b2lkIHRoZSBpc3N1ZSB3aGVyZSBpbnNlcnRpbmcgYW4gZW1wdHkgaWZyYW1l IHBlcmZvcm1zIGEgbWljcm90YXNrIGNoZWNrcG9pbnQuCisgICAgYm9vbCBuZWVkc1RvQXZvaWRT eW5jTWljcm90YXNrQ2hlY2twb2ludER1cmluZ0VtcHR5SWZyYW1lSW5zZXJ0aW9uID0gZnJhbWUo KSAmJiBmcmFtZSgpLT5sb2FkZXIoKS5zdGF0ZU1hY2hpbmUoKS5jcmVhdGluZ0luaXRpYWxFbXB0 eURvY3VtZW50KCk7CisgICAgaWYgKCFuZWVkc1RvQXZvaWRTeW5jTWljcm90YXNrQ2hlY2twb2lu dER1cmluZ0VtcHR5SWZyYW1lSW5zZXJ0aW9uKQorICAgICAgICBldmVudExvb3AoKS5wZXJmb3Jt TWljcm90YXNrQ2hlY2twb2ludCgpOworCiAgICAgZGlzcGF0Y2hFdmVudChFdmVudDo6Y3JlYXRl KGV2ZW50TmFtZXMoKS5ET01Db250ZW50TG9hZGVkRXZlbnQsIEV2ZW50OjpDYW5CdWJibGU6Olll cywgRXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm8pKTsKIAogICAgIGlmICghbV9ldmVudFRpbWluZy5k b21Db250ZW50TG9hZGVkRXZlbnRFbmQpIHsK 460534 2022-06-29 01:13:19 -0700 2022-06-29 11:20:18 -0700 WIP2 wip235322b.patch text/plain 2990 rniwa ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGY0OTU4NzY4YjAzMy4uMWZmOTYzYmQyMTBlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTYyMTgsNyArNjIxOCwxMCBAQCB2b2lkIERvY3Vt ZW50OjpmaW5pc2hlZFBhcnNpbmcoKQogICAgIH0KIAogICAgIC8vIEZJWE1FOiBTY2hlZHVsZSBh IHRhc2sgdG8gZmlyZSBET01Db250ZW50TG9hZGVkIGV2ZW50IGluc3RlYWQuIFNlZSB3ZWJraXQu b3JnL2IvODI5MzEKLSAgICBldmVudExvb3AoKS5wZXJmb3JtTWljcm90YXNrQ2hlY2twb2ludCgp OworICAgIGlmIChhdXRvKiBkb2N1bWVudExvYWRlciA9IGxvYWRlcigpOyBkb2N1bWVudExvYWRl ciAmJiBkb2N1bWVudExvYWRlci0+aXNJbkZpbmlzaGVkTG9hZGluZ09mRW1wdHlEb2N1bWVudCgp KQorICAgICAgICA7IC8vIERvbid0IHBlcmZvcm0gYSBtaWNyb3Rhc2sgY2hlY2twb2ludCB3aGVu IGluc2VydGluZyBhbiBlbXB0eSBpZnJhbWUuCisgICAgZWxzZQorICAgICAgICBldmVudExvb3Ao KS5wZXJmb3JtTWljcm90YXNrQ2hlY2twb2ludCgpOwogICAgIGRpc3BhdGNoRXZlbnQoRXZlbnQ6 OmNyZWF0ZShldmVudE5hbWVzKCkuRE9NQ29udGVudExvYWRlZEV2ZW50LCBFdmVudDo6Q2FuQnVi YmxlOjpZZXMsIEV2ZW50OjpJc0NhbmNlbGFibGU6Ok5vKSk7CiAKICAgICBpZiAoIW1fZXZlbnRU aW1pbmcuZG9tQ29udGVudExvYWRlZEV2ZW50RW5kKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0Rv Y3VtZW50TG9hZGVyLmNwcAppbmRleCA3YWExY2Q4ODhlMWIuLjNhZTkzZGU0OWEzZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCkBAIC00OTAsOCArNDkwLDkgQEAg dm9pZCBEb2N1bWVudExvYWRlcjo6ZmluaXNoZWRMb2FkaW5nKCkKICAgICBpZiAoIW1heWJlQ3Jl YXRlQXJjaGl2ZSgpKSB7CiAgICAgICAgIC8vIElmIHRoaXMgaXMgYW4gZW1wdHkgZG9jdW1lbnQs IGl0IHdpbGwgbm90IGhhdmUgYWN0dWFsbHkgYmVlbiBjcmVhdGVkIHlldC4gQ29tbWl0IGR1bW15 IGRhdGEgc28gdGhhdAogICAgICAgICAvLyBEb2N1bWVudFdyaXRlcjo6YmVnaW4oKSBnZXRzIGNh bGxlZCBhbmQgY3JlYXRlcyB0aGUgRG9jdW1lbnQuCi0gICAgICAgIGlmICghbV9nb3RGaXJzdEJ5 dGUpCisgICAgICAgIGlmICghbV9nb3RGaXJzdEJ5dGUpIHsKICAgICAgICAgICAgIGNvbW1pdERh dGEoU2hhcmVkQnVmZmVyOjpjcmVhdGUoKSk7CisgICAgICAgIH0KIAogICAgICAgICBpZiAoIWZy YW1lTG9hZGVyKCkpCiAgICAgICAgICAgICByZXR1cm47CkBAIC0yMDM1LDYgKzIwMzYsNyBAQCBi b29sIERvY3VtZW50TG9hZGVyOjptYXliZUxvYWRFbXB0eSgpCiAgICAgICAgIH0KICAgICB9CiAK KyAgICBTZXRGb3JTY29wZSBpc0luRmluaXNoZWRMb2FkaW5nT2ZFbXB0eURvY3VtZW50IHsgbV9p c0luRmluaXNoZWRMb2FkaW5nT2ZFbXB0eURvY3VtZW50LCB0cnVlIH07CiAgICAgZmluaXNoZWRM b2FkaW5nKCk7CiAgICAgcmV0dXJuIHRydWU7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVu dExvYWRlci5oCmluZGV4IDUwZGU3ODZhNTQ4My4uNDg3N2E4ZmQzOThiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuaApAQCAtNDU5LDYgKzQ1OSw3IEBAIHB1YmxpYzoKICAg ICBib29sIGlzQ29udGludWluZ0xvYWRBZnRlclByb3Zpc2lvbmFsTG9hZFN0YXJ0ZWQoKSBjb25z dCB7IHJldHVybiBtX2lzQ29udGludWluZ0xvYWRBZnRlclByb3Zpc2lvbmFsTG9hZFN0YXJ0ZWQ7 IH0KICAgICB2b2lkIHNldElzQ29udGludWluZ0xvYWRBZnRlclByb3Zpc2lvbmFsTG9hZFN0YXJ0 ZWQoYm9vbCBpc0NvbnRpbnVpbmdMb2FkQWZ0ZXJQcm92aXNpb25hbExvYWRTdGFydGVkKSB7IG1f aXNDb250aW51aW5nTG9hZEFmdGVyUHJvdmlzaW9uYWxMb2FkU3RhcnRlZCA9IGlzQ29udGludWlu Z0xvYWRBZnRlclByb3Zpc2lvbmFsTG9hZFN0YXJ0ZWQ7IH0KIAorICAgIGJvb2wgaXNJbkZpbmlz aGVkTG9hZGluZ09mRW1wdHlEb2N1bWVudCgpIGNvbnN0IHsgcmV0dXJuIG1faXNJbkZpbmlzaGVk TG9hZGluZ09mRW1wdHlEb2N1bWVudDsgfQogI2lmIEVOQUJMRShDT05URU5UX0ZJTFRFUklORykK ICAgICBib29sIGNvbnRlbnRGaWx0ZXJXaWxsSGFuZGxlUHJvdmlzaW9uYWxMb2FkRmFpbHVyZShj b25zdCBSZXNvdXJjZUVycm9yJik7CiAgICAgdm9pZCBjb250ZW50RmlsdGVySGFuZGxlUHJvdmlz aW9uYWxMb2FkRmFpbHVyZShjb25zdCBSZXNvdXJjZUVycm9yJik7CkBAIC02MDQsNiArNjA1LDcg QEAgcHJpdmF0ZToKICAgICBib29sIG1faXNDbGllbnRSZWRpcmVjdCB7IGZhbHNlIH07CiAgICAg Ym9vbCBtX2lzTG9hZGluZ011bHRpcGFydENvbnRlbnQgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9p c0NvbnRpbnVpbmdMb2FkQWZ0ZXJQcm92aXNpb25hbExvYWRTdGFydGVkIHsgZmFsc2UgfTsKKyAg ICBib29sIG1faXNJbkZpbmlzaGVkTG9hZGluZ09mRW1wdHlEb2N1bWVudCB7IGZhbHNlIH07CiAK ICAgICAvLyBGSVhNRTogRG9jdW1lbnQ6Om1fcHJvY2Vzc2luZ0xvYWRFdmVudCBhbmQgRG9jdW1l bnRMb2FkZXI6Om1fd2FzT25sb2FkRGlzcGF0Y2hlZCBhcmUgcm91Z2hseSB0aGUgc2FtZQogICAg IC8vIGFuZCBzaG91bGQgYmUgbWVyZ2VkLgo= 460549 2022-06-29 11:19:13 -0700 2022-06-29 11:20:02 -0700 Patch bug-235322-20220629111912.patch text/plain 8345 rniwa RnJvbSBhMGI1MjJhNTFiMDVmZjM3ZDJlNDY4MTI2MzYzODJiZjcyYjM1YzYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeW9zdWtlIE5pd2EgPHJuaXdhQHdlYmtpdC5vcmc+CkRhdGU6 IFdlZCwgMjkgSnVuIDIwMjIgMTE6MDY6MTAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBBZGRpbmcg aWZyYW1lIGZsdXNoZXMgbWljcm90YXNrcyBzeW5jaHJvbm91c2x5IHdpdGggZGlydHkKIHN0YWNr IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzUzMjIKClJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IERvY3VtZW50OjpmaW5p c2hlZFBhcnNpbmcgc3luY2hyb25vdXNseSBwZXJmb3JtaW5nIGEgbWljcm90YXNrIGNoZWNrcG9p bnQuCldoZW4gdGhpcyBmdW5jdGlvbiBhbHNvIGdldHMgY2FsbGVkIGR1cmluZyB0aGUgaW5pdGlh bGl6YXRpb24gb2YgaWZyYW1lIG5ld2x5IGNvbm5lY3RlZCB0byBhIGRvY3VtZW50LAppdCBlcnJv bmVvdXNseSBleGVjdXRlcyBtaWNyb3Rhc2tzIGFzc29jaWF0ZWQgd2l0aCB0aGUgY3VycmVudCBl dmVudCBsb29wLgoKVGhpcyBpcyBsaWtlbHkgYSByZWdyZXNzaW9uIGZyb20gaHR0cDovL2NvbW1p dHMud2Via2l0Lm9yZy9yMjM0OTQ0IHdoZXJlIHdlIGludHJvZHVjZWQgdGhpcyB3b3JrYXJvdW5k CmZvciBmaXJpbmcgRE9NQ29udGVudExvYWRlZCBzeW5jaHJvbm91c2x5LiBBdm9pZCBjYWxsaW5n IHRoaXMgZnVuY3Rpb24gaW4gdGhpcyBzcGVjaWZpYyBjaXJjdW1zdGFuY2VzLgoKQWRkZWQgYSBu ZXcgdGVzdCBmb3IgdmFyaW91cyB0eXBlcyBvZiBpZnJhbWUgaW5zZXJ0aW9uLgpOb3RlIHRoYXQg bG9hZCBldmVudCBhbHdheXMgZmlyZXMgc3luY2hyb25vdXNseSB3aGVuIGluc2VydGluZyBhbiBp ZnJhbWUgaXMgbG9hZGluZyBhYm91dDpibGFuay4KVGhpcyBiZWhhdmlvciBtYXRjaGVzIEJsaW5r IHdoZXJlYXMgR2Vja28gZmlyZXMgbG9hZCBldmVudCBmdWxseSBhc3luY2hyb25vdXNseS4KCiog U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcDoKKFdlYkNvcmU6OkRvY3VtZW50OjpmaW5p c2hlZFBhcnNpbmcpOiBGaXhlZCB0aGUgYnVnIGJ5IHNraXBwaW5nIHRoZSBhZm9yZW1lbnRpb25l ZCB3b3JrYXJvdW5kIHdoZW4Kd2UncmUgaW4gdGhlIG1pZGRsZSBvZiBpbml0aWFsaXppbmcgYW4g aWZyYW1lLgoqIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6CihXZWJD b3JlOjpEb2N1bWVudExvYWRlcjo6bWF5YmVMb2FkRW1wdHkpOiBBZGRlZC4gU2V0IG1faXNJbkZp bmlzaGVkTG9hZGluZ09mRW1wdHlEb2N1bWVudCB0byB0cnVlCndoaWxlIGNhbGxpbmcgRG9jdW1l bnRMb2FkZXI6OmZpbmlzaGVkUGFyc2luZy4KKiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1l bnRMb2FkZXIuaDoKKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjppc0luRmluaXNoZWRMb2FkaW5n T2ZFbXB0eURvY3VtZW50IGNvbnN0KTogQWRkZWQuCgoqIExheW91dFRlc3RzL2h0dHAvdGVzdHMv ZXZlbnRsb29wL2luc2VydGluZy1pZnJhbWUtc2hvdWxkLW5vdC1wZXJmb3JtLW1pY3JvdGFzay1j aGVja3BvaW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCiogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9l dmVudGxvb3AvaW5zZXJ0aW5nLWlmcmFtZS1zaG91bGQtbm90LXBlcmZvcm0tbWljcm90YXNrLWNo ZWNrcG9pbnQuaHRtbDogQWRkZWQuCi0tLQogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cCAgICAgICAgICAgICAgIHwgIDUgKy0KIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExv YWRlci5jcHAgICAgICB8ICAxICsKIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRl ci5oICAgICAgICB8ICAyICsKIC4uLi1wZXJmb3JtLW1pY3JvdGFzay1jaGVja3BvaW50LWV4cGVj dGVkLnR4dCB8IDM0ICsrKysrKysrKysKIC4uLm91bGQtbm90LXBlcmZvcm0tbWljcm90YXNrLWNo ZWNrcG9pbnQuaHRtbCB8IDYyICsrKysrKysrKysrKysrKysrKysKIC4uLi9odHRwL3Rlc3RzL2V2 ZW50bG9vcC9yZXNvdXJjZXMvaGVsbG8uaHRtbCB8ICA2ICsrCiA2IGZpbGVzIGNoYW5nZWQsIDEw OSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9ldmVudGxvb3AvaW5zZXJ0aW5nLWlmcmFtZS1zaG91bGQtbm90LXBl cmZvcm0tbWljcm90YXNrLWNoZWNrcG9pbnQtZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9kZSAxMDA2 NDQgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudGxvb3AvaW5zZXJ0aW5nLWlmcmFtZS1zaG91 bGQtbm90LXBlcmZvcm0tbWljcm90YXNrLWNoZWNrcG9pbnQuaHRtbAogY3JlYXRlIG1vZGUgMTAw NjQ0IExheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRsb29wL3Jlc291cmNlcy9oZWxsby5odG1s CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggZWExODNjY2I1NDk0Li42OGYzNDU0OTc3OWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNjIxNyw3ICs2MjE3LDEwIEBAIHZvaWQgRG9j dW1lbnQ6OmZpbmlzaGVkUGFyc2luZygpCiAgICAgfQogCiAgICAgLy8gRklYTUU6IFNjaGVkdWxl IGEgdGFzayB0byBmaXJlIERPTUNvbnRlbnRMb2FkZWQgZXZlbnQgaW5zdGVhZC4gU2VlIHdlYmtp dC5vcmcvYi84MjkzMQotICAgIGV2ZW50TG9vcCgpLnBlcmZvcm1NaWNyb3Rhc2tDaGVja3BvaW50 KCk7CisgICAgYXV0byogZG9jdW1lbnRMb2FkZXIgPSBsb2FkZXIoKTsKKyAgICBib29sIGlzSW5N aWRkbGVPZkluaXRpYWxpemluZ0lmcmFtZSA9IGRvY3VtZW50TG9hZGVyICYmIGRvY3VtZW50TG9h ZGVyLT5pc0luRmluaXNoZWRMb2FkaW5nT2ZFbXB0eURvY3VtZW50KCk7CisgICAgaWYgKCFpc0lu TWlkZGxlT2ZJbml0aWFsaXppbmdJZnJhbWUpCisgICAgICAgIGV2ZW50TG9vcCgpLnBlcmZvcm1N aWNyb3Rhc2tDaGVja3BvaW50KCk7CiAgICAgZGlzcGF0Y2hFdmVudChFdmVudDo6Y3JlYXRlKGV2 ZW50TmFtZXMoKS5ET01Db250ZW50TG9hZGVkRXZlbnQsIEV2ZW50OjpDYW5CdWJibGU6Olllcywg RXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm8pKTsKIAogICAgIGlmICghbV9ldmVudFRpbWluZy5kb21D b250ZW50TG9hZGVkRXZlbnRFbmQpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2Fk ZXIuY3BwCmluZGV4IDgyMWU2Mjc2NzM1Yy4uOTVmOGY1Yzc5MjQ3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKQEAgLTIwMzQsNiArMjAzNCw3IEBAIGJvb2wgRG9j dW1lbnRMb2FkZXI6Om1heWJlTG9hZEVtcHR5KCkKICAgICAgICAgfQogICAgIH0KIAorICAgIFNl dEZvclNjb3BlIGlzSW5GaW5pc2hlZExvYWRpbmdPZkVtcHR5RG9jdW1lbnQgeyBtX2lzSW5GaW5p c2hlZExvYWRpbmdPZkVtcHR5RG9jdW1lbnQsIHRydWUgfTsKICAgICBmaW5pc2hlZExvYWRpbmco KTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVy LmgKaW5kZXggNTBkZTc4NmE1NDgzLi40ODc3YThmZDM5OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5oCkBAIC00NTksNiArNDU5LDcgQEAgcHVibGljOgogICAgIGJvb2wg aXNDb250aW51aW5nTG9hZEFmdGVyUHJvdmlzaW9uYWxMb2FkU3RhcnRlZCgpIGNvbnN0IHsgcmV0 dXJuIG1faXNDb250aW51aW5nTG9hZEFmdGVyUHJvdmlzaW9uYWxMb2FkU3RhcnRlZDsgfQogICAg IHZvaWQgc2V0SXNDb250aW51aW5nTG9hZEFmdGVyUHJvdmlzaW9uYWxMb2FkU3RhcnRlZChib29s IGlzQ29udGludWluZ0xvYWRBZnRlclByb3Zpc2lvbmFsTG9hZFN0YXJ0ZWQpIHsgbV9pc0NvbnRp bnVpbmdMb2FkQWZ0ZXJQcm92aXNpb25hbExvYWRTdGFydGVkID0gaXNDb250aW51aW5nTG9hZEFm dGVyUHJvdmlzaW9uYWxMb2FkU3RhcnRlZDsgfQogCisgICAgYm9vbCBpc0luRmluaXNoZWRMb2Fk aW5nT2ZFbXB0eURvY3VtZW50KCkgY29uc3QgeyByZXR1cm4gbV9pc0luRmluaXNoZWRMb2FkaW5n T2ZFbXB0eURvY3VtZW50OyB9CiAjaWYgRU5BQkxFKENPTlRFTlRfRklMVEVSSU5HKQogICAgIGJv b2wgY29udGVudEZpbHRlcldpbGxIYW5kbGVQcm92aXNpb25hbExvYWRGYWlsdXJlKGNvbnN0IFJl c291cmNlRXJyb3ImKTsKICAgICB2b2lkIGNvbnRlbnRGaWx0ZXJIYW5kbGVQcm92aXNpb25hbExv YWRGYWlsdXJlKGNvbnN0IFJlc291cmNlRXJyb3ImKTsKQEAgLTYwNCw2ICs2MDUsNyBAQCBwcml2 YXRlOgogICAgIGJvb2wgbV9pc0NsaWVudFJlZGlyZWN0IHsgZmFsc2UgfTsKICAgICBib29sIG1f aXNMb2FkaW5nTXVsdGlwYXJ0Q29udGVudCB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2lzQ29udGlu dWluZ0xvYWRBZnRlclByb3Zpc2lvbmFsTG9hZFN0YXJ0ZWQgeyBmYWxzZSB9OworICAgIGJvb2wg bV9pc0luRmluaXNoZWRMb2FkaW5nT2ZFbXB0eURvY3VtZW50IHsgZmFsc2UgfTsKIAogICAgIC8v IEZJWE1FOiBEb2N1bWVudDo6bV9wcm9jZXNzaW5nTG9hZEV2ZW50IGFuZCBEb2N1bWVudExvYWRl cjo6bV93YXNPbmxvYWREaXNwYXRjaGVkIGFyZSByb3VnaGx5IHRoZSBzYW1lCiAgICAgLy8gYW5k IHNob3VsZCBiZSBtZXJnZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2 ZW50bG9vcC9pbnNlcnRpbmctaWZyYW1lLXNob3VsZC1ub3QtcGVyZm9ybS1taWNyb3Rhc2stY2hl Y2twb2ludC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50bG9vcC9p bnNlcnRpbmctaWZyYW1lLXNob3VsZC1ub3QtcGVyZm9ybS1taWNyb3Rhc2stY2hlY2twb2ludC1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwLi43Yjdm YjVlZTg1ZGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50 bG9vcC9pbnNlcnRpbmctaWZyYW1lLXNob3VsZC1ub3QtcGVyZm9ybS1taWNyb3Rhc2stY2hlY2tw b2ludC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzNCBAQAorVGhpcyB0ZXN0cyBpbnNlcnRpbmcg YW4gZW1wdHkgaWZyYW1lIGFmdGVyIHNjaGVkdWxpbmcgYSBtaWNyb3Rhc2suCitXZWJLaXQgc2hv dWxkIG5vdCBwZXJmb3JtIGEgbWljcm90YXNrIGNoZWNrcG9pbnQuCisKKworZW1wdHkKK2JlZ2lu IGluc2VydGluZyBpZnJhbWUKK2xvYWQgZXZlbnQKK2VuZCBpbnNlcnRpbmcgaWZyYW1lCittaWNy b3Rhc2sKKworYWJvdXQ6YmxhbmsKK2JlZ2luIGluc2VydGluZyBpZnJhbWUKK2xvYWQgZXZlbnQK K2VuZCBpbnNlcnRpbmcgaWZyYW1lCittaWNyb3Rhc2sKKworaGVsbG8uaHRtbAorYmVnaW4gaW5z ZXJ0aW5nIGlmcmFtZQorZW5kIGluc2VydGluZyBpZnJhbWUKK21pY3JvdGFzaworbG9hZCBldmVu dAorCitkYXRhIFVSTAorYmVnaW4gaW5zZXJ0aW5nIGlmcmFtZQorZW5kIGluc2VydGluZyBpZnJh bWUKK21pY3JvdGFzaworbG9hZCBldmVudAorCitzcmNkb2MKK2JlZ2luIGluc2VydGluZyBpZnJh bWUKK2VuZCBpbnNlcnRpbmcgaWZyYW1lCittaWNyb3Rhc2sKK2xvYWQgZXZlbnQKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudGxvb3AvaW5zZXJ0aW5nLWlmcmFtZS1z aG91bGQtbm90LXBlcmZvcm0tbWljcm90YXNrLWNoZWNrcG9pbnQuaHRtbCBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvZXZlbnRsb29wL2luc2VydGluZy1pZnJhbWUtc2hvdWxkLW5vdC1wZXJmb3Jt LW1pY3JvdGFzay1jaGVja3BvaW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwLi5mNGVhOGZkMDEzZDMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL2V2ZW50bG9vcC9pbnNlcnRpbmctaWZyYW1lLXNob3VsZC1ub3QtcGVyZm9ybS1t aWNyb3Rhc2stY2hlY2twb2ludC5odG1sCkBAIC0wLDAgKzEsNjIgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8Ym9keT4KKzxwPlRoaXMgdGVzdHMgaW5zZXJ0aW5nIGFuIGVtcHR5IGlmcmFt ZSBhZnRlciBzY2hlZHVsaW5nIGEgbWljcm90YXNrLjxicj4KK1dlYktpdCBzaG91bGQgbm90IHBl cmZvcm0gYSBtaWNyb3Rhc2sgY2hlY2twb2ludC48L3A+Cis8cHJlIGlkPSJsb2ciPjwvcHJlPgor PHNjcmlwdD4KK2xldCBsb2dDb3VudCA9IDA7CisKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgewor ICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4 dCgpOworfQorCitjb25zdCB0ZXN0Q2FzZXMgPSBbCisgICAge25hbWU6ICdlbXB0eScsIHRlc3Q6 IChpZnJhbWUpID0+IHt9fSwKKyAgICB7bmFtZTogJ2Fib3V0OmJsYW5rJywgdGVzdDogKGlmcmFt ZSkgPT4gaWZyYW1lLnNyYyA9ICdhYm91dDpibGFuayd9LAorICAgIHtuYW1lOiAnaGVsbG8uaHRt bCcsIHRlc3Q6IChpZnJhbWUpID0+IGlmcmFtZS5zcmMgPSAncmVzb3VyY2VzL2hlbGxvLmh0bWwn fSwKKyAgICB7bmFtZTogJ2RhdGEgVVJMJywgdGVzdDogKGlmcmFtZSkgPT4gaWZyYW1lLnNyYyA9 ICdkYXRhOnRleHQvaHRtbCw8IURPQ1RZUEUgaHRtbD5kYXRhJ30sCisgICAge25hbWU6ICdzcmNk b2MnLCB0ZXN0OiAoaWZyYW1lKSA9PiBpZnJhbWUuc3JjZG9jID0gJzwhRE9DVFlQRSBodG1sPnNy Y2RvYyd9LAorXQorCitmdW5jdGlvbiB0ZXN0KG5hbWUsIHRlc3RGdW5jdGlvbikgeworICAgIGZ1 bmN0aW9uIGxvZyhtZXNzYWdlKSB7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCds b2cnKS50ZXh0Q29udGVudCArPSBgJHttZXNzYWdlfVxuYDsKKyAgICB9CisKKyAgICByZXR1cm4g bmV3IFByb21pc2UoKHJlc29sdmUpID0+IHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ2xvZycpLnRleHRDb250ZW50ICs9IGBcbiR7bmFtZX1cbmA7CisKKyAgICAgICAgcXVldWVN aWNyb3Rhc2soKCkgPT4geworICAgICAgICAgICAgbG9nKCdtaWNyb3Rhc2snKTsKKyAgICAgICAg fSk7CisKKyAgICAgICAgY29uc3QgaWZyYW1lID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaWZy YW1lIik7CisgICAgICAgIGlmcmFtZS5vbmxvYWQgPSAoKSA9PiB7CisgICAgICAgICAgICBsb2co J2xvYWQgZXZlbnQnKTsKKyAgICAgICAgICAgIHNldFRpbWVvdXQobmV4dFRlc3QpOworICAgICAg ICB9CisgICAgICAgIHRlc3RGdW5jdGlvbihpZnJhbWUpOworICAgICAgICBsb2coJ2JlZ2luIGlu c2VydGluZyBpZnJhbWUnKTsKKyAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChpZnJh bWUpOworICAgICAgICBsb2coJ2VuZCBpbnNlcnRpbmcgaWZyYW1lJyk7CisgICAgfSk7Cit9CisK K29ubG9hZCA9IG5leHRUZXN0OworCitsZXQgdGVzdEluZGV4ID0gMDsKK2Z1bmN0aW9uIG5leHRU ZXN0KCkgeworICAgIGlmICh0ZXN0SW5kZXggPj0gdGVzdENhc2VzLmxlbmd0aCkgeworICAgICAg ICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURv bmUoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICB0ZXN0KHRlc3RDYXNlc1t0ZXN0SW5k ZXhdLm5hbWUsIHRlc3RDYXNlc1t0ZXN0SW5kZXhdLnRlc3QpOworICAgIHRlc3RJbmRleCsrOwor fQorCis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvZXZlbnRsb29wL3Jlc291cmNlcy9oZWxsby5odG1sIGIvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9ldmVudGxvb3AvcmVzb3VyY2VzL2hlbGxvLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwLi40NjU4ZjQ3ZTFmMzcKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50bG9vcC9yZXNvdXJjZXMvaGVsbG8uaHRtbApA QCAtMCwwICsxLDYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxwPmhlbGxv PC9wPgorPC9ib2R5PgorPC9odG1sPgo=