<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>235299</bug_id>
          
          <creation_ts>2022-01-17 14:03:33 -0800</creation_ts>
          <short_desc>Improve git-webkit pr error message</short_desc>
          <delta_ts>2022-01-19 11:49:00 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1831562</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-01-17 14:03:33 -0800</bug_when>
    <thetext>Below is the error message which I got when &apos;git-webkit pr&apos; failed. This isn&apos;t very informative and doesn&apos;t clearly tell what is the problem. There are couple of things which can be improved in it. e.g.: it should list the name of the repository which wasn&apos;t found, it should list the fork (e.g.: git@github.com:username/WebKit.git). It can even suggest to re-run &apos;git-webkit setup&apos; assuming that can potentially fix the problem (See Bug 235297 and Bug 235298).


[WebKit]$git-webkit pr
From github.com:WebKit/WebKit
 * branch                      main       -&gt; FETCH_HEAD
Current branch eng/235296 is up to date.
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Failed to push &apos;eng/235296&apos; to &apos;fork&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1831722</commentid>
    <comment_count>1</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-01-18 10:22:40 -0800</bug_when>
    <thetext>(In reply to Aakash Jain from comment #0)
&gt; Below is the error message which I got when &apos;git-webkit pr&apos; failed. This
&gt; isn&apos;t very informative and doesn&apos;t clearly tell what is the problem. There
&gt; are couple of things which can be improved in it. e.g.: it should list the
&gt; name of the repository which wasn&apos;t found, it should list the fork (e.g.:
&gt; git@github.com:username/WebKit.git). It can even suggest to re-run
&gt; &apos;git-webkit setup&apos; assuming that can potentially fix the problem (See Bug
&gt; 235297 and Bug 235298).
&gt; 
&gt; 
&gt; [WebKit]$git-webkit pr
&gt; From github.com:WebKit/WebKit
&gt;  * branch                      main       -&gt; FETCH_HEAD
&gt; Current branch eng/235296 is up to date.
&gt; ERROR: Repository not found.
&gt; fatal: Could not read from remote repository.
&gt; 
&gt; Please make sure you have the correct access rights
&gt; and the repository exists.
&gt; Failed to push &apos;eng/235296&apos; to &apos;fork&apos;

Kicker here is that other than the final error message, those are actually coming directly from `git`, not `git-webkit` script. So we can&apos;t easily change them. But we can give some resolution advice.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1831725</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-01-18 10:32:22 -0800</bug_when>
    <thetext>&lt;rdar://problem/87721181&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1831726</commentid>
    <comment_count>3</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-01-18 10:34:56 -0800</bug_when>
    <thetext>Pull-request: https://github.com/WebKit/WebKit/pull/76</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1832117</commentid>
    <comment_count>4</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2022-01-19 11:49:00 -0800</bug_when>
    <thetext>Landed 246182@main (r288222)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>