235298 2022-01-17 13:58:13 -0800 git-webkit setup should verify the credentials before saving them 2022-03-09 08:29:53 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235297 https://bugs.webkit.org/show_bug.cgi?id=237439 InRadar P2 Normal --- 1 aakash_jain jbedard webkit-bug-importer oldest_to_newest 1831561 0 aakash_jain 2022-01-17 13:58:13 -0800 git-webkit setup should verify the credentials before saving them. When I run git-webkit setup first time, I entered incorrect credentials (e.g.: email instead of username). git-webkit happily accepted the credentials, and configured incorrect remote based on those incorrect credentials. There should be some kind of validation before saving the credentials to ensure that credentials are correct. 1833467 1 webkit-bug-importer 2022-01-24 13:59:15 -0800 <rdar://problem/87988965> 1841813 2 jbedard 2022-02-15 11:03:58 -0800 I incorrectly associated 247173@main (r289687) with https://bugs.webkit.org/show_bug.cgi?id=235297, when it really fixed this bug. That change was reverted in 247175@main (r289690) because I had forgotten to cover the not-required case and broke commit queue. I have re-landed this change in 247283@main (r289835), fixing that problem. Note that verification only happens when the caller requests it, and we only request verification in `git-webkit setup`