235297 2022-01-17 13:55:17 -0800 git-webkit setup should allow changing the credentials 2022-03-09 08:29:39 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=235298 https://bugs.webkit.org/show_bug.cgi?id=237439 InRadar P2 Normal --- 236539 1 aakash_jain jbedard aakash_jain commit-queue jbedard webkit-bug-importer oldest_to_newest 1831560 0 aakash_jain 2022-01-17 13:55:17 -0800 git-webkit setup show allow changing the credentials. In case user made a mistake and entered incorrect credentials, there should be a way to either correct that or enter new credentials. Perhaps it can ask user if they want to update the stored credentials, and re-configure the correct remotes appropriately. 1833465 1 webkit-bug-importer 2022-01-24 13:56:16 -0800 <rdar://problem/87988794> 1838918 2 jbedard 2022-02-08 15:26:39 -0800 I think users would get a bit annoyed if their credentials were correct and we prompted them to validate them. My proposed change here is that we make an attempt to validate the user's credentials and prompt them only if the validation fails. I also think this applies to bugzilla credentials. 1838928 3 jbedard 2022-02-08 15:46:45 -0800 Pull request: https://github.com/WebKit/WebKit/pull/133 1840643 4 jbedard 2022-02-11 18:05:22 -0800 Landed 247173@main (r289687) 1840683 5 commit-queue 2022-02-12 06:18:22 -0800 Re-opened since this is blocked by bug 236539 1841817 6 jbedard 2022-02-15 11:07:24 -0800 247173@main (r289687) really should have been associated to https://bugs.webkit.org/show_bug.cgi?id=235298. I fixed the issue and re-landed that change. I am going to close this as 'WONTFIX' because I think it will make `git-webkit setup` worse. I think that the validation will, in practice, do a good job of covering the use case in mind here, because I don't think someone having valid credentials in their keychain would want to overwrite them with different credentials, I think they would only want to overwrite invalid credentials, which is covered very well by https://bugs.webkit.org/show_bug.cgi?id=235298