<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>235283</bug_id>
          
          <creation_ts>2022-01-16 14:26:03 -0800</creation_ts>
          <short_desc>[Win] Use character names instead of codepoint values in overrideControlCharacters()</short_desc>
          <delta_ts>2022-01-16 17:11:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Myles C. Maxfield">mmaxfield</reporter>
          <assigned_to name="Myles C. Maxfield">mmaxfield</assigned_to>
          <cc>darin</cc>
    
    <cc>heycam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1831345</commentid>
    <comment_count>0</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2022-01-16 14:26:03 -0800</bug_when>
    <thetext>[Win] Use character names instead of codepoint values in overrideControlCharacters()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1831346</commentid>
    <comment_count>1</comment_count>
      <attachid>449289</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2022-01-16 14:27:15 -0800</bug_when>
    <thetext>Created attachment 449289
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1831347</commentid>
    <comment_count>2</comment_count>
      <attachid>449289</attachid>
    <who name="Cameron McCormack (:heycam)">heycam</who>
    <bug_when>2022-01-16 14:29:49 -0800</bug_when>
    <thetext>Comment on attachment 449289
Patch

r=me although I do wonder if it&apos;s easier to understand the ranges using the code points rather than character names.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1831366</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-01-16 17:06:03 -0800</bug_when>
    <thetext>Committed r288077 (246097@main): &lt;https://commits.webkit.org/246097@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449289.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1831367</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-01-16 17:07:16 -0800</bug_when>
    <thetext>&lt;rdar://problem/87658786&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1831369</commentid>
    <comment_count>5</comment_count>
      <attachid>449289</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2022-01-16 17:11:41 -0800</bug_when>
    <thetext>Comment on attachment 449289
Patch

Win</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>449289</attachid>
            <date>2022-01-16 14:27:15 -0800</date>
            <delta_ts>2022-01-16 17:06:04 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-235283-20220116142714.patch</filename>
            <type>text/plain</type>
            <size>2016</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzVhY2M1OTdmMjEwNjY5
ZDcyNGRmZWYzNWU3YjVkNzBlMGM3NmNlNC4uNzE3Nzk5MDc5MjkwZjBmNzlkZGNjZDBiN2U5MjMx
NTQ3NGNhNzI2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAxLTE2ICBNeWxl
cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbl0gVXNl
IGNoYXJhY3RlciBuYW1lcyBpbnN0ZWFkIG9mIGNvZGVwb2ludCB2YWx1ZXMgaW4gb3ZlcnJpZGVD
b250cm9sQ2hhcmFjdGVycygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0yMzUyODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBJdCdzIHNpbXBseSBlYXNpZXIgdG8gcmVhZC4KKworICAgICAgICBObyBuZXcg
dGVzdHMgYmVjYXVzZSB0aGVyZSBpcyBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBw
bGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om92ZXJyaWRlQ29u
dHJvbENoYXJhY3RlcnMpOgorCiAyMDIyLTAxLTE1ICBBbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl
LmNvbT4KIAogICAgICAgICB3ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9yZW5kZXJpbmcvZGltZW5z
aW9uLWF0dHJpYnV0ZXMuaHRtbCBpcyBmYWlsaW5nIHdoZW4gdGFibGUgd2lkdGggaXMgc2V0IHRv
IDBweApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5j
cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcAppbmRleCA0ZTk0
OWRmYWI5NzY1YTJhMDdjNDg3OGFiZWUxMDNmYmFmMjFmNTcwLi4zNDZjNmRkNTVmOWQzYzBjMzI4
NGI2NjJmNjlkYmUzNmM0ZmU1NWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9Gb250LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy9Gb250LmNwcApAQCAtMzMzLDExICszMzMsMTEgQEAgc3RhdGljIHZvaWQgb3ZlcnJpZGVDb250
cm9sQ2hhcmFjdGVycyhWZWN0b3I8VUNoYXI+JiBidWZmZXIsIHVuc2lnbmVkIHN0YXJ0LCB1bnMK
ICAgICB9OwogCiAgICAgLy8gQ29kZSBwb2ludHMgMHgwIC0gMHgyMCBhbmQgMHg3RiAtIDB4QTAg
YXJlIGNvbnRyb2wgY2hhcmFjdGVyIGFuZCBzaG91bGRuJ3QgcmVuZGVyLiBNYXAgdGhlbSB0byBa
RVJPIFdJRFRIIFNQQUNFLgotICAgIG92ZXJ3cml0ZUNvZGVQb2ludHMoMHgwLCAweDIwLCB6ZXJv
V2lkdGhTcGFjZSk7Ci0gICAgb3ZlcndyaXRlQ29kZVBvaW50cygweDdGLCAweEEwLCB6ZXJvV2lk
dGhTcGFjZSk7CisgICAgb3ZlcndyaXRlQ29kZVBvaW50cyhudWxsQ2hhcmFjdGVyLCBzcGFjZSwg
emVyb1dpZHRoU3BhY2UpOworICAgIG92ZXJ3cml0ZUNvZGVQb2ludHMoZGVsZXRlQ2hhcmFjdGVy
LCBub0JyZWFrU3BhY2UsIHplcm9XaWR0aFNwYWNlKTsKICAgICBvdmVyd3JpdGVDb2RlUG9pbnQo
c29mdEh5cGhlbiwgemVyb1dpZHRoU3BhY2UpOwotICAgIG92ZXJ3cml0ZUNvZGVQb2ludCgnXG4n
LCBzcGFjZSk7Ci0gICAgb3ZlcndyaXRlQ29kZVBvaW50KCdcdCcsIHNwYWNlKTsKKyAgICBvdmVy
d3JpdGVDb2RlUG9pbnQobmV3bGluZUNoYXJhY3Rlciwgc3BhY2UpOworICAgIG92ZXJ3cml0ZUNv
ZGVQb2ludCh0YWJDaGFyYWN0ZXIsIHNwYWNlKTsKICAgICBvdmVyd3JpdGVDb2RlUG9pbnQobm9C
cmVha1NwYWNlLCBzcGFjZSk7CiAgICAgb3ZlcndyaXRlQ29kZVBvaW50KGxlZnRUb1JpZ2h0TWFy
aywgemVyb1dpZHRoU3BhY2UpOwogICAgIG92ZXJ3cml0ZUNvZGVQb2ludChyaWdodFRvTGVmdE1h
cmssIHplcm9XaWR0aFNwYWNlKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>