235273 2022-01-15 13:36:45 -0800 [GTK][STABLE] Missing headers for non-unified 2.34.3 build 2022-01-23 13:45:49 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED DUPLICATE 235444 P2 Normal --- 1 dennisn webkit-unassigned annulen bugs-noreply mcatanzaro oldest_to_newest 1831250 0 dennisn 2022-01-15 13:36:45 -0800 These missing #include's caused my non-unified compilation to fail. 1831251 1 449268 dennisn 2022-01-15 13:37:24 -0800 Created attachment 449268 missing headers patch 1831264 2 dennisn 2022-01-15 14:37:30 -0800 WebCore/css/calc/CSSCalcOperationNode.cpp and ebCore/css/calc/CSSCalcPrimitiveValueNode.cpp weren't able to see the definition of LOG_WITH_STREAM() WebCore/page/EventHandler.cpp wasn't able to recognize SetForScope() WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h wasn't able to recognize WebCore::FloatPoint ... but apparently only #if PLATFORM(GTK) ... so we should probably update the patch. It also wasn't able to find #include <WebCore/CoordinatedGraphicsLayer.h>, so I guess that needed to be wrapped in that additional #if USE(COORDINATED_GRAPHICS) WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h didn't recognize adjustTransientZoom() and commitTransientZoom() 1832878 3 mcatanzaro 2022-01-21 13:45:23 -0800 Please include a ChangeLog and make sure it passes EWS (patch must apply to trunk). Then you can separately submit a patch for the stable branch (which of course doesn't need to pass EWS). 1833138 4 dennisn 2022-01-23 13:45:49 -0800 *** This bug has been marked as a duplicate of bug 235444 *** 449268 2022-01-15 13:37:24 -0800 2022-01-15 20:26:16 -0800 missing headers patch missingheaders-2.34.3.patch text/plain 2205 dennisn LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL2NhbGMvQ1NTQ2FsY09wZXJhdGlvbk5vZGUuY3BwCTIw MjEtMDktMDEgMDU6MTY6NTAuMDAwMDAwMDAwIC0wNDAwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9jYWxjL0NTU0NhbGNPcGVyYXRpb25Ob2RlLmNwcAkyMDIyLTAxLTExIDE2OjI0OjE1LjAwMDAw MDAwMCAtMDUwMApAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1ZGUgIkNTU1ByaW1pdGl2ZVZhbHVl LmgiCiAjaW5jbHVkZSAiQ1NTVW5pdHMuaCIKICNpbmNsdWRlICJDYWxjRXhwcmVzc2lvbk9wZXJh dGlvbi5oIgorI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlIDx3dGYvdGV4dC9UZXh0U3Ry ZWFtLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL2Nh bGMvQ1NTQ2FsY1ByaW1pdGl2ZVZhbHVlTm9kZS5jcHAJMjAyMS0wOS0wMSAwNToxNjo1MC4wMDAw MDAwMDAgLTA0MDAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL2NhbGMvQ1NTQ2FsY1ByaW1pdGl2 ZVZhbHVlTm9kZS5jcHAJMjAyMi0wMS0xMSAxNjoyNDowMy4wMDAwMDAwMDAgLTA1MDAKQEAgLTMx LDYgKzMxLDcgQEAKICNpbmNsdWRlICJDU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgiCiAjaW5j bHVkZSAiQ2FsY0V4cHJlc3Npb25MZW5ndGguaCIKICNpbmNsdWRlICJDYWxjRXhwcmVzc2lvbk51 bWJlci5oIgorI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlIDx3dGYvdGV4dC9UZXh0U3Ry ZWFtLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9F dmVudEhhbmRsZXIuY3BwCTIwMjEtMTEtMjQgMDM6NTE6MDkuMDAwMDAwMDAwIC0wNTAwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkyMDIyLTAxLTExIDE2OjIzOjQz LjAwMDAwMDAwMCAtMDUwMApAQCAtMTE0LDYgKzExNCw3IEBACiAjaW5jbHVkZSAiV2luZG93c0tl eWJvYXJkQ29kZXMuaCIKICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogI2luY2x1ZGUgPHd0 Zi9OZXZlckRlc3Ryb3llZC5oPgorI2luY2x1ZGUgPHd0Zi9TZXRGb3JTY29wZS5oPgogI2luY2x1 ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KIAogI2lmIEVOQUJMRShJT1NfVE9VQ0hfRVZFTlRTKQot LS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNz L0RyYXdpbmdBcmVhQ29vcmRpbmF0ZWRHcmFwaGljcy5oCTIwMjEtMDktMDEgMDU6MTY6NTEuMDAw MDAwMDAwIC0wNDAwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvRHJhd2luZ0FyZWFDb29yZGluYXRlZEdyYXBoaWNzLmgJMjAyMi0wMS0x MSAxNjoyNzowNy4wMDAwMDAwMDAgLTA1MDAKQEAgLTI4LDYgKzI4LDcgQEAKICNwcmFnbWEgb25j ZQogCiAjaW5jbHVkZSAiRHJhd2luZ0FyZWEuaCIKKyNpbmNsdWRlICJMYXllclRyZWVIb3N0Lmgi CiAjaW5jbHVkZSA8V2ViQ29yZS9SZWdpb24uaD4KICNpbmNsdWRlIDx3dGYvUnVuTG9vcC5oPgog Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvTGF5ZXJUcmVlSG9zdC5oCTIwMjEtMDktMDEgMDU6MTY6NTEuMDAwMDAwMDAwIC0wNDAwCisr KyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv TGF5ZXJUcmVlSG9zdC5oCTIwMjItMDEtMTUgMTY6Mjc6MzYuMDAwMDAwMDAwIC0wNTAwCkBAIC0z MywxMyArMzMsMTYgQEAKICNpbmNsdWRlICJTaW1wbGVWaWV3cG9ydENvbnRyb2xsZXIuaCIKICNp bmNsdWRlICJUaHJlYWRlZENvbXBvc2l0b3IuaCIKICNpbmNsdWRlICJUaHJlYWRlZERpc3BsYXlS ZWZyZXNoTW9uaXRvci5oIgorI2luY2x1ZGUgPFdlYkNvcmUvRmxvYXRQb2ludC5oPgogI2luY2x1 ZGUgPFdlYkNvcmUvUGxhdGZvcm1TY3JlZW4uaD4KICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgog I2luY2x1ZGUgPHd0Zi9PcHRpb25TZXQuaD4KICNpbmNsdWRlIDx3dGYvUnVuTG9vcC5oPgorI2lm IFVTRShDT09SRElOQVRFRF9HUkFQSElDUykKICNpZiBQTEFURk9STShHVEspCiAjaW5jbHVkZSA8 V2ViQ29yZS9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaD4KICNlbmRpZgorI2VuZGlmCiAKICNp ZiBVU0UoR1JBUEhJQ1NfTEFZRVJfVEVYVFVSRV9NQVBQRVIpCiAK