235268 2022-01-15 11:38:02 -0800 Only use `diff --binary` switch on Windows 2022-01-15 15:11:35 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 27323 1 ddkilzer ddkilzer ap bburg jbedard webkit-bug-importer oldest_to_newest 1831218 0 ddkilzer 2022-01-15 11:38:02 -0800 Only use `diff --binary` switch on Windows. It was originally added for Windows ports that were not using Cygwin: Bug 27323: Further improve non-Cygwin SVN support. <https://bugs.webkit.org/show_bug.cgi?id=27323> <https://commits.webkit.org/r46095> 1831219 1 ddkilzer 2022-01-15 11:38:15 -0800 <rdar://problem/87490487> 1831220 2 449260 ddkilzer 2022-01-15 11:40:15 -0800 Created attachment 449260 Patch v1 1831221 3 449260 ap 2022-01-15 11:46:16 -0800 Comment on attachment 449260 Patch v1 Do "-u -a" mean the same thing as expected in the scenario that you are addressing? 1831266 4 ddkilzer 2022-01-15 14:46:21 -0800 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 449260 [details] > Patch v1 > > Do "-u -a" mean the same thing as expected in the scenario that you are > addressing? Yes. 1831273 5 ews-feeder 2022-01-15 15:11:31 -0800 Committed r288068 (246088@main): <https://commits.webkit.org/246088@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449260. 449260 2022-01-15 11:40:15 -0800 2022-01-15 15:11:33 -0800 Patch v1 bug-235268-20220115114014.patch text/plain 1389 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3ODI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGIyZTBkYWMxZjdiYWY2MGYwYzJjOTkxNjhjMzRiNGU2 MDQwZWRhMC4uZjhkZWQyNjhmZTY3NzZjYzkzODc3YzExZjkzMjE3NDljZDgyMjU4MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIyLTAxLTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgT25seSB1c2UgYGRpZmYgLS1iaW5hcnlgIHN3aXRjaCBvbiBXaW5kb3dzCisgICAgICAg IDxodHRwczovL3dlYmtpdC5vcmcvYi8yMzUyNjg+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84 NzQ5MDQ4Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvVkNTVXRpbHMucG06CisgICAgICAgIChtZXJnZUNoYW5nZUxvZ3MpOgorICAg ICAgICAtIE9ubHkgcGFzcyBgLS1iaW5hcnlgIHN3aXRjaCBvbiBXaW5kb3dzLgorCiAyMDIyLTAx LTA4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIE51 bGwgcG9pbnRlciBjcmFzaCB3aGVuIGNhbGxpbmcgaW50byBgLVtXZWJWaWV3IGNsb3NlXWAgaW4g YC13ZWJWaWV3OmRpZENvbW1pdExvYWRGb3JGcmFtZTpgCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL1ZDU1V0aWxzLnBtIGIvVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQppbmRleCA0ODZkMDFm NTNjODkyYzFhZjk1ZjdkNThiZTZhOTcxOTY0MTlkYTcxLi5kZjhiNTVmZTI0OWE5MGYxNmM4ZTQ1 MWMzZDAyODc2N2UwMTUzNzcxIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBt CisrKyBiL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KQEAgLTIxNDgsNyArMjE0OCw4IEBAIHN1 YiBtZXJnZUNoYW5nZUxvZ3MoJCQkKQogICAgICAgICByZW5hbWUoJGZpbGVNaW5lLCAiJGZpbGVN aW5lLnNhdmUiKTsKICAgICAgICAgcmVuYW1lKCRmaWxlT2xkZXIsICIkZmlsZU9sZGVyLnNhdmUi KTsKICAgICB9IGVsc2UgewotICAgICAgICBvcGVuKERJRkYsICJkaWZmIC11IC1hIC0tYmluYXJ5 IFwiJGZpbGVPbGRlclwiIFwiJGZpbGVNaW5lXCIgfCIpIG9yIGRpZSAkITsKKyAgICAgICAgbXkg JGJpbmFyeVN3aXRjaCA9IGlzV2luZG93cygpID8gIi0tYmluYXJ5IiA6ICIiOworICAgICAgICBv cGVuKERJRkYsICJkaWZmIC11IC1hICRiaW5hcnlTd2l0Y2ggXCIkZmlsZU9sZGVyXCIgXCIkZmls ZU1pbmVcIiB8Iikgb3IgZGllICQhOwogICAgICAgICAkcGF0Y2ggPSA8RElGRj47CiAgICAgICAg IGNsb3NlKERJRkYpOwogICAgIH0K