235253 2022-01-14 14:35:56 -0800 AX: Remove AXAriaAttributeChanged notification because it's not used by anything 2022-01-15 09:12:43 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach cgarcia dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1831089 0 tyler_w 2022-01-14 14:35:56 -0800 Nothing uses AXAriaAttributeChanged, but we still spend time processing it through the notification pipeline (postNotification -> m_notificationsToPost -> updateIsolatedTree(notifications) + postPlatformNotification(notifications)). 1831090 1 webkit-bug-importer 2022-01-14 14:36:28 -0800 <rdar://problem/87619004> 1831091 2 449227 tyler_w 2022-01-14 14:37:58 -0800 Created attachment 449227 Patch 1831093 3 449227 cfleizach 2022-01-14 14:40:50 -0800 Comment on attachment 449227 Patch we're sure GTK/Win don't use this? 1831102 4 tyler_w 2022-01-14 14:48:38 -0800 Yeah, quite sure. Windows doesn't handle it, and doesn't have a fallthrough in postPlatformNotification for notifications that aren't explicitly handled by name (it returns early if given an unexpected notification). ATK / ATSPI seems to be the same, but CC'd Carlos to confirm. Carlos, can you confirm that the ATK / ATSPI ports don't and won't use this? 1831103 5 cfleizach 2022-01-14 14:50:00 -0800 (In reply to Tyler Wilcock from comment #4) > Yeah, quite sure. Windows doesn't handle it, and doesn't have a fallthrough > in postPlatformNotification for notifications that aren't explicitly handled > by name (it returns early if given an unexpected notification). ATK / ATSPI > seems to be the same, but CC'd Carlos to confirm. > > Carlos, can you confirm that the ATK / ATSPI ports don't and won't use this? Ok if we pass all the builds probably ok. It can always be added back if we need it 1831198 6 ews-feeder 2022-01-15 09:12:40 -0800 Committed r288056 (246076@main): <https://commits.webkit.org/246076@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449227. 449227 2022-01-14 14:37:58 -0800 2022-01-15 09:12:42 -0800 Patch bug-235253-20220114163757.patch text/plain 4089 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQ1M2I0ZjVmMzNmMjM2 ODg0MGVlMjA5MDM0MTVhZDM4NzgyYTA2YS4uNjYyNmU2OGZlODk0NGVjNmJhZmQwZTJmYThlZWYz Mzg2ZmVjYzQwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAxLTE0ICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFJlbW92ZSBBWEFy aWFBdHRyaWJ1dGVDaGFuZ2VkIG5vdGlmaWNhdGlvbiBiZWNhdXNlIGl0J3Mgbm90IHVzZWQgYnkg YW55dGhpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzNTI1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vdGhpbmcgdXNlcyBBWEFyaWFBdHRyaWJ1dGVDaGFuZ2VkLCBidXQgd2Ugc3RpbGwgc3BlbmQg dGltZSBwcm9jZXNzaW5nCisgICAgICAgIGl0IHRocm91Z2ggdGhlIG5vdGlmaWNhdGlvbiBwaXBl bGluZSAocG9zdE5vdGlmaWNhdGlvbiAtPiBtX25vdGlmaWNhdGlvbnNUb1Bvc3QgLT4gdXBkYXRl SXNvbGF0ZWRUcmVlKG5vdGlmaWNhdGlvbnMpICsgcG9zdFBsYXRmb3JtTm90aWZpY2F0aW9uKG5v dGlmaWNhdGlvbnMpKS4KKworICAgICAgICBUaGlzIHBhdGNoIGRlbGV0ZXMgaXQuCisKKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L0FYTG9nZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om9wZXJh dG9yPDwpOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjpoYW5kbGVBdHRyaWJ1dGVDaGFuZ2UpOgorICAg ICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oOgorICAgICAgICAqIGFjY2Vzc2li aWxpdHkvYXRzcGkvQVhPYmplY3RDYWNoZUF0c3BpLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFY T2JqZWN0Q2FjaGU6OnBvc3RQbGF0Zm9ybU5vdGlmaWNhdGlvbik6CisKIDIwMjItMDEtMTQgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uKHIyODE1 MjApIDMgc3VidGVzdHMgc3RhcnRlZCBmYWlsaW5nIG9uIGRvbS90cmF2ZXJzYWwvVHJlZVdhbGtl ci1hY2NlcHROb2RlLWZpbHRlci1jcm9zcy1yZWFsbS5odG1sIFdQVCB0ZXN0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYTG9nZ2VyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQVhMb2dnZXIuY3BwCmluZGV4IDYxM2JmZWQ0NGY1ZGZjNmYxOGNl M2QzZTA5YzcxYThmNjkyYTEzNWIuLjE0N2JiYTk5NTMzMTdhYWM3ODBiYjUyOTUzYjhhMmMxZTU0 MjY1ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhMb2dnZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhMb2dnZXIuY3BwCkBAIC0z NDMsOSArMzQzLDYgQEAgVGV4dFN0cmVhbSYgb3BlcmF0b3I8PChUZXh0U3RyZWFtJiBzdHJlYW0s IEFYT2JqZWN0Q2FjaGU6OkFYTm90aWZpY2F0aW9uIG5vdGlmaWMKICAgICBjYXNlIEFYT2JqZWN0 Q2FjaGU6OkFYTm90aWZpY2F0aW9uOjpBWEFjdGl2ZURlc2NlbmRhbnRDaGFuZ2VkOgogICAgICAg ICBzdHJlYW0gPDwgIkFYQWN0aXZlRGVzY2VuZGFudENoYW5nZWQiOwogICAgICAgICBicmVhazsK LSAgICBjYXNlIEFYT2JqZWN0Q2FjaGU6OkFYTm90aWZpY2F0aW9uOjpBWEFyaWFBdHRyaWJ1dGVD aGFuZ2VkOgotICAgICAgICBzdHJlYW0gPDwgIkFYQXJpYUF0dHJpYnV0ZUNoYW5nZWQiOwotICAg ICAgICBicmVhazsKICAgICBjYXNlIEFYT2JqZWN0Q2FjaGU6OkFYTm90aWZpY2F0aW9uOjpBWEFy aWFSb2xlQ2hhbmdlZDoKICAgICAgICAgc3RyZWFtIDw8ICJBWEFyaWFSb2xlQ2hhbmdlZCI7CiAg ICAgICAgIGJyZWFrOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B WE9iamVjdENhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RD YWNoZS5jcHAKaW5kZXggMjZiMTI3ZjgwYmUzMzEzMDUwMDMyYTU2NDc2Y2YxMzhjMjY1MDI0ZS4u NWY1MzQyMWQ4OTQwNjVkZDUzZTIxYmY3N2EyOWY3YTk4ZjUzNGVmMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCkBAIC0xODQ3LDggKzE4NDcs NiBAQCB2b2lkIEFYT2JqZWN0Q2FjaGU6OmhhbmRsZUF0dHJpYnV0ZUNoYW5nZShjb25zdCBRdWFs aWZpZWROYW1lJiBhdHRyTmFtZSwgRWxlbWVudAogICAgICAgICBwb3N0Tm90aWZpY2F0aW9uKGVs ZW1lbnQsIEFYT2JqZWN0Q2FjaGU6OkFYUmVxdWlyZWRTdGF0dXNDaGFuZ2VkKTsKICAgICBlbHNl IGlmIChhdHRyTmFtZSA9PSBhcmlhX3NvcnRBdHRyKQogICAgICAgICBwb3N0Tm90aWZpY2F0aW9u KGVsZW1lbnQsIEFYT2JqZWN0Q2FjaGU6OkFYU29ydERpcmVjdGlvbkNoYW5nZWQpOwotICAgIGVs c2UKLSAgICAgICAgcG9zdE5vdGlmaWNhdGlvbihlbGVtZW50LCBBWE9iamVjdENhY2hlOjpBWEFy aWFBdHRyaWJ1dGVDaGFuZ2VkKTsKIH0KIAogdm9pZCBBWE9iamVjdENhY2hlOjpoYW5kbGVNb2Rh bENoYW5nZShFbGVtZW50JiBlbGVtZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmggYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FYT2JqZWN0Q2FjaGUuaAppbmRleCAyOTI1MDFiNzI1M2FmNGQ0NDM1YWU2NjFlNzRmODU2ZTM1 YzZiNGVjLi4yOTgwYTFmYjhhYWE5MWI1N2Q3MWM2MmM2ZjJjZGRkYzI0NTk2MDlmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaApAQCAtMjY4LDcgKzI2 OCw2IEBAIHB1YmxpYzoKIAogICAgIGVudW0gQVhOb3RpZmljYXRpb24gewogICAgICAgICBBWEFj dGl2ZURlc2NlbmRhbnRDaGFuZ2VkLAotICAgICAgICBBWEFyaWFBdHRyaWJ1dGVDaGFuZ2VkLAog ICAgICAgICBBWEFyaWFSb2xlQ2hhbmdlZCwKICAgICAgICAgQVhBdXRvY29ycmVjdGlvbk9jY3Vy ZWQsCiAgICAgICAgIEFYQ2hlY2tlZFN0YXRlQ2hhbmdlZCwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkvQVhPYmplY3RDYWNoZUF0c3BpLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkvQVhPYmplY3RDYWNoZUF0c3BpLmNwcAppbmRl eCA4YjNlOTExOTFmNzNlMzg1MGM2MDVjZTU5MmMwMTI3Zjk3NWY5ZDMyLi5mNTBhODU4NjRhMGU2 ZTJmOTI1ZTE5MTM1NDczMDExYTU5MzU0Y2E1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2F0c3BpL0FYT2JqZWN0Q2FjaGVBdHNwaS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BWE9iamVjdENhY2hlQXRzcGkuY3BwCkBAIC0xNTcs OCArMTU3LDYgQEAgdm9pZCBBWE9iamVjdENhY2hlOjpwb3N0UGxhdGZvcm1Ob3RpZmljYXRpb24o QVhDb3JlT2JqZWN0KiBjb3JlT2JqZWN0LCBBWE5vdGlmaWMKICAgICAgICAgaWYgKGF1dG8qIGRl c2NlbmRhbnQgPSBjb3JlT2JqZWN0LT5hY3RpdmVEZXNjZW5kYW50KCkpCiAgICAgICAgICAgICBw bGF0Zm9ybUhhbmRsZUZvY3VzZWRVSUVsZW1lbnRDaGFuZ2VkKG51bGxwdHIsIGRlc2NlbmRhbnQt Pm5vZGUoKSk7CiAgICAgICAgIGJyZWFrOwotICAgIGNhc2UgQVhBcmlhQXR0cmlidXRlQ2hhbmdl ZDoKLSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBBWEFyaWFSb2xlQ2hhbmdlZDoKICAgICAgICAg YnJlYWs7CiAgICAgY2FzZSBBWEF1dG9jb3JyZWN0aW9uT2NjdXJlZDoK