235251 2022-01-14 13:50:53 -0800 Make a function that returns the ordered list of top layer RenderLayers 2022-01-15 10:53:15 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham cdumez changseok esprehn+autocc ews-watchlist fred.wang glenn kangil.han kondapallykalyan ntim pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1831066 0 simon.fraser 2022-01-14 13:50:53 -0800 Make a function that returns the ordered list of top layer RenderLayers 1831068 1 449217 simon.fraser 2022-01-14 13:51:58 -0800 Created attachment 449217 Patch 1831074 2 449217 ntim 2022-01-14 14:03:14 -0800 Comment on attachment 449217 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449217&action=review > Source/WebCore/rendering/RenderLayer.cpp:3996 > +Vector<RenderLayer*> RenderLayer::topLayerRenderLayers(RenderView& renderView) nit: this name has the ambiguity that was trying to be avoided with establishesTopLayer 1831213 3 ews-feeder 2022-01-15 10:52:47 -0800 Committed r288059 (246079@main): <https://commits.webkit.org/246079@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449217. 1831214 4 webkit-bug-importer 2022-01-15 10:53:15 -0800 <rdar://problem/87640036> 449217 2022-01-14 13:51:58 -0800 2022-01-15 10:52:50 -0800 Patch bug-235251-20220114135157.patch text/plain 4898 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3OTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzIwYTY1NmM5OWZjMDNh YmYyZTQwZjdmZWIzMmZmNTVlNzc5Y2E4Ny4uMmIxYjllZGQwOGE1MjE0OGExNGRmMmFjODRkMDkw MTk5ZmVmZjgxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIyLTAxLTE0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgYSBmdW5j dGlvbiB0aGF0IHJldHVybnMgdGhlIG9yZGVyZWQgbGlzdCBvZiB0b3AgbGF5ZXIgUmVuZGVyTGF5 ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzUy NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGYWN0 b3IgdGhlIGNvZGUgaW4gUmVuZGVyTGF5ZXI6OnJlYnVpbGRaT3JkZXJMaXN0cygpIHRoYXQgZ2Vu ZXJhdGVzIHRoZSBsaXN0IG9mCisgICAgICAgIHRvcC1sYXllciBSZW5kZXJMYXllcnMgaW50byBp dHMgb3duIGZ1bmN0aW9uLgorCisgICAgICAgIEFkZCBEb2N1bWVudDo6aGFzVG9wTGF5ZXJFbGVt ZW50KCkgdG8gYXZvaWQgY2FsbGluZyBpdCB3aGVuIHRoZXJlIGFyZSBubyB0b3AgbGF5ZXIKKyAg ICAgICAgZWxlbWVudHMuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKyAgICAgICAgKFdl YkNvcmU6OkRvY3VtZW50OjpoYXNUb3BMYXllckVsZW1lbnQgY29uc3QpOgorICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6 cmVidWlsZFpPcmRlckxpc3RzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaDoK KwogMjAyMi0wMS0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBTaGFyZSBzb21lIGNvZGUgdGhhdCBsb29rcyBhdCB2aXNpYmlsaXR5IGluIG9yZGVy IHRvIHNob3J0LWNpcmN1aXQgcmVwYWludCByZWN0IGNvbXB1dGF0aW9uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5oCmluZGV4IDJjOGRmMzE2ODA2ZDY1MzZmOWUwY2M1MmI3NGE4NTE3ZTA5N2JlNzYuLjA3Nzkw NGM4YTgwMTM3ZmNjMDVmNjAyNTFjMThjOGFiMzE2YWEyMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5o CkBAIC0xNTQ4LDYgKzE1NDgsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBhZGRUb3BMYXllckVsZW1l bnQoRWxlbWVudCYpOwogICAgIHZvaWQgcmVtb3ZlVG9wTGF5ZXJFbGVtZW50KEVsZW1lbnQmKTsK ICAgICBjb25zdCBMaXN0SGFzaFNldDxSZWY8RWxlbWVudD4+JiB0b3BMYXllckVsZW1lbnRzKCkg Y29uc3QgeyByZXR1cm4gbV90b3BMYXllckVsZW1lbnRzOyB9CisgICAgYm9vbCBoYXNUb3BMYXll ckVsZW1lbnQoKSBjb25zdCB7IHJldHVybiAhbV90b3BMYXllckVsZW1lbnRzLmlzRW1wdHkoKTsg fQogCiAgICAgSFRNTERpYWxvZ0VsZW1lbnQqIGFjdGl2ZU1vZGFsRGlhbG9nKCkgY29uc3Q7CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IDZlYzQwNTY1MmQ4 NDFkZTg0ZjlhMWM5Y2MzNjE1Y2QzMmUzNjAxZWQuLmNjY2UxYzY4ZmM1NWM1ZWQ1NDVkOGRmYjZk NDQxODNlNjg1MTRmODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNw cApAQCAtNzg2LDI1ICs3ODYsMTMgQEAgdm9pZCBSZW5kZXJMYXllcjo6cmVidWlsZFpPcmRlckxp c3RzKHN0ZDo6dW5pcXVlX3B0cjxWZWN0b3I8UmVuZGVyTGF5ZXIqPj4mIHBvc1oKICAgICAgICAg bmVnWk9yZGVyTGlzdC0+c2hyaW5rVG9GaXQoKTsKICAgICB9CiAKLSAgICBpZiAoaXNSZW5kZXJW aWV3TGF5ZXIoKSkgewotICAgICAgICBhdXRvIHRvcExheWVyRWxlbWVudHMgPSByZW5kZXJlcigp LmRvY3VtZW50KCkudG9wTGF5ZXJFbGVtZW50cygpOwotICAgICAgICBmb3IgKGF1dG8mIGVsZW1l bnQgOiB0b3BMYXllckVsZW1lbnRzKSB7Ci0gICAgICAgICAgICBSZW5kZXJFbGVtZW50KiByZW5k ZXJlciA9IGVsZW1lbnQtPnJlbmRlcmVyKCk7Ci0gICAgICAgICAgICBpZiAoIXJlbmRlcmVyKQot ICAgICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICAgICAgYXV0byBiYWNrZHJvcFJlbmRl cmVyID0gcmVuZGVyZXItPmJhY2tkcm9wUmVuZGVyZXIoKTsKLSAgICAgICAgICAgIGlmIChiYWNr ZHJvcFJlbmRlcmVyICYmIGJhY2tkcm9wUmVuZGVyZXItPmhhc0xheWVyKCkpIHsKLSAgICAgICAg ICAgICAgICBSZW5kZXJMYXllciogbGF5ZXIgPSBiYWNrZHJvcFJlbmRlcmVyLT5sYXllcigpOwot ICAgICAgICAgICAgICAgIGlmICghcG9zWk9yZGVyTGlzdCkKLSAgICAgICAgICAgICAgICAgICAg cG9zWk9yZGVyTGlzdCA9IG1ha2VVbmlxdWU8VmVjdG9yPFJlbmRlckxheWVyKj4+KCk7Ci0gICAg ICAgICAgICAgICAgcG9zWk9yZGVyTGlzdC0+YXBwZW5kKGxheWVyKTsKLSAgICAgICAgICAgIH0K LSAgICAgICAgICAgIGlmIChyZW5kZXJlci0+aGFzTGF5ZXIoKSkgewotICAgICAgICAgICAgICAg IFJlbmRlckxheWVyKiBsYXllciA9IGRvd25jYXN0PFJlbmRlckxheWVyTW9kZWxPYmplY3Q+KCpy ZW5kZXJlcikubGF5ZXIoKTsKLSAgICAgICAgICAgICAgICBpZiAoIXBvc1pPcmRlckxpc3QpCi0g ICAgICAgICAgICAgICAgICAgIHBvc1pPcmRlckxpc3QgPSBtYWtlVW5pcXVlPFZlY3RvcjxSZW5k ZXJMYXllcio+PigpOwotICAgICAgICAgICAgICAgIHBvc1pPcmRlckxpc3QtPmFwcGVuZChsYXll cik7Ci0gICAgICAgICAgICB9CisgICAgaWYgKGlzUmVuZGVyVmlld0xheWVyKCkgJiYgcmVuZGVy ZXIoKS5kb2N1bWVudCgpLmhhc1RvcExheWVyRWxlbWVudCgpKSB7CisgICAgICAgIGF1dG8gdG9w TGF5ZXJMYXllcnMgPSB0b3BMYXllclJlbmRlckxheWVycyhyZW5kZXJlcigpLnZpZXcoKSk7Cisg ICAgICAgIGlmICh0b3BMYXllckxheWVycy5zaXplKCkpIHsKKyAgICAgICAgICAgIGlmICghcG9z Wk9yZGVyTGlzdCkKKyAgICAgICAgICAgICAgICBwb3NaT3JkZXJMaXN0ID0gbWFrZVVuaXF1ZTxW ZWN0b3I8UmVuZGVyTGF5ZXIqPj4oKTsKKworICAgICAgICAgICAgcG9zWk9yZGVyTGlzdC0+YXBw ZW5kVmVjdG9yKHRvcExheWVyTGF5ZXJzKTsKICAgICAgICAgfQogICAgIH0KIH0KQEAgLTQwMDUs NiArMzk5MywyNSBAQCBFbGVtZW50KiBSZW5kZXJMYXllcjo6ZW5jbG9zaW5nRWxlbWVudCgpIGNv bnN0CiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKK1ZlY3RvcjxSZW5kZXJMYXllcio+IFJlbmRl ckxheWVyOjp0b3BMYXllclJlbmRlckxheWVycyhSZW5kZXJWaWV3JiByZW5kZXJWaWV3KQorewor ICAgIFZlY3RvcjxSZW5kZXJMYXllcio+IGxheWVyczsKKyAgICBhdXRvIHRvcExheWVyRWxlbWVu dHMgPSByZW5kZXJWaWV3LmRvY3VtZW50KCkudG9wTGF5ZXJFbGVtZW50cygpOworICAgIGZvciAo YXV0byYgZWxlbWVudCA6IHRvcExheWVyRWxlbWVudHMpIHsKKyAgICAgICAgYXV0byogcmVuZGVy ZXIgPSBlbGVtZW50LT5yZW5kZXJlcigpOworICAgICAgICBpZiAoIXJlbmRlcmVyKQorICAgICAg ICAgICAgY29udGludWU7CisKKyAgICAgICAgYXV0byBiYWNrZHJvcFJlbmRlcmVyID0gcmVuZGVy ZXItPmJhY2tkcm9wUmVuZGVyZXIoKTsKKyAgICAgICAgaWYgKGJhY2tkcm9wUmVuZGVyZXIgJiYg YmFja2Ryb3BSZW5kZXJlci0+aGFzTGF5ZXIoKSkKKyAgICAgICAgICAgIGxheWVycy5hcHBlbmQo YmFja2Ryb3BSZW5kZXJlci0+bGF5ZXIoKSk7CisKKyAgICAgICAgaWYgKHJlbmRlcmVyLT5oYXNM YXllcigpKQorICAgICAgICAgICAgbGF5ZXJzLmFwcGVuZChkb3duY2FzdDxSZW5kZXJMYXllck1v ZGVsT2JqZWN0PigqcmVuZGVyZXIpLmxheWVyKCkpOworICAgIH0KKyAgICByZXR1cm4gbGF5ZXJz OworfQorCiBib29sIFJlbmRlckxheWVyOjplc3RhYmxpc2hlc1RvcExheWVyKCkgY29uc3QKIHsK ICAgICByZXR1cm4gaXNJblRvcExheWVyT3JCYWNrZHJvcChyZW5kZXJlcigpLnN0eWxlKCksIHJl bmRlcmVyKCkuZWxlbWVudCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgK aW5kZXggMmIwNDUxYWVjYjYxMDliMGEyZGM4ZTRiODVhNzAzMmM0MjkyM2VhZi4uNzU3ODVkZjgz YTljYzkwYjFkNWM4ZDE0NTk1ZjdjZjRlY2Q3ZTZiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmgKQEAgLTgyMCw2ICs4MjAsOCBAQCBwdWJsaWM6CiAKICAgICBFbGVtZW50 KiBlbmNsb3NpbmdFbGVtZW50KCkgY29uc3Q7CiAKKyAgICBzdGF0aWMgVmVjdG9yPFJlbmRlckxh eWVyKj4gdG9wTGF5ZXJSZW5kZXJMYXllcnMoUmVuZGVyVmlldyYpOworCiAgICAgYm9vbCBlc3Rh Ymxpc2hlc1RvcExheWVyKCkgY29uc3Q7CiAgICAgdm9pZCBlc3RhYmxpc2hlc1RvcExheWVyV2ls bENoYW5nZSgpOwogICAgIHZvaWQgZXN0YWJsaXNoZXNUb3BMYXllckRpZENoYW5nZSgpOwo=