235198 2022-01-13 13:32:06 -0800 Avoid unnecessary call to windowScreenDidChange 2022-01-13 15:05:17 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham ggaren graouts simon.fraser slewis webkit-bug-importer oldest_to_newest 1830683 0 pvollan 2022-01-13 13:32:06 -0800 It is a page load performance progression to avoid this call. 1830684 1 pvollan 2022-01-13 13:33:22 -0800 <rdar://87458502> 1830686 2 449098 pvollan 2022-01-13 13:34:40 -0800 Created attachment 449098 Patch 1830691 3 449098 ggaren 2022-01-13 13:44:01 -0800 Comment on attachment 449098 Patch r=me This is a great fix for a regression in trunk. Having fixed the regression, I'm concerned that we've got a ticking time bomb that will regress again when we enable WebAnimationsCustomFrameRate by default. What should we do about that? 1830697 4 pvollan 2022-01-13 13:50:03 -0800 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 449098 [details] > Patch > > r=me > > This is a great fix for a regression in trunk. > > Having fixed the regression, I'm concerned that we've got a ticking time > bomb that will regress again when we enable WebAnimationsCustomFrameRate by > default. What should we do about that? I can create a new bug for that. Thanks for reviewing! 1830737 5 ews-feeder 2022-01-13 15:05:12 -0800 Committed r287995 (246022@main): <https://commits.webkit.org/246022@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449098. 449098 2022-01-13 13:34:40 -0800 2022-01-13 15:05:14 -0800 Patch bug-235198-20220113133439.patch text/plain 2270 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODc5OTIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAxLTEzICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCB1bm5lY2Vzc2FyeSBj YWxsIHRvIHdpbmRvd1NjcmVlbkRpZENoYW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1MTk4CisgICAgICAgIDxyZGFyOi8vODc0NTg1MDI+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgaXMgYSBw YWdlIGxvYWQgcGVyZm9ybWFuY2UgcHJvZ3Jlc3Npb24gdG8gYXZvaWQgdGhpcyBjYWxsIGluIGlu aXRXaXRoRHJhd2luZ0FyZWFQcm94eS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9SZW1vdGVMYXll clRyZWUvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eS5tbToKKyAgICAgICAgKC1bV0tP bmVTaG90RGlzcGxheUxpbmtIYW5kbGVyIGluaXRXaXRoRHJhd2luZ0FyZWFQcm94eTpdKToKKwog MjAyMi0wMS0xMyAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAg ICAgW2lPU11bTmV0d29ya2luZ10gQWRkIGFjY2VzcyB0byByZXF1aXJlZCBuZXR3b3JrIHNlcnZp Y2UKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVM YXllclRyZWVEcmF3aW5nQXJlYVByb3h5Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5 Lm1tCShyZXZpc2lvbiAyODc2MzYpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9SZW1vdGVM YXllclRyZWUvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eS5tbQkod29ya2luZyBjb3B5 KQpAQCAtNzEsMTIgKzcxLDE0IEBAIC0gKGlkKWluaXRXaXRoRHJhd2luZ0FyZWFQcm94eTooV2Vi S2l0OjoKICAgICAgICAgX2Rpc3BsYXlMaW5rLnByZWZlcnJlZEZyYW1lc1BlclNlY29uZCA9IDYw OwogCiAgICAgICAgIGlmIChkcmF3aW5nQXJlYVByb3h5KSB7Ci0gICAgICAgICAgICBhdXRvIG1p bmltdW1SZWZyZXNoSW50ZXJ2YWwgPSBfZGlzcGxheUxpbmsubWF4aW11bVJlZnJlc2hSYXRlOwot ICAgICAgICAgICAgaWYgKG1pbmltdW1SZWZyZXNoSW50ZXJ2YWwgPiAwKSB7Ci0gICAgICAgICAg ICAgICAgYXV0byYgcGFnZSA9IGRyYXdpbmdBcmVhUHJveHktPnBhZ2UoKTsKLSAgICAgICAgICAg ICAgICBpZiAoYXV0byBkaXNwbGF5SWQgPSBwYWdlLmRpc3BsYXlJZCgpKSB7Ci0gICAgICAgICAg ICAgICAgICAgIFdlYkNvcmU6OkZyYW1lc1BlclNlY29uZCBmcmFtZVJhdGUgPSBzdGQ6OnJvdW5k KDEuMCAvIG1pbmltdW1SZWZyZXNoSW50ZXJ2YWwpOwotICAgICAgICAgICAgICAgICAgICBwYWdl LndpbmRvd1NjcmVlbkRpZENoYW5nZSgqZGlzcGxheUlkLCBmcmFtZVJhdGUpOworICAgICAgICAg ICAgYXV0byYgcGFnZSA9IGRyYXdpbmdBcmVhUHJveHktPnBhZ2UoKTsKKyAgICAgICAgICAgIGlm IChwYWdlLnByZWZlcmVuY2VzKCkud2ViQW5pbWF0aW9uc0N1c3RvbUZyYW1lUmF0ZUVuYWJsZWQo KSkgeworICAgICAgICAgICAgICAgIGF1dG8gbWluaW11bVJlZnJlc2hJbnRlcnZhbCA9IF9kaXNw bGF5TGluay5tYXhpbXVtUmVmcmVzaFJhdGU7CisgICAgICAgICAgICAgICAgaWYgKG1pbmltdW1S ZWZyZXNoSW50ZXJ2YWwgPiAwKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChhdXRvIGRpc3Bs YXlJZCA9IHBhZ2UuZGlzcGxheUlkKCkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIFdlYkNv cmU6OkZyYW1lc1BlclNlY29uZCBmcmFtZVJhdGUgPSBzdGQ6OnJvdW5kKDEuMCAvIG1pbmltdW1S ZWZyZXNoSW50ZXJ2YWwpOworICAgICAgICAgICAgICAgICAgICAgICAgcGFnZS53aW5kb3dTY3Jl ZW5EaWRDaGFuZ2UoKmRpc3BsYXlJZCwgZnJhbWVSYXRlKTsKKyAgICAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgfQo=