235190 2022-01-13 10:12:41 -0800 [libpas] add assertions that we aren't switching to a NULL lock 2022-01-13 13:12:33 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo ggaren webkit-bug-importer ysuzuki oldest_to_newest 1830604 0 fpizlo 2022-01-13 10:12:41 -0800 ... 1830605 1 webkit-bug-importer 2022-01-13 10:13:03 -0800 <rdar://problem/87557006> 1830618 2 449082 fpizlo 2022-01-13 10:32:47 -0800 Created attachment 449082 the patch 1830674 3 449082 ysuzuki 2022-01-13 13:10:40 -0800 Comment on attachment 449082 the patch r=me 1830677 4 fpizlo 2022-01-13 13:12:33 -0800 Landed in https://trac.webkit.org/changeset/287991/webkit 449082 2022-01-13 10:32:47 -0800 2022-01-13 13:10:40 -0800 the patch blah.patch text/plain 5489 fpizlo SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4Nzk4MSkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDIyLTAxLTEzICBGaWxpcCBQ aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgW2xpYnBhc10gYWRkIGFzc2VydGlv bnMgdGhhdCB3ZSBhcmVuJ3Qgc3dpdGNoaW5nIHRvIGEgTlVMTCBsb2NrCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzUxOTAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGFkZHMgYSBwYXNfcGFuaWMg Y2FsbCB3aGVuIHBhc19sb2NhbF9hbGxvY2F0b3Jfc3RvcCBzZWVzIGEgTlVMTCBwYWdlLT5sb2Nr X3B0ci4gVGhhdCdzIG9uZQorICAgICAgICBwb3NzaWJsZSBleHBsYW5hdGlvbiBvZiBhIHZlcnkg cmFyZSBjcmFzaCBJJ20gc2VlaW5nIHdoZXJlIHJldHVybl9tZW1vcnlfdG9fcGFnZSBmYWlscyBp dHMgYXNzZXJ0aW9uCisgICAgICAgIHRoYXQgd2UgYXJlIGhvbGRpbmcgdGhlIHBhZ2UgbG9jay4K KworICAgICAgICBUaGlzIGFsc28gYWRkcyBURVNUSU5HIGFzc2VydHMgaW4gYSBidW5jaCBvZiBv dGhlciBwbGFjZXMuIFRoZSBQQVNfVEVTVElOR19BU1NFUlRTIGFib3V0IHRoaXMgYXJlIGluCisg ICAgICAgIHBsYWNlcyB0aGF0IGFyZSBwZXJmLXNlbnNpdGl2ZSwgc28gd2UgcHJvYmFibHkgY2Fu bm90IGFzc2VydCBpbiBwcm9kdWN0aW9uLiBUaGUgaG9wZSBiZWhpbmQgdGhvc2UgaXMKKyAgICAg ICAgdGhhdCBpdCB3aWxsIGhlbHAgdG8gY2F0Y2ggdGhpcyBpc3N1ZSBpbiB0ZXN0X3Bhcy4KKwor ICAgICAgICAqIGxpYnBhcy9zcmMvbGlicGFzL3Bhc19sb2NhbF9hbGxvY2F0b3IuYzoKKyAgICAg ICAgKHN0b3BfaW1wbCk6CisgICAgICAgICogbGlicGFzL3NyYy9saWJwYXMvcGFzX3NlZ3JlZ2F0 ZWRfcGFnZS5jOgorICAgICAgICAocGFzX3NlZ3JlZ2F0ZWRfcGFnZV9zd2l0Y2hfbG9ja19hbmRf cmViaWFzX3doaWxlX2luZWxpZ2libGVfaW1wbCk6CisgICAgICAgICogbGlicGFzL3NyYy9saWJw YXMvcGFzX3NlZ3JlZ2F0ZWRfcGFnZV9pbmxpbmVzLmg6CisgICAgICAgIChwYXNfc2VncmVnYXRl ZF9wYWdlX2xvY2tfd2l0aF91bmJpYXNfbm90X3V0aWxpdHkpOgorICAgICAgICAocGFzX3NlZ3Jl Z2F0ZWRfcGFnZV9sb2NrX3dpdGhfdW5iaWFzKToKKyAgICAgICAgKHBhc19zZWdyZWdhdGVkX3Bh Z2VfbG9jayk6CisgICAgICAgIChwYXNfc2VncmVnYXRlZF9wYWdlX3N3aXRjaF9sb2NrX2ltcGwp OgorICAgICAgICAocGFzX3NlZ3JlZ2F0ZWRfcGFnZV9zd2l0Y2hfbG9ja193aXRoX21vZGUpOgor CiAyMDIyLTAxLTEyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAg W2xpYnBhc10gdGhyZWFkX2xvY2FsX2NhY2hlIHNob3VsZCBub3QgYmUgYWxsb2NhdGVkIGluIHRo ZSBjb21wYWN0IGhlYXAgKGNoZXJyeSBwaWNrIDExYWZjZWRmYjU5NjhmNjg5NDM3OWZmMWE0MWRk NDQ5YmE3NzQ1ZjYpCkluZGV4OiBTb3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNf bG9jYWxfYWxsb2NhdG9yLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvbGlicGFzL3Ny Yy9saWJwYXMvcGFzX2xvY2FsX2FsbG9jYXRvci5jCShyZXZpc2lvbiAyODc5NjgpCisrKyBTb3Vy Y2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfbG9jYWxfYWxsb2NhdG9yLmMJKHdvcmtp bmcgY29weSkKQEAgLTE4MCw2ICsxODAsOSBAQCBzdGF0aWMgYm9vbCBzdG9wX2ltcGwoCiAgICAg CiAgICAgaWYgKCFwYXNfc2VncmVnYXRlZF9wYWdlX3N3aXRjaF9sb2NrX3dpdGhfbW9kZShwYWdl LCAmaGVsZF9sb2NrLCBwYWdlX2xvY2tfbW9kZSwgcGFnZV9jb25maWcpKQogICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICBpZiAoIXBhc19zZWdyZWdhdGVkX3BhZ2VfY29uZmlnX2lzX3V0aWxp dHkocGFnZV9jb25maWcpICYmICFoZWxkX2xvY2spCisgICAgICAgIHBhc19wYW5pYygiU2hvdWxk IGJlIGhvbGRpbmcgYSBsb2NrIGFmdGVyIHBhc19zZWdyZWdhdGVkX3BhZ2Vfc3dpdGNoX2xvY2tf d2l0aF9tb2RlIGluIHN0b3BfaW1wbFxuIik7CiAgICAgCiAgICAgcGFnZV9jb25maWcuc3BlY2lh bGl6ZWRfbG9jYWxfYWxsb2NhdG9yX3JldHVybl9tZW1vcnlfdG9fcGFnZSgKICAgICAgICAgYWxs b2NhdG9yLCB2aWV3LCBwYWdlLCBkaXJlY3RvcnksIGhlYXBfbG9ja19ob2xkX21vZGUpOwpJbmRl eDogU291cmNlL2JtYWxsb2MvbGlicGFzL3NyYy9saWJwYXMvcGFzX3NlZ3JlZ2F0ZWRfcGFnZS5j Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19zZWdy ZWdhdGVkX3BhZ2UuYwkocmV2aXNpb24gMjg3OTY3KQorKysgU291cmNlL2JtYWxsb2MvbGlicGFz L3NyYy9saWJwYXMvcGFzX3NlZ3JlZ2F0ZWRfcGFnZS5jCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUg KzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoYykgMjAxOC0yMDIxIEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoYykgMjAxOC0yMDIyIEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJj ZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJl IHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMTI1 LDYgKzEyNSw3IEBAIHZvaWQgcGFzX3NlZ3JlZ2F0ZWRfcGFnZV9zd2l0Y2hfbG9ja19hbmQKICAg ICAgICAgYm9vbCBnb3RfcmlnaHRfbG9jazsKICAgICAKICAgICAgICAgcGFnZV9sb2NrID0gcGFn ZS0+bG9ja19wdHI7CisgICAgICAgIFBBU19URVNUSU5HX0FTU0VSVChwYWdlX2xvY2spOwogCiAg ICAgICAgIGlmICgqaGVsZF9sb2NrID09IHBhZ2VfbG9jayAmJiAqaGVsZF9sb2NrID09ICZjYWNo ZV9ub2RlLT5wYWdlX2xvY2spIHsKICAgICAgICAgICAgIHBhc19jb21waWxlcl9mZW5jZSgpOwpJ bmRleDogU291cmNlL2JtYWxsb2MvbGlicGFzL3NyYy9saWJwYXMvcGFzX3NlZ3JlZ2F0ZWRfcGFn ZV9pbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvbGlicGFzL3NyYy9saWJw YXMvcGFzX3NlZ3JlZ2F0ZWRfcGFnZV9pbmxpbmVzLmgJKHJldmlzaW9uIDI4Nzk2NykKKysrIFNv dXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19zZWdyZWdhdGVkX3BhZ2VfaW5saW5l cy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoYykg MjAxOC0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAo YykgMjAxOC0yMDIyIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRp c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp dGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMTMwLDYgKzEzMCw4IEBAIHN0YXRpYyBQQVNfQUxXQVlT X0lOTElORSBib29sIHBhc19zZWdyZWcKICAgICBwYXNfbG9jayoqIGhlbGRfbG9jaywKICAgICBw YXNfbG9jayogbG9ja19wdHIpCiB7CisgICAgUEFTX1RFU1RJTkdfQVNTRVJUKGxvY2tfcHRyKTsK KyAgICAKICAgICAqaGVsZF9sb2NrID0gbG9ja19wdHI7CiAgICAgCiAgICAgaWYgKFBBU19MSUtF TFkocGFzX2xvY2tfdHJ5X2xvY2sobG9ja19wdHIpKSkKQEAgLTE1MSw2ICsxNTMsOCBAQCBzdGF0 aWMgUEFTX0FMV0FZU19JTkxJTkUgYm9vbCBwYXNfc2VncmVnCiAgICAgICAgIHJldHVybiB0cnVl OwogICAgIH0KIAorICAgIFBBU19URVNUSU5HX0FTU0VSVChsb2NrX3B0cik7CisKICAgICByZXR1 cm4gcGFzX3NlZ3JlZ2F0ZWRfcGFnZV9sb2NrX3dpdGhfdW5iaWFzX25vdF91dGlsaXR5KHBhZ2Us IGhlbGRfbG9jaywgbG9ja19wdHIpOwogfQogCkBAIC0xNzAsNyArMTc0LDcgQEAgc3RhdGljIFBB U19BTFdBWVNfSU5MSU5FIHZvaWQgcGFzX3NlZ3JlZwogICAgICAgICBwYXNfbG9jayogaGVsZF9s b2NrX2lnbm9yZWQ7CiAgICAgICAgIAogICAgICAgICBsb2NrX3B0ciA9IHBhZ2UtPmxvY2tfcHRy OwotICAgICAgICAKKwogICAgICAgICBpZiAocGFzX3NlZ3JlZ2F0ZWRfcGFnZV9sb2NrX3dpdGhf dW5iaWFzKHBhZ2UsICZoZWxkX2xvY2tfaWdub3JlZCwgbG9ja19wdHIsIHBhZ2VfY29uZmlnKSkK ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgCkBAIC0yMDgsNiArMjEyLDggQEAgc3RhdGlj IFBBU19BTFdBWVNfSU5MSU5FIHZvaWQgcGFzX3NlZ3JlZwogICAgIAogICAgIGhlbGRfbG9ja192 YWx1ZSA9ICpoZWxkX2xvY2s7CiAgICAgcGFnZV9sb2NrID0gcGFnZS0+bG9ja19wdHI7CisKKyAg ICBQQVNfVEVTVElOR19BU1NFUlQocGFnZV9sb2NrKTsKICAgICAKICAgICBpZiAoUEFTX0xJS0VM WShoZWxkX2xvY2tfdmFsdWUgPT0gcGFnZV9sb2NrKSkgewogICAgICAgICBpZiAodmVyYm9zZSkK QEAgLTIzMiw4ICsyMzgsMTIgQEAgc3RhdGljIFBBU19BTFdBWVNfSU5MSU5FIGJvb2wgcGFzX3Nl Z3JlZwogICAgIH0KIAogICAgIHN3aXRjaCAobG9ja19tb2RlKSB7Ci0gICAgY2FzZSBwYXNfbG9j a19sb2NrX21vZGVfdHJ5X2xvY2s6Ci0gICAgICAgIHJldHVybiBwYXNfbG9ja19zd2l0Y2hfd2l0 aF9tb2RlKGhlbGRfbG9jaywgcGFnZS0+bG9ja19wdHIsIHBhc19sb2NrX2xvY2tfbW9kZV90cnlf bG9jayk7CisgICAgY2FzZSBwYXNfbG9ja19sb2NrX21vZGVfdHJ5X2xvY2s6IHsKKyAgICAgICAg cGFzX2xvY2sqIHBhZ2VfbG9jazsKKyAgICAgICAgcGFnZV9sb2NrID0gcGFnZS0+bG9ja19wdHI7 CisgICAgICAgIFBBU19URVNUSU5HX0FTU0VSVChwYWdlX2xvY2spOworICAgICAgICByZXR1cm4g cGFzX2xvY2tfc3dpdGNoX3dpdGhfbW9kZShoZWxkX2xvY2ssIHBhZ2VfbG9jaywgcGFzX2xvY2tf bG9ja19tb2RlX3RyeV9sb2NrKTsKKyAgICB9CiAKICAgICBjYXNlIHBhc19sb2NrX2xvY2tfbW9k ZV9sb2NrOiB7CiAgICAgICAgIHBhc19zZWdyZWdhdGVkX3BhZ2Vfc3dpdGNoX2xvY2tfaW1wbChw YWdlLCBoZWxkX2xvY2spOwo=